Commit Graph

950 Commits

Author SHA1 Message Date
Hsiao-Wei Wang 61b2b6392c
bugfix and rename
Use `deposit_root_vote` for `DepositRootVote` object and `deposit_root` for the
deposit root hash.
2019-01-04 15:54:48 +08:00
Danny Ryan 36231e698a
Apply suggestions from code review
Co-Authored-By: hwwhww <hwwang156@gmail.com>
2019-01-04 15:54:35 +08:00
Danny Ryan e3c4155ba5
Merge pull request #393 from terenc3t/patch-27
Align Field Names with Phase 0 Spec
2019-01-03 21:48:14 -07:00
Danny Ryan d360330f83
Merge pull request #394 from ralexstokes/fix-update-validator-registry-fn
Remove dangling `return` statement from spec function
2019-01-03 21:46:34 -07:00
Danny Ryan a84dd398e4
Merge pull request #392 from ralexstokes/fix-units-ejection-balance
Fix a type error with units of wei when determining ejection balance.
2019-01-03 21:44:08 -07:00
Danny Ryan d5e6d84269
Merge pull request #391 from ralexstokes/typo/hash-slot
Change "justified hash" to "justified slot"
2019-01-03 21:43:12 -07:00
terence tsao 97bd04607c
Update 0_beacon-chain.md 2019-01-03 19:40:03 -08:00
terence tsao c0140d72ee
Update 0_beacon-chain.md 2019-01-03 18:23:23 -08:00
vbuterin a5b1f2cc0a
Moved comment and changed conditional 2019-01-03 19:44:39 -06:00
vbuterin 3f4be7abb7
Fixed activation slot conditional. 2019-01-03 19:42:59 -06:00
Alex Stokes 19a9582a48
Remove dangling `return` statement from spec function
This function declares that it returns `None` and instead directly mutates the
state.

There is a dangling return statement that this commit deletes.
2019-01-03 19:42:07 -06:00
terence tsao 19b1a31903
Update 1_shard-data-chains.md 2019-01-03 13:57:04 -08:00
Alex Stokes 9a83ad7b9b
Fix a type error with units of wei when determining ejection balance.
`EJECTION_BALANCE` is in units of ETH.

`state.validator_balances[index]` is in units of Gwei.

For the ejection computation to work as desired, we need to convert the
`EJECTION_BALANCE` constant from ETH to Gwei.
2019-01-03 14:28:36 -06:00
Alex Stokes 457f84fa64
Change "justified hash" to "justified slot"
There should be a correspondence here but referring to the slot is more
explicit, especially for those who are not as familiar with the
details of FFG finalization.
2019-01-03 12:06:44 -06:00
Hsiao-Wei Wang f92735454e
Fix `verify_slashable_vote_data`
The first field of `AttestationDataAndCustodyBit` should be an `AttestationData` object, not an `SlashableVoteData` object.
2019-01-03 16:19:54 +08:00
Hsiao-Wei Wang b614595fbe
Merge branch 'master' into vbuterin-patch-19 2019-01-03 00:26:31 +08:00
Hsiao-Wei Wang af8ed89170
Merge branch 'master' into rename_pow_to_deposit 2019-01-03 00:10:18 +08:00
Hsiao-Wei Wang 78e73633bc
Merge pull request #382 from ethereum/remove_shard_reassignment_record
Remove `ShardReassignmentRecord`
2019-01-02 23:48:04 +08:00
Hsiao-Wei Wang dcaf510213
Merge branch 'master' into rename_pow_to_deposit 2019-01-02 23:44:12 +08:00
Justin 3efe1b3b6c
Update 0_beacon-chain.md 2019-01-02 15:21:22 +00:00
Justin 429e5721f2
RANDAO hash chain and no stale shuffles
* Make RANDAO into a hash chain (this makes it easy for applications to prove the intermediate RANDAO reveals).
* Include `state.slot` when shuffle to avoid stale shuffles with skip slots
2019-01-02 14:20:01 +00:00
Justin 93b18d5160
Fix typo 2019-01-02 13:51:57 +00:00
Justin 696bf23b5e
Remove returned value for process_deposit
Also trim trailing whitespace
2019-01-02 13:41:32 +00:00
Justin 7d240946a9
Update 0_beacon-chain.md
* Cleanup comments related to custody
* Rename "Miscellaneous" to "Custody" in the table of contents
* Use `INITIAL_SLOT_NUMBER` instead of `0` for initial custody slots
* (typo) Fix `second_latest_custody_reseed_slot` => `penultimate_custody_reseed_slot`
2019-01-02 13:35:57 +00:00
Justin 9a90803f5c
Update 0_beacon-chain.md
* `processed_deposit_root` => `latest_deposit_root`
* `receipt_root` => `deposit_root`
* `receipt_tree` => `deposit_tree`
* Emphasize that deposits are Ethereum 1.0 deposits in text in various places
* `Eth1Deposit` => `Deposit` for consistency (Also happy sticking with `Eth1Deposit` and replacing `deposit_` with `eth1_deposit_` everywhere. This may be unnecessary since Ethereum 2.0 deposits can be distinguished with the `shard_` prefix, e.g. `ShardDeposit` and `shard_deposit`.)
* Clarify `withdrawal_credentials`.
* Clarify that multiple Ethereum 1.0 blocks can have the same deposit root.
2019-01-02 13:18:35 +00:00
Hsiao-Wei Wang 3dbee05aa6
Rename `pow_receipt_` to `deposit_` 2019-01-02 18:27:09 +08:00
Hsiao-Wei Wang 35adc9c61a
Remove `ShardReassignmentRecord` 2019-01-02 15:31:57 +08:00
Hsiao-Wei Wang 0d9ecce344
Rename `poc_` to `custody` 2019-01-02 15:16:55 +08:00
vbuterin 2105614059
Bunch of fixes 2019-01-01 22:37:43 -06:00
Alex Stokes d49b6e5087 Fix typo with missing bracket (#379) 2018-12-31 23:35:09 +00:00
vbuterin fdb1b6775d
Removed extraneous variable setting 2018-12-31 14:08:59 -06:00
Justin fd295eb539
Merge branch 'master' into vbuterin-patch-19 2018-12-31 15:17:00 +00:00
Justin d36b403c2e
Cleanups and fixes
Cleanups

* (typo) Remove `get_new_validator_registry_delta_chain_tip` from table of contents
* (typo) Update "Routines for updating validator status" in table of contents
* Update `FAR_FUTURE_SLOT` from `2**63` to `2**64 - 1`
* Put more constants in "Initial values", homogenise
* Cleanup note formatting
* Remove `ZERO_BALANCE_VALIDATOR_TTL` logic (to be possibly reintroduced in phase 2).
* Cleanup `min_empty_validator_index`
* Rename `deposit` to `amount` in `process_deposit` and `DepositData`.
* (typo) Remove new line under `process_penalties_and_exits`
* (typo) "Status codes" => "Status flags" in the table of contents
* (typo) `(state.slot - EPOCH_LENGTH) % LATEST_RANDAO_MIXES_LENGTH` => Use `SEED_LOOKAHEAD` instead.
* Put `state.validator_registry_latest_change_slot = state.slot` in `update_validator_registry`.
* Use `GENESIS_SLOT` for `last_poc_change_slot=0` and `second_last_poc_change_slot=0`.

Bugfixes

* (typo) `validator_exit` => `exit.validator_index`
* Separate initial deposits and initial activations to avoid double activations
* Replace `proposer.status != EXITED_WITH_PENALTY` with `validator.penalized_slot > state.slot` in two different places.
* Replace `status == EXITED_WITH_PENALTY` with `validator.penalized_slot <= state.slot` (and validator active) in two different places.
2018-12-31 15:14:14 +00:00
Danny Ryan 8f29bcdf08
Merge pull request #373 from ethereum/fix-slashing
fix slashing conditons
2018-12-31 07:57:51 -06:00
vbuterin 011970169c
Edited as per Justin's comments 2018-12-30 20:42:05 -06:00
terence tsao c8ff723514
Update 0_beacon-chain.md 2018-12-30 16:06:33 -08:00
vbuterin 1a4973171f Remove references to the persistent committees (#376)
* Remove references to the persistent committees
2018-12-30 23:46:32 +00:00
vbuterin 4a93374025
Fixed as per hww's comments 2018-12-30 09:15:23 -06:00
Hsiao-Wei Wang 14f49aaacb
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-29 13:47:10 -06:00
vbuterin bd5b32ec5a
Initialize status_flags 2018-12-29 13:44:51 -06:00
vbuterin 85d001001c
Fixed seed lookahead 2018-12-28 12:08:19 -06:00
vbuterin d9e897bbcb
Status code / slot reorganization
* Added `activation_slot`, `exit_slot`, `penalized_slot`, `withdrawal_slot`, use these to determine if a validator is active
* Universal min activation/exit delay of 256 slots
* Min exit time of ~1 day, but penalization delays this to ~18 days
* Penalty calculation period of `[time penalized - 18 days, time penalized + 18 days]`; made the total penalties array fixed size and wraparound to make calculation more fine-grained
* Processes withdrawals in all epochs, not just dynasty-changing epochs
* Change `get_shuffling` function to take slot as argument

Not yet done:

* Removed `shard_committees` from the state
* Removed persistent committees from the state
2018-12-28 12:04:03 -06:00
Danny Ryan aa9bda271f
fix slashing conditons to be based upon epochs rather than slots 2018-12-28 11:10:12 -06:00
terence tsao 10a8ba2d9e
rewording for validator registry precondition 2018-12-28 09:04:00 -08:00
Hsiao-Wei Wang 6b84dae09e Fix #361: pass `poc_commitment` to `validate_proof_of_possession` (#364)
* Fix #361
2018-12-27 18:11:38 +00:00
terence tsao 44c389bfe3 crosslink rewards typo (#367) 2018-12-27 18:01:20 +00:00
Nishant Das 8c12896fa0 Cleanup merkle_root
Add docstring and fix spacing.
2018-12-27 17:58:24 +00:00
Hsiao-Wei Wang 2c9cefa6a7
`Use `current_` instead of `this_` 2018-12-26 15:48:20 +08:00
terence tsao a2422de686
Potential bug for crosslinks? 2018-12-23 09:34:46 -08:00
vbuterin 4938481428 Added hash-and-bit data structure as per #286 (#355)
* Added hash-and-bit data structure as per #286
2018-12-23 10:48:11 +00:00
Hsiao-Wei Wang 0ee724a4ab
Merge pull request #356 from terenc3t/patch-22
updated SSZ implementation list
2018-12-23 12:04:31 +08:00
Hsiao-Wei Wang 985a3fe958
Merge pull request #351 from dangerousfood/vrc-con-update
Update VRC contract for Vyper v0.1.0-beta.6
2018-12-23 12:03:34 +08:00
terence tsao f21da324ef
updated SSZ implementation list 2018-12-22 15:13:54 -08:00
Danny Ryan f8652fa25b
Merge pull request #347 from ethereum/vbuterin-patch-15
Changes to inactivity leak
2018-12-22 07:13:41 -06:00
Danny Ryan f84b7b5f31
Merge pull request #341 from ethereum/target-committee-size
change TARGET_COMMITTEE_SIZE to 128
2018-12-22 07:12:21 -06:00
Danny Ryan a60ab53647
PR feedback 2018-12-22 07:11:58 -06:00
Danny Ryan d0b5133912
Merge pull request #349 from ethereum/vbuterin-patch-17
Proof of custody placeholders
2018-12-22 07:08:18 -06:00
vbuterin 99817aeb0e
Typo fix: lastest -> last 2018-12-21 17:23:42 -05:00
Danny Ryan 6a73a056f0
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-21 17:22:42 -05:00
Joseph Delong 1068076822 update vrc cotnract for vyper v0.1.0-beta.6 2018-12-21 16:18:41 -06:00
Danny Ryan fa8be783ad
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-21 17:12:38 -05:00
vbuterin 4f94f7579c
Moved notes to the end of the section to make Danny happy 2018-12-21 11:29:15 -05:00
vbuterin 5fc8f6cfca
Fixed deposit inclusion and positioning of state variables 2018-12-21 11:26:40 -05:00
Justin c8efdc7431
Add placeholder array in state for VDFs
Added `latest_vdf_outputs` in `state` initialised to an array of `ZERO_HASH` of length `LATEST_RANDAO_MIXES_LENGTH // EPOCH_LENGTH`. (There's one VDF output per epoch. The VDF input is the RANDAO mix at the epoch boundary.)

 Further changes to activate VDFs (in a future phase):

* Add a new beacon "VDF output and proof" transaction, e.g. with `MAX_VDF_OUTPUT_AND_PROOF := 1`.
* Adjust the `MAX_SEED_LOOKAHEAD` constant, e.g. to `2**4 * EPOCH_LENGTH`. (The `2**4` parameter is essentially `A_max`.)
* Add a `process_vdf_output_and_proof` helper function in the per-block processing:
    * Verify the VDF input hasn't already been processed (check the corresponding `state.latest_vdf_outputs` entry is not `ZERO_HASH`.)
    * Verify the proof is correct, i.e. matches the VDF input and output
    * Save the VDF output to `state.latest_vdf_outputs`
* In the per-epoch processing set the corresponding entry in `state.latest_vdf_outputs` to `ZERO_HASH`.
* Use a VDF output for the shuffling seed.
2018-12-21 15:26:13 +00:00
Hsiao-Wei Wang 6667edb015
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-21 09:08:01 -05:00
vbuterin 6eb4e59b8c
slots -> epochs 2018-12-21 09:07:04 -05:00
vbuterin 8e30f1b63e
Set zero balance TTL back to 2**22 2018-12-21 09:06:30 -05:00
Hsiao-Wei Wang 1d1db908e2
Fix grammar 2018-12-21 16:43:59 +08:00
Hsiao-Wei Wang ac0b8aac07
Add initial setting of proof of custody placeholders 2018-12-21 16:41:48 +08:00
Hsiao-Wei Wang e639f365a6
Merge pull request #344 from ethereum/hwwhww/chunk_size
phase1: Adjust `CHUNK_SIZE`
2018-12-21 11:04:36 +08:00
vbuterin 985c8a2c30
Proof of custody placeholders
Replacing #145
2018-12-20 16:01:00 -05:00
vbuterin ac5db1da8d
Doubled sqrt e drop time. 2018-12-20 12:51:34 -05:00
vbuterin 53dd49167b
Changes to inactivity leak
* Fixes parameters and makes clear that the inactivity leak is on a per-epoch basis (before the leak was technically 64 times too weak as it was calculated per-slot but applied per-epoch)
* Adds a `// 2` to the inactivity leak to compensate for it being applied twice
* Changes how it is calculated (no inactivity leak for not being part of the head, only basic leak)
* Separates out early inclusion incentives into a separate incentive component rather than being multiplicative with everything else
2018-12-20 12:41:17 -05:00
Danny Ryan eaab06f2dd
Merge pull request #298 from ethereum/update_vyper_contract
deposit contract: reduce on-chain computation
2018-12-20 09:24:32 -06:00
terence tsao 96633781fb
simplify total_attesting_balance 2018-12-20 06:37:03 -08:00
Danny Ryan e780be349e
Merge pull request #345 from ChihChengLiang/patch-2
Fix typo in get_new_shuffling
2018-12-20 07:52:30 -06:00
Danny Ryan c90ab16701
Merge pull request #340 from ethereum/vbuterin-patch-15
Remove MIN_VALIDATOR_REGISTRY_CHANGE_INTERVAL
2018-12-20 07:51:58 -06:00
Chih Cheng Liang d3cdd3fcc0
Fix typo in get_new_shuffling 2018-12-20 19:36:35 +08:00
Hsiao-Wei Wang e4e923fbba
Adjust `CHUNK_SIZE` 2018-12-20 14:36:33 +08:00
terence tsao c177ce23b3
typo on attesting_validator? 2018-12-19 21:56:43 -08:00
Akhila Raju bf753a6120
Remove line repeat in initiate_validator_exit 2018-12-19 19:56:26 -06:00
Akhila Raju 09e31acda5
Remove line repeat in activate_validator 2018-12-19 19:53:28 -06:00
Danny Ryan 0809ca0d62
fix 'CYCLE_LENGTH' -> 'EPOCH_LENGTH' 2018-12-19 19:35:55 -06:00
Danny Ryan 55ac9ac313
change TARGET_COMMITTEE_SIZE to 128 2018-12-19 15:09:17 -06:00
vbuterin 56bc4412bc
Remove MIN_VALIDATOR_REGISTRY_CHANGE_INTERVAL
Slight simplification. Only substantive change is that if the validator registry stays constant, we don't reshuffle 3 epochs after the last reshuffling (ie. before the reshufflings happened after 1, 2, 3, 4, 8, 16... epochs, now it's just 1, 2, 4, 8, 16...)
2018-12-19 14:09:50 -05:00
Vitalik Buterin a9328157a8
Don't lexicographically sort 2018-12-19 13:48:04 -05:00
Hsiao-Wei Wang 9b9114fac2
Merge branch 'master' into update_vyper_contract 2018-12-19 23:39:59 +08:00
Danny Ryan 105e669391
Merge pull request #327 from ethereum/vbuterin-patch-18
Keep randao mixes in the state
2018-12-19 09:03:25 -06:00
Anirudha Bose 257c83cc23
Fix typos in the beacon chain spec 2018-12-19 12:47:37 +01:00
Danny Ryan 36e26c86a3
fix assert conditions in get_block_hash 2018-12-18 12:53:48 -06:00
Danny Ryan 0de7240452
Merge branch 'master' into vbuterin-patch-18 2018-12-18 12:50:06 -06:00
Danny Ryan 20006c674b
Merge branch 'master' into hwwhww-patch-2 2018-12-18 12:45:50 -06:00
Danny Ryan 8548f03d5a
Merge pull request #317 from ethereum/vbuterin-patch-15
Put validator balances into a separate list in the state
2018-12-18 12:41:10 -06:00
Danny Ryan f7afd679da
fix comment 2018-12-18 12:37:25 -06:00
Danny Ryan 5943fd507f
fix remaining index error 2018-12-18 12:27:33 -06:00
Hsiao-Wei Wang bb1559a86f
PR feedback 2018-12-19 01:19:47 +08:00
Danny Ryan 0bf1acc1eb
Merge pull request #333 from burnburn/casper_ref
Make Casper ref normative
2018-12-18 10:05:52 -06:00
Danny Ryan 8bf1a542fe
Merge pull request #288 from ethereum/prev-balance-note
per-epoch Balance difference consensus safety note
2018-12-18 08:52:00 -06:00
Dan Burnett 5a0d8c8f42
move to Informative 2018-12-18 09:41:59 -05:00
Hsiao-Wei Wang 49f3746dc7
fix 2018-12-18 18:58:59 +08:00
vbuterin 2611180119
Fixes as per Danny's comments 2018-12-18 05:33:03 -05:00
Hsiao-Wei Wang edf335ebf0
Fix on startup functions 2018-12-18 11:58:28 +08:00
Dan Burnett cc4e066029
formatting change 2018-12-17 15:19:58 -05:00
Dan Burnett d505aa28fe
make Casper FFG normative 2018-12-17 15:15:37 -05:00
vbuterin cc5cef52cb
Separated block roots and randao mixes length, and fixed per-slot randao updates 2018-12-17 14:04:04 -05:00
Danny Ryan 49ce718cc2
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-17 13:53:42 -05:00
Danny Ryan e16c98b854
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-17 13:53:35 -05:00
Danny Ryan eee26d7b69
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-17 13:53:17 -05:00
Danny Ryan 9c620d3853
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-17 13:53:04 -05:00
vbuterin 7f66f06871
Fixed one more outdated-style balance query 2018-12-17 10:43:05 -05:00
vbuterin 2fa7d254dd
Merge branch 'master' into vbuterin-patch-15 2018-12-17 10:41:23 -05:00
Danny Ryan 2c48bab3d8
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-17 10:40:41 -05:00
Danny Ryan 110fe75a70
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-17 10:40:31 -05:00
Danny Ryan fbabeff838
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-17 10:40:21 -05:00
Danny Ryan f4fa55842b
fix bls_signature toc 2018-12-17 08:48:06 -06:00
vbuterin b402a7c1d6
Made a function multiline 2018-12-17 09:12:51 -05:00
Danny Ryan eccfc912b5
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-17 09:11:39 -05:00
vbuterin c0d65cc334
Changed get_effective_balance definition to use state+index 2018-12-17 09:10:44 -05:00
Danny Ryan e9f986971e
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-17 09:08:13 -05:00
vbuterin 365437d4c2
Forgot to update randao mixes in one place 2018-12-17 04:46:28 -05:00
vbuterin d1aa3b4cd6
Editing randao_mixes in place instead of as a queue
Saves having to re-Merkelize an entire 8192-item list every block.
2018-12-17 04:44:49 -05:00
vbuterin 416bbf9cea
Edit latest_block_roots in place instead of as a queue
Faster editing that way; otherwise every block will require completely reconstructing a 8192-sized Merkle tree.
2018-12-17 04:40:27 -05:00
vbuterin 4aa6e4de7b
Merge pull request #328 from ethereum/vbuterin-patch-19
Remove clamp
2018-12-17 04:17:02 -05:00
vbuterin 3725dd5cb1
Merge pull request #316 from ethereum/vbuterin-patch-13
Edit BLS spec as per issue #300
2018-12-16 04:06:57 -05:00
vbuterin 9e6c1a6244
Remove clamp
Removed the use of `clamp` from the spec, as there's no point in a helper function that's used exactly once; it only increases the amount people have to jump around the spec to understand what's going on.
2018-12-15 06:44:18 -05:00
vbuterin 425f7d51c9
Keep randao mixes in the state
Response to #295 

Also a simplification, as two special cases get replaced: `state.randao_mix` -> `state.latest_randao_mixes[-1]`, and `state.next_seed` -> `state.latest_randao_mixes[-CYCLE_LENGTH-1]`.
2018-12-15 05:10:31 -05:00
vbuterin 829911c0fd
Swapped order of aggregate and verify 2018-12-14 19:55:05 -05:00
Danny Ryan 62b95fbe33
fix process_deposit function signature 2018-12-14 15:21:32 -06:00
Danny Ryan 179352dbfe
remove ProofOfPossessionData 2018-12-14 15:20:21 -06:00
Danny Ryan 7b4c4f299d
add bls_aggregate_pubkeys ref in beacon chain spec 2018-12-14 09:39:14 -06:00
Danny Ryan 7306851f0b
Merge branch 'master' into vbuterin-patch-13 2018-12-14 09:31:55 -06:00
Danny Ryan c448db46ea
Merge pull request #315 from ethereum/more-ssz-objects
More ssz objects pt 1
2018-12-14 09:30:19 -06:00
Danny Ryan 221874efcb
pr feedback 2018-12-14 09:29:49 -06:00
Danny Ryan 68a76ba727
Merge pull request #313 from ethereum/slashable-functions
Cleanup casper slashing
2018-12-14 08:58:01 -06:00
vbuterin c43724132b
Clarify block hash -> block root 2018-12-13 23:01:32 -05:00
vbuterin 964395c362
Some bugfixes 2018-12-13 19:40:00 -05:00
vbuterin 2b9a0e999c
Separate validator balances 2018-12-13 19:28:59 -05:00
vbuterin add628d26b
Edit BLS spec as per issue #300
See https://github.com/ethereum/eth2.0-specs/issues/300
2018-12-13 19:06:07 -05:00
Danny Ryan 96aade9a2c
add proofofpossessiondata ssz object 2018-12-13 14:03:22 -06:00
Danny Ryan f30d404856
add ValidatorRegistryDeltaBlock ssz object 2018-12-13 13:50:50 -06:00
Danny Ryan 9e74043a17 move ejectiosn to per-epoch. fix a couple bugs in validator status change functions (#314) 2018-12-13 19:45:08 +00:00
Danny Ryan cd9e7ecaeb
minor fix 2018-12-13 12:18:29 -06:00
Danny Ryan 697d3c5eb5
add doc string for new slashing helper funtions 2018-12-13 12:17:39 -06:00
Danny Ryan 7c833fafc5
clean up casper slashing with helper functions etc 2018-12-13 12:09:39 -06:00
Raul Jordan 923df80b03 replace shard_block_hash with shard_block_root 2018-12-13 11:26:10 -06:00
terence tsao 9170efee1b
removed old comments 2018-12-13 08:27:22 -08:00
Hsiao-Wei Wang 1ea887c964 Deposits: define `DepositData` and rename `DepositParameters` to `DepositInput` (#310) 2018-12-13 15:36:57 +00:00
terence tsao ddb91adecf
quick fix on typo 2018-12-13 06:51:47 -08:00
Gregory Markou b554204688 clarified language around start_up (#303) 2018-12-13 13:08:51 +00:00
Justin 6b6a04c884
Bugfix (missing `state.`) 2018-12-13 10:03:50 +00:00
Hsiao-Wei Wang c1a3b29145 Fix `verify_slashable_vote_data`: use `get_domain` (#306) 2018-12-13 09:55:37 +00:00
Hsiao-Wei Wang 6fa12f6603
Merge pull request #301 from ethereum/vote_rename
Some renames about vote and fix `verify_slashable_vote_data` (`verify_casper_votes`)
2018-12-13 13:58:10 +08:00
Hsiao-Wei Wang d5a5e1815c
Rename `LATEST_BLOCK_ROOT_COUNT` -> `LATEST_BLOCK_ROOTS_LENGTH` 2018-12-13 13:55:34 +08:00
Hsiao-Wei Wang 9eeb863ec6
Refactor `verify_slashable_vote_data` 2018-12-13 03:11:53 +08:00
Hsiao-Wei Wang ab7549e52e
Move `verify_slashable_vote_data` to the last verification of Casper slashings 2018-12-13 03:04:10 +08:00
Hsiao-Wei Wang d2fda68ccb
Fix ToC 2018-12-13 03:00:53 +08:00
Hsiao-Wei Wang 4aa6ec4468
Update `CasperSlashing` and `verify_casper_votes`
1. Rename `verify_casper_votes` -> `verify_slashable_vote_data`
2. Rename `CasperSlashing.votes_1` -> `CasperSlashing.slashable_vote_data_1`
3. Rename `CasperSlashing.votes_2` -> `CasperSlashing.slashable_vote_data_2`
4. Fix `verify_slashable_vote_data` `(verify_casper_votes)`
2018-12-13 02:55:28 +08:00
Hsiao-Wei Wang ae5221c4f8
Move BLS verification to later step 2018-12-13 02:11:47 +08:00
Hsiao-Wei Wang ac3ffb3df6
`LATEST_BLOCK_ROOTS_COUNT` -> `LATEST_BLOCK_ROOT_COUNT` 2018-12-13 02:08:37 +08:00
Hsiao-Wei Wang 81c6b561fc
`CandidatePoWReceiptRootRecord.votes` -> `CandidatePoWReceiptRootRecord.vote_count` 2018-12-13 02:07:12 +08:00
Danny Ryan cc34097fba
fix genesis 2018-12-12 11:51:42 -06:00
Hsiao-Wei Wang 130e45ee39
Reduce on-chain computation 2018-12-13 01:39:34 +08:00
Hsiao-Wei Wang 92b9253ecb
Fix ToC 2018-12-13 01:35:11 +08:00
terence tsao 3b0fe25c14
multiply GWEI_PER_ETH 2018-12-12 09:29:26 -08:00
Hsiao-Wei Wang 4c3c8510d4
Fix 'validator_index': 'uint64' -> 'uint24' 2018-12-13 01:09:56 +08:00
Danny Ryan acd83973fb
bold note 2018-12-12 10:02:49 -06:00
Danny Ryan 70a577a786
Merge branch 'master' into prev-balance-note 2018-12-12 10:01:14 -06:00
Danny Ryan 10fa84b057
rename base_inactivity_penalty to inactivity_penalty 2018-12-12 09:28:47 -06:00
Danny Ryan 541f33094f
move rewards helpers to rewrds and penalties section 2018-12-12 09:14:44 -06:00
Danny Ryan bc60576d3c
rework rewards sections as per PR feedback 2018-12-12 09:07:44 -06:00
Justin 19b0421d4d
Merge branch 'master' into fix-rewards 2018-12-12 13:11:10 +00:00
vbuterin 6b5479cac9 Moved ancestor hashes to state, changed to batched accumulator (#269)
* Replaced ancestors hashes in blocks with the previous block root
* Add a block root batched accumulator
* Cleanup processing presentation
2018-12-12 13:02:50 +00:00
Chih Cheng Liang 21da07b4f7 typo (#294) 2018-12-12 10:30:58 +00:00
Danny Ryan e2714b3344 add bls_verify_multiple def to phase 0 spec (#292) 2018-12-11 21:18:30 +00:00
Danny Ryan 726ed97eb2
Merge branch 'rename_tree_roots' of https://github.com/terenc3t/eth2.0-specs into terenc3t-rename_tree_roots 2018-12-11 14:54:30 -06:00
Terence Tsao 3f31eecb18 fixed typo & s/winning_hash/winning_root/ 2018-12-11 12:50:20 -08:00
Terence Tsao a13997d738 updated rest of the fields except ancestor_hashes 2018-12-11 12:38:32 -08:00
Justin 9f8ae361f9
Rename `BLSVerify` to `bls_verify` and put `hash` in helpers 2018-12-11 20:30:28 +00:00
Danny Ryan 032007ad17
add organization to previous epoch attester helpers 2018-12-11 13:40:00 -06:00
Danny Ryan 5e84a53ff1
base_reward is 1/4 of total reward val can earn per cycle 2018-12-11 13:32:27 -06:00
Danny Ryan 42364fe7b1
add granular reward for the four different parts of attestation 2018-12-11 13:22:17 -06:00
Terence Tsao e0e2fed1b5 rename hash tree roots as root 2018-12-11 09:53:56 -08:00
Danny Ryan 83224c320a
small edit to language 2018-12-11 11:16:24 -06:00
Danny Ryan befc349878
add balance diff consensus safety note 2018-12-11 11:14:42 -06:00
Danny Ryan defe2668a0
Merge pull request #266 from ethereum/JustinDrake-patch-10
First pass cleanup of bls_verify.md
2018-12-11 10:38:21 -06:00
Danny Ryan e8d8b03089 note the vyper version the contract is expected to be compiled with (#287) 2018-12-11 16:29:09 +00:00
Danny Ryan 084880511d
Merge pull request #280 from ethereum/validator-status
validator status cleanup
2018-12-11 10:14:02 -06:00
Danny Ryan 5734b25fb1
rename bls verification spec ref 2018-12-11 10:13:31 -06:00
Danny Ryan c462f563b1
use Deposit object for processing intiial deposits 2018-12-11 10:02:59 -06:00
Danny Ryan 1e3f518f02
pr feedback 2018-12-11 09:49:50 -06:00
Danny Ryan e64bfb289c
Merge pull request #282 from ethereum/ssztreehash-cleanup
cleanup refs to SSZTreeHash
2018-12-11 09:17:57 -06:00
Justin d1c20b862b
Update bls_verify.md 2018-12-11 14:02:34 +00:00
Justin a32af50513
Update bls_verify.md 2018-12-11 13:56:40 +00:00
Justin 23f7e9db62
Rename FQ2 to Fq2 and specify the G1 generator 2018-12-11 13:36:34 +00:00
vbuterin 47dc3eb48b Updated winning_hash description (#283) 2018-12-11 13:25:21 +00:00
Danny Ryan 6fccd9f793
cleanup a few more hash refs to ssztreehash 2018-12-10 17:08:04 -06:00
Danny Ryan fa685abc47
add ref to ssztreehash spec. cleanup where ssztreehash should be used 2018-12-10 16:58:36 -06:00
Danny Ryan ae33eec081
Merge branch 'master' into validator-status 2018-12-10 16:43:35 -06:00
Danny Ryan e77bf04711
remove direct calls to exit_validator 2018-12-10 16:42:28 -06:00
Danny Ryan 37450e9a4d
Merge pull request #279 from status-im/attestation-unsigned
attestations: avoid unsigned underflow (eth2.0-specs/issues/#224)
2018-12-10 16:34:54 -06:00
Danny Ryan 70765a205e
fix toc 2018-12-10 16:30:25 -06:00
Danny Ryan 49f3cfebdf
add link to appendix A 2018-12-10 16:22:42 -06:00
Danny Ryan 0c281c8113
local var i -> index 2018-12-10 16:17:42 -06:00
Danny Ryan 03901ffe65
cleanups 2018-12-10 16:14:08 -06:00
Danny Ryan 9cff4ae653
fix exit conditions 2018-12-10 15:56:22 -06:00
Alex Stokes ed3611904d
update reference to hash function 2018-12-10 13:32:16 -08:00
Danny Ryan 6f058c2756
begin validator status cleanup 2018-12-10 15:16:06 -06:00
Jacek Sieka 2facc754cc
attestations: avoid unsigned underflow (eth2.0-specs/issues/#224)
* and some nitpicks
2018-12-10 14:38:32 -06:00
Jacek Sieka 44ac70e7fe remove trailing whitespace (#278) 2018-12-10 19:55:11 +00:00
Justin 411d347b6b
Update bls_verify.md 2018-12-10 14:30:36 +00:00
Justin 03c014d0e3
Update 0_beacon-chain.md 2018-12-10 11:22:42 +00:00
Justin c782725aa1
Update bls_verify.md 2018-12-10 10:43:42 +00:00
Justin 25cc1cf382
Address issues from reviewers 2018-12-10 10:34:36 +00:00
Justin 0afafe1c76
Merge branch 'master' into JustinDrake-patch-8 2018-12-10 10:11:41 +00:00
Nishant Das 88ef7b8186 typo (#270) 2018-12-10 08:28:11 +00:00
vbuterin d6cc826bb0
Some edits 2018-12-09 23:44:44 -05:00
Justin cd07ec126b
Update bls_verify.md 2018-12-09 14:51:15 +00:00
Justin 6079f70ebd
Update bls_verify.md 2018-12-09 14:49:16 +00:00
Justin 6c196fc411
Update bls_verify.md 2018-12-09 14:48:54 +00:00
Danny Ryan de32e25bfc fix initial initial persistent_committees (#258)
* fix initial persistent_committees
* initial persistent commmitees from active validator indices
2018-12-09 14:47:30 +00:00
Justin 0b8fa12289
Update bls_verify.md 2018-12-09 14:43:13 +00:00
Danny Ryan 685a1be651
Merge pull request #252 from ethereum/remove-specials
new block format pt2 -- remove specials
2018-12-09 08:33:46 -06:00
Danny Ryan cc476db8c9
address pr ffeedback 2018-12-09 08:33:12 -06:00
Justin 24d3c9c33a
Update bls_verify.md 2018-12-09 14:30:48 +00:00
Hsiao-Wei Wang c897dd99c2
Update specs/core/0_beacon-chain.md
Co-Authored-By: djrtwo <dannyjryan@gmail.com>
2018-12-09 08:25:34 -06:00
Justin 1b0b2f21cc
First pass cleanup of bls_verify.md
Misc cleanups:

* (typo) `highflag` => `highflag1`
* (typo) `lowflag = x = 0` => `lowflag == x == 0`
* Add structure and table of contents
* Describe more notation in words (e.g. `i`)
* Make sure flags are 1-bit
* Clarify and polish presentation

Example notation cleanups:

* `G1` => `id_G1` (to avoid confusing with the group G1)
* `field_modulus` => `q` (avoid using two names for same thing)
* `BLSVerify` => `bls_verify` (respect notation for functions in main document)
* `sig` => `signature` (avoid abbreviations as in main document)

TODO:

* Potentially describe `FQ2`, `b2`, `is_on_curve`, `multiply` in words
* Make the naming changes around `bls_verify` in the main document
* Fix any bugs introduced by the cleanup
2018-12-09 14:21:34 +00:00
vbuterin 70836ecd1c Clarify why it's called INVERSE_SQRT_E_DROP_TIME (#261)
* (cleanup) Rename `SQRT_E_DROP_TIME` to `INVERSE_SQRT_E_DROP_TIME` to reflect `1/sqrt(e)`
* (cleanup) Justify why it's called INVERSE_SQRT_E_DROP_TIME
* (cleanup) Polish and simplify presentation
* (bug fix) Fixed 2**34 value
* (bug fix) Replace epochs with slots to make the calculations work
2018-12-09 13:08:11 +00:00
vbuterin 238c0e10fe Added explicit "must be < q" phrasing to BLS description (#262) 2018-12-09 12:33:37 +00:00
Hsiao-Wei Wang e04378c38c bytes32(pubkey) -> bytes48(pubkey) (#265) 2018-12-09 12:33:13 +00:00
Chris Leishman eefaaf5ac3 Clarify TreeHash treatment of integers > 256bit
Also clarify treatment of hashes < 32bytes
2018-12-07 16:39:52 -08:00
Justin 2ed18bfa1f
Casper cleanups and bug fixes
* (cleanup) `SpecialAttestationData` => `CasperVotes`
* (cleanup) `vote_1`, `vote_2` => `votes_1`, `votes_2`
* (bug fix) Place a bound on the number of votes with `MAX_CASPER_VOTES`
* (bug fix) Supply `state` when calling `verify_casper_votes`
2018-12-07 20:09:49 +00:00
Danny Ryan e2eedabed2
Merge pull request #254 from mkalinin/fix-boundary_attesting_balance-2
Fix epoch_boundary_attesting_balance calculation
2018-12-07 13:00:38 -06:00
Danny Ryan a0e226c957
remove record from operation types 2018-12-07 12:51:15 -06:00
Danny Ryan 74ac7e6ee1
PR feedback 2018-12-07 12:43:11 -06:00
Chih Cheng Liang 357cb72d7a fix broken md (#257) 2018-12-07 16:16:09 +00:00
Danny Ryan dc4bbfedab
clarify header 2018-12-07 09:18:06 -06:00
Danny Ryan c4acafdb58
change block objects to operations 2018-12-07 09:15:55 -06:00
Danny Ryan 3a24fed194
fix toc' 2018-12-07 09:05:29 -06:00
Danny Ryan d9abce4471
rename transactiosn to block objects 2018-12-07 09:04:16 -06:00
Danny Ryan 76e5b76dc2
Merge branch 'master' into remove-specials 2018-12-07 08:12:58 -06:00
Danny Ryan 9f64530aac
remove BeaconBlockHeader 2018-12-07 07:46:52 -06:00
Mikhail Kalinin 1a716609ba
Fix epoch_boundary_attesting_balance calculation
get_effective_balance accepts ValidatorRecord object as an input but it was called with validator index instead
2018-12-07 18:23:55 +06:00
Justin 2d8efe57c0
Bug fixes and cleanups around exit_validator
Cleanups

* Use `state.slot` over `current_slot`.
* Specify `new_status`
* Segregate ejection processing

Bug fixes:

* Put ejections at the end of the per-slot processing (TODO: per-slot processing should come *after* per-epoch processing)
* Immediately exit ejections
* Include `ACTIVE_PENDING_EXIT` as an active state
* Renamed two `State` to `BeaconState`
2018-12-07 12:18:55 +00:00
Danny Ryan 35f8eccc1f
fix tox 2018-12-06 19:18:49 -06:00
Danny Ryan 57b86e3204
fix toc 2018-12-06 19:16:10 -06:00
Danny Ryan bcb09a49a0
rework transactions data structure ordering 2018-12-06 19:13:19 -06:00
Danny Ryan 3ea04a28ca
fix table 2018-12-06 19:07:26 -06:00
Danny Ryan 80e224be8c
remove specials 2018-12-06 19:02:23 -06:00
Danny Ryan 40fd893fc1
remove extra field 2018-12-06 17:55:23 -06:00
Danny Ryan d18ab07803
fix toc 2018-12-06 17:54:14 -06:00
Danny Ryan 7f542ca714
add beaconblockheader and body 2018-12-06 17:51:01 -06:00
Danny Ryan 15c11a46bd
consistency in multiplication of EPOCH_LENGTH formatting 2018-12-06 16:56:23 -06:00
Danny Ryan 332511b42b
simplify finality conditions 2018-12-06 16:51:29 -06:00
Danny Ryan 98430c7c68
address comments 2018-12-06 16:47:22 -06:00
Danny Ryan ae1b64ccff
remove s helper 2018-12-06 16:38:40 -06:00
Danny Ryan eb7715aa41
pr feedback 2018-12-06 16:12:33 -06:00
Danny Ryan 330b2449bf
pr feedback 2018-12-06 15:54:39 -06:00
Danny Ryan 5e058a15b8
remove 'slot_hash_block' 2018-12-06 10:41:50 -06:00
Danny Ryan 464ad63464
minor slot cleanups 2018-12-06 10:25:35 -06:00
Danny Ryan 3e1aad24b0
Merge branch 'master' into virtual-skip-block 2018-12-06 09:45:25 -06:00
Danny Ryan c5eddd54f4
Merge branch 'master' into cleanup-validator-change 2018-12-06 09:42:24 -06:00
Danny Ryan b8b2586c92
address review comments 2018-12-06 09:40:40 -06:00
Danny Ryan f7e58dd82c
Merge branch 'master' into virtual-skip-block 2018-12-06 09:38:07 -06:00
Danny Ryan 8bc0254deb
add missing toc entry 2018-12-06 09:29:49 -06:00
Danny Ryan 7c25665d61
remove state.slot ref 2018-12-06 09:28:55 -06:00
Danny Ryan c0ca669bd0
cleanup validator registry change to merge before #234 2018-12-06 08:51:57 -06:00
Danny Ryan 91f83e3861
isolate some of the per-epoch changes from the other #234 2018-12-06 08:38:31 -06:00
terence tsao 0626061977
don't need slot num in get_active_validator_indices 2018-12-05 17:26:07 -08:00
Danny Ryan db65429cc8
rework to do virtual block transitions 2018-12-05 19:24:37 -06:00
Danny Ryan 22a77c331b
fix change_validators 2018-12-05 14:35:58 -06:00
Danny Ryan 1ccb1074c5
fix just/finality 2018-12-05 14:07:41 -06:00
Danny Ryan e894a2dc18
fix issues in justificaiton/finality 2018-12-05 13:55:56 -06:00
Danny Ryan 4e0b120fe3
Merge branch 'master' into JustinDrake-patch-3 2018-12-05 13:14:16 -06:00
Danny Ryan 59494d1774
add state root processing 2018-12-05 13:03:24 -06:00
Danny Ryan 3a677eefa9
minor cleanup 2018-12-05 12:49:45 -06:00
Danny Ryan cb871c3f0e
minor cleanups 2018-12-05 12:47:21 -06:00
Danny Ryan c154c65f14
cleanup calls to 'get_block_hash' 2018-12-05 12:42:16 -06:00
Danny Ryan 3bd56891c5
cleanup per slot processing 2018-12-05 12:40:08 -06:00
Justin eb26e10fae
Update 0_beacon-chain.md 2018-12-05 17:30:37 +00:00
Justin f956135763
Fix #237 (#238) 2018-12-05 17:17:17 +00:00
terence tsao 130b837975 Fix ZERO_BALANCE_VALIDATOR_TTL and move get_domain 2018-12-05 14:41:11 +00:00
Justin 20407c8dd1
Update 0_beacon-chain.md 2018-12-05 14:34:50 +00:00
Justin 2fc3f88795
Update 0_beacon-chain.md 2018-12-05 11:22:15 +00:00
Paul Hauner 2913dfa6fe Change `state.crosslinks` to `state.latest_crosslinks` (#236)
Change `state.crosslinks` to `state.latest_crosslinks` to match the `BeaconState` definition.
2018-12-05 09:03:09 +00:00
Justin 4c0841ec6a
Move to a per-slot state transition function
Initial pass for the migration from a per-block state transition function to a per-slot state transition function. More simplifications and cleanups can be made.
2018-12-04 21:28:31 +00:00
Justin a4722faf12
Handle activations and exits separately for balance churn (#230)
This change is to avoid deposits from fully consuming the allowable balance churn, preventing exits from being processed. And vice versa with deposits/exits swapped.

A bunch of cleanups and bug fixes were made along the way.
2018-12-04 19:49:26 +00:00
Danny Ryan b40a7c5ad6
Merge pull request #228 from ethereum/fix-validator-states
Fix deposit logic
2018-12-04 11:51:47 -06:00
Danny Ryan 17cf4e9f56
remove WITHDRAWN again 2018-12-04 11:23:37 -06:00
Danny Ryan 84a1a5fc07
fix pending -> exited_without_penalty. change pendning_exit to active_pending_exit. fix merkle tree in contract 2018-12-04 10:07:46 -06:00
Justin 5e4883ccbf
Stick with Keccak-256/SHA3 for now
See https://github.com/ethereum/eth2.0-specs/issues/218
2018-12-04 15:50:44 +00:00
Justin 73e77b75e1
Fix #223
`next_start_shard` does not need to be part of `state` (it's already available via `(state.shard_committees_at_slots[-1][-1].shard + 1) % SHARD_COUNT`)
2018-12-04 12:37:05 +00:00
Justin 67e4fa9d6f
Cleanup of deposit
* Structure the presentation, add sections to table of contents
* Remove incorrect and redundant information
* Add section on withdrawal credentials
2018-12-04 11:47:41 +00:00
Justin 4bf1539c83
Cleanups part 2 (#217)
Changelog (nothing major):

* Clean up constants
   * Add to table of contents
   * Rename a few
   * Split into more categories (e.g. "Deposit contract"  and "Initial values")
   * Replaced `SQRT_E_DROP_TIME ` by `INACTIVITY_PENALTY_QUOTIENT`
* Put all the data structures in "Data structures", including specials
* Move deposit contract after "Data structures"
* `ShardAndCommittee` => `ShardCommittee` (and related changes)
* `aggregate_sig` => `aggregate_signature`
* `justified_slot_bitfield` => `justification_bitfield`
* Use double-ticks everywhere in Python docstrings
* Clean up deposit contract a bit
* Bug fix: ensure uniqueness of the `ChainStart` log
2018-12-04 10:57:09 +00:00
Danny Ryan c2227a59de
fix int384 to uint384 2018-12-03 12:27:58 -06:00
vbuterin 0f59a564d0
Merge pull request #215 from mratsim/patch-1
Small typo in get_active_validator_indices
2018-12-03 09:38:03 -05:00
vbuterin 2f112e12fc
Merge pull request #202 from ethereum/initial_fork_slot
set initial fork_slot to INITIAL_SLOT_NUMBER
2018-12-03 09:37:27 -05:00
Mamy Ratsimbazafy fe5a472ff6
Small typo in get_active_validator_indices
Change [ValidatorRecords] to [ValidatorRecord]
2018-12-03 15:14:31 +01:00
Hsiao-Wei Wang 2983e68f03
Merge pull request #213 from paulhauner/patch-1
ForkData typo
2018-12-03 14:29:41 +08:00
Antoine Toulme ff2551e754 Add Java implementation of SSZ 2018-12-02 21:22:51 -08:00
Paul Hauner 95211af400
ForkData typo
Extremely small change: added a close bracket to `ForkData`.
2018-12-03 14:08:33 +11:00