This PR upgrades a number of libraries as well as nim itself, to address
security issues and crashes that we've worked to solve over the past few
months on the nimbus-eth2 side leading up to its 1.6 migration - they
include changes that are safe to use in both 1.2 and 1.6 without
requiring 1.6, making the code compatible with both versions.
In particular, 1.6 becomes more strict in several ways including
exception handling, style and certain langauge constructs related to
memory safety - as a result, we've cleaned up said libraries and
improved their stability overall, including fixing several crashes.
* nim 1.2.18 - this is the last release in the 1.2 series we produced
together with upstream based on nimbus' needs - between the version
Desktop is using today and v1.2.18, changes are predominantly backports
from newer Nim versions that we asked for while working on stability in
Nimbus itself.
* chronicles - cleanups
* confutils - cleanups
* faststreams - cleanups & crash fixes
* nim-json-serialization - several important crash fixes for json
parsing edge cases
* metrics - cleanups & threading fixes
* secp256k1 - upstream updates (including security fixes)
* serialization - cleanups
* stew - many convenience fixes and updates to common low-level
utilities, such as Result and hex / base64 / etc parsing
* stint - cleanups
* zlib - cleanups
* nimPNG - cleanups
* nimcrypto - cleanups
This is part 1 of library upgrades and focuses on the low-level
libraries - part 2 will upgrade the network stack (chronos, json-rpc,
web3, etc), keeping the two separate so as to limit the potential impact
of this PR.
This commit is the first of implementing community permissions.
**It is not implementing the complete feature**, rather does it
introduce the first pieces, such that we can get code reviewed and
merged before it grows too big.
To review these features, please make sure to
1. Enable wallet (Settings -> Advanced -> Wallet toggle)
2. Enable community permissions (Settings -> Advanced -> Community
Permissions toggle)
You'll have to restart the app after doing so.
The commit introduces the following:
**UI, API calls and view models to CRUD community permissions**
After creating a community, the user can go to the community
settings and create new token permissions. The user can also update
and delete existing permissions.
**Asset and collectible view models**
To create community token permissions, users have to select
the token criteria. This commit introduces the `assetsModel` for ERC20
tokens and `collectiblesModel` for `ERC721` tokens.
The latter only supports custom minted community tokens at this point.
**This commit requires:** https://github.com/status-im/status-go/pull/3207
As of #9596, task-runner is no longer used.
Due to how the build system works, task-runner was providing nim-stew,
nim-bearssl and nim-chronos to the project, even though these are also
top-level dependencies - effectively this means there were multiple
versions of these libraries in the source tree and it is not entirely
intuitive which is actually used - adding to the confusion, the
submodule was pinning different versions.
This PR removes task-runner and resets the other dependencies to the
versions in task-runner thus minimising collateral changes.
A duplicate copy of bearssl is also removed.
This commit resolves a crash happened due to connection to
`SIGNAL_WALLET_ACCOUNT_TOKENS_REBUILT` when keycard sync
flow was run in the background.
Also updated the keycard synchronization process with the current state of
the application and is the first step of many which leads towards completion
of entire syncing feature.
- Bump status-go head that include the required specific changes
- fetch token balance (native or ERC20) and cache historical token quantity data
- fetch FIAT currency
- Extend presentation layer (NIM and QML) to account for API changes
- Remove timed request and other optimizations from the time of fetching
balance history every time instead of querying cache
- Add C++ integration debugging tests and update network chain configuration (outdated)
Closes: #8175
Previously DOtherSide was an external, standalone library with own
submodule for SortFilterProxyModel. After merging DOtherSide directly
to status-desktop it should be treated as a build tool or part of build
configuration. Instead of owning c++ files by itselft, DOtherSide should
refer to all needed c++ sources in order to compile them and build
status-desktop properly.
Removing SortFilterProxyModel submodule from original DOtherSide and
changing config after merge to status-desktop was needed to be done
along with merge itself because otherwise there would be a conflict -
both DOtherSide and status-desktop had the same submodule
(SortFilterProxyModel).
Closes: #9410
this seems to only happen on some linux platform QPAs where the native
file/folder dialog is returning bogus target directory URL; anyways
manipulating the URL using a QRegExp is fragile, better use builtin QUrl
methods for that
Needed for fixing https://github.com/status-im/status-desktop/issues/9307
this was a memleak and fd leak bomb resulting in the app not starting at
all:
```
(nim_status_client:342629): GLib-ERROR **: 11:16:11.873: Creating pipes for GWakeup: Too many open files
/home/jakubgs/bin/StatusIm: line 2: 342627 Trace/breakpoint trap (core dumped) appimage-run
~/Downloads/Status/StatusIm-Desktop-221206-082906-5ee51a.AppImage
```
Hardcoding this is already far from ideal. We should at least use the
same type that's later used in desktop before sending images to
status-go, **before** this gets fixed properly.
The next step will be to detect codecs and use them them dynamically.
LocalAuthentication class - used to authenticate OS' logged user (using Touch Id)
Keychain class - able to store/read/remove item from the Keychain
KeychainManager class - manages the flow of storing/reading/removing an item from
the Keychain using own sync/async methods
This change is required as part of the feature issue-2675
- DockShowAppEvent
- OSThemeEvent
- OSNotification
are now part of our `Status` namespace
Corresponding files are renamed and moved to appropriate Status folder.
This is corresponding dotherside part of the issue 1725.
So far we had kind of a memory leak, cause objects added to the filter were not
deleted ever. When the app is closing, it just removes filters, but doesn't
delete them.
I faced a logical issue, that we were sending qmlengine pointer to the
installEventFilter method, instead object which may or may not rely on the
qqmlengine instance, that is fixed also.
Fixes: #1725
Add an event filter to `qApp` that can detect a dock icon click (in macos) when the main window is hidden or closed.
Co-authored-by: Boris Melnik <82511785+borismelnik@users.noreply.github.com>
Intended to prevent Nim from inopportunely garbage collecting cstrings passed
through signal_handler/dos_signal as they make their way back to the main
thread
Bumps status-go to include the fix for not fetching balance for
overridden tokens
Add documentation on how to run wallet tests locally using ganache
Closes#9091
Due to changes done in https://github.com/status-im/status-go/pull/3133
we had to update procedure for adding migration keypair (which includes
local keystor files deletion for the accounts being migrated) and procedure
for account deletion, cause in order to delete local keystore file for the
acount which is being deleted, we have to provide a password now (states
only for non keycard accounts, keycard accounts use empty password).
This adjust the front-end for the import tool by handling new
properties that have been added to the discord import progress signals.
Namely, the import is now done in chunks, so the progress signal
contains information about how many chunks have been processed.
This needs: https://github.com/status-im/status-go/pull/3134Closes#9262#9261
Because we've switched to `QuotedMessage` as an attached payload to
messages to make message replies data more reliable, we lost some of
the author information in imported messages, that was available prior
to that move.
This commit introduces `quotedMessageAuthorDisplayName` and
`quotedMessageAuthorAvatar` to our model so it can be set in case
we can't retrieve contact details for a given message (which is always
the case for imported messages)
Igor Sirotin
Dario Gabriel Lipicar
Alex Jbanca
Michal Iskierko
MishkaRogachev
Jacek Sieka
Pascal Precht
Stefan
Sale Djenic
Anthony Laibe
Richard Ramos
Khushboo Mehta
Michał Cieślak
Lukáš Tinkl
mprakhov
Boris Melnik
Pascal Precht
Patryk Osmaczko
Jonathan Rainville
Alexandra Betouni
Sale Djenic
Iuri Matias
Andrei Smirnov
Michael Bradley, Jr
Alexandra Betouni
B.Melnik
Boris Melnik
Eric Mastro
Pascal Precht
Ștefan Talpalaru
Lukáš Tinkl