Grammar fixes, consistency across contexts, and some good ol' content changes.
Some minor content changes for better, clearer explanations.
Lots of spelling and grammar changes.
Most of the grammar changes were to capitalised letters (which I have made at least consistent in different contexts) and whether or not the prompt ends with a full stop (again, context dependent)
status: ready
- in unsigned transaction tab, show the transaction sent screen when user
signs a transaction
- in send command flow, show dialog when users want to sign later
This PR fixes the fact, that `[:wallet :send-transaction]` path
in db was not properly cleared in some cases, which demonstrated
as couple of the subtle issues (like that you were taken straight
to the signing state on tx-modal in when sending `/send` command
and some tx was sent previously from wallet, and some quite serious,
like #2197, which was caused by password info not properly cleared
between multiple invocations of the `/send` command.
- makes it possible to hide the tabs in a view under certain conditions (e.g
when the keyboard is displayed)
- hide tabs in main screens when the keyboard is displayed
- fix bug where toolbar wasn't ready with zero statuses
- fix toolbar center and margin to top
- fix grey background missing
- fix top status text margin from the top of the card
- fix separation lines between statuses edge to edge
- margin with chat icon to bottom 12
Also apply same to popular hashtags for consistency
Addresses all non-test must haves except "All content hidden behind right edge on smaller screen (check 5s)"
- Main screen (empty): fix topbar margin
- Main screen: Font size name (and dapp list item)
- Main screen: Get rid of popular hashtag border
- Main screen: All for DApps should be blue
- Main screen: tap on number of popular hashtag -> error
* Upgrade status-go to bugfix-no-messaging-rinkeby-gd04e667-12 (geth 1.7 rebase)
* [bug] fix#2089 and #2098 with geth update
with geth 1.7 addresses are passed with 0x prefix and mix of lower/upper cases
update the normalize hex function so that addresses are always without prefix
and entirely lower-cased.
previously one would get a red screen in develop and probably a white screen
in the app
now it shows a label indicating that the transaction has expired
- Refactor: more consistent styles naming
- Align text next to icon
- Grey background whole discover
- Set background popular apps
- Fix margin-bottom for all-dapps
All styles belonging to screen/component should be in styles.cljs. This commit
moves platform specific styles to appropriate place.
Also fixes misc weird ns imports.
Also moves colors to common ns (FUBAR).
- Move permission check from main screen (no longer makes sense given
choose recipient is reached from send)
- Add ios-specific display and permission checks
The flat-list component handles the nil case but the precondition does
not.
This is currently causing transaction list failures when the list of
unsigned transactions is empty.
- Use flat-list and 3 column layout for grid
- Get rid of platform ns dependency
- Minor refactor: "wrap" -> :wrap, backgroundColor -> background-color
Disable screen while transaction is signing
Add handling for incorrect password on signing
Fix bug where spinner doesn't appear on the second time
Address feedback
More rebase fixes
Fix spec failure
this fixed involved changing the swiper so that a function can be passed as
title instead of a string.
this allows developpers to pass custom elements as titles and still use style
and variables that are computed when tab is built
* [design] remove syncing animation outside of chat views
replace no-sync-bar? parameter by show-sync-bar? parameter as not showing
the sync bar is the norm and showing it the exception (only appears in chats)
* add suscription and spec for sync-state
[bugfix] transaction details background should be white
[bugfix] button styling in unsigned transactions
[bugfix] make whole item touchable in transactions history and unsigned
[bugfix] correction of icons styling in transactions history
[bugfix] error message should not touch the toolbar in wallet
[bugfix] add asset icon and text are different on ios and android
PR review fixes
- Update toolbar text
- Add frame for camera/qr
- Add button for choose contacts
- Add button for address from clipboard
- Add button for browse photos
Set recipient from clipboard.
Added functionality and event handling necessary to set recipient
from clipboard.
Add choose-recipient event to assoc into the database
Add QR code scanning to first screen
Add vector icons for copy and select image
Fix svg
Fix rebase, localize labels
Add checkmark icon (this is a placeholder, current svg won't render)
Remove leak from develop
Vertical alignment fixes
Vertically align maps in view
Address review comments
Fix rebase reference problems/styling issues
Small style tweaks, fix icon
Fix small design issues
Indentation fixes
Address review points
Fix indentation
Prevent permissions request on ios
On ios, a permissions request results in a null reference error,
do a platform check before performing a permissions request.
Fix compile error
Restyle for ios, colours, layout
Update icons on ios
Restyle disabled button
Browse photos button disabled
Add viewfinder and platform specific styling.
Viewfinder and style changes
Add some torch functionality, fix toolbar, style issues
Refactor view style, add translucent bits to viewfinder
Address pull request feedback
Replace a style by defstyle
- Update toolbar text
- Add frame for camera/qr
- Add button for choose contacts
- Add button for address from clipboard
- Add button for browse photos
Set recipient from clipboard.
Added functionality and event handling necessary to set recipient
from clipboard.
Add choose-recipient event to assoc into the database
Add QR code scanning to first screen
Add vector icons for copy and select image
Fix svg
Fix rebase, localize labels
Add checkmark icon (this is a placeholder, current svg won't render)
Remove leak from develop
Vertical alignment fixes
Vertically align maps in view
Address review comments
Fix rebase reference problems/styling issues
Small style tweaks, fix icon
Fix small design issues
Indentation fixes
Address review points
Fix indentation
Prevent permissions request on ios
On ios, a permissions request results in a null reference error,
do a platform check before performing a permissions request.
Fix compile error
update react-native-swipper to latest working version
remove bottom margin hack in other screens with similar bug
fixes Cannot scroll transaction history when app is syncing #1902 as well
* Fix#1886
Completly rework the way how async handlers work
Delay further processing of message till async handler returns result
* Fix indent
* Fix#1903
In release 0.9.11 we'll have v13, so we don't want to modify this in develop.
This moves Push notification related changes into a new migration as opposed to
merging them into one.
- Send notification when sending message in 1on1 chat
- Add notify FFI with binds for ObjC and Java
- Add fcm-token to contacts in spec and realm
- Add notifications to db
- Include fcm-token in contact request
- Update fcm-token when it arrives and put it in DB
- Disable copy-paste hijacking and popup
- Turn on notifications flag in Jenkins build
* Implement possibility for async command handlers
Command handler can now return results asynchronously,
and those results as saved and persisted, indexed by
command message-id.
* Address feedback raised in PR comments
* Different handler codes + simplified error message
cljs-priority-map provides a special purpose data structure that needlessly
complicated things and doesn't appear to provide much value for what it gives
us.
Instead, keep :chats an ordinary map and sort vector on final subscription, as
our ListView destructures data-source items correctly.
This means we can upgrade Clojurescript.
- After testing we don't need to expose this WIP with popups etc
- get-fcm-token event was accidentally included twice during rebase leading to warnings
- Asks for permissions on iOS at startup
- Introduce NOTIFICATIONS_WIP_ENABLED flag
- Surface FCM Token and put it in clipboard for QA manual end to end testing
- Listen for FCM RefreshToken event at root
fix wallet errors that were sticking when refresh occured
add separate errors for transaction history fetching with visual feedback
update wallet when going on wallet tab
update transaction list when opening transaction modal
- Add wallet key to db
- Add sub for wallet error messages
- Add event handlers to set wallet values
- Cover the above with tests
Oh and add the tests
Add error view
Add exclamation mark, style error message, add message to view
Remove commented styling
Localise wallet error
Add translation
- Add an english translation for the error message
- Change error representation in db to a keyword
- Update handlers to set and clear keywords
Constrain spec, make view conditional
- The spec for error messages now takes a predefined set.
- Error message only pops on error
Fix test
Align maps
Reduce event chain size, move logging to timbre
- Print FCMToken which can be used to send PNs from Firebase Console
- Include react-native-fcm and related packages
- Update capabilities for iOS
- google service config files for Android and iOS
The ```:account-update``` event was being passed the key
```update-status?``` which has nothing to do with an account as
represented in the db. This resulted in a spec failure when this
key was detected on an attempt to save changes.
I've sanitized this event by pulling out the three account keys,
```[:name :photo-path :status]```
that are relevant to ```profile``` and ensuring that only they get
passed to ```:account-update```.
Profile updates now work as expected.
Add tests covering profile events
Fix the runner
Currently account recovery includes whitespace on either side of the
passphrase, preventing recovery of the desired account.
We trim that whitespace in the account-recovery-fx
Initial utility for live data binding in the new wallet.
- Add prices namespace to get fiat prices from Cryptocompare
- Events to init wallet balance and load prices
- Listen to these events in wallet main view
- Show accurate ETH balance, USD value and %change from yesterday
- Enable wallet tab in Jenkins
Mapview component accepts the `:initialCenterCoordinate` which always must have
longitude and latitude attributes. This ensures that they will always be present
even when they are missing from the map passed retreived from the app state.
Also accomplished was removal of redundant preview loading
and command markup is now stored as cljs data in app-db,
only being translated to RN components in subscriptions
This commit ensures messages are ordered correctly when participants join and
leave a group chat. Specifically, the last received message will appear last.
Previously the user and chat clock was queried and updated in an ad hoc manner.
With this change there are only two clock changes to keep track of:
Sending messages:
time = time+1;
time_stamp = time;
send(message, time_stamp);
Receiving messages:
(message, time_stamp) = receive();
time = max(time_stamp, time)+1;
(See https://en.wikipedia.org/wiki/Lamport_timestamps)
Note that this means we can get rid of all the non-message clock queries and
updates.
Oskar Thorén
Roman Volosovskyi
Eric Dvorsak
janherich
Goran Jovic
Andrey Shovkoplyas
Andy Tudhope
Julien Eluard
Vic Shybaiev
alwx
Audrius Molis
angusiguess
Eric Dvorsak
Henrik Kjerringvåg
vojta
Gustavo Nunes
Mihael Konjevic