status-im
/
status-mobile
mirror of https://github.com/status-im/status-mobile.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Enable treating warnings as errors and list acceptable warnings

This commit is contained in:
Oskar Thorén 2017-09-09 12:27:54 +02:00 committed by Roman Volosovskyi
parent 35b69030bf
commit ef777511dc
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/status_im/utils/build.clj
View File

@ -1,10 +1,21 @@
(ns status-im.utils.build
(:require [cljs.analyzer :as analyzer]))
;; Some warnings are unavoidable due to dependencies. For example, reagent 0.6.0
;; has a warning in its util.cljs namespace. Adjust this as is necessary and
;; unavoidable warnings arise.
(def acceptable-warning?
#{
"Protocol IFn implements method -invoke with variadic signature (&)" ;; reagent 0.6.0 reagent/impl/util.cljs:61
})
(defn nil-acceptable-warning [s]
(when-not (acceptable-warning? s)
s))
(defn warning-handler [warning-type env extra]
(when (warning-type analyzer/*cljs-warnings*)
(when-let [s (analyzer/error-message warning-type extra)]
(when-let [s (nil-acceptable-warning (analyzer/error-message warning-type extra))]
(binding [*out* *err*]
(println (analyzer/message env (str "\u001B[31mWARNING\u001B[0m: " s))))
;; TODO Do not enable yet as our current reagent version generates warnings
#_(System/exit 1))))
(System/exit 1))))