This fixes bugs #2520 and #2484
The cause of the bugs is the fact that calling `.sorted` method
on the realm resultset produces another resultset which is sorted
when iterated through `Iterator<T>` interface, but does absolutely
nothing to way how resultset object is serialised (printed out
as JSON).
So when we sorted, printed to json, parsed back through transit
and expected the order to be retained, it was not, and it was
failing quite randomly.
To be precise, it failed in a case where we sorted the resultset
according to some property and picked the top element from the result.
As the top element picking was done AFTER the sorted realm resultset
was converted into cljs datastructure, it was sometimes failing.
This fix just ensures that we select the single element from js
resultset (where sorting info is still retained) and only convert
that single element to cljs (it's also much more efficient).
We want minimial scope for 0.9.12b release so only relevant migrations made it
into that. To ensure a happy upgrade path in future versions, other v17
migrations (all related to pending messages) have been moved into v18.
This means develop will break for current developers, but 0.9.12 -> 0.9.12b
-> (next version / develop after this commit) will work as expected.
Grammar fixes, consistency across contexts, and some good ol' content changes.
Some minor content changes for better, clearer explanations.
Lots of spelling and grammar changes.
Most of the grammar changes were to capitalised letters (which I have made at least consistent in different contexts) and whether or not the prompt ends with a full stop (again, context dependent)
status: ready
- in unsigned transaction tab, show the transaction sent screen when user
signs a transaction
- in send command flow, show dialog when users want to sign later
This PR fixes the fact, that `[:wallet :send-transaction]` path
in db was not properly cleared in some cases, which demonstrated
as couple of the subtle issues (like that you were taken straight
to the signing state on tx-modal in when sending `/send` command
and some tx was sent previously from wallet, and some quite serious,
like #2197, which was caused by password info not properly cleared
between multiple invocations of the `/send` command.
- makes it possible to hide the tabs in a view under certain conditions (e.g
when the keyboard is displayed)
- hide tabs in main screens when the keyboard is displayed
- fix bug where toolbar wasn't ready with zero statuses
- fix toolbar center and margin to top
- fix grey background missing
- fix top status text margin from the top of the card
- fix separation lines between statuses edge to edge
- margin with chat icon to bottom 12
Also apply same to popular hashtags for consistency
Addresses all non-test must haves except "All content hidden behind right edge on smaller screen (check 5s)"
- Main screen (empty): fix topbar margin
- Main screen: Font size name (and dapp list item)
- Main screen: Get rid of popular hashtag border
- Main screen: All for DApps should be blue
- Main screen: tap on number of popular hashtag -> error
* Upgrade status-go to bugfix-no-messaging-rinkeby-gd04e667-12 (geth 1.7 rebase)
* [bug] fix#2089 and #2098 with geth update
with geth 1.7 addresses are passed with 0x prefix and mix of lower/upper cases
update the normalize hex function so that addresses are always without prefix
and entirely lower-cased.
previously one would get a red screen in develop and probably a white screen
in the app
now it shows a label indicating that the transaction has expired
- Refactor: more consistent styles naming
- Align text next to icon
- Grey background whole discover
- Set background popular apps
- Fix margin-bottom for all-dapps
All styles belonging to screen/component should be in styles.cljs. This commit
moves platform specific styles to appropriate place.
Also fixes misc weird ns imports.
Also moves colors to common ns (FUBAR).
- Move permission check from main screen (no longer makes sense given
choose recipient is reached from send)
- Add ios-specific display and permission checks
The flat-list component handles the nil case but the precondition does
not.
This is currently causing transaction list failures when the list of
unsigned transactions is empty.
- Use flat-list and 3 column layout for grid
- Get rid of platform ns dependency
- Minor refactor: "wrap" -> :wrap, backgroundColor -> background-color
Disable screen while transaction is signing
Add handling for incorrect password on signing
Fix bug where spinner doesn't appear on the second time
Address feedback
More rebase fixes
Fix spec failure
this fixed involved changing the swiper so that a function can be passed as
title instead of a string.
this allows developpers to pass custom elements as titles and still use style
and variables that are computed when tab is built
* [design] remove syncing animation outside of chat views
replace no-sync-bar? parameter by show-sync-bar? parameter as not showing
the sync bar is the norm and showing it the exception (only appears in chats)
* add suscription and spec for sync-state
[bugfix] transaction details background should be white
[bugfix] button styling in unsigned transactions
[bugfix] make whole item touchable in transactions history and unsigned
[bugfix] correction of icons styling in transactions history
[bugfix] error message should not touch the toolbar in wallet
[bugfix] add asset icon and text are different on ios and android
PR review fixes
- Update toolbar text
- Add frame for camera/qr
- Add button for choose contacts
- Add button for address from clipboard
- Add button for browse photos
Set recipient from clipboard.
Added functionality and event handling necessary to set recipient
from clipboard.
Add choose-recipient event to assoc into the database
Add QR code scanning to first screen
Add vector icons for copy and select image
Fix svg
Fix rebase, localize labels
Add checkmark icon (this is a placeholder, current svg won't render)
Remove leak from develop
Vertical alignment fixes
Vertically align maps in view
Address review comments
Fix rebase reference problems/styling issues
Small style tweaks, fix icon
Fix small design issues
Indentation fixes
Address review points
Fix indentation
Prevent permissions request on ios
On ios, a permissions request results in a null reference error,
do a platform check before performing a permissions request.
Fix compile error
Restyle for ios, colours, layout
Update icons on ios
Restyle disabled button
Browse photos button disabled
Add viewfinder and platform specific styling.
Viewfinder and style changes
Add some torch functionality, fix toolbar, style issues
Refactor view style, add translucent bits to viewfinder
Address pull request feedback
Replace a style by defstyle
- Update toolbar text
- Add frame for camera/qr
- Add button for choose contacts
- Add button for address from clipboard
- Add button for browse photos
Set recipient from clipboard.
Added functionality and event handling necessary to set recipient
from clipboard.
Add choose-recipient event to assoc into the database
Add QR code scanning to first screen
Add vector icons for copy and select image
Fix svg
Fix rebase, localize labels
Add checkmark icon (this is a placeholder, current svg won't render)
Remove leak from develop
Vertical alignment fixes
Vertically align maps in view
Address review comments
Fix rebase reference problems/styling issues
Small style tweaks, fix icon
Fix small design issues
Indentation fixes
Address review points
Fix indentation
Prevent permissions request on ios
On ios, a permissions request results in a null reference error,
do a platform check before performing a permissions request.
Fix compile error