979c01ed2d
Build yoga in OSS
...
Differential Revision: D7417644
fbshipit-source-id: 2641c1abc1083db83cbb304f8dcc7b781e329041
2018-03-27 15:19:20 -07:00
99e9c6e798
Fabric: Collecting and printing ShadowNode's revision/generation
...
Summary: It drastically simplifies reading logs.
Reviewed By: fkgozali
Differential Revision: D7388963
fbshipit-source-id: 7849c803f295719918c20ddf8c082e5a5780116f
2018-03-25 22:48:19 -07:00
cb7a7f3b93
Fabric: Deleted virtual default destructor from Props
...
Summary: Trivial. We don't need this because we already have another virtual method.
Reviewed By: fkgozali
Differential Revision: D7388964
fbshipit-source-id: 5ea6eb33ece72796d8cde2cc4b12c1240447d22a
2018-03-25 22:48:18 -07:00
6f17e3b328
Fabric: Introducing `TreeMutationInstruction`
...
Summary: The Great Diffing algorithm is coming.
Reviewed By: fkgozali
Differential Revision: D7376528
fbshipit-source-id: bdfef69551980136cfd1717a11ae376d5eef126b
2018-03-25 22:48:18 -07:00
53dfbcc81c
Fabric: Fixed bug in node management in FabricUIManager
...
Summary: Suddenly, `{}` means `{nullptr}`, not `empty list`.
Reviewed By: mdvacca
Differential Revision: D7376347
fbshipit-source-id: 76f81eebe046ae592f0a42be7bcaa0587732c2a9
2018-03-25 22:48:18 -07:00
5642514aa5
Fabric: Detailed looging in FabricUIManager
...
Summary: Apparently, we need this.
Reviewed By: mdvacca
Differential Revision: D7376350
fbshipit-source-id: 11d8ad54c7439e6c19a739ae1ac31af90d37166a
2018-03-25 22:48:18 -07:00
ee0cc6bbe7
Fabric: Implementing cloneAndReplaceChild() for ViewShadowNode
...
Summary:
First, LayoutableShadowNode::cloneAndReplaceChild() is now pure virtual. The default implementation was useless and confusing.
Second, cloneAndReplaceChild() is now fully implemented for ViewShadowNode, so fancy Yoga Concurrent layout *should* work now.
Reviewed By: mdvacca
Differential Revision: D7376352
fbshipit-source-id: 1199a37e64535c8592a2a5480e60139f61d02006
2018-03-25 22:48:18 -07:00
8f9212b839
Fabric: Fixed lost YogaNode's context in YogaLayoutableShadowNode
...
Summary: We replace yogaNode with newly creaded (by Yoga) one. So, we have to set up context.
Reviewed By: mdvacca
Differential Revision: D7376345
fbshipit-source-id: 7926a10e3f057fc385e7731c354827aeb8245760
2018-03-25 22:48:18 -07:00
1bb6db36be
Fabric: Removed unused copy constructor YogaLayoutableShadowNode()
...
Summary: Trivial. We don't use it, and it shouldn't be exist by desing.
Reviewed By: mdvacca
Differential Revision: D7376351
fbshipit-source-id: 22f03af2b3596c274a22bab1fab6d8af854a7374
2018-03-25 22:48:18 -07:00
53782eafc9
Fabric: Source shadow node is now stored as a weak pointer
...
Summary:
We use shource nodes only in the diffing alogorithm. It implies that we have strong pointers to those nodes in trees we compare against.
Using weak_ptr's allows to avoid memory leaks.
Reviewed By: mdvacca
Differential Revision: D7376348
fbshipit-source-id: 34e5f58f18a00475f6bcdfbea3996b41c84dff62
2018-03-25 22:48:18 -07:00
2cc75f7d47
Add YGNodeSetChildren(), YGNodeTraversePreOrder()
...
Reviewed By: Woody17
Differential Revision: D7360203
fbshipit-source-id: 32df8e1213ead03bc0a026ec4bf453bc799bb9ce
2018-03-25 14:35:04 -07:00
1acef45977
iOS: added placeholder test setup for fabric graphics/uimanager/view targets
...
Reviewed By: shergin
Differential Revision: D7390366
fbshipit-source-id: d49fcc335fc03d52402676341f1da24177c6084b
2018-03-23 22:22:20 -07:00
408a5f264b
iOS: added fabric/core ComponentDescriptor tests
...
Summary: Basic test for ComponentDescriptor mechanism.
Reviewed By: shergin
Differential Revision: D7388297
fbshipit-source-id: 3b0c625656e31df03d71a2e036388621a5e2e21d
2018-03-23 17:32:52 -07:00
e254474d4c
iOS: added fabric/core ShadowNode tests
...
Summary: basic tests for shadow nodes and props for fabric
Reviewed By: shergin
Differential Revision: D7377867
fbshipit-source-id: dc8e5bb369aeb32b4790fd8b56f333376bc1578c
2018-03-23 17:32:52 -07:00
8c0070c706
iOS: added fabric/core primitives tests
...
Summary: basic tests for fabric core primitives
Reviewed By: shergin
Differential Revision: D7373952
fbshipit-source-id: e2d9b3c15716c16b1aab698883817e670dcb7a57
2018-03-23 17:32:52 -07:00
10c95a25cc
fixed contacts for the test target
...
Reviewed By: mdvacca
Differential Revision: D7366977
fbshipit-source-id: 93341f8964da71a7e23049fc5d2324a0da376746
2018-03-22 10:49:44 -07:00
6ae38feb65
Added sample iOS unit test setup for fabric/debug target
...
Summary: basic setup for unit testing Fabric impl
Reviewed By: hramos
Differential Revision: D7359239
fbshipit-source-id: ccaf36e775036f2fad4d8c882bce86bbbe06dd28
2018-03-21 16:40:06 -07:00
f015900d30
fixed debug string formatting for structure
...
Summary:
Fixed minor issue:
* use double spaces instead of a tab character for indentation
* depth should increase by 1, not 2
Reviewed By: shergin
Differential Revision: D7332803
fbshipit-source-id: 74fda2c7a4be4f509270d3074a7d71a3d4d32fe4
2018-03-21 16:40:06 -07:00
cb3103ce09
Mark more member functions as const
...
Reviewed By: priteshrnandgaonkar
Differential Revision: D7291364
fbshipit-source-id: 2e7d96cfe0345692ffa411bb21a80eb7a859880b
2018-03-21 16:40:06 -07:00
ed0ba1bfc7
Pass some constructor argumetns by const-reference
...
Reviewed By: priteshrnandgaonkar
Differential Revision: D7291363
fbshipit-source-id: 22e606d0b3fa1133d7e0334c8cf9f5f1f32fe64b
2018-03-21 16:40:06 -07:00
0b085a80bd
Pass-by-reference in YGNode::setStyle() ::setChildren() ::setLayout()
...
Reviewed By: priteshrnandgaonkar
Differential Revision: D7291096
fbshipit-source-id: 7a4025831811d622050adbb5f86608855b94d68e
2018-03-21 16:40:06 -07:00
cf036dbc7a
Updates Yoga to handle being in a Xcode framework project
...
Summary:
Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga https://github.com/facebook/yoga/pull/726
(Which should also get merged too please ❤️ )
Set it manually in my own project and tested 👍
Only https://github.com/facebook/yoga/pull/726
[IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks.
Closes https://github.com/facebook/react-native/pull/18492
Differential Revision: D7355907
Pulled By: hramos
fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
2018-03-21 14:15:33 -07:00
b808bfdce2
Fabric: Introducting `ShadowNode.sourceNode`, the node used in copy-constructor
...
Summary: We will need this later in the diffing alogrithm.
Reviewed By: fkgozali
Differential Revision: D7330337
fbshipit-source-id: 3da44a62e4d5f30deed28b18a5779544153244f3
2018-03-19 17:08:31 -07:00
39383d1189
Fabric: Improved YogaLayoutableShadowNode printing
...
Summary: `LTR` is actually a default value for `direction` here, because an `inherit` value makes no sense for YGLayout (because it's *computed* value by definition).
Reviewed By: fkgozali
Differential Revision: D7330335
fbshipit-source-id: b3c7736c104689f2296e150f0cf57d622483d537
2018-03-19 17:08:31 -07:00
ff288b7416
Fabric: Complete implementation of `layoutMetricsFromYogaNode`
...
Summary: That was simply incomplete.
Reviewed By: fkgozali
Differential Revision: D7330336
fbshipit-source-id: c495c7f61d8e551fa963bfa6cc0408343eb8439b
2018-03-19 17:08:31 -07:00
a5a34565e0
Fabric: Proper return value of `LayoutableShadowNode::setLayoutMetrics()`
...
Summary: `LayoutableShadowNode::setLayoutMetrics()` must return `false` is nothing was changes.
Reviewed By: fkgozali
Differential Revision: D7330334
fbshipit-source-id: 700d50b0047919fa2b919acfa72825f100cd496f
2018-03-19 17:08:31 -07:00
aaaa946e6d
Fabric: Equality operators for geometry types
...
Summary: We will need this soon.
Reviewed By: fkgozali
Differential Revision: D7330338
fbshipit-source-id: 30aeadc182893e86c6a039c74d245f9b56624151
2018-03-19 17:08:31 -07:00
12535ae69d
Fix clang-6 strictness surrounding virtual destructors
...
Reviewed By: smeenai
Differential Revision: D7326765
fbshipit-source-id: 9df477dfa89812e05e79b5e6d510bcbbc793381c
2018-03-19 15:00:09 -07:00
f42b5892a1
iOS C++: Add ICxxExceptionManager to access RCTExceptionsManager native module
...
Summary: It is sometimes useful to report soft/fatal errors from C++ (native) to the same RCTExceptionsManager that is already handling JS exceptions. `ICxxExceptionManager` is an approach to provide such access, which impl provided for ObjC++.
Reviewed By: shergin
Differential Revision: D7224944
fbshipit-source-id: 8c607226b67851d46f4c787f5b6e6c8cb6a1afea
2018-03-19 00:06:57 -07:00
378da73201
DebugStringConvertibleOptions: Formating
...
Summary:
DebugStringConvertibleOptions allows pretty-format debug strings.
https://pxl.cl/ch0m
Reviewed By: fkgozali
Differential Revision: D7312622
fbshipit-source-id: 0ed62520bbc521790bedf5a6d18c796b42f85658
2018-03-18 19:17:39 -07:00
4cda0df2e5
Switching to the new FabricUIManager and all new shadow tree infra
...
Reviewed By: fkgozali
Differential Revision: D7230670
fbshipit-source-id: bca7d2859b87931c0d15406782b7d689de1d8c36
2018-03-18 19:17:39 -07:00
c2ad59a277
`fabric/uimanager` module
...
Summary: `fabric/uimanager` implements FabricUIModule.
Reviewed By: fkgozali
Differential Revision: D7230669
fbshipit-source-id: db6228021352598feac7854b5871d9d6c5c85119
2018-03-18 19:17:39 -07:00
965e60b05a
`fabric/view` module
...
Summary: Defines `<View>`: Yoga-powered, Accessible and styleable component.
Reviewed By: fkgozali
Differential Revision: D7230673
fbshipit-source-id: 08a1d8626c0b41260fafdca938d4fe9489b1b793
2018-03-18 19:17:39 -07:00
6b0960cbdb
Introducing `ConcreteShadowNode`
...
Summary: ConcreteShadowNode defines a template which connects typed Props and typed ShadowNode.
Reviewed By: fkgozali
Differential Revision: D7230667
fbshipit-source-id: be28314d6846d69960e921da852f01232951f965
2018-03-18 19:17:39 -07:00
811d5bfc73
Introducing LayoutableShadowNode
...
Summary: LayoutableShadowNode defines a unified interface (and set of primitives) essential for laying out shadow nodes.
Reviewed By: fkgozali
Differential Revision: D7230668
fbshipit-source-id: d8c1772d4c3bd1f87c41f7240a39aecebf3696ae
2018-03-18 19:17:39 -07:00
840638c441
Introducing `ComponentDescriptor`
...
Summary:
Abstract class and default template implementation.
`ComponentDescriptor`s define basic logic of managing (creation, cloning, applying props) ShadowNode of particular type.
Reviewed By: fkgozali
Differential Revision: D7230671
fbshipit-source-id: c32636f4db0716b55a1637f61c4f1872fc52cea7
2018-03-18 19:17:39 -07:00
608d1fb590
`fabric/graphics` module: all about graphics
...
Summary: `fabric/graphics` provides graphics primitives; the implementation should be platform-specific eventually.
Reviewed By: fkgozali
Differential Revision: D7230675
fbshipit-source-id: ff05d2673072fad5ee6f331f0155561969e1a8b6
2018-03-18 19:17:39 -07:00
c623455845
Abstract classes for ShadowNode and Props
...
Summary: Foundation clases for Fabric designed to be "const-first".
Reviewed By: fkgozali
Differential Revision: D7230672
fbshipit-source-id: 433acd35a7958d5d577358b0a306923f970e573f
2018-03-18 19:17:39 -07:00
d16772a31e
Sealable: fixed semantic; atomic type for the flag variable
...
Summary:
* Fixed semantic: all kinds of derivative instances lose `sealed` flag (which is expected);
* Using atomic<bool> for `sealed_` ivar.
Reviewed By: fkgozali
Differential Revision: D7230674
fbshipit-source-id: abe786610c20a45a0fabb9068120e24adeeeac7f
2018-03-18 19:17:39 -07:00
9102ff94e7
Moved YGFloatOptional from C struct to C++ struct
...
Reviewed By: emilsjolander
Differential Revision: D7288555
fbshipit-source-id: f61cc92c8fd0d48d2fc1f4d0e6fcef155f19ff8a
2018-03-15 12:41:16 -07:00
ce92b8592b
Fixed a typo and added a test case
...
Reviewed By: emilsjolander
Differential Revision: D7289221
fbshipit-source-id: 48ee9ccfac4adee51d515a366b5a11790f7236fc
2018-03-15 12:41:16 -07:00
8e85bf84e8
Gatekeeper for Native Extensions
...
Reviewed By: danzimm, johnislarry
Differential Revision: D6965463
fbshipit-source-id: 28bcfbff980abfda3c63d7016ccf05beb1d178eb
2018-03-15 09:27:40 -07:00
c989ea8728
Extract NativeExtensionsProvider definition
...
Reviewed By: danzimm
Differential Revision: D6964355
fbshipit-source-id: e20dfa99bd9d8784a5f31a313302104d6dc33652
2018-03-15 09:27:40 -07:00
da2d410122
Fix getters and setters if min and max Dimension
...
Reviewed By: emilsjolander
Differential Revision: D7274807
fbshipit-source-id: 7c1a4c19e8d0552b089a410c3330392cb26a6a47
2018-03-15 07:23:13 -07:00
040642dba3
Fix setter and getter of margin, position, border and padding
...
Reviewed By: emilsjolander
Differential Revision: D7274115
fbshipit-source-id: 942a91e6562ef789ae79102a828f397889468fa7
2018-03-15 07:23:13 -07:00
321b107685
Expose layout diffing flag to java
...
Reviewed By: emilsjolander
Differential Revision: D7272067
fbshipit-source-id: e67e82eb057e4c7124904c715f9dca4dcfea21ea
2018-03-14 08:48:52 -07:00
f3ef8f8510
Remove the use of YGUndefined for flex-basis
...
Reviewed By: emilsjolander
Differential Revision: D7243924
fbshipit-source-id: 2bfaca1a5e3da40d5292a273cabf705f59c9d666
2018-03-14 04:34:04 -07:00
e3af1508c8
Change the type of flexShrink to YGFloatOptional
...
Reviewed By: emilsjolander
Differential Revision: D7232171
fbshipit-source-id: 3111119d3d74a7035c01132bff61b30cf44e120a
2018-03-14 04:34:04 -07:00
3274e9fa51
Change the type of flexGrow to YGFloatOptional
...
Reviewed By: emilsjolander
Differential Revision: D7215355
fbshipit-source-id: 1298ee332551d44e4d070169a1e4103d005c4f43
2018-03-14 04:34:04 -07:00
5b3d59598a
Change the type of flex to YGFloatOptional
...
Reviewed By: emilsjolander
Differential Revision: D7211327
fbshipit-source-id: 0d979b6ba00317317b98bbc6e63979c7f1feb2da
2018-03-14 04:34:04 -07:00
9f7e70363a
Changed the return type of YGResolveValue
...
Reviewed By: emilsjolander
Differential Revision: D7195099
fbshipit-source-id: 72c4163cd08691cf6e40df05394cc52e83b0de14
2018-03-14 04:34:03 -07:00
af4a36337d
Remove the usage of YGUndefined in the default values of Border in YGStyle
...
Reviewed By: emilsjolander
Differential Revision: D7195115
fbshipit-source-id: e635cf55ac94d8a90caef6cafce281579da2cbfc
2018-03-14 04:34:02 -07:00
19dd9a2ce6
Use -fdata-sections in mode/opt
...
Differential Revision: D7194366
fbshipit-source-id: 676f2db2e493230b8d9698941f003ec4e96f15ea
2018-03-12 06:34:59 -07:00
3c86701ea7
`fabric/core` module and `Sealable` class
...
Summary:
`Sealable` class represents something which can be *sealed* (imperatively marked as immutable).
Authored by shergin
Reviewed By: shergin
Differential Revision: D7174883
fbshipit-source-id: 8b26ca5b1a5154953a099895778eab86228acc46
2018-03-08 18:04:28 -08:00
34f8e7f848
`fabric/debug` module and `DebugStringConvertible` class
...
Summary:
This is a very first diff in a series of undefined length implementing React Native Shadow Tree infra in C++.
All Shadow Nodes, Props and etc. implements `DebugStringConvertible`.
Authored by shergin
Reviewed By: shergin
Differential Revision: D7163868
fbshipit-source-id: 9c001aa5bd0723f709a07b1833f512c51e3bec11
2018-03-08 18:04:28 -08:00
5f497ca302
Convert constant with build flags to function
...
Reviewed By: ttsugriy
Differential Revision: D7184372
fbshipit-source-id: c66f473ad15898532f24c6276898ab250e749744
2018-03-08 00:17:53 -08:00
7bf3b20837
iOS: create C++ <-> ObjC++ connector for FabricUIManager to do UI operations
...
Reviewed By: shergin
Differential Revision: D7162911
fbshipit-source-id: 3e303020dafdccc51f52c3359a7054dc8a787978
2018-03-07 16:54:16 -08:00
19a4a7d3cb
Remove callFunctionSync experimental APIs
...
Reviewed By: michalgr
Differential Revision: D6124038
fbshipit-source-id: 219afe30783da92cf10f800dc35e64823b61cf4b
2018-03-05 14:32:00 -08:00
f389ad8b76
Move fb_xplat_cxx.bzl to xplat/build_defs
...
Reviewed By: mzlee, ttsugriy
Differential Revision: D7152463
fbshipit-source-id: ad7ca85f225343a043e2f606c6b3bbf74f42bbcd
2018-03-05 10:55:50 -08:00
b181b7797f
Check PATENTS does not creep into files
...
Summary:
Some files have crept into the repo with the old license header. These are usually from PRs that were opened prior to the re-licensing of the project.
Let the script run, prior to fixing the errant files. The script outputs the following:
```
PATENTS crept into some new files?
--- /dev/fd/63 2018-03-01 01:42:48.250153746 +0000
+++ /dev/fd/62 2018-03-01 01:42:48.250153746 +0000
@@ -1 +1,9 @@
+Libraries/NativeAnimation/Nodes/RCTTrackingAnimatedNode.h
+Libraries/NativeAnimation/Nodes/RCTTrackingAnimatedNode.m
+ReactAndroid/src/main/java/com/facebook/react/animated/TrackingAnimatedNode.java
+ReactAndroid/src/main/java/com/facebook/react/views/text/CustomLetterSpacingSpan.java
+ReactCommon/yoga/yoga/YGLayout.cpp
+ReactCommon/yoga/yoga/YGLayout.h
+ReactCommon/yoga/yoga/YGStyle.cpp
+ReactCommon/yoga/yoga/YGStyle.h
scripts/circleci/check_license.sh
Exited with code 1
```
Fix the headers in these files and run the script again. No output, exit code 0.
Closes https://github.com/facebook/react-native/pull/18143
Reviewed By: sophiebits
Differential Revision: D7119356
Pulled By: hramos
fbshipit-source-id: d238e4d4a3ae320a2c8e625c2fa29690057a4814
2018-03-01 08:22:05 -08:00
d174ab8a7a
Change NaN with large number
...
Reviewed By: emilsjolander
Differential Revision: D6969537
fbshipit-source-id: bdc09eaf703e0d313ca65c25a4fb44c99203d9bf
2018-03-01 04:02:01 -08:00
0bc80e9a72
Use #include instead of #import
...
Reviewed By: compnerd
Differential Revision: D7114385
fbshipit-source-id: a443770910714aab1af3f3ac5e932f6aaf1afe99
2018-02-28 15:41:43 -08:00
52acbbdd62
iOS: adjusted JSI binding for C++ FabricUIManager
...
Reviewed By: sebmarkbage, shergin
Differential Revision: D7078631
fbshipit-source-id: 6df21e52d3941372a9845fdcf2aed777de7cb359
2018-02-27 08:42:14 -08:00
84ad5d3d3c
Explicitly handle null props in bindings
...
Reviewed By: fkgozali, mdvacca
Differential Revision: D7080813
fbshipit-source-id: 7c9706df719a39e11a3d99c2de38af992b62dabf
2018-02-26 19:46:51 -08:00
0ee03178a0
added C++ setup for FabricUIManager
...
Reviewed By: shergin
Differential Revision: D7077312
fbshipit-source-id: e284c151438eb4d1f67a8386580ab54e3dce7c17
2018-02-23 19:49:03 -08:00
22cf81571b
Added default constructor for YGCachedMeasurement
...
Reviewed By: emilsjolander
Differential Revision: D7020337
fbshipit-source-id: e084e234bf6a2ae22e53e739959683abca169b88
2018-02-20 05:55:36 -08:00
c75ce8146f
Add constructor in YGLayout
...
Reviewed By: emilsjolander
Differential Revision: D7019653
fbshipit-source-id: 5a2655626db0915fcebe7d4517e2d0b2e2484460
2018-02-20 05:55:36 -08:00
b9991d33e3
Move YGStyle to seperate file and add constructors
...
Reviewed By: emilsjolander
Differential Revision: D7016575
fbshipit-source-id: eb28df0ffb4cc813b23edaff80d7d4ebc56ce6af
2018-02-20 05:55:36 -08:00
26684cf3ad
Update to MIT license
...
Summary: Manual changes.
Reviewed By: TheSavior, yungsters
Differential Revision: D7012152
fbshipit-source-id: de7459be3db13c687868b45059856f125c4f2eb1
2018-02-16 18:31:53 -08:00
1490ab12ef
Update license headers for MIT license
...
Summary:
Includes React Native and its dependencies Fresco, Metro, and Yoga. Excludes samples/examples/docs.
find: ^(?:( *)|( *(?:[\*~#]|::))( )? *)?Copyright (?:\(c\) )?(\d{4})\b.+Facebook[\s\S]+?BSD[\s\S]+?(?:this source tree|the same directory)\.$
replace: $1$2$3Copyright (c) $4-present, Facebook, Inc.\n$2\n$1$2$3This source code is licensed under the MIT license found in the\n$1$2$3LICENSE file in the root directory of this source tree.
Reviewed By: TheSavior, yungsters
Differential Revision: D7007050
fbshipit-source-id: 37dd6bf0ffec0923bfc99c260bb330683f35553e
2018-02-16 18:31:53 -08:00
f751c3460e
Fix main size calculation from the aspect ratio
...
Summary:
When the following conditions are met, the main size become smaller by the margins in the main axis.
* The aspect ratio is defined
* The main size is not defined
* The cross size is defined
* The main margin is defined
This is because the main margin size is not included when calculating the main size from the aspect ratio.
Closes https://github.com/facebook/yoga/pull/715
Reviewed By: emilsjolander
Differential Revision: D6998988
Pulled By: priteshrnandgaonkar
fbshipit-source-id: f6f69c47ece17bd7c5e41517b96032bf0c149356
2018-02-15 07:26:52 -08:00
ad2d9e7fab
Forward VM version to inspector
...
Reviewed By: bnham
Differential Revision: D6938018
fbshipit-source-id: c79853ddf835acab86a16ebd539874d29d3aa60a
2018-02-13 08:16:50 -08:00
fdef3784f0
Add flag in YGConfig for running experiments
...
Reviewed By: emilsjolander
Differential Revision: D6948702
fbshipit-source-id: 009fe2d64b6098f8c3a0289f0e6939dea5ce0d37
2018-02-09 06:16:36 -08:00
400a29e151
Fix memory leak by not duplicating the YGConfig
...
Reviewed By: emilsjolander
Differential Revision: D6945022
fbshipit-source-id: 5fd3c3e2ac1cd94d459d5aa06e0daa8f107779ac
2018-02-09 04:56:49 -08:00
1a1a956831
JSIExecutor Bundle Splitting Support
...
Reviewed By: mhorowitz
Differential Revision: D6847638
fbshipit-source-id: d9ae3d182d6f07bcac81cfd06dcc19f8139bb1e4
2018-02-09 03:45:37 -08:00
a8c95d2417
Convert fb_xplat_cxx to Skylark
...
Reviewed By: ttsugriy
Differential Revision: D6937683
fbshipit-source-id: 472c95b393d054c29413a46b86bf03559aff8741
2018-02-08 13:16:55 -08:00
79a63d040f
Skylarkify RN defs.
...
Reviewed By: adamjernst
Differential Revision: D6934209
fbshipit-source-id: 59f50b739482a53473c157f9e0183024dc88dc67
2018-02-08 09:47:28 -08:00
528bbacf6b
Expose a function which marks all descendants dirty
...
Reviewed By: emilsjolander
Differential Revision: D6911869
fbshipit-source-id: e0a3abcf5653f921297edfdca473d83b947cc627
2018-02-08 05:04:02 -08:00
f75e21f1ca
call margin method on child instead of node
...
Reviewed By: emilsjolander
Differential Revision: D6918367
fbshipit-source-id: cee90e015f9e45a717a7307f59fd3b9ef6f399b6
2018-02-07 17:37:56 -08:00
64d530ba07
Fix screenshot test due main axis justification refactor
...
Reviewed By: emilsjolander
Differential Revision: D6923178
fbshipit-source-id: d8f81b06d9127c75daecffb73b5e6c5abbad8ade
2018-02-07 08:45:46 -08:00
0c49c1f332
Native Modules -> Native Extensions
...
Reviewed By: danzimm
Differential Revision: D6887988
fbshipit-source-id: 475c05f60a2e1ddcfaa9263ab363bff8a528236a
2018-02-07 08:07:13 -08:00
d3db764f38
Convert intent_binary_defs to Skylark
...
Reviewed By: ttsugriy
Differential Revision: D6910777
fbshipit-source-id: b661be9f2383ca93b940dc7b625f46ae9725ebd7
2018-02-06 22:32:41 -08:00
62d01006a1
Moved margin axis function as a method in YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6900003
fbshipit-source-id: a42da3bcd3126bf8c432c6740987b5ec0b572172
2018-02-06 08:46:05 -08:00
1475fc4856
Moved trailing padding and border function as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6899571
fbshipit-source-id: 7f686e8771d5a94aae502191516557b20c557d7c
2018-02-06 08:46:05 -08:00
9daa17458a
Moved out main axis justification logic to seperate function
...
Reviewed By: emilsjolander
Differential Revision: D6845997
fbshipit-source-id: fdb64e00de39427ce1d66d4fbfd06c23c0d32bcf
2018-02-06 08:46:05 -08:00
9658d9f82b
Fixed failing snapshot test
...
Reviewed By: emilsjolander
Differential Revision: D6901242
fbshipit-source-id: 7391d6a34fa28e9f92f4ff834755a89dd876fdad
2018-02-06 07:16:03 -08:00
816d417189
Delete RCTBatchedBridge
...
Summary:
I've talked to several major community users, and they're all ok with deleting this
code. There's several doc fixes which will make it easier for third
party developers which should land about the same time this will.
Also buried along with it is RCTJSCExecutor.
Reviewed By: javache
Differential Revision: D6880781
fbshipit-source-id: b4cb1143def6fd23a96290e478fa728adbedacd3
2018-02-05 12:02:35 -08:00
d4517ddb9f
Made a separate function for resolving flexible length
...
Reviewed By: emilsjolander
Differential Revision: D6834269
fbshipit-source-id: 954bc7fe8eb9256d353cdda27e5c64c076808e25
2018-02-05 07:04:54 -08:00
ca91f0e3ac
Seperate function for second pass
...
Reviewed By: emilsjolander
Differential Revision: D6833635
fbshipit-source-id: 7680a67db8bfe22f8fb86407159888882f3a3353
2018-02-05 07:04:54 -08:00
fda861a889
Replaced first pass with a function
...
Reviewed By: emilsjolander
Differential Revision: D6819719
fbshipit-source-id: e5e77c21d1dca2255433da3388887d9db3f7b642
2018-02-05 07:04:53 -08:00
34b7ec82b5
Moved out logic to calculate size consumed on a line into seperate function
...
Reviewed By: emilsjolander
Differential Revision: D6797640
fbshipit-source-id: ad9757e7d603c0ce57f452b1e5c404037605bed9
2018-02-05 07:04:53 -08:00
9f7cedbe14
Remove the use of legacy flag and log the diff if its used
...
Reviewed By: emilsjolander
Differential Revision: D6856812
fbshipit-source-id: e4724d80702cc75c1894e348e137b24e663573d2
2018-02-02 07:40:25 -08:00
9f57dedc17
Use delete instead of free
...
Reviewed By: richardjrossiii
Differential Revision: D6866064
fbshipit-source-id: a44828cedb5045b6c97179fb30ffd8c8dafcbfbe
2018-01-31 18:01:34 -08:00
2a3c37f424
Give IInspector a virtual destructor for correct InspectorImpl destruction
...
Reviewed By: bnham
Differential Revision: D6815637
fbshipit-source-id: bfd3bd4a664ec51d5364df512bfc9bc366f516c1
2018-01-25 20:31:58 -08:00
be8e7c6e65
Made logging logic dynamic to log string length
...
Reviewed By: emilsjolander
Differential Revision: D6784491
fbshipit-source-id: 26e4520a84be355ff992b808297ce7a95b3d09e3
2018-01-23 06:46:08 -08:00
b8e79a7e8b
Split folly/Memory out from headers-only targets
...
Reviewed By: yfeldblum
Differential Revision: D6732464
fbshipit-source-id: 9d9498e0faa02c2003ab0e363444b7a2be51fd93
2018-01-22 08:42:18 -08:00
4f2cc42a2d
Make xplat react native files buildable
...
Reviewed By: mzlee
Differential Revision: D6605611
fbshipit-source-id: baa33947319a27b95020924d177a9398a276dabe
2018-01-21 22:05:05 -08:00
cec2e80fc2
Fix dependencies
...
Reviewed By: adamjernst
Differential Revision: D6754488
fbshipit-source-id: 49f2a45d024c7bd6b52f51f7705bcd167a499e47
2018-01-20 12:16:52 -08:00
9e34cbda9d
Add Bundle Splitting support for source code bundles
...
Reviewed By: amnn
Differential Revision: D6695431
fbshipit-source-id: 76f4c09b7caadabad5b327af29c02afe61f31abd
2018-01-16 15:20:45 -08:00
d0f7d4d107
Use vector instead of linked list
...
Reviewed By: emilsjolander
Differential Revision: D6722959
fbshipit-source-id: 4e81176802b9a9319bc5f385c824a06be14a83a2
2018-01-16 09:36:09 -08:00
ee5c91c031
Fix for failing screenshot tests
...
Reviewed By: emilsjolander
Differential Revision: D6726745
fbshipit-source-id: 99f91aabe2337b23953724545f97695238f2124e
2018-01-16 09:16:01 -08:00
6bb8617f3a
Exposing `setDirtiedFunc` as plain C function YGNodeSetDirtiedFunc
...
Summary: Trivial. Those lines were lost during rebasing of the original commit.
Reviewed By: priteshrnandgaonkar
Differential Revision: D6717696
fbshipit-source-id: a5dce25427c8977352b3ae7ea01e546a540e0c13
2018-01-15 16:06:11 -08:00
831a1bb4b1
Moved leadingpaddingnandborder function as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6711991
fbshipit-source-id: 41ad7191bf8df6fe3131106436dc0c87e9dee297
2018-01-15 10:17:29 -08:00
2fe65b032e
Move trailing padding function as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6711897
fbshipit-source-id: fa2e1a8e31242358a6e94aef51368e2c2c58b79d
2018-01-15 10:17:29 -08:00
bd7bf94af9
Moved leading padding function as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6711830
fbshipit-source-id: d2f6f55ec23b007bb51f8a91385e02236f46dc7b
2018-01-15 10:17:29 -08:00
7f94bff89a
Resolve direction function is now as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6711755
fbshipit-source-id: a0e80596e10f0c7fb7a31b75377da4db846c4bbb
2018-01-15 10:17:29 -08:00
82088580ab
Move trailing border function as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6711666
fbshipit-source-id: fe4fdfc2db59d03beb763317e1a6f9de52f851d4
2018-01-15 10:17:29 -08:00
210ae5b95a
Move leading border function as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6711523
fbshipit-source-id: 76e90083a9dd0728dc9557cc3b0a1f431f3afd5d
2018-01-15 10:17:29 -08:00
2b27f1aa19
Moved YGNodeIsFlex as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6711536
fbshipit-source-id: e60be7da55e3e8d254eb253c141d219a37a76087
2018-01-15 10:17:28 -08:00
fcf2c7cf61
Refactored step3 of flexbox algorithm
...
Reviewed By: emilsjolander
Differential Revision: D6702749
fbshipit-source-id: 15dcc94ae30ac185e4d1c7d6e3744a40cfa47317
2018-01-15 10:17:28 -08:00
ac1c8c265e
Refactored the flexbox step to determine available space in main and cross dim
...
Reviewed By: emilsjolander
Differential Revision: D6693777
fbshipit-source-id: d6c87670e74bdc22b32916c2d77fe423d831b378
2018-01-15 06:05:24 -08:00
d2c569795c
Typos in comments and log messages
...
Summary:
No code changes, no testing required.
alligned -> aligned
allignment -> alignment
completly -> completely
conseptually -> conceptually
decendents -> descendants
indefinetly -> indefinitely
dimention -> dimension
doesnt -> doesn't
safegaurd -> safeguard
intialization -> initialization
hierachy -> hierarchy
happend -> happened
gaurd -> guard
programatically -> programmatically
initalized -> initialized
immidiately -> immediately
occured -> occurred
unkown -> unknown
neccessary -> necessary
neccesarily -> necessarily
occuring -> occurring
comoponent -> component
propogate -> propagate
recieved -> received
referece -> reference
perfomance -> performance
recieving -> receiving
subsquently -> subsequently
scoll -> scroll
suprisingly -> surprisingly
targetting -> targeting
tranform -> transform
symetrical -> symmetrical
wtih -> with
Closes https://github.com/facebook/react-native/pull/17578
Differential Revision: D6718791
Pulled By: shergin
fbshipit-source-id: 4ab79c1131ec5971d35a0c7199eba7ec0a0918ad
2018-01-12 22:18:45 -08:00
c8e98bbaf5
CI for Android fixed
...
Summary:
Fix for android github CI.
Github CI doesn't work without this change.
CI passes.
[INTERNAL] Android CI fix.
Closes https://github.com/facebook/react-native/pull/17551
Differential Revision: D6707477
Pulled By: hramos
fbshipit-source-id: f98515234da3b90ee3233523bcd7cc67ed82c1b4
2018-01-12 08:01:00 -08:00
8f358a2088
Report module id as string and as double, in case of invalid values are passed to nativeRequire
...
Differential Revision: D6695769
fbshipit-source-id: b578b9d52ed711fb5a3e51717ac555fa8a232d7a
2018-01-11 14:21:00 -08:00
702b7e877e
(almost) kill fbjsc
...
Reviewed By: johnislarry
Differential Revision: D6701327
fbshipit-source-id: 17630f336e2b275c1de30ebfa32d1cbfbc1b9634
2018-01-11 13:16:37 -08:00
4b4959a21c
Moved setPosition as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6683387
fbshipit-source-id: 83f64101faa700933771c69b222056ec2a6b8d1e
2018-01-11 05:13:56 -08:00
89c14579d0
Moved trailingmargin function as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6683313
fbshipit-source-id: 5ee458c2f4698768724901df0e3f5d8805c7c8f5
2018-01-11 05:13:51 -08:00
f0f4bee429
Moved getLeadingMargin as a function on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6683270
fbshipit-source-id: a26663006419e13cb783e9849183e3c665f59b3c
2018-01-11 05:13:47 -08:00
b709ff4f13
Moved getTrailingPosition function as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6683205
fbshipit-source-id: d30003d90d634c644d92c833e58165b073d4d13e
2018-01-11 05:13:45 -08:00
040197a485
Moved is isTrailingPos defined as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6683190
fbshipit-source-id: c37e57d02cc4475eb8181a2bb003c555bdb0aaea
2018-01-11 05:13:43 -08:00
98a74b0a2b
Moved isLeadingPos defined as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6682956
fbshipit-source-id: 31c60e0eae906e1434a6969f3cd786fcaf9097a5
2018-01-11 05:13:39 -08:00
00f1a37b2c
Moved YGNodeLeading position as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6682929
fbshipit-source-id: 3607aab1544b62b1126c5d75b2f6fb8f5ca2d45f
2018-01-11 05:13:33 -08:00
c2b0f34533
Introducing on-dirty handler (aka `YGNodeSetDirtiedFunc`)
...
Summary:
Currently, we can dirty leaf nodes with `measure` function, we also can get `dirty` status for any node, but we cannot handle a moment when this change happen. This diff introduces a new call-back-manner handler for it.
We need this to plug Yoga inside and outside other layout systems without maintaining own dirty propagation infrastructure.
Consider using Yoga for flex-box layout in React Native where we can have deeply nested layout like `<View><Text><View><Text/></View></Text></View>` where all content of all <Text> nodes are laid out using native text/inline (not flex-box!) layout system. In this case, when some change dirties some deeply nested Yoga node, we have to propagate the dirty state down to outer one. Having this handler makes possible to wire up `on-dirty` handler on the root node and `setDirtied` for the leaf node.
Removing custom dirting mechanism from React Native should drastically simplify rendering layer and bring a huge performance win.
Reviewed By: emilsjolander
Differential Revision: D6597856
fbshipit-source-id: 6588cd712f9c1dede4af32f3d326f90103e48ff0
2018-01-10 09:56:41 -08:00
b41d41fd40
Move utility functions to utils file
...
Reviewed By: emilsjolander
Differential Revision: D6682933
fbshipit-source-id: 0fd90fdaf5ca4f9b7a11cbd15d8c54c7d0ce8a03
2018-01-10 05:02:24 -08:00
a8d4666651
Fix warnings of casting and null pointer handling
...
Reviewed By: emilsjolander
Differential Revision: D6675111
fbshipit-source-id: 884659fabb05033b4d43d3aa6629e22481d39b7e
2018-01-09 04:30:56 -08:00
d85da86dc7
Move YGNodeResolveFlexShrink to a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6611418
fbshipit-source-id: 6e5ba39b555d313a967800589891027920112c15
2018-01-08 03:01:30 -08:00
6627d7723c
Moved YGResolveFlexGrow as a method on YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6611385
fbshipit-source-id: 71660946c469fac77c5ffa0284c793e6adc9db7b
2018-01-08 03:01:30 -08:00
0a9e652bdd
Move markDirtyInternal as a method in YGNode
...
Reviewed By: emilsjolander
Differential Revision: D6611287
fbshipit-source-id: 54402145d51ea717553ea136be739b9880a79817
2018-01-08 03:01:30 -08:00
28968e2c0b
Move YGCloneChildrenIfNeeded as a method on `YGNode`
...
Reviewed By: emilsjolander
Differential Revision: D6611155
fbshipit-source-id: 463723a363e0fbd2c7686f65226eca73236bd07e
2018-01-08 03:01:30 -08:00
1fd7315c3b
Remove unnecessary include
...
Reviewed By: mzlee
Differential Revision: D6638538
fbshipit-source-id: 4b11b8f4f88aa533ac0467348df36e5780bfbb70
2017-12-27 13:16:30 -08:00
33da6047a3
Include OSS defs in Yoga BUCK
...
Reviewed By: ttsugriy
Differential Revision: D6630280
fbshipit-source-id: 6355d4b64a39feb000d5a104f39733a90fc5a31e
2017-12-22 14:31:21 -08:00
a163f70f87
Optimize the performance of Origami
...
Reviewed By: emilsjolander
Differential Revision: D6619293
fbshipit-source-id: c1632efd97f47696b7f8bb1b3e763de92c707287
2017-12-22 06:51:09 -08:00
ba31d29dc9
Replace native cxx_library with fb-specific macros.
...
Reviewed By: adamjernst
Differential Revision: D6618153
fbshipit-source-id: 188e2ca3cc78efad6e71f0a22547e26abf2f62e1
2017-12-21 08:58:50 -08:00
4cdbb77c33
Do not set FB_ASSERTION_ENABLED
...
Reviewed By: emilsjolander
Differential Revision: D6611904
fbshipit-source-id: f01ac144159c1b333d8deb8cbb5ba0288e4bf7a4
2017-12-21 04:45:34 -08:00
f9f40cd3e4
JSBigString to MAP_PRIVATE not MAP_SHARED
...
Reviewed By: mhorowitz
Differential Revision: D6613463
fbshipit-source-id: 2553a0475ade061f3b70ffce90fcf4e0ceb7d9fa
2017-12-20 14:01:33 -08:00
59c7967627
document isInspectable
...
Reviewed By: mhorowitz
Differential Revision: D6601992
fbshipit-source-id: 4bd69f90943b14286e5618c70fc7eaca689fb02c
2017-12-20 02:30:47 -08:00
6ad1f0957a
Kill orphaned marker end in JSCExecutor
...
Reviewed By: mhorowitz
Differential Revision: D6594498
fbshipit-source-id: 67f281ded088bdbad3eb1e173882d4328c1fdc93
2017-12-19 14:00:36 -08:00
f1055bcac8
Make YGNode as c++ struct with properties exposed through accessors
...
Reviewed By: emilsjolander
Differential Revision: D6592257
fbshipit-source-id: 641e8b9462ad00731a094511f9f5608b23a6bb21
2017-12-19 11:32:49 -08:00
d89901fa60
Use wildcard instead of manual file addition
...
Reviewed By: emilsjolander
Differential Revision: D6601704
fbshipit-source-id: 9bac4bc1a8d9e40feb0111fc4c7a627d4d3c4270
2017-12-19 07:41:57 -08:00
15cd98b782
add isInspectable property
...
Reviewed By: Hypuk
Differential Revision: D6578736
fbshipit-source-id: a4229c3766125ff55cff50a49893b2385f9c8a6a
2017-12-18 13:32:36 -08:00
3852c42ad8
add isInspectable property
...
Reviewed By: Hypuk
Differential Revision: D6578737
fbshipit-source-id: 05143e4cf59b5be9e20ab79b83efbfaa7da059d8
2017-12-18 13:32:35 -08:00
bef7967f9a
move page registration logic in to jsinspector
...
Reviewed By: pakoito
Differential Revision: D6531199
fbshipit-source-id: ed1ae9e2f0c19e7656cd022e438693798320e55a
2017-12-15 09:20:13 -08:00
88f6f69152
Skylarkify config_utils_defs macros.
...
Reviewed By: adamjernst
Differential Revision: D6569785
fbshipit-source-id: d2f20cd648822846e59830614d4eb0f466252363
2017-12-14 18:52:18 -08:00
eca51eb46a
Type global hooks as function pointers
...
Reviewed By: danzimm
Differential Revision: D6568053
fbshipit-source-id: 94fdecaf066a36c9c916bbd7b23c2f0680d91895
2017-12-14 14:47:10 -08:00
434f432d5d
Meyers singleton jsc error extractor
...
Reviewed By: mhorowitz
Differential Revision: D6554142
fbshipit-source-id: f586cd7030130e4ccb069f9aed8fb1364c527e54
2017-12-13 12:35:11 -08:00
f8fe6b0c70
Explicitly #define isnan __builtin_isnan for Android clang-5 to mimic gcc's default behavior
...
Reviewed By: passy
Differential Revision: D6527499
fbshipit-source-id: 65d9e43c7e7d973a6c92e9863ebe469b35a24ac8
2017-12-12 17:02:08 -08:00
ed2bfcb35a
Skalarkify flags macros.
...
Reviewed By: adamjernst
Differential Revision: D6528242
fbshipit-source-id: f809cfb853d6615a1aa47e145063ef1d7f5838be
2017-12-09 22:06:09 -08:00
e76abfa036
Revert D6155682: Use clang-5.0 -Oz
...
Differential Revision: D6155682
fbshipit-source-id: 9139ed14e0d24784bf25b2783e364a511173ab83
2017-12-08 09:54:37 -08:00
f59140eb21
Use clang-5.0 -Oz
...
Reviewed By: mzlee
Differential Revision: D6155682
fbshipit-source-id: 2f64e742f4dc44be171274c2ad0a41fb1e7079d7
2017-12-07 13:32:23 -08:00
4034febb7e
Round size geometry for Button and RichText components.
...
Reviewed By: cuva
Differential Revision: D6466875
fbshipit-source-id: 62a480411e7d2354a6879917c42bbf0ee96cdadd
2017-12-06 16:33:34 -08:00
Héctor Ramos
Valentin Shergin
Jonathan Dann
Kevin Gozali
Orta
Naris Siamwalla
Pritesh Nandgaonkar
Dmitry Zakharov
Amir Livneh
Jakub Grzmiel
Dan Zimmerman
Jonathan Kim
Shoaib Meenai
Sebastian Markbage
Sophie Alpert
Yuichi ONO
Paco Estevez Garcia
Alex Dvornikov
Taras Tsugrii
Marc Horowitz
Mark Wang
Andy Toulouse
Michael Lee
Scott Wolchok
Semen Zhydenko
Sergei Dryganets
Michał Gregorczyk
Peter Ammon
Ben Nham
Max Sherman
Greg McGary
Yaroslav Pavlov