Commit Graph

1715 Commits

Author SHA1 Message Date
Danny Ryan 0e837c3386
update v-guide to v0.5.0 2019-03-13 12:17:21 -06:00
Hsiao-Wei Wang cdd59ae230
add return types to phase 1 functions
Co-Authored-By: djrtwo <dannyjryan@gmail.com>
2019-03-13 09:11:35 -06:00
Danny Ryan b40236685c
phase 1 nitpicks 2019-03-13 09:04:12 -06:00
Vitalik Buterin 3371dcc23b Added light client related files 2019-03-13 02:54:27 -05:00
Vitalik Buterin 34cd96be54 Added light client related files 2019-03-13 02:47:29 -05:00
Matthew Slipper e4a1ef16e6 Add networking specs 2019-03-12 13:46:58 -07:00
Danny Ryan e8a5cd0747
fix up for tests 2019-03-12 12:32:11 -06:00
Danny Ryan 6e04b2118c
Merge branch 'dev' into store-justified-root 2019-03-12 12:08:59 -06:00
Danny Ryan acf0f76d60
Merge branch 'dev' into JustinDrake-patch-1 2019-03-12 11:48:05 -06:00
Danny Ryan a68b050053
set fork values in genesis as bytes4 2019-03-12 11:35:59 -06:00
Danny Ryan 7b829227ee
Merge branch 'dev' into JustinDrake-patch-4 2019-03-12 11:28:33 -06:00
Danny Ryan 25f6647ef2
minor formatting 2019-03-12 11:07:20 -06:00
Danny Ryan bdaba00a58
Merge branch 'dev' into JustinDrake-patch-7 2019-03-12 10:56:22 -06:00
Justin 0a349f8bdc
Update 0_beacon-chain.md 2019-03-12 15:58:31 +00:00
Hsiao-Wei Wang 0f120415b5
Update specs/core/0_beacon-chain.md
Co-Authored-By: JustinDrake <drakefjustin@gmail.com>
2019-03-12 16:49:04 +01:00
Justin d8a3048f2c
Update 0_beacon-chain.md 2019-03-12 12:36:09 +00:00
Justin 64ba3a3107
Epoch-based proposer slashing
See #675 item 25.
2019-03-12 12:24:37 +00:00
Justin 6c35934060
Update 0_beacon-chain.md 2019-03-12 10:34:24 +00:00
Justin addf7b77ab
Update 0_beacon-chain.md 2019-03-12 10:26:34 +00:00
Justin 578bf02b6f
Update 0_beacon-chain.md 2019-03-12 10:17:34 +00:00
Justin a7544864d5
Update 0_beacon-chain.md 2019-03-12 10:02:52 +00:00
vbuterin 5266bbd378
Honest validator doc update for mandatory deposits
Co-requisite with #758.
2019-03-11 23:38:22 -05:00
vbuterin 4410a55c4d
Mandatory deposits
Resolves #675 point 5.
2019-03-11 23:30:08 -05:00
Danny Ryan 3916643ef6
only update justified epoch/root if changed 2019-03-11 18:23:17 -06:00
Justin 3459ea0838
Check proposer is not slashed 2019-03-11 22:07:34 +00:00
Danny Ryan f06a3b82e7
cache current and previous justified root in state 2019-03-11 14:38:10 -06:00
Danny Ryan bf6bdbb021
cleanup minor var errors 2019-03-11 12:38:11 -06:00
Danny Ryan 36efb4498f
Merge branch 'dev' into vbuterin-patch-3 2019-03-11 10:44:18 -06:00
Justin 0704297480
Update 0_beacon-chain.md 2019-03-11 17:28:39 +01:00
Danny Ryan 9c2d34d876
Merge branch 'dev' into min-time-to-exit 2019-03-11 09:45:39 -06:00
Danny Ryan 2c7c48a4e0
Merge pull request #751 from ethereum/JustinDrake-patch-8
Disallow duplicate voluntary exits
2019-03-11 09:09:53 -06:00
Justin 2d3d7e33b3
Weaken criterion for attestation inclusion
The invariant that `get_current_epoch(state) in [get_current_epoch(state), get_previous_epoch(state)]` is preserved, as well as symmetry/fairness across blocks.
2019-03-10 21:58:32 +01:00
Danny Ryan 641bfc2f2c
Merge pull request #744 from ethereum/empty-attestation-bug
minor execution bugs
2019-03-10 08:26:21 -06:00
Justin d425ea26e2
Update 0_beacon-chain.md 2019-03-10 13:50:28 +01:00
Justin b7376aea5c
Disallow duplicate voluntary exits
Stricter processing of voluntary exits to remove an edge case
2019-03-10 13:49:37 +01:00
Justin 02428ec252
Do not check withdrawal credentials for existing validators
We should not invalidate blocks that contain a deposit with an inconsistent withdrawal credential as that would stall the chain.
2019-03-10 13:25:57 +01:00
Danny Ryan 902e65e072
add min persistent committee period resitriction on exits 2019-03-08 15:16:06 -07:00
Danny Ryan 0f3e0ef2ad
Merge pull request #743 from ethereum/JustinDrake-patch-9
Minor cleanups
2019-03-08 14:59:39 -07:00
Danny Ryan 30e64d7de6
fix get_inactivity_penalty function signature 2019-03-08 12:14:21 -07:00
Danny Ryan f88db44e81
skip proposer bonus if no attestation for v index 2019-03-08 12:07:57 -07:00
Danny Ryan f72e856620
Merge branch 'dev' into JustinDrake-patch-7 2019-03-08 10:46:36 -07:00
Danny Ryan 29014d554e
Merge branch 'dev' into JustinDrake-patch-9 2019-03-08 10:39:26 -07:00
Justin f253feeacf
Update 0_beacon-chain.md 2019-03-08 18:34:51 +01:00
Justin f180eb5e9e
Update 0_beacon-chain.md 2019-03-08 18:14:00 +01:00
Justin de60533d72
Update 0_beacon-chain.md 2019-03-08 18:13:05 +01:00
Danny Ryan f081f23c31
cache more than just state root at start of state transition 2019-03-08 09:48:46 -07:00
Justin ecd93468a2
Update 0_beacon-chain.md 2019-03-08 17:38:19 +01:00
Justin 3aedf1226a
Update 0_beacon-chain.md
Did I get the type casting OK @hwwhww?
2019-03-08 17:36:58 +01:00
Justin 1141467349
Update 0_beacon-chain.md 2019-03-08 17:28:00 +01:00
Danny Ryan 9b598c91b7
Merge branch 'dev' into JustinDrake-patch-7 2019-03-08 09:10:08 -07:00
Danny Ryan 7dc61c6126
Merge branch 'dev' into epoch-start 2019-03-08 08:51:19 -07:00
Justin a51d7d5db5
Update 0_beacon-chain.md 2019-03-08 10:50:45 +01:00
Justin 12695425c9
Use hash_tree_root everywhere
And get rid of merkle_root. This is possible because of SSZ tuples.
2019-03-08 10:32:40 +01:00
vbuterin 8dcc1ba930 Break LMD GHOST ties in favor of higher hash tree roots (#737) 2019-03-08 09:58:38 +01:00
Justin 1f147486fc
Semantic fork versions and signature domains
Fix #706
2019-03-08 09:57:09 +01:00
Justin e74c79e353
Update 0_beacon-chain.md 2019-03-08 09:08:30 +01:00
Justin 33a05109ea
Fair proposer sampling
I think we want `first_committee[epoch % len(first_committee)]` as opposed to `first_committee[slot % len(first_committee)]`. The reason is that if the shuffling happens infrequently and `len(first_committee)` is a multiple of `SLOTS_PER_EPOCH` then the proposers will not be sampled fairly.

Taking this logic further, we may want to avoiding always picking the proposer from `first_committee`, e.g.:

```
    validators_at_slot = []
    for crosslink_committee, _ in get_crosslink_committees_at_slot(state, slot, registry_change):
        validators_at_slot.append(crosslink_committee)

    return validators_at_slot[epoch % len(validators_at_slot)]
```
2019-03-07 23:56:03 +01:00
Justin 339a7fb63b
Update 0_beacon-chain.md 2019-03-07 23:14:47 +01:00
Justin 2d9724dbfc
Update 0_beacon-chain.md 2019-03-07 23:13:06 +01:00
Danny Ryan e57bfaab7c
clean up state transition notes 2019-03-07 13:36:22 -07:00
Danny Ryan d00353534d
Merge branch 'dev' into epoch-start 2019-03-07 13:32:15 -07:00
Danny Ryan 6cf14884a8
epoch transition at start of epoch 2019-03-07 12:05:34 -07:00
Danny Ryan 8dec7d805c
reorder ssz types topologically 2019-03-07 11:02:13 -07:00
Hsiao-Wei Wang 250455a67e
Apply suggestions from code review
Co-Authored-By: djrtwo <dannyjryan@gmail.com>
2019-03-07 10:03:25 -07:00
Danny Ryan 987c741bea
fix state types 2019-03-07 09:44:55 -07:00
Danny Ryan b1baea2d28
Merge branch 'dev' into vbuterin-patch-7 2019-03-07 08:56:29 -07:00
vbuterin f9a07f7653
Fixed MIN_DEPOSIT_AMOUNT 2019-03-07 04:04:05 -06:00
vbuterin be4b912373
Added underflow checking to decrease_balance 2019-03-07 04:02:53 -06:00
vbuterin 0759e170a7
High/low balance separation
See #685 for reasoning
2019-03-07 01:38:03 -06:00
vbuterin ec12460b8b
Make wthdrawn validators immune to inactivity leak 2019-03-07 01:21:17 -06:00
vbuterin 663bc489b6
Added lexicographic tiebreaking 2019-03-06 22:54:52 -06:00
Danny Ryan 175dde7cf7
Merge branch 'dev' into patch-1 2019-03-06 15:56:35 -07:00
Danny Ryan 2f6e560e30
Merge branch 'dev' into vbuterin-patch-7 2019-03-06 15:07:20 -07:00
Danny Ryan 28f2a723af
Merge pull request #725 from ralexstokes/dev
Fix calls of `signed_root`
2019-03-06 15:03:20 -07:00
Danny Ryan fc9686636e
Merge pull request #724 from dankrad/dev
Make basic/non-basic for bytes explicit
2019-03-06 14:58:48 -07:00
Alex Stokes ee2fbd0df7
Fix calls of `signed_root` 2019-03-06 13:48:06 -08:00
Dankrad Feist 37b77725d8 Make basic/non-basic for bytes explicit 2019-03-06 22:32:26 +01:00
Dankrad Feist 81f48ea1c3 Also fix length of Deposit.proof 2019-03-06 21:11:50 +01:00
Akhila Raju f4e0d9804a Minor spelling fixes. 2019-03-06 12:03:03 -05:00
Dankrad Feist eece029cdf Array spec to [type] and tuple to [type, N]. Also make notation consistent: use "base" for base types 2019-03-06 17:46:40 +01:00
Dankrad Feist 9d175c9dc9 Merge branch 'dev' into patch-1 2019-03-06 17:28:09 +01:00
Carl Beekhuizen b4779cd83d
Apply suggestions from code review
Co-Authored-By: djrtwo <dannyjryan@gmail.com>
2019-03-06 08:55:39 -07:00
Carl Beekhuizen c9e06d31f3
Apply suggestions from code review
base_reward -> get_base_reward

Co-Authored-By: djrtwo <dannyjryan@gmail.com>
2019-03-06 07:29:06 -07:00
dankrad 776196e66d
Add tuple lengths
Adding tuple lengths in BeaconState objects (this changes merkleization/serialization as no length mixin required)
2019-03-06 14:46:52 +01:00
Danny Ryan b36e70040b
fix call to union 2019-03-05 16:18:41 -07:00
Danny Ryan b5f0509595
fix proposal slashing minor bugs 2019-03-05 11:29:40 -07:00
Danny Ryan be1cb4a850
Merge pull request #718 from ethereum/empty-base-reward
handle get_base_reward when no previous balance
2019-03-05 09:24:12 -07:00
Danny Ryan f93e6fe53d
Merge pull request #696 from ethereum/JustinDrake-patch-4
Rewrite SSZ spec
2019-03-05 09:22:33 -07:00
Danny Ryan 0eacabc273
fix minor typo 2019-03-05 08:51:34 -07:00
Danny Ryan 99da6fe141
fix advance_slot ordering issue 2019-03-05 08:50:51 -07:00
Justin 57971aacb4
Update simple-serialize.md 2019-03-05 15:20:36 +01:00
Danny Ryan e2a0452108 fix previous root (#716) 2019-03-05 14:07:00 +01:00
Hsiao-Wei Wang ecb76420ec
`1e9` is float in Python, change it to `10**9`. 2019-03-05 17:30:42 +08:00
Danny Ryan d2f7fa9a7e
fix call to get_current_epoch 2019-03-04 19:09:31 -07:00
Danny Ryan bd936fa6ab
add missing return for justification/finalization reward deltas 2019-03-04 19:07:24 -07:00
Danny Ryan 02e8e89740
handle get_base_reward when no previous balance 2019-03-04 19:05:00 -07:00
Danny Ryan 0fdfbc473e
minor variable issues in helpers 2019-03-04 18:53:31 -07:00
Danny Ryan 0f274a906c
Merge branch 'vbuterin-patch-7' of github.com:ethereum/eth2.0-specs into vbuterin-patch-7 2019-03-04 18:02:46 -07:00
Danny Ryan 738acf0e05
fix calls for get_total_balance 2019-03-04 18:00:38 -07:00
Danny Ryan 47cca60148 handle when no attestations availble for crosslinking (#717) 2019-03-04 18:56:50 -06:00
Danny Ryan 66105b01e4
previous epoch uses -1 in all cases 2019-03-04 17:27:53 -07:00
Danny Ryan d4a4c73599
fix calls to get_attesting_indices 2019-03-04 17:17:31 -07:00
Danny Ryan 8802f57790
add missing var to get_attesting_balance calls 2019-03-04 17:11:38 -07:00
Danny Ryan f7397a5970
add xor def 2019-03-04 15:49:21 -07:00
Danny Ryan a561656b68
add get_state_root helper 2019-03-04 11:45:41 -07:00
Danny Ryan 5ac30fdf77
Merge branch 'dev' into vbuterin-patch-7 2019-03-04 09:50:07 -07:00
Danny Ryan c4c1903460
Merge pull request #709 from ethereum/vbuterin-patch-6
Unified deposit processing between genesis and transaction
2019-03-04 09:49:38 -07:00
Danny Ryan 831f04e3ea
separate our rewards/penalty deltas 2019-03-04 09:45:55 -07:00
Danny Ryan 908d7c42ad
pr feedback 2019-03-04 09:17:43 -07:00
terence tsao e2ce0d9583
Update 0_beacon-chain.md 2019-03-04 06:45:55 -08:00
vbuterin 5282b289cf
exits -> voluntary_exits 2019-03-04 04:49:24 -06:00
vbuterin 044c87fe39
fix State -> BeaconState 2019-03-03 22:41:23 -06:00
Danny Ryan 1444687798
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-03 20:14:03 -06:00
Danny Ryan cc146475d9
Merge pull request #694 from ethereum/proposer-next-epoch
make get_beacon_proposer_index safe for next epoch
2019-03-03 17:01:20 -07:00
Danny Ryan 0444c2e05e
Merge branch 'dev' into vbuterin-patch-7 2019-03-03 16:58:54 -07:00
Danny Ryan 146aef313e
Merge pull request #699 from ethereum/start_shard_bug
fix committee assignment bugs
2019-03-03 16:53:57 -07:00
vbuterin 38e166d4a3
More python typos! 2019-03-03 06:01:03 -06:00
vbuterin 805ea5dad5
Transfer from -> sender
Needed to avoid triggering errors in python
2019-03-03 05:59:11 -06:00
vbuterin 68bc91bb3a
Fixed custody bit participants typo 2019-03-03 05:56:57 -06:00
vbuterin 73f9ad0512
Added missing colon 2019-03-03 05:54:58 -06:00
vbuterin d0fc455a1f
Assimilated #649 2019-03-03 05:04:28 -06:00
vbuterin dcb0205adc
Merge branch 'dev' into vbuterin-patch-7 2019-03-03 04:30:51 -06:00
vbuterin 46b1d4eef5
Assimilated #697 2019-03-03 04:28:13 -06:00
Hsiao-Wei Wang 868359a674
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-03 04:00:09 -06:00
Hsiao-Wei Wang cd7c7228c9
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-03 03:59:12 -06:00
Hsiao-Wei Wang 72c28bc59a
Refactor `process_slashings` 2019-03-03 17:58:45 +08:00
Hsiao-Wei Wang 19924f3148
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-03 03:58:18 -06:00
Hsiao-Wei Wang 07599b3a45
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-03 03:57:48 -06:00
Hsiao-Wei Wang 1103fd1ee8
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-03 03:57:27 -06:00
Hsiao-Wei Wang fa613b401f
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-03 03:56:54 -06:00
Hsiao-Wei Wang 2d6697eb62
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-03 03:56:12 -06:00
Hsiao-Wei Wang c42cab87a7
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-03 03:55:20 -06:00
Hsiao-Wei Wang c9a6215ab8
Merge pull request #713 from protolambda/protolambda-fix-randao-mixes
fix randao mixes type, bytes32 like in function and state spec
2019-03-03 13:50:34 +08:00
vbuterin cefe9e995b
Proof of custody game, take 2 (#682)
* Proof of custody game, take 2

Unfortunately not simpler than before, but moves challenges outside of the validator records and so keeps validator records constant-size.

* Removed unneeded challenge codes

* Formatting fixes
2019-03-02 20:36:04 -06:00
vbuterin fde66a7105
Update to make CC happy 2019-03-02 20:11:33 -06:00
protolambda f137f1ce90
fix randao mixes type, bytes32 like in function and state spec 2019-03-02 18:02:50 +01:00
vbuterin ce5599db2f
Made crosslink processing a function 2019-03-02 00:42:20 -06:00
vbuterin 0134e56010
Fixed table of contents 2019-03-02 00:40:43 -06:00
Hsiao-Wei Wang fa327a18ea
Add docstring 2019-03-02 13:51:48 +08:00
Hsiao-Wei Wang 00804da13e
Fix type hinting 2019-03-02 13:48:46 +08:00
vbuterin 4ad3529e4e
Finished epoch transition 2019-03-01 19:49:28 -06:00
vbuterin 2d4c8af489
Split up big function into two smaller functions 2019-03-01 19:34:26 -06:00
vbuterin 7c6232a602
Update 0_beacon-chain.md 2019-03-01 19:22:24 -06:00
vbuterin 4cc738dc53
Apply suggestions from code review
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 19:17:07 -06:00
Hsiao-Wei Wang e0b8eea7d6
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 19:12:31 -06:00
Hsiao-Wei Wang 46269310ee
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 19:12:21 -06:00
Hsiao-Wei Wang 6c1abbc2fc
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 19:12:11 -06:00
vbuterin b8d1003c2c
Updates to make HW and Danny happy 2019-03-01 19:11:13 -06:00
Hsiao-Wei Wang ec20edb80e
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 19:05:02 -06:00
Hsiao-Wei Wang 3d8e0f1920
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 19:04:55 -06:00
Hsiao-Wei Wang ff88d22f9a
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 19:04:49 -06:00
vbuterin 26179ede5f
branch -> proof 2019-03-01 19:01:40 -06:00
Hsiao-Wei Wang 0c24ca9bb0
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 18:59:55 -06:00
vbuterin 5ceec70dd3
Pythonize epoch transitions (in progress) 2019-03-01 07:59:52 -06:00
Justin 25ef2553c7
Update simple-serialize.md 2019-03-01 12:02:29 +01:00
vbuterin 236298a8e4
Hard assert that the Merkle branch is valid 2019-03-01 03:58:18 -06:00
Danny Ryan 19665e4ca5
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 00:16:05 -06:00
Danny Ryan 0fb4cae2d6
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 00:15:49 -06:00
Danny Ryan 5ed0f276f6
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 00:13:59 -06:00
Danny Ryan a9be1018d3
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 00:13:32 -06:00
Danny Ryan 19c3189c1c
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 00:13:22 -06:00
Danny Ryan 087576a7bb
Update specs/core/0_beacon-chain.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-03-01 00:12:45 -06:00
vbuterin 80ac62606c
Unified deposit processing between genesis and transaction 2019-02-28 21:07:10 -06:00
vbuterin d5900836aa
Convert transaction descriptions from English to python code
Only a change of presentation, does not make any substantive changes.

Does NOT handle Deposit transactions because that is a special case for which I recommend a deeper change (will do this in another PR soon).
2019-02-28 20:54:59 -06:00
Danny Ryan 8df7de150e
Merge pull request #703 from Nashatyrev/strict-active-validator
Make 'Any active validator' statements stricter.
2019-02-28 17:24:30 -07:00
Hsiao-Wei Wang bcb0b8bf87
Refactor `exit_validator` 2019-03-01 00:49:51 +08:00
Hsiao-Wei Wang bdd6868736
Fix ToC 2019-03-01 00:49:51 +08:00
Hsiao-Wei Wang b836b30bff
Fix "is_ready_to_exit" condition 2019-03-01 00:49:45 +08:00
Anton Nashatyrev f38dc048e4 Make 'Any active validator' statement more strict. 2019-02-28 17:17:00 +03:00
Hsiao-Wei Wang dbbfb93873
Order by `committees_per_epoch`, `seed`, `shuffling_epoch`, and
`shuffling_start_shard`
2019-02-28 19:07:37 +08:00
Justin 67793edc8d
Update simple-serialize.md 2019-02-28 11:34:24 +01:00
Justin 7ab7abe2ca
Update simple-serialize.md 2019-02-28 11:32:54 +01:00
Hsiao-Wei Wang 34091d70ec
Fix typo 2019-02-28 16:30:46 +08:00
Danny Ryan bb44d25665
Merge pull request #688 from decanus/patch-21
Use `slashed` bool more Pythonicly
2019-02-27 15:02:33 -07:00
Danny Ryan 5692b3483d
Update 0_beacon-chain.md 2019-02-27 15:02:11 -07:00
Danny Ryan 769afa704e
Merge pull request #684 from ethereum/vbuterin-patch-5
Developer notice
2019-02-27 14:58:29 -07:00
Justin 3e6934b602
Update simple-serialize.md 2019-02-27 22:44:20 +01:00
Justin 74349eacd2
Update simple-serialize.md 2019-02-27 22:33:36 +01:00
Danny Ryan 8176cc4cf0
Apply suggestions from code review
Co-Authored-By: JustinDrake <drakefjustin@gmail.com>
2019-02-27 22:23:42 +01:00
Danny Ryan c9ac8170f0
ensure that next committee assignemtns is stable when need to be 2019-02-27 11:37:54 -07:00
Danny Ryan e2f4e32332
fix committee start shard bug 2019-02-27 11:27:23 -07:00
Justin bac352e70f
Update simple-serialize.md 2019-02-27 18:02:53 +01:00
Justin 99074d09ec
Update simple-serialize.md 2019-02-27 18:00:49 +01:00
Justin e766193588
Update simple-serialize.md 2019-02-27 17:59:49 +01:00
Justin 54a81a8ebf
Update simple-serialize.md 2019-02-27 17:56:51 +01:00
Justin aa676354a0
Update simple-serialize.md 2019-02-27 17:54:19 +01:00
Justin 95fa9d56b8
Update simple-serialize.md 2019-02-27 17:35:26 +01:00
jannikluhn 828146cbf8
Apply suggestions from code review
Co-Authored-By: JustinDrake <drakefjustin@gmail.com>
2019-02-27 17:15:46 +01:00
Justin 0df8f8b3c6
Update simple-serialize.md 2019-02-27 13:04:36 +01:00
Justin e698d7e29b
Update simple-serialize.md 2019-02-27 12:57:06 +01:00
Justin 07922a63fb
Update simple-serialize.md 2019-02-27 12:54:56 +01:00
Justin 28cf5860ea
Update simple-serialize.md 2019-02-27 12:53:24 +01:00
Justin 5116645dfa
Update simple-serialize.md 2019-02-27 12:40:08 +01:00
Justin 313fe46a94
Update simple-serialize.md 2019-02-27 12:06:06 +01:00
Justin df50ac1adc
Update simple-serialize.md 2019-02-27 12:03:27 +01:00
Justin 5c5f15c82c
Rewrite SSZ spec
* Implement tuples and a chunk-size reduction to 32 bytes (see #665 and #679)
* Simplify presentation where appropriate. For example, deserialisation is implicit from serialisation (similar to `bls_sign` being implicit from `bls_verify`) and is left as an implementation exercise.
* Dramatically reduce spec size and hopefully improve readability.
2019-02-27 11:54:23 +01:00
vbuterin e9c3af5428
Update 1_shard-data-chains.md 2019-02-26 18:00:20 -06:00
Danny Ryan b2c53045fc
make get_beacon_proposer_index safe for next epoch 2019-02-26 15:55:27 -07:00
Alex Stokes e7d908f1f1
formatting nitpick
drop some parens in the spirit of consistency and parsimony
2019-02-26 14:45:25 -08:00
Dean Eigenmann 8b14a2bef5
Update 0_beacon-chain.md 2019-02-26 17:15:26 +01:00
Danny Ryan daa8275318 minor bug in validator doc `get_committee_assignment` (#689) 2019-02-26 12:19:28 +08:00
vbuterin 05f6f68028
Made developer notice less committal 2019-02-25 16:45:57 -06:00
Dean Eigenmann c9f1dfcbb3
Update 0_beacon-chain.md 2019-02-25 21:39:23 +01:00
Danny Ryan b2a3ee4bbc
skip bad proof of possession deposits 2019-02-25 09:36:52 -07:00
Danny Ryan fbb70e91eb
remove todo 2019-02-25 07:58:23 -07:00
Danny Ryan b2ed80250a
Merge pull request #678 from ethereum/JustinDrake-patch-6
Allow transfers from non-activated validators
2019-02-25 07:54:57 -07:00
vbuterin 6a92407702
Developer notice 2019-02-25 04:16:18 -06:00
Justin 6b5769a861
Update 0_beacon-chain.md 2019-02-25 10:30:03 +01:00
Danny Ryan 8c666e8930
Merge pull request #676 from ethereum/JustinDrake-patch-4
Specify lexicographic ordering of crosslink_data_root
2019-02-24 18:43:26 -07:00
Danny Ryan 8dbb7326ee
Merge pull request #673 from ethereum/genesis_committee_assign
make getting assignments more generic
2019-02-24 17:50:42 -07:00
Justin da6b5466d5
Allow transfers from non-activated validators
See item 6 in https://github.com/ethereum/eth2.0-specs/issues/675. This makes transfers more generic.
2019-02-23 20:25:55 +01:00
Justin 1d757aec74
Specify lexicographic ordering of crosslink_data_root
Fix #542.
2019-02-22 21:02:03 +01:00
Danny Ryan 060e3c36c5 fix up previous epoch logic around genesis (#672) 2019-02-22 20:51:09 +01:00
Hsiao-Wei Wang c96f709505
Update 0_beacon-chain-validator.md 2019-02-23 00:31:27 +08:00
Danny Ryan 06e6496bca
Merge pull request #662 from ethereum/vbuterin-patch-5
Rename shard_block_root -> crosslink_data_root
2019-02-22 08:51:01 -07:00
Danny Ryan b89cd234f0
change shard_block_root to crosslink_data_root throughout 2019-02-22 08:50:03 -07:00
Danny Ryan a683416537 Fix slot range for attestation inclusion (#669)
* Fix slot range for attestation inclusion

* Update specs/core/0_beacon-chain.md

Co-Authored-By: djrtwo <dannyjryan@gmail.com>
2019-02-22 23:36:36 +08:00
Danny Ryan d0d2fa10d9
Merge pull request #671 from ethereum/v-guide-bugs
validator guide bug fixes
2019-02-22 08:34:34 -07:00
Danny Ryan d27132cb0a
Merge pull request #658 from ethereum/vbuterin-patch-3
Turned slashed and initiated_exit into booleans
2019-02-22 08:34:17 -07:00
terence tsao 68b5fe5b9f
small typo
Co-Authored-By: djrtwo <dannyjryan@gmail.com>
2019-02-22 08:15:40 -07:00
Dean Eigenmann e1fc8a5765
Update 0_beacon-chain.md 2019-02-22 13:00:29 +01:00
Dean Eigenmann a8c3c45faf
Update 0_beacon-chain.md 2019-02-22 12:58:59 +01:00
Hsiao-Wei Wang e8d41fd889
Fix missing `get_epoch_start_slot()` 2019-02-22 14:30:07 +08:00
vbuterin f77b9e2414
Changed name to crosslink data commitment 2019-02-22 00:21:56 -06:00
Danny Ryan 8169229f5a
clean up 2019-02-21 16:58:58 -07:00
Danny Ryan f28af3f72b
Add spacing 2019-02-21 16:56:43 -07:00
Danny Ryan 2bd6057c12
make getting assignments more generic 2019-02-21 16:53:52 -07:00
Danny Ryan d31aeacd3c
fix minor errors per #628 2019-02-21 15:18:41 -07:00
Danny Ryan 0f222171ca
fix epoch boundary root per #652 2019-02-21 15:14:59 -07:00
Danny Ryan 830ae3be9a
Merge pull request #655 from ethereum/JustinDrake-patch-4
Reduce GENESIS_SLOT to 2**32
2019-02-21 14:51:12 -07:00
Justin 5f59aad00d
Clarify use of `FAR_FUTURE_EPOCH` as a flag 2019-02-21 22:34:11 +01:00
Hsiao-Wei Wang 26908d5579 Fix constant name `MIN_VALIDATOR_WITHDRAWABILITY_DELAY` -> `MIN_VALIDATOR_WITHDRAWABILITY_DELAY` (#661) 2019-02-20 15:58:25 +00:00
Hsiao-Wei Wang a79fa398f1 Minor fix: `messages` -> `message_hashes` (#664) 2019-02-20 11:42:53 +00:00
Justin e25e87f003
Update 0_beacon-chain.md 2019-02-20 07:45:19 +00:00
Justin 9ac61e57c0
Update 0_beacon-chain.md 2019-02-20 07:18:12 +00:00
vbuterin 461cd8b599
Rename shard_block_root -> shard_data_commitment 2019-02-20 00:46:28 -06:00
vbuterin 09e8448763
Turned slashed and initiated_exit into booleans
Cuts validator record size from 120 to 106 bytes, and arguably is a simplification
2019-02-19 20:00:46 -06:00
Alex Stokes 8262ce1cc0
Fix typo from earlier renaming in #534. 2019-02-19 15:09:11 -07:00
Justin 9b7b35bc9d
Reduce GENESIS_SLOT to 2**32
* Address the slot/epoch underflow problem, even for Java implementers! 🎉
* Squash a bug with `get_previous_epoch`
* Fix #642
* Address #626 (Vitalik, Danny, myself agree that avoiding signed integers is probably best)
2019-02-19 21:08:10 +00:00
terence tsao a3d85c8405 Update 0_beacon-chain.md (#654) 2019-02-19 17:49:37 +00:00
sigmoid 00aa553fee updated SSZ implementation list (#653)
* updated SSZ implementation list

Signed-off-by: sigmoid <alphabet@hotmail.co.kr>

* Update specs/simple-serialize.md

Co-Authored-By: NAKsir-melody <alphabet@hotmail.co.kr>
2019-02-20 00:47:15 +08:00
vbuterin 2540f55c13
Updated phase 1: branch and early subkey reveal challenges (#587)
* Updated phase 1: branch challenges

* Removed unnecessary line

* Added early subkey reveal slashing

* Revealing during the active period is still revealing early

* Added....

* Machinery for publishing old subkeys
* Inability to withdraw until you published all subkeys
* After a validator exits the queue there's still a minimum 1-day delay before they can withdraw (in the future this delay will be used as an opportunity to start a PoC challenge game)

* Update 1_shard-data-chains.md

* formatting

* minor edits

* Added masking scheme for reveals

Secure under the aggregate extraction infeasibility assumption described on pages 11-12 of https://crypto.stanford.edu/~dabo/pubs/papers/aggreg.pdf

* Added rewards going to challengers

* Add ToC and reorg the constant tables

* Remove tags

* fix constant formatting

* normalize domain constants in phase 1

* Update 1_shard-data-chains.md

* Update 1_shard-data-chains.md

* Update 1_shard-data-chains.md

* Added transition logic

* Fix ToC

* Fix ToC

* Adjusted for #615

* Added more helpers

* epoch -> slot

* fix some type hints

* clean up `get_attestation_merkle_depth`
2019-02-19 05:26:35 -06:00
terence tsao f0b562054f Update 0_beacon-chain-validator.md (#650) 2019-02-19 16:19:31 +08:00
Danny Ryan 0bc3998c89
Merge pull request #641 from paulhauner/patch-11
Fix out-of-bounds in `get_shuffling`
2019-02-18 10:22:57 -07:00
Danny Ryan 75e649cc15
Merge pull request #634 from paulhauner/patch-10
Add explicit assert to get_permutated_index
2019-02-18 10:14:07 -07:00
Danny Ryan 9eb3be5471
Merge branch 'dev' into JustinDrake-patch-1 2019-02-17 21:16:45 -07:00
Cayman 5fbbb4f181 Clarify merkle_root documentation (#646)
This function is used to get the merkle root of some block roots which are themselves hashes, so the leaves do not need to be rehashed.
Unfortunately, it's easy to assume that a merkle_root function would hash its leaves, so it should be clarified.
2019-02-18 12:11:01 +08:00
Cayman eea413bcc5 Fix typos (#648) 2019-02-17 22:53:59 +00:00
vbuterin 59ade930d6 Signature hashing proposal (#625)
If this is accepted, then we can replace all uses of signing in the protocol, which are currently done in a relatively inconsistent way (see proposer signatures, attester signatures, shard proposer signatures, exit message signatures.....) could be unified.
2019-02-16 21:44:27 +00:00
Justin 4baa13050e
Update 0_beacon-chain.md 2019-02-16 21:13:46 +00:00
Justin 1d95c1482c
Update 0_beacon-chain.md 2019-02-16 21:11:48 +00:00
d-yokoi f2e547e629 docs: fix typo in 0_beacon-chain.md 2019-02-16 23:12:00 +09:00
d-yokoi 464947dbd4 docs: fix typo in 0_beacon-chain.md (#640) 2019-02-16 09:11:29 +00:00
Paul Hauner b92cd9be03
Add fix to `get_shuffling`
Ensures it does not try to shuffle out of range of the `active_validator_indices` list.
2019-02-16 17:55:27 +11:00
Paul Hauner 2e6bf87bdf
Fix max list size for get_permutated_index 2019-02-16 17:27:47 +11:00
Danny Ryan f932534763
Merge pull request #637 from ethereum/hwwhww-patch-2
Fix `slash_validator`
2019-02-15 09:40:24 -07:00
Jonny Rhea e074bc2c34 Update 0_beacon-chain.md (#635)
replace vote_data with slashable_attestation in verify_slashable_attestation()
2019-02-15 14:48:09 +00:00
Hsiao-Wei Wang 984eb79f68 Fix unix time condition of an acceptable block (#636) 2019-02-15 13:46:47 +00:00
Justin 2207fd17f5
Update 0_beacon-chain.md 2019-02-15 13:37:36 +00:00
Hsiao-Wei Wang 6f856ba009
Comparing in slot 2019-02-15 18:33:22 +08:00
Hsiao-Wei Wang e0c28a3cd0
Fix `slash_validator`
Define `validator` before using it.
2019-02-15 18:25:30 +08:00
Paul Hauner 2f327f36d8
Improve asset in get_permutated_index 2019-02-15 12:50:56 +11:00
Paul Hauner 267f840570
Add explicit assert to get_permutated_index
There is an implicit assert in `int_to_bytes4`, however I think it's rather hidden.
2019-02-15 11:57:23 +11:00
Justin 888b06ce4a
Update 0_beacon-chain.md 2019-02-15 00:24:46 +00:00
Justin ab140c2f1c
Update 0_beacon-chain.md 2019-02-15 00:23:03 +00:00
Danny Ryan 375659dc6c
name changes in validator doc and phase 1 doc 2019-02-14 16:02:01 -07:00
Danny Ryan 81e8f53ab9
Merge pull request #629 from terenc3t/patch-50
Quick fix on epoch boundary root
2019-02-14 15:44:40 -07:00
terence tsao 380f5bc86b
Update 0_beacon-chain-validator.md 2019-02-14 14:00:43 -08:00
Justin 241ae5ed49
Merge branch 'dev' into name-changes 2019-02-14 20:48:34 +00:00
Danny Ryan 677efe5840 fix off by one attestaton issue due to attesting to post state of block (#627) 2019-02-14 20:16:19 +00:00
Paul Hauner d7fb7729e6 Add cautionary assert in shuffling function (#622) 2019-02-14 14:14:59 +00:00
vbuterin 6c49270664 Added minimum slashing penalty of ~1 ETH (#624) 2019-02-14 14:00:12 +00:00
Justin e86fa58167
Merge branch 'dev' into name-changes 2019-02-14 10:27:17 +00:00
vbuterin eadfa20b99 Bring forward changes to withdrawability from phase 1 (#615)
* Bring forward changes to withdrawability from phase 1

* The `WITHDRAWABLE` flag is removed; instead, a validator's withdrawability is determined through the `withdrawable_epoch` field (renamed and re-purposed from `withdrawal_epoch` which was not used)
* When a validator passes through the withdrawal queue, the `prepare_validator_for_withdrawal` function does not let them withdraw immediately; instead, they have to wait `MIN_VALIDATOR_WITHDRAWAL_EPOCHS`. This extra minimum delay serves no value in phase 0, but is crucial for phase 1 as the period between a validator passing through the queue and the validator being eligible to withdraw is where proof of custody challenges can come in; adding it in phase 0 is only half a line of code so easier to add it now.
* If a validator is penalized, they are no longer subject to the exit queue; instead, their `withdrawable_epoch` is set `LATEST_PENALIZED_EXIT_LENGTH` into the future and this is used to determine when the validator can withdraw
* Changes the eligibility condition for a transfer to use the `withdrawable_epoch`
2019-02-14 10:20:53 +00:00
Justin f14af7ae67
Merge branch 'dev' into name-changes 2019-02-13 23:53:38 +00:00
Danny Ryan 83b67b6097
Merge pull request #617 from ethereum/hwwhww/fix_compute_commitment
Fix `compute_commitment`
2019-02-13 11:54:03 -07:00
terence tsao fd5c3ee8b5
Update 0_beacon-chain.md 2019-02-13 08:38:03 -08:00
Hsiao-Wei Wang f7320ec25b
Fix `compute_commitment`
1. Use `+` to concatenate the merkle roots in `hash` function.
2. Fix `pad_to_power_of_2`: padding with `[b'\x00' * SHARD_BLOCK_SIZE]`,
not `[SHARD_BLOCK_SIZE]`.
2019-02-14 00:30:00 +08:00
Danny Ryan 3d5aa352be
Merge pull request #597 from ethereum/reward-clarifications
Reward clarifications/fix
2019-02-13 08:21:30 -07:00
terence tsao a730295982 Update 0_beacon-chain.md (#614) 2019-02-13 01:40:24 +00:00
vbuterin cf371c4973 Add support for transfers between withdrawn accounts (#601) 2019-02-12 22:41:38 +00:00
Justin b6d27edd6e
Update 0_beacon-chain.md 2019-02-12 22:38:29 +00:00
Justin 3459515c2c
Merkleise SSZ container elements (#595)
Reasons to use `merkle_hash` instead of  `hash` for containers:

1) **Smaller witnesses**: `BeaconState` is a somewhat wide container (26 fields as of now, likely 30+ in phase 2). With concatenation and plain concatenation the size of the Merkle witnesses for the top level are ~32 bytes per field element.
2) **Faster incremental hashing**
3) **Consistency**: Consistent with `merkle_hash` for lists/vectors.
2019-02-12 21:57:54 +00:00
Danny Ryan 8213ad64e2
add note about attestations on chain voting for justified 2019-02-12 13:08:17 -08:00
Justin bd9baeca0c
Update 0_beacon-chain.md 2019-02-12 13:37:30 +00:00
Justin d4f79c8878
Update 0_beacon-chain.md 2019-02-12 12:28:13 +00:00
Justin de7263c838
Update 0_beacon-chain.md 2019-02-12 12:24:19 +00:00
Justin 8445d06b8f
Merge branch 'dev' into name-changes 2019-02-12 11:59:05 +00:00
Jacek Sieka f871b9a0d1 Use little endian bit order (#575)
Slightly more simple and common to find bit n at position `1 << n`
2019-02-12 11:52:07 +00:00
Justin 9a4f4d5344
Fix SSZ merkleisation bug (#602) 2019-02-12 11:12:29 +00:00
Hsiao-Wei Wang 41e95cf9ea Refactor `get_persistent_committee` (#604) 2019-02-12 11:11:45 +00:00
Paul Hauner de90d4475e Provide definition for undefined `index` (#608)
The `index` variable is not defined and, IMO, it's difficult to discern.
2019-02-12 11:09:27 +00:00
Paul Hauner 3ea0c27be0 Minor modification to reduce lines of code (#607) 2019-02-12 11:06:26 +00:00
Danny Ryan 98902d12e3 assert/unhandled exception note to state transition (#606) 2019-02-11 21:30:36 +00:00
Danny Ryan c44f6c0dbb
Merge pull request #600 from ethereum/JustinDrake-patch-3
Add note on leap seconds
2019-02-11 08:08:50 -07:00
Justin 0069241b9c
Alias `bytes` to `List[bytes1]` 2019-02-11 14:49:11 +00:00
Justin 2275587149
Add note on leap seconds
Clarify the local time is Unix time and add note on leap seconds.
2019-02-11 13:29:54 +00:00
Jordan Andrews afca1e2127 Add C# implementation 2019-02-11 22:01:05 +11:00
Danny Ryan 1d77c57374
clarify active validator meaning for rewards/penalties 2019-02-10 18:43:56 -07:00
Danny Ryan e8f9dce1d3
simply reward logic for justified slot from previous epoch 2019-02-10 18:38:42 -07:00