f8670e8069
SSZ: Remove note on efficiency
2019-01-22 17:18:21 +01:00
a5519a7d3b
SSZ: List serialization with variable element size
...
Fix #232
2019-01-22 17:14:25 +01:00
c32a79f940
Update specs/validator/0_beacon-chain-validator.md
...
Co-Authored-By: djrtwo <dannyjryan@gmail.com>
2019-01-22 08:03:00 -06:00
05e8d25a80
Update specs/validator/0_beacon-chain-validator.md
...
Co-Authored-By: djrtwo <dannyjryan@gmail.com>
2019-01-22 07:58:55 -06:00
daa1b6ebf1
Update specs/validator/0_beacon-chain-validator.md
...
Co-Authored-By: djrtwo <dannyjryan@gmail.com>
2019-01-22 07:58:29 -06:00
a934138d8b
Update specs/validator/0_beacon-chain-validator.md
...
Co-Authored-By: djrtwo <dannyjryan@gmail.com>
2019-01-22 07:58:10 -06:00
b7de018f4d
Update specs/validator/0_beacon-chain-validator.md
...
Co-Authored-By: djrtwo <dannyjryan@gmail.com>
2019-01-22 07:57:51 -06:00
634740a2f2
Update specs/validator/0_beacon-chain-validator.md
...
Co-Authored-By: djrtwo <dannyjryan@gmail.com>
2019-01-22 07:56:44 -06:00
e52d374521
Update 0_beacon-chain.md
2019-01-22 10:30:31 +00:00
fb92d68bb9
Update 0_beacon-chain.md
2019-01-22 09:27:47 +00:00
afd9260ae2
Merge branch 'master' into vbuterin-patch-2
2019-01-22 17:07:32 +08:00
a1b550a34f
fix formatting of references
2019-01-21 13:55:49 -06:00
941dfed863
Update 0_beacon-chain.md
2019-01-21 19:45:11 +00:00
80940ddd37
BLS-based RANDAO and custody (friendly to decentralised pools)
...
Unlock decentralised pools using m-of-n threshold BLS signatures for both RANDAO and custody. We also simplify a bunch:
* Remove `randao_commitment` and `custody_commitment`
* Remove miscellaneous logic such as `repeat_hash`
(Side note: Dfinity seems to be working to reduce the communication complexity of BLS DKG (Distributed Key Generation) so validator pools should also benefit from that.)
2019-01-21 18:41:29 +00:00
460188f9f5
clarify get_shuffling invariant
2019-01-21 11:47:23 -06:00
52696f8806
ensure validator links to master
2019-01-21 11:07:56 -06:00
c60a4f13fc
Merge pull request #478 from ethereum/hwwhww/refactor_validator_registry
...
Extract the first two lines of (non-)validator-registry-update
2019-01-21 08:52:42 -06:00
32bfa812d1
Merge pull request #470 from mkalinin/mkalinin-patch-2
...
Add a note about exceptions in Python code
2019-01-21 08:48:49 -06:00
2e58d52aa6
Update 0_beacon-chain.md
2019-01-21 08:48:36 -06:00
8e502dd03f
Merge pull request #464 from ethereum/inclusion-fix
...
clarify `inclusion_distance`
2019-01-21 08:47:23 -06:00
0efeed9a56
fix constants in validator section
2019-01-21 08:39:24 -06:00
f204a81e04
Merge branch 'master' into honest-validator
2019-01-21 08:36:37 -06:00
12b217df70
Updated as per hww's suggestions
2019-01-19 18:13:17 -06:00
02725b870e
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2019-01-19 18:11:14 -06:00
958c338c8f
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2019-01-19 18:11:07 -06:00
c8d8dc94c0
Extract the first two lines of (non-)validator-registry-update
2019-01-19 17:19:14 +08:00
1ae3768ac8
Minor fixes
2019-01-19 16:06:00 +08:00
41813462c3
Add custom types
2019-01-19 15:58:24 +08:00
ba8c44dd9a
Fix the new `Eth1Data` fields to `bytes32`
2019-01-19 15:46:09 +08:00
47170bfafd
Merge branch 'master' into vbuterin-patch-2
2019-01-19 15:28:14 +08:00
28ec5846de
Merge pull request #475 from ethereum/djrtwo-patch-4
...
remove unused variable def
2019-01-19 15:17:05 +08:00
8dff59abd8
Merge pull request #474 from ethereum/djrtwo-patch-3
...
add some missing `data` calls
2019-01-19 15:16:00 +08:00
15685cd3f1
Merge pull request #458 from ethereum/bytes32
...
Update BLS and core specs for `bytes32` and `bytes48` SSZ types
2019-01-19 15:09:09 +08:00
9e75a76fc1
Implement #459
...
Contents:
* Peg entries and exits to epoch boundaries
* Add a store of historical active index roots
* Mix it into the randomness
* Remove the delta hash chain
Note that the actual light client implementation is beyond the scope of the spec.
[Note to reviewers: verify that the invariant added in the PR is correct]
Question:
* Do we want to also only store epoch-boundary randao values? I don't think we use the epoch-intermediate ones anywhere.....
2019-01-18 21:06:21 -06:00
cc18df1185
remove unused variable def
2019-01-18 18:45:15 -06:00
89f0543ab9
add some missing `data` calls
2019-01-18 17:13:23 -07:00
8d5c75c6fd
Update bls_signature.md ( #473 )
...
fq2 param should be a list
2019-01-18 21:39:28 +00:00
1c48544fee
Update 0_beacon-chain.md
2019-01-18 21:38:25 +00:00
70dfdace15
Update 0_beacon-chain.md
2019-01-18 21:37:30 +00:00
aa29b9a347
add missing state param to calls to get_crosslink_committees_at_slots
2019-01-18 09:55:32 -06:00
b493f850fc
cleanup crosslink committees iters
2019-01-18 09:40:15 -06:00
11009af16e
Adds a note about Python code exceptions
2019-01-18 18:01:43 +06:00
a7307b9236
Sign full `Exit` message so that a validator can prevent tampering ( #468 )
2019-01-18 10:10:23 +00:00
690cf4b787
PR feedback
2019-01-18 16:21:58 +08:00
c8a42c4dcc
Merge pull request #429 from Nashatyrev/master
...
Potential UInt underflow in get_shard_committees_at_slot
2019-01-17 22:01:46 -06:00
421ef9e08d
fix bad link in v guide
2019-01-17 21:29:38 -06:00
b8f48d20a5
add follow distance constant and extra details around time to being added to the validator registry
2019-01-17 21:28:14 -06:00
90273cf46d
Merge pull request #469 from decanus/patch-10
...
`a.beacon_block_root` -> `a.data.beacon_block_root`
2019-01-17 20:25:50 -06:00
166a1d0638
Merge pull request #467 from decanus/patch-9
...
Adds Data field
2019-01-17 20:25:17 -06:00
15fdea5b1b
`a.beacon_block_root` -> `a.data.beacon_block_root`
2019-01-18 02:36:37 +01:00
96aac450b5
Update 0_beacon-chain.md
2019-01-18 02:22:12 +01:00
c8597a0d49
Update 0_beacon-chain.md
2019-01-18 02:11:54 +01:00
063f658697
`bytes96` for Signature
2019-01-18 03:19:38 +08:00
91eba49eeb
fix slot for domain in verify_slashable_vote_data ( #465 )
2019-01-17 19:00:29 +00:00
8b64832a02
ensure inclusion distance is for lower applicable attestation
2019-01-17 12:07:41 -06:00
7fc5238b8f
update deposit root section to utilize eth1data
2019-01-17 11:38:56 -06:00
8cdb8d9334
Merge branch 'master' into honest-validator
2019-01-17 11:00:51 -06:00
13dc373224
Update specs/simple-serialize.md
...
Co-Authored-By: decanus <dean@tokenate.io>
2019-01-17 17:51:34 +01:00
f485259d74
Update simple-serialize.md
2019-01-17 17:48:07 +01:00
7603d1d5c9
Update simple-serialize.md
2019-01-17 17:47:07 +01:00
a80f2717f3
ssz: switch integer encoding to little endian ( #139 )
2019-01-17 15:34:07 +00:00
df83dc7bf5
Merge branch 'master' into bytes32
2019-01-17 19:49:10 +08:00
7686702c29
Vote for block hash along with deposit root ( #448 )
2019-01-17 11:43:47 +00:00
18b97cf922
pubkey: Bytes48
2019-01-17 19:40:26 +08:00
7439939e29
Misc Renamings ( #450 )
...
- `participation_bitfield` -> `aggregation_bitfield`
- `validator_registry_latest_change_slot` -> `validator_registry_update_slot`
- `latest_penalized_exit_balances` -> `latest_penalized_balances`
- `fork_data` -> `fork`
- `pre_fork_version` -> `previous_version`
- `pork_fork_version` -> `current_version`
- `fork_slot` -> `slot`
2019-01-17 11:18:30 +00:00
8d2f4a1705
SSZ: Add `bytesN`, remove `hashN` and `Address` ( #455 )
2019-01-17 11:02:57 +00:00
87fb35d244
Remove Record suffix ( #434 )
2019-01-17 11:01:13 +00:00
812b385f64
Normalize ETH units to Gwei ( #420 )
2019-01-17 10:55:05 +00:00
ba7bc29ce9
Fix `bls_aggregate_signatures`
2019-01-17 17:36:31 +08:00
209220787b
Deal with BLS APIs, will define `Bytes48` in the type hinting cleanup
2019-01-17 17:29:28 +08:00
713af88c43
`proof_of_possession: Signature`
2019-01-17 17:03:20 +08:00
725199593b
For pubkey type hinting, use `bytes` for now.
2019-01-17 17:00:39 +08:00
0b10b0444a
Replace `Hash32` with `Bytes32`
2019-01-17 16:56:33 +08:00
61f5d99dee
Fix `Deposit.branch` type notation
2019-01-17 16:54:38 +08:00
14891047d7
Update `EMPTY_SIGNATURE`
2019-01-17 16:52:56 +08:00
a588643661
Replace `uint384` with `bytes48` for pubkey
2019-01-17 16:51:50 +08:00
7005e5fd55
Replace `['uint384']` with `Signature`
2019-01-17 16:49:08 +08:00
b515683e39
Replace `'[uint384]'` with Signature
2019-01-17 16:47:27 +08:00
8d5fd404a7
Add `Signature` SSZ obj
2019-01-17 16:42:46 +08:00
accd3cfd01
Replace `hash32` with `bytes32`
2019-01-17 16:33:59 +08:00
23e3f4defe
Rename `bytes1(x)`, `bytes2(x)`... function to `int_to_bytes1(x)`, `int_to_bytes2(x)`...
2019-01-17 16:30:04 +08:00
d29cbd6535
Merge remote-tracking branch 'upstream/master'
2019-01-17 11:00:19 +03:00
509870d138
Update 0_beacon-chain.md
2019-01-17 02:18:30 +01:00
412d295da3
Update 0_beacon-chain.md
2019-01-16 22:28:15 +01:00
40d4ec33cb
add basics for all block operations
2019-01-16 15:24:59 -06:00
b74f518e4b
Fix typo `validators` -> `validator_registry`
2019-01-16 22:01:32 +01:00
2881f56c08
add pr feedback
2019-01-16 14:44:58 -06:00
60bbe7addc
Update 0_beacon-chain.md
2019-01-16 21:33:36 +01:00
5d542576d9
Update 0_beacon-chain.md
2019-01-16 21:31:33 +01:00
a8716436a5
Merge branch 'master' into honest-validator
2019-01-16 13:46:06 -06:00
2c78645fc6
Merge pull request #452 from GregTheGreek/master
...
fix typo with get_attestation_participants
2019-01-16 13:41:03 -06:00
e5ea67f4ac
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: GregTheGreek <gregorymarkou@gmail.com>
2019-01-16 14:39:00 -05:00
3b1ccae58c
Update 0_beacon-chain.md
2019-01-16 20:35:01 +01:00
2c25ed9062
fix typo with get_attestation_participants
2019-01-16 14:05:53 -05:00
85d6082990
Merge pull request #443 from terenc3t/patch-35
...
Replace shard_committee with crosslink_committee
2019-01-16 12:05:43 -06:00
5058e38b23
fix ValidatorRegistryDeltaBlock field naming/reference inconsistency
2019-01-15 20:26:53 -08:00
0515adff44
Merge pull request #438 from mkalinin/fix-proposer-slashings
...
Fix one of proposer slashing verifications
2019-01-15 20:53:37 +08:00
5321fee1cd
Merge with spec update
2019-01-15 11:32:19 +03:00
8173854227
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: mkalinin <noblesse.knight@gmail.com>
2019-01-15 12:02:17 +06:00
aa990eb10e
update `shard committees` in get_shuffling
2019-01-14 21:07:36 -08:00
134ef6d252
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: terenc3t <terence@prysmaticlabs.com>
2019-01-14 20:44:30 -08:00
6b72ae3a3b
fill in missing links in phase 0 validator doc
2019-01-14 22:36:33 -06:00
d29ce725db
add deposit root logic in block proposals
2019-01-14 21:50:34 -06:00
1070ba2d11
Add ToC
2019-01-15 11:33:46 +08:00
1d44023731
initial pass on phase 0 validator doc
2019-01-14 21:25:23 -06:00
bd506e1222
Update 0_beacon-chain.md
2019-01-14 16:06:33 -08:00
6f539fb1af
minor fix to bls_verify param names in "proposer signature" ( #441 )
2019-01-14 22:23:57 +00:00
1cd71b9d58
Fix some naming inconsistency and typos
2019-01-14 21:54:29 +08:00
61cf6209d8
Fix one of proposer slashing verifications
2019-01-14 15:31:02 +06:00
43d0142da9
Merge pull request #414 from benjaminion/vyper-merkle-branch
...
Add getter to Vyper contract for Merkle branches
2019-01-14 14:49:40 +08:00
4d1aadcc5c
Update 0_beacon-chain.md
2019-01-13 21:11:44 -08:00
891c87eca2
Merge pull request #408 from ethereum/vitalik91
...
Remove shard committees from the state
2019-01-13 22:55:08 -06:00
bbf6b5c267
Merge pull request #419 from jimpo/bls-correction
...
Correct references to signature scheme in beacon spec.
2019-01-13 16:05:53 -06:00
2646ca1337
Update 0_beacon-chain.md
2019-01-13 08:55:48 -08:00
2b66811a04
address terence pr feedback
2019-01-11 11:35:18 -06:00
0a7e72f641
Merge branch 'master' into vitalik91
2019-01-11 11:33:38 -06:00
271e7b5cb8
Update 0_beacon-chain.md
2019-01-11 16:23:10 +00:00
7a0d45279c
Update 0_beacon-chain.md
2019-01-11 15:24:29 +00:00
d9c6ad9008
get_attestation_participants: inline ceil_div8() ( #430 )
2019-01-11 14:37:38 +00:00
8ebc4dece8
Local var should stay uint
2019-01-11 15:07:18 +03:00
c8bd90aba3
Update 0_beacon-chain.md
2019-01-11 11:53:12 +00:00
dd532d7887
Update 0_beacon-chain.md
...
* Avoid abbreviations
* Use `branch` as a more suggestive variable name than `ret`
* Cleanup spacing after comma
* Avoid having two index variables (`index` and `idx`)—Does this break anything?
2019-01-11 11:52:04 +00:00
b75ac05ab6
Fix typo seed -> randao_mix
2019-01-11 11:05:43 +00:00
459734cb9e
get_randao_mix slot boundary fix
2019-01-10 22:34:13 -06:00
70c0cc43c5
Fixes as per Danny and Terence
2019-01-10 22:33:22 -06:00
eec8b4ac44
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2019-01-10 21:02:51 -06:00
7736843917
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2019-01-10 21:01:30 -06:00
648c35dc3d
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2019-01-10 21:01:05 -06:00
a0a96c7e7c
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2019-01-10 21:00:59 -06:00
d2eca73482
added assertion that n >= 0
2019-01-10 18:09:58 -06:00
c141d90f0f
Fix typo with initial generation of `latest_penalized_exit_balances`
...
The spec as written is not valid python -- the generator of the list
comprehension must be iterable.
It looks like the author simply meant to `range` over the intended length.
This commit fixes the missing `range` operator
2019-01-10 15:41:15 -06:00
78fcda7ce0
Use bitwise xor to simplify merkle branch getter
2019-01-10 20:45:39 +00:00
ab7f9d8f54
Merge pull request #422 from ethereum/JustinDrake-patch-1
...
Fix #320
2019-01-10 12:27:53 -06:00
5b1f352414
Merge pull request #388 from ralexstokes/add-missing-property-to-merkle-verification
...
Fixes a few bugs with deposit verification.
2019-01-10 12:15:12 -06:00
69cd904782
Merge branch 'master' into vitalik91
2019-01-10 11:29:11 -06:00
e2886bf3d3
prev -> previous, cur -> current, get_shard_committee_at_slot rework, get_randao_mix rework
2019-01-10 11:01:19 -06:00
c589f8273b
Update 0_beacon-chain.md
2019-01-10 08:19:56 -08:00
3476b02ffa
Fix #320
...
* Avoids unnecessary hashing of `message`
* Makes the ordering of arguments (`message` followed by `domain`) consistent with usage order
2019-01-10 11:52:21 +00:00
4cf06d908a
Truncate the index into the Merkle tree to bytes[8]
...
The beacon chain expects a `uint64` in part to avoid big-int computation.
This commit updates the `Deposit` log so that it broadcasts data of the
appropriate size.
2019-01-09 17:18:15 -06:00
d62834654f
Broadcast `merkle_tree_index` in lieu of the deposit count
2019-01-09 17:02:19 -06:00
7a6854aab9
Fix variable name that was lost in botched rebase
2019-01-09 16:52:43 -06:00
b25154c774
Correct references to sig scheme in beacon spec.
...
BLS is the name of the signature scheme and BLS12-381 is the name of the
curve that it is defined over. So it is more correct to talk about a
"BLS signature/pubkey" rather than a "BLS12-381 signature/pubkey".
2019-01-09 12:47:19 -08:00
f49f7eddf9
Use the correct name for the `amount` field
2019-01-09 14:44:06 -06:00
c5de2fe710
Add missing deposit root when performing Merkle verification
2019-01-09 14:37:51 -06:00
6f5a865508
Reorder type so the ssz serialization matches other uses
...
There is an order based on the Vyper deposit contract which should be maintained
here. There is also a reference to it when processing `Deposit` messages.
This commit corrects the order here so all serializations will match.
2019-01-09 14:35:26 -06:00
4ea430207b
Update 0_beacon-chain.md
2019-01-09 14:12:47 -06:00
dff84c00b0
Fixes bugs with description of deposit verification.
...
1. The order of the `deposit_data` serialization does not match the current
Vyper contract. The description now matches that serialization.
2. The `deposit.merkle_tree_index` was not being used (at least explicitly) so
the text now reflects which inputs are to be used for which parameters in the
pseudocode spec that follows.
3. There seems to be a bug where we want the initial leaf to be the `hash` of
the `DepositData`, not the data itself. The text now reflects this requirement.
2019-01-09 14:08:24 -06:00
5f19622f86
Add clarifying comment about where this index is coming from
2019-01-09 14:06:45 -06:00
0b16430cf5
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2019-01-09 11:00:13 -06:00
608ec2452c
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2019-01-09 10:59:56 -06:00
83d54f6aa4
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2019-01-09 10:59:45 -06:00
06c5c11cd5
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2019-01-09 10:59:31 -06:00
35851b5303
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2019-01-09 10:59:20 -06:00
8f1325f95e
Fixed bugs found by Danny
2019-01-09 10:58:33 -06:00
1daab4659a
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2019-01-09 10:40:40 -06:00
994a42e6b1
Add getter to Vyper contract for Merkle branches
...
Returns the Merkle branch for the leaf at index `index`. This getter provides
an alternative way for beacon chain proposers to access the Merkle tree of
deposits rather than being Ethereum 1.0 light clients. The method can be
called on a trusted Ethereum 1.0 archive node at specific past block numbers
to retrieve the Merkle branch needed to register a validator.
2019-01-08 20:42:19 +00:00
61f7e37eff
Replace numeric constant with symbolic in Vyper contract
...
Vyper v0.1.0-beta.6 supports ranges with symbolic constants.
2019-01-08 19:42:22 +00:00
9dfc459849
Merge pull request #406 from terenc3t/patch-29
...
inclusion_slot and inclusion_distance in its own section
2019-01-08 10:49:14 -07:00
197b88df92
Merge pull request #404 from akhila-raju/patch-2
...
Removes naming conflict in get_shuffling.
2019-01-08 09:57:56 -07:00
609082c1af
change slot_num to slot_position
2019-01-08 09:57:15 -07:00
78ee210d56
fix seed xor in get_shuffling using bytes32
2019-01-08 09:51:12 -07:00
fff0989b8c
fix call to hash (from Hash32)
2019-01-08 09:35:51 -07:00
f6453a7455
Merge branch 'master' into JustinDrake-patch-1
2019-01-08 10:09:30 -06:00
9f87511632
Merge pull request #372 from terenc3t/patch-25
...
Rewording Validator Registry Precondition
2019-01-08 08:43:59 -07:00
b66218a264
Initial commit
2019-01-07 18:53:33 -06:00
4dab5fc72c
Update 0_beacon-chain.md
2019-01-07 15:55:05 -08:00
b78458bbb2
Removes naming conflict in get_shuffling.
...
The variable name 'slot' in the for-loop in 'get_shuffling' conflicts with the get_shuffling argument name 'slot'. Renames 'slot' in for-loop to 'slot_num'.
2019-01-07 13:06:44 -05:00
14e14ce576
Merge pull request #397 from ralexstokes/fix-merkle-bug
...
Fixes bug with Merkle proof branch selection
2019-01-07 09:45:42 -07:00
58bb609780
Merge pull request #400 from wemeetagain/ssz/fix-deserialize-container-variable-names
...
Fix minor variable name mismatch
2019-01-07 08:43:27 -07:00
92747579cd
Merge pull request #398 from wemeetagain/ssz/fix-deserialize-uint
...
Fix deserialize uint bounds logic
2019-01-07 08:13:56 -07:00
31d4ca594d
conform to standard
2019-01-07 08:13:26 -07:00
a6851cfd2a
Merge pull request #402 from wemeetagain/ssz/fix-hash-function-link
...
Fix hash function link
2019-01-07 16:38:27 +08:00
6fc131433c
Update specs/simple-serialize.md
...
Co-Authored-By: wemeetagain <caymannava@gmail.com>
2019-01-07 00:54:40 -06:00
e772c4da6f
Merge branch 'master' into rename_pow_to_deposit
2019-01-07 14:02:11 +08:00
140ee1ade9
Fix hash function link
2019-01-06 23:10:33 -06:00
c69fa9a793
Fixes typo in `sorted` function.
...
In keeping with the rest of the code in this document we adhere to valid Python
where possible.
The custom comparator keyword argument for `sorted` is `key` so this commit
updates its usage when sorting validators by exit order.
2019-01-06 17:41:11 -06:00
cebbe7b7c5
Fix minor variable name mismatch
2019-01-06 13:05:27 -06:00
fd2cc6956f
Merge branch 'master' into vbuterin-patch-19
2019-01-05 08:53:04 -07:00
fb17be0e9b
Fix deserialize uint bounds logic
...
Array accesses should be relative to uint byte length, not bit length.
2019-01-04 11:14:27 -06:00
a0e454d86c
Fixes bug with Merkle proof branch selection
...
This code determines the order in which the next branch element and the
current value should be hashed to produce the parent node in the Merkle tree.
The existing code fails to verify branches constructed in the standard way.
This patch fixes the spec code so that it works properly by using an appropriate
parity calculation.
Example code here to illustrate it working:
https://gist.github.com/ralexstokes/9d82e188bd3286ff74a1fa1dcb5068e0
2019-01-04 09:48:50 -06:00
c24f907088
Put back spaces
2019-01-04 09:22:59 -06:00
88de4e35f2
Merge pull request #395 from terenc3t/patch-28
...
Get shard_block_root from crosslink
2019-01-04 16:04:43 +08:00
fa08e240c8
Merge branch 'master' into HEAD
2019-01-04 15:55:03 +08:00
61b2b6392c
bugfix and rename
...
Use `deposit_root_vote` for `DepositRootVote` object and `deposit_root` for the
deposit root hash.
2019-01-04 15:54:48 +08:00
36231e698a
Apply suggestions from code review
...
Co-Authored-By: hwwhww <hwwang156@gmail.com>
2019-01-04 15:54:35 +08:00
e3c4155ba5
Merge pull request #393 from terenc3t/patch-27
...
Align Field Names with Phase 0 Spec
2019-01-03 21:48:14 -07:00
d360330f83
Merge pull request #394 from ralexstokes/fix-update-validator-registry-fn
...
Remove dangling `return` statement from spec function
2019-01-03 21:46:34 -07:00
a84dd398e4
Merge pull request #392 from ralexstokes/fix-units-ejection-balance
...
Fix a type error with units of wei when determining ejection balance.
2019-01-03 21:44:08 -07:00
d5e6d84269
Merge pull request #391 from ralexstokes/typo/hash-slot
...
Change "justified hash" to "justified slot"
2019-01-03 21:43:12 -07:00
97bd04607c
Update 0_beacon-chain.md
2019-01-03 19:40:03 -08:00
c0140d72ee
Update 0_beacon-chain.md
2019-01-03 18:23:23 -08:00
a5b1f2cc0a
Moved comment and changed conditional
2019-01-03 19:44:39 -06:00
3f4be7abb7
Fixed activation slot conditional.
2019-01-03 19:42:59 -06:00
19a9582a48
Remove dangling `return` statement from spec function
...
This function declares that it returns `None` and instead directly mutates the
state.
There is a dangling return statement that this commit deletes.
2019-01-03 19:42:07 -06:00
19b1a31903
Update 1_shard-data-chains.md
2019-01-03 13:57:04 -08:00
9a83ad7b9b
Fix a type error with units of wei when determining ejection balance.
...
`EJECTION_BALANCE` is in units of ETH.
`state.validator_balances[index]` is in units of Gwei.
For the ejection computation to work as desired, we need to convert the
`EJECTION_BALANCE` constant from ETH to Gwei.
2019-01-03 14:28:36 -06:00
457f84fa64
Change "justified hash" to "justified slot"
...
There should be a correspondence here but referring to the slot is more
explicit, especially for those who are not as familiar with the
details of FFG finalization.
2019-01-03 12:06:44 -06:00
f92735454e
Fix `verify_slashable_vote_data`
...
The first field of `AttestationDataAndCustodyBit` should be an `AttestationData` object, not an `SlashableVoteData` object.
2019-01-03 16:19:54 +08:00
b614595fbe
Merge branch 'master' into vbuterin-patch-19
2019-01-03 00:26:31 +08:00
af8ed89170
Merge branch 'master' into rename_pow_to_deposit
2019-01-03 00:10:18 +08:00
78e73633bc
Merge pull request #382 from ethereum/remove_shard_reassignment_record
...
Remove `ShardReassignmentRecord`
2019-01-02 23:48:04 +08:00
dcaf510213
Merge branch 'master' into rename_pow_to_deposit
2019-01-02 23:44:12 +08:00
3efe1b3b6c
Update 0_beacon-chain.md
2019-01-02 15:21:22 +00:00
429e5721f2
RANDAO hash chain and no stale shuffles
...
* Make RANDAO into a hash chain (this makes it easy for applications to prove the intermediate RANDAO reveals).
* Include `state.slot` when shuffle to avoid stale shuffles with skip slots
2019-01-02 14:20:01 +00:00
93b18d5160
Fix typo
2019-01-02 13:51:57 +00:00
696bf23b5e
Remove returned value for process_deposit
...
Also trim trailing whitespace
2019-01-02 13:41:32 +00:00
7d240946a9
Update 0_beacon-chain.md
...
* Cleanup comments related to custody
* Rename "Miscellaneous" to "Custody" in the table of contents
* Use `INITIAL_SLOT_NUMBER` instead of `0` for initial custody slots
* (typo) Fix `second_latest_custody_reseed_slot` => `penultimate_custody_reseed_slot`
2019-01-02 13:35:57 +00:00
9a90803f5c
Update 0_beacon-chain.md
...
* `processed_deposit_root` => `latest_deposit_root`
* `receipt_root` => `deposit_root`
* `receipt_tree` => `deposit_tree`
* Emphasize that deposits are Ethereum 1.0 deposits in text in various places
* `Eth1Deposit` => `Deposit` for consistency (Also happy sticking with `Eth1Deposit` and replacing `deposit_` with `eth1_deposit_` everywhere. This may be unnecessary since Ethereum 2.0 deposits can be distinguished with the `shard_` prefix, e.g. `ShardDeposit` and `shard_deposit`.)
* Clarify `withdrawal_credentials`.
* Clarify that multiple Ethereum 1.0 blocks can have the same deposit root.
2019-01-02 13:18:35 +00:00
3dbee05aa6
Rename `pow_receipt_` to `deposit_`
2019-01-02 18:27:09 +08:00
35adc9c61a
Remove `ShardReassignmentRecord`
2019-01-02 15:31:57 +08:00
0d9ecce344
Rename `poc_` to `custody`
2019-01-02 15:16:55 +08:00
2105614059
Bunch of fixes
2019-01-01 22:37:43 -06:00
d49b6e5087
Fix typo with missing bracket ( #379 )
2018-12-31 23:35:09 +00:00
fdb1b6775d
Removed extraneous variable setting
2018-12-31 14:08:59 -06:00
fd295eb539
Merge branch 'master' into vbuterin-patch-19
2018-12-31 15:17:00 +00:00
d36b403c2e
Cleanups and fixes
...
Cleanups
* (typo) Remove `get_new_validator_registry_delta_chain_tip` from table of contents
* (typo) Update "Routines for updating validator status" in table of contents
* Update `FAR_FUTURE_SLOT` from `2**63` to `2**64 - 1`
* Put more constants in "Initial values", homogenise
* Cleanup note formatting
* Remove `ZERO_BALANCE_VALIDATOR_TTL` logic (to be possibly reintroduced in phase 2).
* Cleanup `min_empty_validator_index`
* Rename `deposit` to `amount` in `process_deposit` and `DepositData`.
* (typo) Remove new line under `process_penalties_and_exits`
* (typo) "Status codes" => "Status flags" in the table of contents
* (typo) `(state.slot - EPOCH_LENGTH) % LATEST_RANDAO_MIXES_LENGTH` => Use `SEED_LOOKAHEAD` instead.
* Put `state.validator_registry_latest_change_slot = state.slot` in `update_validator_registry`.
* Use `GENESIS_SLOT` for `last_poc_change_slot=0` and `second_last_poc_change_slot=0`.
Bugfixes
* (typo) `validator_exit` => `exit.validator_index`
* Separate initial deposits and initial activations to avoid double activations
* Replace `proposer.status != EXITED_WITH_PENALTY` with `validator.penalized_slot > state.slot` in two different places.
* Replace `status == EXITED_WITH_PENALTY` with `validator.penalized_slot <= state.slot` (and validator active) in two different places.
2018-12-31 15:14:14 +00:00
8f29bcdf08
Merge pull request #373 from ethereum/fix-slashing
...
fix slashing conditons
2018-12-31 07:57:51 -06:00
011970169c
Edited as per Justin's comments
2018-12-30 20:42:05 -06:00
c8ff723514
Update 0_beacon-chain.md
2018-12-30 16:06:33 -08:00
1a4973171f
Remove references to the persistent committees ( #376 )
...
* Remove references to the persistent committees
2018-12-30 23:46:32 +00:00
4a93374025
Fixed as per hww's comments
2018-12-30 09:15:23 -06:00
14f49aaacb
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-29 13:47:10 -06:00
bd5b32ec5a
Initialize status_flags
2018-12-29 13:44:51 -06:00
85d001001c
Fixed seed lookahead
2018-12-28 12:08:19 -06:00
d9e897bbcb
Status code / slot reorganization
...
* Added `activation_slot`, `exit_slot`, `penalized_slot`, `withdrawal_slot`, use these to determine if a validator is active
* Universal min activation/exit delay of 256 slots
* Min exit time of ~1 day, but penalization delays this to ~18 days
* Penalty calculation period of `[time penalized - 18 days, time penalized + 18 days]`; made the total penalties array fixed size and wraparound to make calculation more fine-grained
* Processes withdrawals in all epochs, not just dynasty-changing epochs
* Change `get_shuffling` function to take slot as argument
Not yet done:
* Removed `shard_committees` from the state
* Removed persistent committees from the state
2018-12-28 12:04:03 -06:00
aa9bda271f
fix slashing conditons to be based upon epochs rather than slots
2018-12-28 11:10:12 -06:00
10a8ba2d9e
rewording for validator registry precondition
2018-12-28 09:04:00 -08:00
6b84dae09e
Fix #361 : pass `poc_commitment` to `validate_proof_of_possession` ( #364 )
...
* Fix #361
2018-12-27 18:11:38 +00:00
44c389bfe3
crosslink rewards typo ( #367 )
2018-12-27 18:01:20 +00:00
8c12896fa0
Cleanup merkle_root
...
Add docstring and fix spacing.
2018-12-27 17:58:24 +00:00
2c9cefa6a7
`Use `current_` instead of `this_`
2018-12-26 15:48:20 +08:00
a2422de686
Potential bug for crosslinks?
2018-12-23 09:34:46 -08:00
4938481428
Added hash-and-bit data structure as per #286 ( #355 )
...
* Added hash-and-bit data structure as per #286
2018-12-23 10:48:11 +00:00
0ee724a4ab
Merge pull request #356 from terenc3t/patch-22
...
updated SSZ implementation list
2018-12-23 12:04:31 +08:00
985a3fe958
Merge pull request #351 from dangerousfood/vrc-con-update
...
Update VRC contract for Vyper v0.1.0-beta.6
2018-12-23 12:03:34 +08:00
f21da324ef
updated SSZ implementation list
2018-12-22 15:13:54 -08:00
f8652fa25b
Merge pull request #347 from ethereum/vbuterin-patch-15
...
Changes to inactivity leak
2018-12-22 07:13:41 -06:00
f84b7b5f31
Merge pull request #341 from ethereum/target-committee-size
...
change TARGET_COMMITTEE_SIZE to 128
2018-12-22 07:12:21 -06:00
a60ab53647
PR feedback
2018-12-22 07:11:58 -06:00
d0b5133912
Merge pull request #349 from ethereum/vbuterin-patch-17
...
Proof of custody placeholders
2018-12-22 07:08:18 -06:00
99817aeb0e
Typo fix: lastest -> last
2018-12-21 17:23:42 -05:00
6a73a056f0
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-21 17:22:42 -05:00
1068076822
update vrc cotnract for vyper v0.1.0-beta.6
2018-12-21 16:18:41 -06:00
fa8be783ad
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-21 17:12:38 -05:00
4f94f7579c
Moved notes to the end of the section to make Danny happy
2018-12-21 11:29:15 -05:00
5fc8f6cfca
Fixed deposit inclusion and positioning of state variables
2018-12-21 11:26:40 -05:00
c8efdc7431
Add placeholder array in state for VDFs
...
Added `latest_vdf_outputs` in `state` initialised to an array of `ZERO_HASH` of length `LATEST_RANDAO_MIXES_LENGTH // EPOCH_LENGTH`. (There's one VDF output per epoch. The VDF input is the RANDAO mix at the epoch boundary.)
Further changes to activate VDFs (in a future phase):
* Add a new beacon "VDF output and proof" transaction, e.g. with `MAX_VDF_OUTPUT_AND_PROOF := 1`.
* Adjust the `MAX_SEED_LOOKAHEAD` constant, e.g. to `2**4 * EPOCH_LENGTH`. (The `2**4` parameter is essentially `A_max`.)
* Add a `process_vdf_output_and_proof` helper function in the per-block processing:
* Verify the VDF input hasn't already been processed (check the corresponding `state.latest_vdf_outputs` entry is not `ZERO_HASH`.)
* Verify the proof is correct, i.e. matches the VDF input and output
* Save the VDF output to `state.latest_vdf_outputs`
* In the per-epoch processing set the corresponding entry in `state.latest_vdf_outputs` to `ZERO_HASH`.
* Use a VDF output for the shuffling seed.
2018-12-21 15:26:13 +00:00
6667edb015
Update specs/core/0_beacon-chain.md
...
Co-Authored-By: vbuterin <v@buterin.com>
2018-12-21 09:08:01 -05:00
6eb4e59b8c
slots -> epochs
2018-12-21 09:07:04 -05:00
8e30f1b63e
Set zero balance TTL back to 2**22
2018-12-21 09:06:30 -05:00
Jannik Luhn
Hsiao-Wei Wang
Justin
Danny Ryan
vbuterin
Jonny Rhea
Mikhail Kalinin
Alex Stokes
Dean Eigenmann
Jacek Sieka
terence tsao
JinHwan
Anton Nashatyrev
Dean Eigenmann
Gregory Markou
Dustin Brody
Stan Drozd
Ben Edgington
Jim Posen
Akhila Raju
Cayman
Nishant Das
Joseph Delong