14e14ce576
Merge pull request #397 from ralexstokes/fix-merkle-bug
...
Fixes bug with Merkle proof branch selection
2019-01-07 09:45:42 -07:00
58bb609780
Merge pull request #400 from wemeetagain/ssz/fix-deserialize-container-variable-names
...
Fix minor variable name mismatch
2019-01-07 08:43:27 -07:00
92747579cd
Merge pull request #398 from wemeetagain/ssz/fix-deserialize-uint
...
Fix deserialize uint bounds logic
2019-01-07 08:13:56 -07:00
31d4ca594d
conform to standard
2019-01-07 08:13:26 -07:00
a6851cfd2a
Merge pull request #402 from wemeetagain/ssz/fix-hash-function-link
...
Fix hash function link
2019-01-07 16:38:27 +08:00
6fc131433c
Update specs/simple-serialize.md
...
Co-Authored-By: wemeetagain <caymannava@gmail.com>
2019-01-07 00:54:40 -06:00
a961689a52
Merge pull request #383 from ethereum/rename_pow_to_deposit
...
Rename `pow_receipt_` to `deposit_`
2019-01-07 14:03:17 +08:00
e772c4da6f
Merge branch 'master' into rename_pow_to_deposit
2019-01-07 14:02:11 +08:00
7715a48cc8
Merge pull request #401 from ralexstokes/fix-sorted-typo
...
Fixes typo in `sorted` function.
2019-01-07 13:52:31 +08:00
140ee1ade9
Fix hash function link
2019-01-06 23:10:33 -06:00
c69fa9a793
Fixes typo in `sorted` function.
...
In keeping with the rest of the code in this document we adhere to valid Python
where possible.
The custom comparator keyword argument for `sorted` is `key` so this commit
updates its usage when sorting validators by exit order.
2019-01-06 17:41:11 -06:00
c63803a4ec
Merge pull request #374 from ethereum/vbuterin-patch-19
...
Status code / slot reorganization
2019-01-06 14:17:58 -06:00
cebbe7b7c5
Fix minor variable name mismatch
2019-01-06 13:05:27 -06:00
fd2cc6956f
Merge branch 'master' into vbuterin-patch-19
2019-01-05 08:53:04 -07:00
fb17be0e9b
Fix deserialize uint bounds logic
...
Array accesses should be relative to uint byte length, not bit length.
2019-01-04 11:14:27 -06:00
a0e454d86c
Fixes bug with Merkle proof branch selection
...
This code determines the order in which the next branch element and the
current value should be hashed to produce the parent node in the Merkle tree.
The existing code fails to verify branches constructed in the standard way.
This patch fixes the spec code so that it works properly by using an appropriate
parity calculation.
Example code here to illustrate it working:
https://gist.github.com/ralexstokes/9d82e188bd3286ff74a1fa1dcb5068e0
2019-01-04 09:48:50 -06:00
c24f907088
Put back spaces
2019-01-04 09:22:59 -06:00
88de4e35f2
Merge pull request #395 from terenc3t/patch-28
...
Get shard_block_root from crosslink
2019-01-04 16:04:43 +08:00
fa08e240c8
Merge branch 'master' into HEAD
2019-01-04 15:55:03 +08:00
61b2b6392c
bugfix and rename
...
Use `deposit_root_vote` for `DepositRootVote` object and `deposit_root` for the
deposit root hash.
2019-01-04 15:54:48 +08:00
36231e698a
Apply suggestions from code review
...
Co-Authored-By: hwwhww <hwwang156@gmail.com>
2019-01-04 15:54:35 +08:00
e3c4155ba5
Merge pull request #393 from terenc3t/patch-27
...
Align Field Names with Phase 0 Spec
2019-01-03 21:48:14 -07:00
d360330f83
Merge pull request #394 from ralexstokes/fix-update-validator-registry-fn
...
Remove dangling `return` statement from spec function
2019-01-03 21:46:34 -07:00
a84dd398e4
Merge pull request #392 from ralexstokes/fix-units-ejection-balance
...
Fix a type error with units of wei when determining ejection balance.
2019-01-03 21:44:08 -07:00
d5e6d84269
Merge pull request #391 from ralexstokes/typo/hash-slot
...
Change "justified hash" to "justified slot"
2019-01-03 21:43:12 -07:00
cf6b296ab0
Merge pull request #390 from ethereum/hwwhww-patch-1
...
Fix `verify_slashable_vote_data`
2019-01-03 21:41:50 -07:00
97bd04607c
Update 0_beacon-chain.md
2019-01-03 19:40:03 -08:00
c0140d72ee
Update 0_beacon-chain.md
2019-01-03 18:23:23 -08:00
a5b1f2cc0a
Moved comment and changed conditional
2019-01-03 19:44:39 -06:00
3f4be7abb7
Fixed activation slot conditional.
2019-01-03 19:42:59 -06:00
19a9582a48
Remove dangling `return` statement from spec function
...
This function declares that it returns `None` and instead directly mutates the
state.
There is a dangling return statement that this commit deletes.
2019-01-03 19:42:07 -06:00
19b1a31903
Update 1_shard-data-chains.md
2019-01-03 13:57:04 -08:00
9a83ad7b9b
Fix a type error with units of wei when determining ejection balance.
...
`EJECTION_BALANCE` is in units of ETH.
`state.validator_balances[index]` is in units of Gwei.
For the ejection computation to work as desired, we need to convert the
`EJECTION_BALANCE` constant from ETH to Gwei.
2019-01-03 14:28:36 -06:00
457f84fa64
Change "justified hash" to "justified slot"
...
There should be a correspondence here but referring to the slot is more
explicit, especially for those who are not as familiar with the
details of FFG finalization.
2019-01-03 12:06:44 -06:00
f92735454e
Fix `verify_slashable_vote_data`
...
The first field of `AttestationDataAndCustodyBit` should be an `AttestationData` object, not an `SlashableVoteData` object.
2019-01-03 16:19:54 +08:00
b614595fbe
Merge branch 'master' into vbuterin-patch-19
2019-01-03 00:26:31 +08:00
af8ed89170
Merge branch 'master' into rename_pow_to_deposit
2019-01-03 00:10:18 +08:00
78e73633bc
Merge pull request #382 from ethereum/remove_shard_reassignment_record
...
Remove `ShardReassignmentRecord`
2019-01-02 23:48:04 +08:00
dcaf510213
Merge branch 'master' into rename_pow_to_deposit
2019-01-02 23:44:12 +08:00
17b5305c97
Merge pull request #381 from ethereum/rename_custody
...
Rename `poc_` to `custody_`
2019-01-02 23:38:00 +08:00
93b18d5160
Fix typo
2019-01-02 13:51:57 +00:00
696bf23b5e
Remove returned value for process_deposit
...
Also trim trailing whitespace
2019-01-02 13:41:32 +00:00
7d240946a9
Update 0_beacon-chain.md
...
* Cleanup comments related to custody
* Rename "Miscellaneous" to "Custody" in the table of contents
* Use `INITIAL_SLOT_NUMBER` instead of `0` for initial custody slots
* (typo) Fix `second_latest_custody_reseed_slot` => `penultimate_custody_reseed_slot`
2019-01-02 13:35:57 +00:00
9a90803f5c
Update 0_beacon-chain.md
...
* `processed_deposit_root` => `latest_deposit_root`
* `receipt_root` => `deposit_root`
* `receipt_tree` => `deposit_tree`
* Emphasize that deposits are Ethereum 1.0 deposits in text in various places
* `Eth1Deposit` => `Deposit` for consistency (Also happy sticking with `Eth1Deposit` and replacing `deposit_` with `eth1_deposit_` everywhere. This may be unnecessary since Ethereum 2.0 deposits can be distinguished with the `shard_` prefix, e.g. `ShardDeposit` and `shard_deposit`.)
* Clarify `withdrawal_credentials`.
* Clarify that multiple Ethereum 1.0 blocks can have the same deposit root.
2019-01-02 13:18:35 +00:00
3dbee05aa6
Rename `pow_receipt_` to `deposit_`
2019-01-02 18:27:09 +08:00
35adc9c61a
Remove `ShardReassignmentRecord`
2019-01-02 15:31:57 +08:00
0d9ecce344
Rename `poc_` to `custody`
2019-01-02 15:16:55 +08:00
2105614059
Bunch of fixes
2019-01-01 22:37:43 -06:00
d49b6e5087
Fix typo with missing bracket ( #379 )
2018-12-31 23:35:09 +00:00
fdb1b6775d
Removed extraneous variable setting
2018-12-31 14:08:59 -06:00
Danny Ryan
Hsiao-Wei Wang
Cayman
Alex Stokes
vbuterin
terence tsao
Justin