status-im/consul
2
0
Fork 0
mirror of https://github.com/status-im/consul.git synced 2025-01-10 22:06:20 +00:00
Code Issues Projects Releases Wiki Activity
3,767 Commits 445 Branches 179 Tags 489 MiB
Commit Graph

3767 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sean Chittenden
cff05be5b4 Merge pull request #1894 from hashicorp/f-rename-server-manager 
F rename server manager
 2016-03-29 17:44:26 -07:00
Sean Chittenden
7cdc056ca5 Rename server_details package to agent 2016-03-29 17:39:19 -07:00
Sean Chittenden
80f9f54bb3 Add a quick package doc for the servers package 2016-03-29 16:22:53 -07:00
Sean Chittenden
5501feecbe Rename serverConfig to serverList 
serverList is a vastly more accurate name.  Chase accordingly.  No functional change other than types and APIs.
 2016-03-29 16:17:16 -07:00
Sean Chittenden
6185f931d8 Gratuitous rename 1/2 
Reduce cognative load and perform an overdue rename.  No functional change.

Rename the `server_manager` package to `servers`.  Rename the `ServerManager` package to `Manager`.  In `client`, rename `serverMgr` to `servers`.
 2016-03-29 16:12:00 -07:00
Sean Chittenden
5cffcd56c3 Merge pull request #1880 from hashicorp/f-pretest-server 
Pre-connect new rebalanced server
 2016-03-29 11:12:59 -07:00
Sean Chittenden
3666c87d2f Remove two unused constants 2016-03-29 11:11:41 -07:00
Sean Chittenden
299d058d54 Remove useless comment residual from decomposing functions 2016-03-29 10:53:00 -07:00
Sean Chittenden
ec25ad84a6 EDYSLEXICMOMENT 2016-03-29 10:50:10 -07:00
Sean Chittenden
b684b15d94 Refactor out recocileServerList anon function 
Add testing to reconcileServerList and test various server sizes.

Test that a percentage of nodes fail their Ping (50% in testing atm)
 2016-03-29 02:45:38 -07:00
Sean Chittenden
c56f039884 Teach fauxConnPool to fail a pct of the time 
50% failure rate seems legit as a starting point w/ 100 servers.
 2016-03-28 14:53:29 -07:00
Sean Chittenden
43aed6376a Call NotifyFailedServers to rotate the server list 2016-03-28 14:12:41 -07:00
Sean Chittenden
6648d31579 Add log line re: server manager backing off and sleeping 
This is useful in situations where the RPC rotate duration is greater than 1µs.  WTB exponential backoff of logging so we don't spam forever.
 2016-03-28 14:04:04 -07:00
Sean Chittenden
544a263a62 Remove old debugging lines of questionable future value 2016-03-28 14:02:53 -07:00
Sean Chittenden
e5b5078415 Shuffle in place 
Don't create a copy and save the copy, not necessary any more.
 2016-03-28 14:02:27 -07:00
Sean Chittenden
a81eb95acc Nuke unnecessary comment 
See above function comments for details
 2016-03-28 13:57:36 -07:00
Sean Chittenden
e237904d80 Move FIXME comment to the right call site 2016-03-28 13:49:55 -07:00
Sean Chittenden
3dfd9e02b7 Rename the ConnPoolPinger interface to Pinger 2016-03-28 13:46:01 -07:00
Sean Chittenden
c9afc16d96 Return error from PingConsulServer 
In order to report why a Ping failed, change the signature of PingConsulServers to include an error message.
 2016-03-28 13:38:58 -07:00
Sean Chittenden
28dc6451d9 Change the definition of the ServerDetails struct key 
Use only the serf Name for now.  Leaving the plumbing for now.
 2016-03-28 12:53:19 -07:00
Sean Chittenden
62c38ecb39 Correct the comment to match reality 2016-03-28 12:32:30 -07:00
Sean Chittenden
8ac35d84f0 Rename serverCfg to sc for consistency 2016-03-28 12:06:26 -07:00
Sean Chittenden
664ab238fd Add a quick length check 
Verify that AddServer behaved as expected
 2016-03-28 11:38:12 -07:00
Sean Chittenden
4589c36308 Switch the order of ServerDetails.String() 
It's more natrual to have the network first.  I think I flipped the order accidentally.
 2016-03-28 11:37:25 -07:00
Sean Chittenden
e8a2e56370 Move rebalance log statement from INFO to DEBUG 2016-03-27 01:32:04 -07:00
Sean Chittenden
060dd49a95 Chase the API bump re: refreshServerRebalanceTimer 
If it works in prod, why shouldn't it work in the tests?
 2016-03-27 00:04:52 -07:00
Sean Chittenden
3d00208351 Move initialization of the rebalanceTimer to New() 2016-03-27 00:03:48 -07:00
Sean Chittenden
5652c60971 Add a test for ConnPool.PingConsulServer 
Spin up 5x servers, join and ping each server
 2016-03-26 23:52:06 -07:00
Sean Chittenden
efc1113406 Expose ServerManager.ResetRebalanceTimer 
Move the rebalance timer from ServerManager.Start's stack to struct ServerManager.  This makes it possible to shuffle during tests without actually waiting >120s.
 2016-03-26 23:41:01 -07:00
Sean Chittenden
d275cac1a3 Logging improvements 
Comment out noisly loggers for the time being.

Improve the final logging statement to be useful and hint what the next active server for the client is going to be.
 2016-03-26 22:41:08 -07:00
Sean Chittenden
35ff2eb71a Standardize the log message based on the package 
This log statement used to belong in the consul package but has since moved to the server manager package.
 2016-03-26 22:29:00 -07:00
Sean Chittenden
e327630523 Reduce the error level from Fatal when unit testing 2016-03-26 22:07:09 -07:00
Sean Chittenden
92c2e8e668 Start server rebalance task after init'ing Serf 
Now that there is no longer an event loop driven directly by Serf, start the ServerManager task after Serf has been setup.  When testing and adjusting timers and timeouts to unreasonably low values, it's possible to tickle a race condition where Serf's NumNodes() would fail because Serf had not been initialized.
 2016-03-26 22:04:41 -07:00
Sean Chittenden
ee95c55d88 Catch up to a few renames 2016-03-26 19:32:11 -07:00
Sean Chittenden
dc291e4027 Use empty string for addr in ServerDetails.String() 2016-03-26 19:30:04 -07:00
Sean Chittenden
970938c2dd Guard against a nil ServerDetails.Addr 
It's not clear how or why this would ever be nil, but some of the unit tests produce a nil addr.  Be defensive.
 2016-03-26 19:29:31 -07:00
Sean Chittenden
ca5950a538 Proactively ping server before rotation 
Before shuffling the server list, proactively ping the next server in the list to establish the connection and verify the remote endpoint is healthy.
 2016-03-26 19:28:13 -07:00
Sean Chittenden
18270bbd04 Factor out the shuffle server 2016-03-26 19:19:04 -07:00
Sean Chittenden
90d626b5d9 Revise comments re: cycleServer 
Improve the comments to discuss what happens presently.  Add a note to consider possibly calling to TestConsulServer proactively.
 2016-03-26 18:53:13 -07:00
Sean Chittenden
cf59a860e7 Comment why the interface is needed: cyclic import 2016-03-26 18:38:35 -07:00
Sean Chittenden
3ecd72f3b5 Add a struct key type for server_details 2016-03-26 17:58:12 -07:00
Sean Chittenden
ae32a3ceae Merge pull request #1873 from hashicorp/f-rebalance-worker-0.7 
Periodically rebalance the servers that agents talk to
 2016-03-25 15:03:18 -07:00
Sean Chittenden
5893bd5a35 Add additional checks 2016-03-25 14:40:46 -07:00
Sean Chittenden
d18e4d7455 Delete the right tag 
"role" != "consul"
 2016-03-25 14:31:48 -07:00
Sean Chittenden
b1194e83cb Don't pass in sm, server manager is already in scope 
Go closures are implicitly capturing lambdas.
 2016-03-25 14:10:09 -07:00
Sean Chittenden
a3a0eeeadd Trim residual complexity from server join notifications 
Now that serf node join events are decoupled from rebalancing activities completely, remove the complixity of draining the channel and ensuring only one go routine was rebalancing the server list.

Now that we're no longer initializing a notification channel, we can remove the config load/save from `Start()`
 2016-03-25 14:06:35 -07:00
Sean Chittenden
a71fbe57e3 Only log in FindServers 
In FindServer this is a useful warning hinting why its call failed. RPC returns error and leaves it to the higher level caller to do whatever it wants. As an operator, I'd have the detail necessary to know why the RPC call(s) failed.
 2016-03-25 13:58:50 -07:00
Sean Chittenden
58246fcc0b Initialize the rebalancce to clientRPCMinReuseDuration 
In an earlier version there was a channel to notify when a new server was added, however this has long since been removed.  Just default to the sane value of 2min before the first rebalance calc takes place.

Pointed out by: slackpad
 2016-03-25 13:46:18 -07:00
Sean Chittenden
4fec6a9608 Guard against very small or negative rates 
Pointed out by: slackpad
 2016-03-25 13:31:55 -07:00
Sean Chittenden
d9251e30c8 Use range vs for 
Returning a new array vs mutating an array in place so we can use range now.
 2016-03-25 13:08:08 -07:00