status-im/consul
2
0
Fork 0
mirror of https://github.com/status-im/consul.git synced 2025-02-22 18:38:19 +00:00
Code Issues Projects Releases Wiki Activity

Revise comments re: cycleServer

Browse Source 
Improve the comments to discuss what happens presently.  Add a note to consider possibly calling to TestConsulServer proactively.
This commit is contained in:
Sean Chittenden 2016-03-26 18:53:13 -07:00
parent cf59a860e7
commit 90d626b5d9
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
consul/server_manager/server_manager.go
View File

@ -125,7 +125,12 @@ func (sm *ServerManager) AddServer(server *server_details.ServerDetails) {
// cycleServers returns a new list of servers that has dequeued the first
// server and enqueued it at the end of the list. cycleServers assumes the
// caller is holding the serverConfigLock.
// caller is holding the serverConfigLock. cycleServer does not test or ping
// the next server inline. cycleServer may be called when the environment
// has just entered an unhealthy situation and blocking on a server test is
// less desirable than just returning the next server in the firing line. If
// the next server fails, it will fail fast enough and cycleServer will be
// called again.
func (sc *serverConfig) cycleServer() (servers []*server_details.ServerDetails) {
numServers := len(sc.servers)
if numServers < 2 {
@ -135,6 +140,9 @@ func (sc *serverConfig) cycleServer() (servers []*server_details.ServerDetails)
newServers := make([]*server_details.ServerDetails, 0, numServers)
newServers = append(newServers, sc.servers[1:]...)
newServers = append(newServers, sc.servers[0])
// FIXME(sean@): Is it worth it to fire off a go routine and
// TestConsulServer?
return newServers
}