Commit Graph

2287 Commits

Author SHA1 Message Date
Andre Medeiros 29c1ea39f8 Address feedback 2018-09-11 14:50:43 -04:00
Andre Medeiros 799a87f35e Clean up; Lint 2018-09-11 14:32:40 -04:00
Iuri Matias 4f50229beb temp/poc for eth_call coverage 2018-09-11 14:32:40 -04:00
Subramanian Venkatesan b3eedc4ba2 embark config 2018-09-10 23:12:04 +05:30
Subramanian Venkatesan fe0bbc3559 changes from the code review 2018-09-10 22:38:17 +05:30
Anthony Laibe 6ad9c0dc5a Update error with or 2018-09-10 17:08:09 +01:00
Anthony Laibe 32a6b53c6a Add missing callback 2018-09-10 17:05:11 +01:00
Anthony Laibe 16c870ac34 Use error logger 2018-09-10 13:57:54 +01:00
Subramanian Venkatesan 2782acf438 fix plugin command 2018-09-10 18:25:17 +05:30
emizzle 1d03f01531 Update warnings in embark after upload
warn user that they need to run a blockchain node and swarm for the dapp to work correctly.
2018-09-10 22:47:31 +10:00
emizzle b759e9eed7 Add ‘defaultpath’ for upload
Hardcode to ‘index.html’
2018-09-10 22:42:10 +10:00
emizzle 9d39fa39ac Swarm updates for embark
Change __embarkSwarm to use new SwarmJS and change over from promises.

Add note after upload that blockchain nodes needs to be running to access the swarm uploaded dapp.

Fix typo with swarm “on” available.

Linting / cleanup
2018-09-10 22:42:10 +10:00
emizzle e44b62d550 SwarmJS browser support 2018-09-10 22:42:10 +10:00
emizzle 3f5fe21b90 change to ‘uploadDirectory’ 2018-09-10 22:42:10 +10:00
emizzle 2dc8d8c276 Fix issue with swarm isAvailable 2018-09-10 22:42:10 +10:00
emizzle fcb75dee11 Move to swarmjs and await geth ready
Move to swarmjs library (in embark-framework).

Wait for geth to start before start of swarm check.
2018-09-10 22:42:10 +10:00
emizzle b5e8546ebd Converted upload procedure to local SwarmGW lib
# Conflicts:
#	package-lock.json
2018-09-10 22:42:00 +10:00
Anthony Laibe 68ef5454e0 Avoid multiple connect to IPC 2018-09-10 11:52:06 +01:00
Subramanian Venkatesan 53de6dcb19 Fixes to npm command parsing 2018-09-10 16:19:37 +05:30
Anthony Laibe 613921169a Better trace register ens 2018-09-10 10:12:02 +01:00
Subramanian Venkatesan 78bc27ad95 fix runCmd 2018-09-10 14:16:02 +05:30
Subramanian Venkatesan f20934ac8c Use Object.assign 2018-09-10 14:11:40 +05:30
Subramanian Venkatesan 4823d2312e remove console.log 2018-09-10 14:07:02 +05:30
Subramanian Venkatesan cb751b5213 install npm package using shell.js 2018-09-10 14:01:36 +05:30
Anthony Laibe b41bcbbe17 Use trace logger for code runner error 2018-09-10 09:26:37 +01:00
Subramanian Venkatesan c8e812e638 Plugin Command Module 2018-09-09 23:22:57 +05:30
Subramanian Venkatesan 74f0d05ca0 Plugin Command 2018-09-09 23:07:55 +05:30
Iuri Matias 833fcef22a
Merge pull request #795 from embark-framework/bug_fix/webserver-config-change
Watch webserver config and restart it
2018-09-07 19:04:17 -04:00
Iuri Matias 4128a96997
Merge pull request #796 from embark-framework/bug_fix/web3-location
getWeb3Location should use require.resolve()
2018-09-07 19:03:59 -04:00
Michael Bradley, Jr 7549c1f8e6 require.resolve() should start by looking in embark's own node_modules 2018-09-07 16:28:03 -05:00
Michael Bradley, Jr 13e21702d2 getWeb3Location should use require.resolve() for "version:get:web3" event 2018-09-07 15:52:30 -05:00
Jonathan Rainville 3d37fe6362 catch webserver config and restart it 2018-09-07 14:54:15 -04:00
Anthony Laibe 4c580dd54d Pr feedback using once 2018-09-07 14:57:49 +01:00
Anthony Laibe 4481e6eb99 Ens config is run only once 2018-09-07 11:18:43 +01:00
Iuri Matias 18ab1ce101
Merge pull request #790 from embark-framework/bugfix/solc-die
Avoid Solc to die because of compilation
2018-09-06 13:31:39 -04:00
Jonathan Rainville bee3aa1fde
Merge pull request #789 from eiselems/extendTemplateGenerator
Extend template_generator to support git urls and branches
2018-09-06 09:33:07 -04:00
Anthony Laibe 5957be9571 Avoid Solc to die because of compilation 2018-09-06 11:24:29 +01:00
eiselems c99d75c9f1 Extend template_generator to support git urls and branches
This change will also:
* upgrade calls from HTTP to HTTPS
* update / add some tests
See: #765
2018-09-06 02:09:46 +02:00
Iuri Matias 10035fe46b
Merge pull request #786 from embark-framework/bug_fix/upload-simple
Fix uploading a simple app
2018-09-05 18:23:27 -04:00
Iuri Matias 48a3d70df2
Merge pull request #785 from embark-framework/bug_fix/no-warning-dev
No accounts warning in development
2018-09-05 18:22:09 -04:00
Iuri Matias 428820f2c6
Merge pull request #781 from embark-framework/bug_fix/no-webserver-if-false
Do not start webserver if set to false in embark.json
2018-09-05 18:20:31 -04:00
Michael Bradley, Jr 7d29e53048 remove stray `?` in webpack.config.js 2018-09-05 16:49:26 -05:00
Jonathan Rainville 55bb028a13 add test too 2018-09-05 12:35:45 -04:00
Jonathan Rainville 56147ba200 fix order and remove ? 2018-09-05 11:47:53 -04:00
Jonathan Rainville 047286b46d skip webpack if no js files 2018-09-05 11:38:09 -04:00
Jonathan Rainville 3991880b44 no warning in development 2018-09-05 09:45:34 -04:00
Anthony Laibe c92f6f8865 Fix dynamic IPC 2018-09-05 10:40:37 +01:00
Jonathan Rainville e925200592 disable webserver if false 2018-09-04 16:44:42 -04:00
Iuri Matias 0f1f3a782a
Merge pull request #779 from embark-framework/chore/add-embarkjs-to-help
Add embarkJS to help
2018-09-04 15:26:31 -04:00
Jonathan Rainville 9351a12444 add embarkJS to help 2018-09-04 14:12:12 -04:00
Iuri Matias bf8183cf76
Merge pull request #778 from embark-framework/fix_deploy
Fix issue with changes in config file not causing a proper reload
2018-09-04 14:02:54 -04:00
Iuri Matias 7ee02525a7
Merge pull request #770 from embark-framework/features/open-browser
open browser when Embark's webserver starts
2018-09-04 13:51:57 -04:00
Michael Bradley, Jr d4be16ba3c move reporting to final callback 2018-09-04 08:20:58 -05:00
Michael Bradley, Jr b67aa8cc2d best practice re: early return w/ callback invocation 2018-09-04 08:20:27 -05:00
Michael Bradley, Jr c02199db0f rev comment 2018-09-04 07:36:21 -05:00
Michael Bradley, Jr 7d65c2b0cd rename placeholder event: 'build-placeholder' 2018-09-04 07:35:53 -05:00
Michael Bradley, Jr 57b2c5c4e4 'browser open' console command 2018-09-04 07:35:02 -05:00
Michael Bradley, Jr 68c6d1549a 'open-browser' event 2018-09-04 07:34:37 -05:00
Michael Bradley, Jr 103bb43a05 consistent naming, quotes-style 2018-09-04 07:32:31 -05:00
Anthony Laibe 5ad17be140 Fix Gas Price 2018-09-04 08:21:31 +01:00
Iuri Matias c3f7c58b8d delete require cache for config file so configs are actually reloaded 2018-09-03 14:01:46 -04:00
Iuri Matias 0314fb77c9 return if contract deploy is false 2018-09-03 14:01:26 -04:00
Michael Bradley, Jr 03c51fba46 pipeline fires placeholder event only after first build 2018-09-03 10:17:45 -05:00
Michael Bradley, Jr de0034c1fc formatting -- pipeline.js 2018-09-03 10:17:45 -05:00
Michael Bradley, Jr 9cd96ddd29 formatting -- webserver/server.js 2018-09-03 10:17:45 -05:00
Michael Bradley, Jr 52ed0e2856 webserver uses event and waterfall for triggering placeholder build, opening browser 2018-09-03 10:17:45 -05:00
Michael Bradley, Jr 6ee195aba9 make webserver module responsible for building placeholder 2018-09-03 10:17:45 -05:00
Michael Bradley, Jr 1d38af1f58 expose buildDir to webserver in same manner as its done for pipeline 2018-09-03 10:17:45 -05:00
Michael Bradley, Jr 1d9237820a make isFirstStart, opened props of Server instance 2018-09-03 10:17:45 -05:00
Michael Bradley, Jr 4f8107bf17 fail silently if opn doesn't work 2018-09-03 10:17:45 -05:00
Michael Bradley, Jr 72943dc0e5 open default browser when webserver has started 2018-09-03 10:17:45 -05:00
Michael Bradley, Jr f778dad589 write placeholder page when webserver is first starting 2018-09-03 10:17:45 -05:00
Iuri Matias 15467e6f49 use es string templates 2018-09-01 09:35:14 -04:00
Iuri Matias 9912c71b6f cleanup 2018-09-01 09:35:14 -04:00
Iuri Matias 1be58863e7 cleanup 2018-09-01 09:35:14 -04:00
Iuri Matias af947910c4 re-add context code 2018-09-01 09:35:14 -04:00
Iuri Matias 262a6d3aef move older code to embarkjs & refactor 2018-09-01 09:35:13 -04:00
Iuri Matias e42c4f94d8 remove utils; use EmbarkJS.connect method 2018-09-01 09:30:37 -04:00
Anthony Laibe 98e63ad424 Fix message events already declared 2018-08-31 18:55:38 +01:00
Iuri Matias 43945f6a49
Merge pull request #759 from embark-framework/bug_fix/ens-crash
Don't crash if ENS contracts don't deploy
2018-08-31 09:05:43 -04:00
Iuri Matias aeb4c0d0c0
Merge pull request #758 from embark-framework/bugfix/profile-do-not-crash
profile always return
2018-08-31 08:57:03 -04:00
Jonathan Rainville f1e5aff3fb dont crash if ens contracts don't deploy 2018-08-31 08:50:15 -04:00
Jonathan Rainville 3e89729331 conflict with indents 2018-08-31 08:46:08 -04:00
Anthony Laibe a325abe1c2 profile always return 2018-08-31 13:41:41 +01:00
Iuri Matias a1c2d7e77a
Merge pull request #756 from embark-framework/feature/console-ipc-server-client
Console can be a client or server ipc
2018-08-31 07:58:55 -04:00
Iuri Matias f0221bbb10
Merge pull request #755 from embark-framework/chores/es-lint-no-else
Enable no-else-return
2018-08-31 07:49:25 -04:00
Iuri Matias 46076c8d4e
Merge pull request #751 from embark-framework/feature/embarkjs-console
Feature/embarkjs console
2018-08-31 07:46:54 -04:00
Anthony Laibe e0f73c7d22 Make console a module 2018-08-31 09:36:50 +01:00
Andre Medeiros bb92582c0a Fix passing compiler options 2018-08-30 16:11:42 -04:00
André Medeiros 026da48e74
Merge pull request #749 from embark-framework/features/coverage-loops-declarations-events
Improve code coverage
2018-08-30 14:46:34 -04:00
Andre Medeiros 34f6a130d8 Update complexity 2018-08-30 13:50:36 -04:00
Andre Medeiros f3857e4084 Import directives and struct definitions don't really count as executed code 2018-08-30 13:46:26 -04:00
Andre Medeiros 05dea5844a Fix the way we pass compiler options instead of assuming via the environment 2018-08-30 13:27:18 -04:00
Andre Medeiros 2c2e54b613 Fix feedback 2018-08-30 13:01:13 -04:00
Andre Medeiros bc5de4ef90 Support modifiers 2018-08-30 12:49:41 -04:00
Anthony Laibe 59e82d5fc6 Console can be a client or server ipc 2018-08-30 15:45:01 +01:00
Anthony Laibe df651865c1 Enable no-else-return 2018-08-30 14:53:04 +01:00
Anthony Laibe 31cb79bf5b PR feedback 2018-08-30 10:41:13 +01:00
Anthony Laibe 581b0c9f42 Fix lint 2018-08-30 10:04:58 +01:00
Anthony Laibe 98c785a4bb Fix register var and runcode 2018-08-30 10:04:58 +01:00
Anthony Laibe cc312a91b6 Refactor code runner 2018-08-30 10:04:58 +01:00
Anthony Laibe deb433c0fb Fix ens enabled 2018-08-30 10:04:58 +01:00
Anthony Laibe b9944b18d2 Pass web3 as params 2018-08-30 10:04:58 +01:00
Anthony Laibe 0a261b050d Name available in console 2018-08-30 10:04:58 +01:00
Anthony Laibe a8c5205b67 Extract global and web3js 2018-08-30 10:04:58 +01:00
Anthony Laibe 83c01cffdc Storage and Whisper connect 2018-08-30 10:04:58 +01:00
Anthony Laibe 00ccad1d9b Fix isavailable 2018-08-30 10:04:58 +01:00
Anthony Laibe 6c63179fa1 Fix lint 2018-08-30 10:04:58 +01:00
Anthony Laibe 6a2b91d99b Add console/require to codeRunner 2018-08-30 10:04:58 +01:00
Anthony Laibe 307b7dc8e7 EmbarkJS available 2018-08-30 10:04:58 +01:00
Anthony Laibe d772b4fdaf Add embarkjs to console 2018-08-30 10:04:58 +01:00
Iuri Matias bd49e3672c
Merge pull request #752 from embark-framework/feature/silent-already-deployed
Silent already deployed
2018-08-29 17:37:54 -04:00
Iuri Matias 7eb52c1f8f
Merge pull request #735 from embark-framework/bugfix/allow-zero-config-blockchain
Allow zero config in blockchain
2018-08-29 17:33:15 -04:00
Anthony Laibe c94b5574cf Silent already deployed 2018-08-29 11:23:24 +01:00
Michael Bradley, Jr 12d37f8f68 don't load the CompressionPlugin by default 2018-08-28 15:50:40 -05:00
Michael Bradley, Jr fccdee35ed don't have webpack produce a .gz of output by default 2018-08-28 15:45:11 -05:00
Michael Bradley, Jr 08fc21c890 gateway URLs: http -> https 2018-08-28 15:44:50 -05:00
Andre Medeiros 824353fb32 Lint 2018-08-28 13:51:55 -04:00
Andre Medeiros 543f883b7d Fix consolidation of coverage and compiler events; Cleanup 2018-08-28 13:39:18 -04:00
Andre Medeiros 4c127d1192 Events 2018-08-28 11:27:37 -04:00
Andre Medeiros 4e9d2823e5 Improvements 2018-08-28 11:27:37 -04:00
Andre Medeiros 5dcd679e12 Add for loops and variable declarations; Coverage improvements 2018-08-28 11:27:37 -04:00
Anthony Laibe fdd2d10d38 Add warning 2018-08-28 09:32:39 +01:00
Anthony Laibe 23f7ec396a Allow zero config in blockchain 2018-08-27 10:06:37 +01:00
Michael Bradley, Jr 8fa5bddde5 rev comment re: webpack-bundle-analyzer 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 6149921562 rev comments 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 65d2153638 prefer early return for config.stats tests 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 9e62d9c1a9 isDir test should support possible use of '\' by devs on Windows 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 8bec33177e rm some else clauses 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f4b11ce29f explanatory comment 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 382122c6d9 mapCb -> eachCb 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 04a5e3335d self.logger -> self.logger.error 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f66552b044 errorMessage helper moved to utils 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr c8cd5f4229 consistent indentation 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 46c4aea520 rev comment re: NODE_PATH in webpack config 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr cec7dc5750 DRY resolve 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 792a8f57eb consistent handling of error messages, no double reporting 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 421927d815 paths more DRY 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f1edc28f6d anchoredPath helper (more DRY) 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 67147f2cad make the linter happy 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 7fb9c552dc assetFileWrite no longer processes files corresponding to .js keys 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 0161a9b402 "writing file" messages for files that will be written by webpack 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr e1fb746aa7 relocate webpack.config.js under lib/pipeline/ 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 53a4fd2089 rm redundant setup of env vars 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 76502fa693 rm utils.pwd() -- redundant now that fs.dappPath is anchored to env var 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr f0f95554a5 prefer fs.dappPath 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 8be1090a44 prefer joinPath to +'ing strings together 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 40c14a08de whitespace 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 019f0b68c8 anchor fs.dappPath, fs.embarkPath to env vars setup in cmd.js 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr b3c8e5fa45 missing spaces 2018-08-24 15:04:16 -05:00
Michael Bradley, Jr 3ad834d93d rev comment to reflect code changes 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 35f92f2ae8 more DRY re: config 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 04fcb1510a rev comment 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 1f56f717b8 'running webpack' message should indicate config name 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 7291fd1187 can use `this`, don't need `self` 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 963ecc0d92 formatting 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 878186660b change timing of "writing file" messages 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr f654c0a013 single webpack run 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr e9ec968598 whitespace 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 6282e092f1 note/question 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr 2f2f007d5c use embark's webpack config, or a dapp's webpack config if it exists 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr c60d26e258 make fs.embarkPath more flexible 2018-08-24 15:04:15 -05:00
Michael Bradley, Jr b41f5a397d --pipeline option for `ebmark build|run` to spec webpack config name 2018-08-24 15:04:15 -05:00
Iuri Matias f0a6b913c4
Merge pull request #747 from embark-framework/features/password-protected-keyfiles
Unlock account using keystore file with password
2018-08-24 16:01:55 -04:00
Iuri Matias a0d864b8ae
Merge pull request #746 from embark-framework/bug_fix/tests-ws-bug
Fix test_app with a WS node
2018-08-24 15:53:54 -04:00
Jonathan Rainville 9d4a3fd228 if there is a password field in privateKeyFile object, decode keystore 2018-08-24 15:30:44 -04:00
Jonathan Rainville 13e0d453ae fix websocket test, but still some hangs on second test run 2018-08-24 12:09:38 -04:00
Iuri Matias 864b41a2c2
Merge pull request #745 from embark-framework/deployIf
deployIf field + minor refactor
2018-08-24 10:33:58 -04:00
Iuri Matias 4305d63108 clarify param is not used 2018-08-24 10:31:40 -04:00
Iuri Matias eb57b358cd
Merge pull request #738 from embark-framework/bug_fix/double-embark
Enable multiple Embark runs at the same time
2018-08-24 10:09:45 -04:00
Iuri Matias 052ffb72f9
Merge pull request #744 from embark-framework/bugfix/buffer-contract
Isolate the code runner
2018-08-24 10:03:11 -04:00
Iuri Matias ffbd39882a remove isTest 2018-08-24 09:25:47 -04:00
Anthony Laibe de57e48cff Isolate the code runner 2018-08-24 14:05:19 +01:00
Iuri Matias c52142cb4c move always deploy on tests to deploy tracker 2018-08-24 08:59:56 -04:00
Iuri Matias 8f5b47adf4 add deployIf directive support 2018-08-23 18:00:52 -04:00
Michael Bradley, Jr 2280d30cd1 don't continue with template install if destination path exists 2018-08-23 15:43:42 -05:00
Iuri Matias a56431d19a refactor run actions for events to a reduce; add initial plug for shouldDeploy using deployIf 2018-08-23 16:25:28 -04:00
Michael Bradley, Jr 1a3e1a18df use console.warn and yellow text for locale fallback msg 2018-08-23 15:00:25 -05:00
Michael Bradley, Jr 72c1a9cd4c fix locale detection so it works w/ env var and/or --locale 2018-08-23 14:51:33 -05:00
Jonathan Rainville b9c65f2d58 use listen(0) to find a port 2018-08-23 15:11:43 -04:00
Iuri Matias 5fe86e35d1
Merge pull request #736 from embark-framework/features/test-node-option
Add --node option for tests
2018-08-23 15:07:10 -04:00
Iuri Matias 7da523b48c
Merge pull request #737 from embark-framework/i18n_updates
I18n updates
2018-08-23 15:05:26 -04:00
Iuri Matias d66dae15d9
Merge pull request #734 from embark-framework/bugfix/fix-livenet-naming
Mainnet is livenet
2018-08-23 15:01:39 -04:00
Iuri Matias 26cde59fcb
Merge pull request #732 from embark-framework/feature/hide-ens-transaction-log
Hide ENS Transaction log
2018-08-23 14:57:36 -04:00
Iuri Matias 7bd3202ad5
Merge pull request #731 from embark-framework/features/await-console
simple implementation of await in the console
2018-08-23 14:53:13 -04:00
Iuri Matias fc12a2996e
Merge pull request #730 from embark-framework/bug_fix/on-deploy-twice
remove double registerModule
2018-08-23 14:50:00 -04:00
Jonathan Rainville 7e59b6f0d0 increment port multiple times if multiple embarks 2018-08-23 14:28:44 -04:00
Iuri Matias 20cabeff84 update i18n 2018-08-23 14:16:31 -04:00
Jonathan Rainville a38c317ecd check port for webserver, if in use ++ port 2018-08-23 14:14:10 -04:00
Iuri Matias 4a5c53b43a update i18n 2018-08-23 13:53:18 -04:00
Jonathan Rainville c6abafff05 fix printing 2018-08-23 13:38:58 -04:00
Jonathan Rainville 36c6de4b99 add error message if no connection 2018-08-23 13:01:22 -04:00
Jonathan Rainville 86f1cf51d2 enable node=embark 2018-08-23 12:54:43 -04:00
Anthony Laibe a19fc16426 Mainnet is livenet 2018-08-23 11:06:47 +01:00
Anthony Laibe 39b9d6e1d8 PR feedback 2018-08-23 09:59:02 +01:00
Anthony Laibe 607c2657c4 Hide ENS Transaction log 2018-08-23 09:23:51 +01:00
Jonathan Rainville 3f561f5257 use node option for tests 2018-08-22 16:46:39 -04:00
Jonathan Rainville 326e12d23a fix one with variable 2018-08-22 14:23:23 -04:00
Jonathan Rainville a0b06c6197 make it work with variables too 2018-08-22 14:09:10 -04:00
Jonathan Rainville 8ebe55f457 simple implementation of await 2018-08-22 11:32:15 -04:00