Merge pull request #790 from embark-framework/bugfix/solc-die

Avoid Solc to die because of compilation
This commit is contained in:
Iuri Matias 2018-09-06 13:31:39 -04:00 committed by GitHub
commit 18ab1ce101
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions

View File

@ -12,13 +12,14 @@ class ProcessWrapper {
* Manages the log interception so that all console.* get sent back to the parent process
* Also creates an Events instance. To use it, just do `this.events.[on|request]`
*
* @param {Options} _options Nothing for now
* @param {Options} options pingParent: true by default
*/
constructor(_options) {
constructor(options = {pingParent: true}) {
this.interceptLogs();
this.events = new Events();
this.pingParent();
if(options.pingParent) {
this.pingParent();
}
}
// Ping parent to see if it is still alive. Otherwise, let's die

View File

@ -10,7 +10,7 @@ const NpmTimer = require('../library_manager/npmTimer');
class SolcProcess extends ProcessWrapper {
constructor(options){
super();
super({pingParent: false});
this._logger = options.logger;
this._showSpinner = options.showSpinner === true;
}