embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

rev comment re: NODE_PATH in webpack config

This commit is contained in:
Michael Bradley, Jr 2018-08-18 22:14:43 -05:00
parent e0fda460ba
commit 46c4aea520
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/pipeline/webpack.config.js
View File

@ -5,15 +5,15 @@
// in the dapp's own package.json, perhaps with a different version/range or
// other specifier
// NOTE: embark modifies process.env.NODE_PATH so that embark's own
// node_modules directory will be searched by node's require(). That allows an
// ejected version of this config, inside a dapp, to function correctly without
// embark being an explicit dependency of the dapp. However, webpack and babel
// do not directly support NODE_PATH, so in various parts of the config,
// modules such as plugins and presets must be resolved with
// require.resolve(). That is only necessary if a plugin/preset is in embark's
// node_modules; if it's in the dapp's node_modules then it can be specified
// directly
// NOTE: embark modifies process.env.NODE_PATH so that when running dapp
// scripts in embark's child processes, embark's own node_modules directory
// will be searched by node's require(); that allows an ejected version of this
// config, inside a dapp, to function correctly without embark being an
// explicit dependency of the dapp; however, webpack and babel do not directly
// support NODE_PATH, so in various parts of the config, modules such as babel
// plugins and presets must be resolved with require.resolve(); that is only
// necessary if a plugin/preset is in embark's node_modules vs. the dapp's
// node_modules
// there's a bug in pkg clone-deep re: regex; for now use lodash.clonedeep
// see: https://github.com/jonschlinkert/clone-deep/pull/14