embarklabs/embark
2
0
Fork 0
mirror of https://github.com/embarklabs/embark.git synced 2025-02-02 17:03:36 +00:00
Code Issues Projects Releases Wiki Activity

use listen(0) to find a port

Browse Source
This commit is contained in:
Jonathan Rainville 2018-08-23 15:11:43 -04:00
parent 7e59b6f0d0
commit b9c65f2d58
2 changed files with 20 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lib/modules/webserver/index.js
View File

@ -18,13 +18,15 @@ class WebServer {
this.events.emit("status", __("Starting Server"));
this.server = new Server({host: this.host, port: this.port});
this.testPort(() => {
this.server = new Server({host: this.host, port: this.port});
this.setServiceCheck();
this.listenToCommands();
this.registerConsoleCommands();
this.server.start((_err, message) => this.logger.info(message));
this.server.start((_err, message, port) => {
this.logger.info(message);
this.port = port;
this.setServiceCheck();
});
});
}
@ -33,17 +35,18 @@ class WebServer {
if (err) { // Port is ok
return done();
}
this.logger.warn(__('Webserver already running on port {{oldPort}}. Trying to connect on {{newPort}}',
{oldPort: this.port, newPort: this.port + 1}));
this.port++;
this.testPort(done);
this.logger.warn(__('Webserver already running on port %s. Assigning an available port', this.port));
this.port = 0;
this.server.port = 0;
done();
});
}
setServiceCheck() {
let url = 'http://' + canonicalHost(this.host) + ':' + this.port;
const self = this;
this.events.request("services:register", 'Webserver', function (cb) {
let url = 'http://' + canonicalHost(self.host) + ':' + self.port;
utils.checkIsAvailable(url, function (available) {
let devServer = __('Webserver') + ' (' + url + ')';
let serverStatus = (available ? 'on' : 'off');

14
lib/modules/webserver/server.js
View File

@ -24,12 +24,14 @@ class Server {
serve(req, res, finalhandler(req, res));
}).withShutdown();
let message = __("webserver available at") +
" " +
("http://" + canonicalHost(this.hostname) +
":" + this.port).bold.underline.green;
this.server.listen(this.port, this.hostname);
callback(null, message);
this.server.listen(this.port, this.hostname, () => {
this.port = this.server.address().port;
callback(null, __("webserver available at") +
" " +
("http://" + canonicalHost(this.hostname) +
":" + this.port).bold.underline.green, this.port);
});
}
stop(callback) {