Commit Graph

27 Commits

Author SHA1 Message Date
burnettk 02855719b8 Squashed 'SpiffWorkflow/' changes from 98c6294f..0e61be85
0e61be85 Merge pull request #289 from sartography/improvement/execution-and-serialization-cleanup
527684da fix some typos in the class & method docs
0dff44a4 Merge branch 'main' into improvement/execution-and-serialization-cleanup
64737498 Allow for other PythonScriptEngine environments besides task data (#288)
dd63e916 remove some unused tests & diagrams
24aae519 clean up various small stuff
3b2dc35d use context when opening files for parsing
69eec3eb update class/method docs
24528dfb move all spec conversion classes to top level
5af33b11 remove some unused methods related to old serializer
931b90fb reorganize serializer
4e81ed29 consolidate pointless serializer classes
d62acf02 change task_spec._update_hook to return a boolean indicating whether the task is ready

git-subtree-dir: SpiffWorkflow
git-subtree-split: 0e61be85c47474a33037e6f398e64c96e02f13ad
2023-02-02 20:59:28 -05:00
Dan ba67d7ad34 Squashed 'SpiffWorkflow/' changes from 450ef3bcd..98c6294f1
98c6294f1 Merge pull request #287 from sartography/feature/workflow_data_exceptions
d40a1da59 Workflow Data Exceptions were broken in the previous error refactor.  This assures we are getting good messages from these errors.
a156378e1 Merge pull request #286 from sartography/feature/inclusive-gateway-support
7f6e398c2 bypass unnecessary checks in gateway joins
ade21a894 revert a few things
e1cf75202 Merge branch 'main' into feature/inclusive-gateway-support
15a0a4414 revert change to MultiChoice and handle no defaults in BPMN specs
e1469e6bb add support for diverging inclusive gateways
71fd86386 really prevent non-default flows without conditions
924759d9b clean up join specs
7378639d3 Merge pull request #284 from sartography/feature/improved-timer-events
dc8d139d2 remove useless method
530f23697 Merge branch 'main' into feature/improved-timer-events
307cca9c5 partially clean up existing gateways
0a344285e clean up task parsers
2cef997d1 add waiting_events method to bpmn workflow
48091c407 serializer migration script and miscellaneous fixes to serialization
61316854b store internal timer data as string/float
389c14c4c add some tests for parsing durations
582bc9482 convert timers to iso 8601
6dfd7ebe9 remove extraneous calls to update
6bd429529 clean up tests
d56e9912f remove useless method

git-subtree-dir: SpiffWorkflow
git-subtree-split: 98c6294f1240aee599cd98bcee58d121cb57b331
2023-01-26 18:17:35 -05:00
jasquat eedac61165 Squashed 'SpiffWorkflow/' changes from 1f51db962..450ef3bcd
450ef3bcd Merge pull request #105 from sartography/feature/avoid_logs_when_call_activity_waiting
58468a489 do not write set data logs at all since they are redundant w/ burnettk
0eeccaf1c do not write to logs when a task is inheriting data from the parent w/ burnettk

git-subtree-dir: SpiffWorkflow
git-subtree-split: 450ef3bcd639b6bc1c115fbe35bf3f93946cb0c7
2023-01-19 13:44:52 -05:00
jasquat 35ef5cbe54 Squashed 'SpiffWorkflow/' changes from 4195453a4..1f51db962
1f51db962 Merge pull request #283 from sartography/feature/better_errors
69fb4967e Patching up some bugs and logical disconnects as I test out the errors.
cf5be0096 * Making a few more things consistent in the error messages -- so there isn't filename for validation errors, and file_name for WorkflowExceptions.  Same for line_number vs sourceline. * Assure than an error_type is consistently set on exceptions. * ValidationExceptions should not bild up a detailed error message that replicates information available within it.
440ee16c8 Responding to some excellent suggestions from Elizabeth:
655e415e1 Merge pull request #282 from subhakarks/fix-workfowspec-dump
1f6d3cf4e Explain that the error happened in a pre-script or post script.
8119abd14 Added a top level SpiffWorklowException that all exceptions inherit from.  Aside from a message string you can append information to these exceptions with "add_note", which is a new method that all exceptions have starting in python 3.11 Switched arguments to the WorkflowException, WorkflowTaskException - which now always takes a string message as the first argument, and named arguments thereafter to be consistent with all other error messages in Python. Consistently raise ValidationExceptions whenever we encounter an error anywhere during parsing of xml. The BPMN/WorkflowTaskExecException is removed, in favor of just calling a WorkflowTaskException.  There is nothing BPMN Specific in the logic, so no need for this. Consolidated error message logic so that things like "Did you mean" just get added by default if possible.  So we don't have to separately deal with that logic each time. Better Error messages for DMN (include row number as a part of the error information)
13463b5c5 fix for workflowspec dump
be26100bc Merge pull request #280 from sartography/feature/remove-unused-bpmn-attributes-and-methods
23a5c1d70 remove 'entering_* methods
4e5875ec8 remove sequence flow
5eed83ab1 Merge pull request #278 from sartography/feature/remove-old-serializer
614f1c68a remove compact serializer and references
e7e410d4a remove old serializer and references

git-subtree-dir: SpiffWorkflow
git-subtree-split: 1f51db962ccaed5810f5d0f7d76a932f056430ab
2023-01-19 10:47:07 -05:00
jasquat 3ff98fb51e Squashed 'SpiffWorkflow/' changes from 5664815a2..4195453a4
4195453a4 Merge commit 'b55571406634555736fc471e7a53ca8b22288980'
0629dcb9a added fix to SpiffWorkflow to deepcopy operation params before evaluating them w/ burnettk

git-subtree-dir: SpiffWorkflow
git-subtree-split: 4195453a46638f23e87c3ffdb038717c2d8abd00
2023-01-05 17:35:20 -05:00
jasquat b555714066 Squashed 'SpiffWorkflow/' changes from 80640024a..5664815a2
5664815a2 Merge pull request #277 from sartography/bugfix/update-serializer-version
893ae8334 Merge branch 'main' of github.com:sartography/SpiffWorkflow into main
40a5f3412 add link to Spiffworkflow.org
38ce694ee update serializer version

git-subtree-dir: SpiffWorkflow
git-subtree-split: 5664815a2e61cd334f35136d2d7ac8856a95a28c
2023-01-05 17:33:33 -05:00
burnettk 7280cc5ea5 Squashed 'SpiffWorkflow/' changes from 5c4592801..80640024a
80640024a Merge pull request #275 from sartography/bugfix/data-object-error
71a377981 prevent output associations from being removed twice

git-subtree-dir: SpiffWorkflow
git-subtree-split: 80640024a8030481645f0c34f34c57e88f7b4f0c
2023-01-04 08:28:48 -05:00
jasquat 2505de7027 Squashed 'SpiffWorkflow/' changes from 841bd630..5c459280
5c459280 update discord link with one that does not expire

git-subtree-dir: SpiffWorkflow
git-subtree-split: 5c4592801fea56ba2f0c56df467f759bcfe47b7e
2022-12-27 13:53:09 -05:00
jasquat df6e065606 Squashed 'SpiffWorkflow/' changes from ffb16867..841bd630
841bd630 Merge pull request #273 from sartography/bugfix/catch-timers-in-event-gateways
103c70d0 hacks to handle timer events like regular events

git-subtree-dir: SpiffWorkflow
git-subtree-split: 841bd63017bb1d92858456393f144b4e5b23c994
2022-12-16 13:23:00 -05:00
burnettk 71a2a3ec0e Squashed 'SpiffWorkflow/' changes from 46d3de27f..ffb168675
ffb168675 Option to run tests in parallel (#271)
062eaf15d another hot match -- assure hit policy is correctly passed through.
c79ee8407 Quick patch the DMN hit policy to fix a dump mistake.
36dd1b23a Fix ResourceWarning: unclosed file BpmnParser.py:60 (#270)
bba7ddf54 Merge pull request #268 from sartography/feature/multiple-event-definition
8cf770985 remove unused import
9d31e035e make multiple throw events work with start events
890c4b921 add throw support for multiple events
c1fc55660 add support for catching parallel multiple event definitions
511830b67 add event based gateway
56bd858dc add event type for multiple events

git-subtree-dir: SpiffWorkflow
git-subtree-split: ffb1686757f944065580dd2db8def73d6c1f0134
2022-12-10 23:39:00 -05:00
Dan cc1903387b Squashed 'SpiffWorkflow/' changes from 46f410a28..46d3de27f
46d3de27f Merge pull request #267 from sartography/feature/dmn_collect_policy
2d5ca32d5 Support for the "COLLECT" hit policy. * DecisionTable constructor now expects a third argument (the HitPolicy) * DMNParser now checks for a hitPolicy attribute, but defaults ot "UNIQUE" as Camunda doesn't put another in there if Unique is selected. * DecisionTable deserializer will default to a hitPolicy of "UNIQUE" if not value is in the Json.

git-subtree-dir: SpiffWorkflow
git-subtree-split: 46d3de27ffbcaf60025f09d1cf04fcc7ee98658a
2022-11-25 11:07:31 -05:00
burnettk d2af3e7252 Squashed 'SpiffWorkflow/' changes from cd4da465e..46f410a28
46f410a28 Merge pull request #265 from sartography/bugfix/spiff-script-errors
ffe07df7b correct xpath for extensions

git-subtree-dir: SpiffWorkflow
git-subtree-split: 46f410a2852baeedc8f9ac5165347ce6d4470594
2022-11-20 19:48:29 -05:00
burnettk 37b7f3d7cd Squashed 'SpiffWorkflow/' changes from 580939cc..cd4da465
cd4da465 Merge pull request #264 from sartography/bugfix/dmn-equality-with-boolean
414a59eb disambiguate DMN expressions
eea53c91 Merge pull request #263 from sartography/feature/cleanup-task-completion
d248d5b1 execute postscript before other complete hook tasks
c09f1a90 streamline predict & remove some duplicated calls to it
64c21791 remove duplicate calls to update
4ca1076d move task update to _on_complete to ensure data is copied consistently after task related activities are done
d037a7eb small changes for readability
025bc30f Quick patch -- is_executable needs to be accurate immediately.
14d3d8c3 Merge pull request #262 from sartography/feature/parser_info_features
849c223e We are jumping through a lot of complex xml parsing in SpiffWorkflow-Backend because we need to know some basic information about a BPMN process at the moment it is saved.  Rather than do that work in the backend, it seems better to have SpiffWorkflow handle parsing the xml and providing a bit of metadata, including:

git-subtree-dir: SpiffWorkflow
git-subtree-split: cd4da465e125ca1ae1b57d227bfa324d9d4c507c
2022-11-18 10:03:32 -05:00
Jon Herron 9bb7af4f43 Squashed 'SpiffWorkflow/' changes from 5d35f5c50..580939cc8
580939cc8 Merge commit 'cc24e8685b4a965955e9ce2fdd9d55fed6d360fc'
0898498e5 Move to Python 3.11 (#27)

git-subtree-dir: SpiffWorkflow
git-subtree-split: 580939cc8cb0b7ade1571483bd1e28f554434ac4
2022-11-09 15:44:06 -05:00
jasquat cc24e8685b Squashed 'SpiffWorkflow/' changes from 8d820dce1..5d35f5c50
5d35f5c50 Quick fix on the readthedocs.

git-subtree-dir: SpiffWorkflow
git-subtree-split: 5d35f5c50d06e35b17c7e045fcf6000a6e16d8b6
2022-11-09 15:02:17 -05:00
burnettk 7ac4b51c6a Squashed 'SpiffWorkflow/' changes from a6392d1906..8d820dce1f
8d820dce1f Track spiff step details more granularly (#17)
426da26d8f Clear the remaining __init__.py imports in SpiffWorkflow (#14)
9a1d1c484a Fix FutureWarning in SpiffWorkflow (#16)

git-subtree-dir: SpiffWorkflow
git-subtree-split: 8d820dce1f439bb76bc07e39629832d998d6f634
2022-11-04 09:33:42 -04:00
burnettk c3cdca16b8 Squashed 'SpiffWorkflow/' changes from 5cdb881ed..a6392d190
a6392d190 SpiffWorkflow cold start improvements (#13)

git-subtree-dir: SpiffWorkflow
git-subtree-split: a6392d19061f623394f5705fb78af23673d3940d
2022-11-02 12:19:52 -04:00
burnettk 53bc093c53 Squashed 'SpiffWorkflow/' changes from 2d3bd0085..5cdb881ed
5cdb881ed Merge pull request #8 from sartography/feature/clean_up_sentry_errors
26d9788bd avoid sending two errors to sentry w/ burnettk

git-subtree-dir: SpiffWorkflow
git-subtree-split: 5cdb881edc4621502bfd61ce67565cf1148199f0
2022-10-31 14:09:41 -04:00
burnettk f82f4c2582 Squashed 'SpiffWorkflow/' changes from 3579c477e..2d3bd0085
2d3bd0085 Merge pull request #261 from sartography/feature/xml-validation
a67abd453 Merge pull request #260 from sartography/feature/add_init_to_schema
905c1265d remove debug code w/ burnettk
8daf322da attempt using package data w/ burnettk
7f7c0c10b add an init file to schema directory to see if it can be picked up as a package w/ burnettk
abb2898b1 cleaning up code smell

git-subtree-dir: SpiffWorkflow
git-subtree-split: 2d3bd00854ab483e823c4b386430abc9267f536b
2022-10-27 15:15:03 -04:00
Dan 7184b165bb Squashed 'SpiffWorkflow/' changes from d27519a36..3579c477e
3579c477e use last task data instead of subworkflow data on subworkflow complete

git-subtree-dir: SpiffWorkflow
git-subtree-split: 3579c477eaf19a982a2822609fcf20b56c050eb5
2022-10-27 14:57:23 -04:00
jasquat 742f549e98 Squashed 'SpiffWorkflow/' changes from 12f81480a..d27519a36
d27519a36 Merge pull request #259 from sartography/bugfix/spiff-postscript-execution
21aa8a12c update execution order for postscripts
d83fd3d81 Merge pull request #256 from sartography/feature/xml-validation
8303aaab5 uping the sleep time in a test slightly to see if we can get this test to pass consistently in CI.
1d251d55d determine whether to validate by passing in a validator instead of a parameter
2d3daad2d add spiff schema
f8c65dc60 Minor changes to BPMN diagrams to assure all tests are run against valid BPMN Diagrams. Changes required:
9e06b25bf add DMN validation
1b7cbeba0 set parser to validate by default
53fdbba52 add schemas & validation option
a212d9c5d general cleanup

git-subtree-dir: SpiffWorkflow
git-subtree-split: d27519a3631b9772094e5f24dba2f478b0c47135
2022-10-27 10:50:48 -04:00
burnettk 98b76370b1 Squashed 'SpiffWorkflow/' changes from bb9832928..12f81480a
12f81480a Merge pull request #258 from sartography/bugfix/script-attribute-error
7ca0917eb pass script to workflow task exec exception

git-subtree-dir: SpiffWorkflow
git-subtree-split: 12f81480a5f9e848e64221b9287c6cfa6cb682b4
2022-10-26 16:24:47 -04:00
burnettk 8c7fc36ec3 Squashed 'SpiffWorkflow/' changes from a094adad8..bb9832928
bb9832928 Merge pull request #257 from sartography/bugfix/add-spiff-scripts-to-service-task
ecd9ecb84 parse spiff script extensions in service tasks

git-subtree-dir: SpiffWorkflow
git-subtree-split: bb9832928b47055d2d51e1f5711f1abc4139f7d8
2022-10-26 13:40:35 -04:00
burnettk dfd3eee5e9 Squashed 'SpiffWorkflow/' changes from d9fcd45a3..a094adad8
a094adad8 Prep for release 1.2.1 - Minor fix for a dependency in Python 3.10
b9e3dd80e Merge pull request #253 from sartography/feature/avoid_importlib_for_python_3.8_up
df311639c do not install importlib-metadata if greater than python 3.7 w/ burnettk

git-subtree-dir: SpiffWorkflow
git-subtree-split: a094adad8767f82e9c5fa806a46597e066252a72
2022-10-19 10:31:33 -04:00
jasquat 7515519bc9 Squashed 'SpiffWorkflow/' changes from 9d597627..d9fcd45a
d9fcd45a Updating release numbers
e0d04877 Merge pull request #251 from sartography/bugfix/make-data-objects-available-to-prescripts
7d260c36 Merge pull request #252 from sartography/bug/data_object_serializer_fix
3de54d97 Fixing a failing test.
27c5d3e1 A minor fix during deserialization to avoid issues for some users that upgraded between official releases.
250311d6 copy data objects before prescript execution

git-subtree-dir: SpiffWorkflow
git-subtree-split: d9fcd45a384f8376a669cf58677564289d2c661c
2022-10-14 15:42:16 -04:00
Jon Herron a79d0962a9 Squashed 'SpiffWorkflow/' changes from 63db3e459..9d597627b
9d597627b Merge pull request #250 from sartography/feature/documentation-updates-for-1.2
896447557 Merge pull request #249 from sartography/feature/improved-logging
10b710498 remove comments
3e8a29d6f Merge branch 'main' into feature/improved-logging
ca8a88d9e first draft of updated docs
f0bb63294 remove one unnecessary log statement during BpmnWorkflow init and add some debug info about the other two
acce225e0 do not log task & workflow changes when deserializing

git-subtree-dir: SpiffWorkflow
git-subtree-split: 9d597627b46d236c684ca5d62cae16cfed6e1dec
2022-10-13 20:45:00 -04:00
Jon Herron 7c219fd731 Squashed 'SpiffWorkflow/' content from commit 63db3e4
git-subtree-dir: SpiffWorkflow
git-subtree-split: 63db3e45947ec66b8d0efc2c74064004f8ff482c
2022-10-12 10:19:53 -04:00