status-im
/
samyoul-notes
mirror of https://github.com/status-im/samyoul-notes.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
samyoul-notes/README.md

15 KiB
Raw Blame History

2024-06-18

PRs

Schedule

Ad Hoc

  • I'm not feeling very well, this is really getting annoying

2024-06-17

Issues

Schedule

Ad Hoc

  • I've been struggling with some kind of flu, I feel really rotten. I've been doing as much as I can.

2024-06-14

Issues

Reading

Schedule

  • 15:30 - 16:30 : Samuel and Andrea
    • Discussion on the local pairing issues
    • Discussion of approaches to network failure fallback

Ad hoc

2024-06-13

Reviews

Schedule

Ad Hoc

  • Helping debug local pairing and syncing with Jarrad

2024-06-12

Pulls

  • status-go-websockets - created
    • Not actually a PR but a proof of concept repo, demonstrating native websocket support in Go over TLS.
      • Added websocket computeAcceptKey required in handshake
      • Added basic websocket handler
      • Added setting response headers
      • Added http hijacking, to allow for taking over http
      • Added main loop to websocket handler
      • wrote handleWriteWebSocketData to write to a websocket
      • copied over some code for handleReadWebSocketData
      • Added main function and debugged connection error
      • Added gitignore
      • Added README.md file

Schedule

  • 12:00 – 12:30 : ❄🔥 Snow Blowers (status-go flaky tests) Sync Call
    • https://meet.google.com/cvh-crfd-uji
    • Future Actions:
      • Agreement to extend the interval between sync meetings to every three weeks.
      • Plan to tackle parallelization and test optimization at the beginning of the next milestone in August.
      • Commitment to continue addressing flaky tests and optimizing the CI process to ensure stability and efficiency.
    • Meeting Outcomes:
      • Action items include enhancing test parallelisation, optimising test practices, and maintaining rigorous monitoring of test results.
      • Acknowledgment of the importance of balancing speed and thoroughness in testing to maintain code quality and stability.
    • Details

2024-06-11

Schedule

  • 10:00 – 11:00 : Samuel / Arwen
  • 12:00 – 12:45 : mobile-core planning
    • https://meet.google.com/azr-ppob-obc
    • Meeting notes
    • Action Points:
      • Ensure clear requirements and thorough testing for V1 to V2 migrations.
      • Address keycard functionalities and ensure funds are usable post-migration.
      • Update project board regularly and prioritize visible UI issue fixes.
      • Plan for assisting notifications and potentially enabling features post extensive QA.
      • Consider user feedback quality for upcoming release and prepare for app store readiness by version 2.30.

Ad Hoc

  • Research into extending existing TLS server functionality to support local WebSockets
    • Short story is we can, we just need to make a light(ish) weight wrapper / handler for handling the WS protocol.
    • I've got some basic code, but it doesn't work at the moment. I'll push a new repo tomorrow

2024-06-10

Issues

Pulls

Reviews

2024-06-07

Issues

Pulls

2024-06-06

Pulls

  • Removing torrent from mobile build #5257 - commits
    • Readied this PR for review, and requested reviews
    • Gave proper attribution and full context
    • Replaced entirely LogStdout with default logger
    • Replaced fmt.Sprintf usage from zap.logger calls
    • Explicitly cast ManagerSuite.torrentManager
      • Instead of using the TorrentContract interface I've set the field to expicitly declare as *TorrentManager. This removes all the random type casting used in the tests. I also removed all the usages of buildTorrentConfig() as we build the test suite with the torrent config now.
    • Renamed **ManagerMobile to **ManagerNop
    • Renamed Torrent to Archive
      • I've renamed TorrentManager to ArchiveManager, ArchiveManager to ArchiveFileManager, TorrentContract to ArchiveService, ArchiveContract to ArchiveFileService. I've also renamed all init functions and struct fields to the appropriate archive-centric naming.
    • Renamed archive files to archive_file
    • Renamed torrent files to archive
    • Fixed failing tests
    • Gave a defence of my approach and acknowledgment of its failings

Reviews

Schedule

2024-06-05

Pulls

Ad Hoc

  • Got gold star approved for EthCC

2024-06-04

Pulls

  • Removing torrent from mobile build #5257 - commits
    • Implemented build OS conditional build instructions
    • Added more complex build conditions to exclude OSes
    • 😱 Debugging why OS conditional builds are not working 😱

Reviews

  • fix missing value of keyuid for old mobile user #5203 approved, feedback
    • Related to this PR there seems to be some discrepancy between what Code Climate judges as having test coverage and what IntelliJ IDEA reports.
    • From the case of this PR it seems that Code Climate is less accurate and reports that some statements are not covered when they are.

Schedule

2024-06-03

Pulls

  • Removing torrent from mobile build #5257 - commits, scoping
    • Removed TorrentManager from handleImportedMessages
    • Removed TorrentManager from checkIfIMemberOfCommunity
    • Moved archive related funcs into ArchiveManager
      • To be honest once I started this work I quickly realised how pointless it is as archiving functionality and torrent seeding functionality are really entwined. So I'm keeping the code I've done, but it is a bit pointless without spending a lot of time untangling torrenting and archiving. I'm just going to make an interface for all the functions that are used publicly from TorrentManager. I think that this will be the fast way to move on from this issue. I don't like this work anymore, there is a lot of work to do elsewhere and torrent is a rabbit hole filled with canned worms.
    • Created TorrentContract and ArchiveContract interfaces
    • Created nil structs for Mobile use (or close to nil as possible)
    • Mapped all 2nd level TorrentManager usage

Schedule

  • 11:30 – 12:00 : Melanie <> Sam
  • 13:00 – 13:45 : bi-weekly status-go call
    • https://meet.google.com/gbq-tyqe-vju
    • Stand-ups
    • Belal was introduced to the group (Hey Belal)
    • Discussion of how to ensure compatibility between V1 and V2 key derivation and generation
    • Action points / Key Decisions
      • Activating Code Climate diff test coverage as REQUIRED
      • Agreement to activate audio transcription to ensure we have low effort, yet (reasonably) accurate notes for our calls