samyoul-notes/README.md

# 2024-06-18

# PRs

- [Added test suite for `validateInputData()` `#5323`](https://github.com/status-im/status-go/pull/5323) - `created`, `commits`
  - Added Error consts for all tested paths
  - Added test cases for Sticker and Swaps
  - [Discussed with Sale coordination over his work in #5362](https://github.com/status-im/status-go/pull/5323#issuecomment-2175790885)
    - [Router - calculating route/s which result multi-paths #5362](https://github.com/status-im/status-go/pull/5362)
    - [I gave a detailed suggestion for more idiomatic error constants](https://github.com/status-im/status-go/pull/5323#issuecomment-2176104843)
      - [Also see](https://github.com/status-im/status-go/pull/5323#issuecomment-2176131626)

## Schedule

- 12:00 – 12:30 : mobile-core planning
  - https://meet.google.com/azr-ppob-obc
  - [Meeting Summary](https://www.notion.so/Planning-Call-Notes-29050a4e2bcb4c4db48903e05b5fa7bc)
  - [Stand-ups](https://www.notion.so/Week-Beginning-a41d9258b6f04474a26a04031ff159ff)

## Ad Hoc

- I'm not feeling very well, this is really getting annoying

---

# 2024-06-17

# Issues

- [Can't launch Status app on intel MacOS `#15134`](https://github.com/status-im/status-desktop/issues/15134) - `feedback`
  - After initially get the app working with Sid's binary the application continues to crash on load. 
- [add MacOS specific flags for go shared lib `#15194`](https://github.com/status-im/status-desktop/pull/15194#issuecomment-2173000727)
  - Sid pointed out that Diana has reported a similar thing.
- [Router transfer multitx `#5362`](https://github.com/status-im/status-go/pull/5362) - `read`

# Schedule

- 13:00 – 13:45 : bi-weekly status-go call
  - https://meet.google.com/gbq-tyqe-vju
  - https://www.notion.so/status-go-Meeting-Notes-d634faa90e604e0db3e532d21595e867
    - Browser Plugin Connector Backend
    - Pairing and Network Issues

## Ad Hoc

- I've been struggling with some kind of flu, I feel really rotten. I've been doing as much as I can.

---

# 2024-06-14

# Issues

- [Can't launch Status app on intel MacOS `#15134`](https://github.com/status-im/status-desktop/issues/15134) - `read`, `feedback`
  - I struggled for a while trying to figure out what was causing my problems with Desktop
  - Apparently this is a new problem.
  - Good luck Desktopers

# Reading

- https://status.app/blog/new-dawn-for-status-and-snt-embracing-decentralisation#introducing-the-xp-programme `read`

# Schedule

- 15:30 - 16:30 : Samuel and Andrea
  - Discussion on the local pairing issues 
  - Discussion of approaches to network failure fallback

# Ad hoc

- Reviewed and logged issues reported by Jarrad on local pairing
  - https://www.notion.so/Jarrad-s-local-pairing-and-sync-issues-1e4eebf38e714d51814bae94f5c3d4a5
    - [Local connection with wifi in airplane mode](https://www.notion.so/Jarrad-s-local-pairing-and-sync-issues-1e4eebf38e714d51814bae94f5c3d4a5?pvs=4#95354c8183214871b017f66258217b4a)
    - [Sign in with QR code, with 2 different accounts.](https://www.notion.so/Jarrad-s-local-pairing-and-sync-issues-1e4eebf38e714d51814bae94f5c3d4a5?pvs=4#86aa98d9f5514ea089cdfcda69378e80)
    - [Sign in after account has been deleted. - Invalid Ciphertext Length](https://www.notion.so/Jarrad-s-local-pairing-and-sync-issues-1e4eebf38e714d51814bae94f5c3d4a5#c61202f8686249c4948b3d6f322db1db)
    - [Recordings from Jarrad](https://www.notion.so/Jarrad-s-local-pairing-and-sync-issues-1e4eebf38e714d51814bae94f5c3d4a5#49f0621ce470474e80e65b0231665d96)
      - [✅ Recorded Scenario 1: New account transfer from Desktop to Mobile](https://www.notion.so/Jarrad-s-local-pairing-and-sync-issues-1e4eebf38e714d51814bae94f5c3d4a5?pvs=4#404b3994595b425c88ef4e2cce9818de)
      - [❌ Recorded Scenario 2: New account transfer from Mobile to Desktop](https://www.notion.so/Jarrad-s-local-pairing-and-sync-issues-1e4eebf38e714d51814bae94f5c3d4a5#5ed2011447384c21a88fd84dd3d73c3e)

---

# 2024-06-13

## Reviews

- [Move images from community data to `MediaServer` `#5336`](https://github.com/status-im/status-go/pull/5336) - `approved`

## Schedule

- [x] 11:00 - 11:30 : Andrea and Samuel 1:1
  - https://meet.google.com/rhy-trwc-ybb
- [x] 15:00 – 16:00 : mobile-core retro
  - https://meet.google.com/hci-mahx-rfr
  - Details to follow on the notes

## Ad Hoc

- Helping debug local pairing and syncing with Jarrad

---

# 2024-06-12

## Pulls

- [status-go-websockets](https://github.com/status-im/status-go-websockets) - `created`
  - Not actually a PR but a proof of concept repo, demonstrating native websocket support in Go over TLS.
    - Added websocket computeAcceptKey required in handshake
    - Added basic websocket handler
    - Added setting response headers
    - Added http hijacking, to allow for taking over http
    - Added main loop to websocket handler
    - wrote handleWriteWebSocketData to write to a websocket
    - copied over some code for handleReadWebSocketData
    - Added main function and debugged connection error
    - Added gitignore
    - Added README.md file

## Schedule

- [x] 12:00 – 12:30 : ❄🔥 Snow Blowers (status-go flaky tests) Sync Call
  - https://meet.google.com/cvh-crfd-uji
  - Future Actions:
    - Agreement to extend the interval between sync meetings to every three weeks.
    - Plan to tackle parallelization and test optimization at the beginning of the next milestone in August.
    - Commitment to continue addressing flaky tests and optimizing the CI process to ensure stability and efficiency.
  - Meeting Outcomes:
    - Action items include enhancing test parallelisation, optimising test practices, and maintaining rigorous monitoring of test results.
    - Acknowledgment of the importance of balancing speed and thoroughness in testing to maintain code quality and stability.
  - Details
    - https://www.notion.so/Sync-Call-dfbfc0923aab49ebb6c901b1a0852b95

---

# 2024-06-11

## Schedule

- 10:00 – 11:00 : Samuel / Arwen
  - https://meet.google.com/rzt-mota-sez
- 12:00 – 12:45 : mobile-core planning
  - https://meet.google.com/azr-ppob-obc
  - [Meeting notes](https://www.notion.so/Planning-Call-Notes-ca3508af11414f9aa71a31d4496de2cd)
  - Action Points:
    - Ensure clear requirements and thorough testing for V1 to V2 migrations.
    - Address keycard functionalities and ensure funds are usable post-migration.
    - Update project board regularly and prioritize visible UI issue fixes.
    - Plan for assisting notifications and potentially enabling features post extensive QA.
    - Consider user feedback quality for upcoming release and prepare for app store readiness by version 2.30.

## Ad Hoc

- Research into extending existing TLS server functionality to support local WebSockets
  - Short story is we can, we just need to make a light(ish) weight wrapper / handler for handling the WS protocol.
  - I've got some basic code, but it doesn't work at the moment. I'll push a new repo tomorrow

---

# 2024-06-10

## Issues

- [Check Validity of `fromLockedAmount` in `SuggestedRoutesV2` `#5227`](https://github.com/status-im/status-go/issues/5227) - `addressed`
  - Resolved with `#5323`

## Pulls

- [Added test suite for `validateInputData()` `#5323`](https://github.com/status-im/status-go/pull/5323) - `created`, `commits`
  - Added validation to prevent all excluded networks
  - Added full test cases for validateInputData
    - For full details of the test cases please view the PR description https://github.com/status-im/status-go/pull/5323
- [Reported regression, suspect `#5310` is the cause, investigatory PR - `5324`](https://github.com/status-im/status-go/pull/5324) - `created`, `closed`
- [Mobile build counterpart of reverting `#5310` - `#20419`](https://github.com/status-im/status-mobile/pull/20419) - `created`, `closed`
  - This PR confirmed that `#5310` was the source of the wallet regression.
  - Sale took charge of the fix and resolved this issue in his PR #5325

## Reviews

- [chore_: use the old name for backward compatibility #5325](https://github.com/status-im/status-go/pull/5325) - `approved`
  - This PR fixed the wallet related regression reported by Tetiana
  - See this comment for detail https://github.com/status-im/status-go/pull/5325#pullrequestreview-2108807269
  - Also see: https://github.com/status-im/status-go/pull/5310

---

# 2024-06-07

## Issues

- [Remove torrent dependencies at build time for mobile `#5146`](https://github.com/status-im/status-go/issues/5146) - `closed`
- [Refactor `Messenger` to Delegate Archive Management to `communities.Manager` `#5313`](https://github.com/status-im/status-go/issues/5313) - `created`
- [Check Validity of `fromLockedAmount` in `SuggestedRoutesV2` `#5227`](https://github.com/status-im/status-go/issues/5227) - `scoping`
- [Refactor, Split and Clean Up Exported Functions in `ArchiveManager` `#5316`](https://github.com/status-im/status-go/issues/5316) - `created`

## Pulls

- [Test PR to check that removing torrent code from status-go will give us a smaller APK #20393](https://github.com/status-im/status-mobile/pull/20393) - `created`, `discussed`, `closed`
  - A PR to prove that my work on [Removing torrent from mobile build #5257](https://github.com/status-im/status-go/pull/5257) actually does what we expect it to do.
  - IT DOES!!! https://github.com/status-im/status-mobile/pull/20393#issuecomment-2154562874
    - 🎉 Android APK **93.7mb** 🎉
    - 🎉 iOS IPA **55.7mb** 🎉
- [Removing torrent from mobile build #5257](https://github.com/status-im/status-go/pull/5257) - `commits`, `merged`
  - Refactored NewArchiveManager to use config pattern
  - MERGED!

---

# 2024-06-06

## Pulls

- [Removing torrent from mobile build #5257](https://github.com/status-im/status-go/pull/5257) - `commits`
  - Readied this PR for review, and requested reviews
  - Gave proper attribution and full context
  - Replaced entirely `LogStdout` with default `logger`
  - Replaced `fmt.Sprintf` usage from `zap.logger` calls
  - Explicitly cast `ManagerSuite.torrentManager`
    - Instead of using the `TorrentContract` interface I've set the field to expicitly declare as `*TorrentManager`. This removes all the random type casting used in the tests. I also removed all the usages of `buildTorrentConfig()` as we build the test suite with the torrent config now.
  - Renamed **ManagerMobile to **ManagerNop
  - Renamed Torrent to Archive
    - I've renamed `TorrentManager` to `ArchiveManager`, `ArchiveManager` to `ArchiveFileManager`, `TorrentContract` to `ArchiveService`, `ArchiveContract` to `ArchiveFileService`. I've also renamed all init functions and struct fields to the appropriate archive-centric naming.
  - Renamed archive files to archive_file
  - Renamed torrent files to archive
  - Fixed failing tests
  - Gave a defence of my approach and acknowledgment of its failings
    - https://github.com/status-im/status-go/pull/5257#issuecomment-2152326864

## Reviews

- [Add timeout to call rpc endpoint #5285](https://github.com/status-im/status-go/pull/5285) - `approved`
- [decreased limits for concurrent requests and rps](https://github.com/status-im/status-go/pull/5253) - `approved`, `feedback`
- [status-go integration tests](https://github.com/status-im/status-go/pull/5302) - `approved`

## Schedule
- [x] 11:00 - 12:00 : Andrea and Samuel 1:1
  - https://meet.google.com/rhy-trwc-ybb
  - <details>
    <summary style="color:red;">*Knock knock*</summary>
      <img src="./attachments/2024-05/200w.gif" title="Dennis Nedry - Jurassic Park" alt="&quot;Ah ah aaaah. You didn't say the magic word.&quot;"/>
    </details>

---

# 2024-06-05

## Pulls

- [Removing torrent from mobile build #5257](https://github.com/status-im/status-go/pull/5257) - `commits`
  - Added pre 1.17 build commands
  - [Had a number of frustrating build fails](https://github.com/status-im/status-go/issues/5146#issuecomment-2149259488)
  - Copy and pasted Andrea's work
    - https://github.com/status-im/status-go/pull/5295
    - FFS Andrea spent 10 minutes looking at this and fixed what I'd spent 2 hours rage quitting about.
  - Fixed torrent tests
    - This was annoying
  - Resolved rebase conflicts :)

## Ad Hoc

- Got gold star approved for EthCC

---

# 2024-06-04

## Pulls

- [Removing torrent from mobile build #5257](https://github.com/status-im/status-go/pull/5257) - `commits`
  - Implemented build OS conditional build instructions
  - Added more complex build conditions to exclude OSes
  - 😱 Debugging why OS conditional builds are not working 😱

## Reviews

- [fix missing value of keyuid for old mobile user #5203](https://github.com/status-im/status-go/pull/5203) `approved`, `feedback`
  - Related to this PR there seems to be some discrepancy between what Code Climate judges as having test coverage and what IntelliJ IDEA reports.
  - From the case of this PR it seems that Code Climate is less accurate and reports that some statements are not covered when they are.

## Schedule

- [x] 12:00 – 13:00 : mobile-core planning
  - https://meet.google.com/azr-ppob-obc
  - 🎉 Announcement - Ícaro's 100% guaranteed promotion to `🤘 mobilecore 🤘` lead 🎉
  - Discussion and review of ongoing release V2.29 cycle
    - Discussed Waku issues that are causing major blockers
  - Stand-ups
    - https://www.notion.so/Week-Beginning-af2a460c8d0d43f290fe9730241b2323
  - Planning session

---

# 2024-06-03

## Pulls

- [Removing torrent from mobile build #5257](https://github.com/status-im/status-go/pull/5257) - `commits`, `scoping`
  - Removed TorrentManager from `handleImportedMessages`
  - Removed TorrentManager from `checkIfIMemberOfCommunity`
  - Moved archive related funcs into `ArchiveManager`
    - To be honest once I started this work I quickly realised how pointless it is as archiving functionality and torrent seeding functionality are really entwined. So I'm keeping the code I've done, but it is a bit pointless without spending a lot of time untangling torrenting and archiving. I'm just going to make an interface for all the functions that are used publicly from `TorrentManager`. I think that this will be the fast way to move on from this issue. I don't like this work anymore, there is a lot of work to do elsewhere and torrent is a rabbit hole filled with canned worms.
  - Created `TorrentContract` and `ArchiveContract` interfaces
  - Created nil structs for Mobile use (or close to nil as possible)
  - Mapped all 2nd level `TorrentManager` usage
    - https://github.com/status-im/status-go/pull/5257#issuecomment-2143956872
    - Follow on from [`TorrentManager` API Usage](https://github.com/status-im/status-go/pull/5257#issuecomment-2142881649)

## Schedule

- [x] 11:30 – 12:00 : Melanie <> Sam
  - https://meet.google.com/xmr-vjog-zj
  - Discussion of EthCC
  - And to be honest just a very delightful catchup ❤️
- [x] 13:00 – 13:45 : bi-weekly status-go call
  - https://meet.google.com/gbq-tyqe-vju
  - Stand-ups
  - Belal was introduced to the group (Hey Belal)
  - Discussion of how to ensure compatibility between V1 and V2 key derivation and generation
  - Action points / Key Decisions
    - Activating Code Climate diff test coverage as REQUIRED
    - Agreement to activate audio transcription to ensure we have low effort, yet (reasonably) accurate notes for our calls