d8a69b87dc
Improve change calculation performance for nontrivial object graphs
...
Skip doing any checking at all if none of the tables reachable from the root
table have been modified (which can happen if the table version was bumped due
to insertions, unrelated backlinks, or unlinked-to rows being deleted in linked
tables).
Add cycle checking rather than relying on the max depth to handle it, as the
worst case was O(N^16) if the cycle involved a LinkList of size N.
Track which rows have been confirmed to have not been modified.
Cache the information about the links for each of the relevant tables as
checking the table schema can get somewhat expensive.
2016-05-11 16:08:30 -07:00
f9364b50a4
Return the correct iterator from ChunkedVector::erase()
...
When a chunk is removed entirely it should return an iterator to the first
element in the next chunk, not the last.
2016-05-11 16:08:30 -07:00
4df552ba2d
Clean up old move info even when the row being deleted is the last one
2016-05-11 16:08:30 -07:00
3218740fd9
Fix the check for a deleted LV in ListNotifier::add_required_change_info()
2016-05-11 16:08:30 -07:00
632d757014
Always deliver results to the correct SharedGroup
...
If there are multiple Realm instances for a single file on a single thread due
to disabling caching we need to actually deliver the results to the appropriate
SharedGroup for each notifier rather than delivering them all to the first one.
2016-05-11 16:08:30 -07:00
8879212111
Fix assertion failure when a notifier is removed before it runs
2016-05-11 16:08:30 -07:00
eee6e55eb0
Refactor SortedMoveCalculator and add more of an explanation
2016-05-11 16:08:30 -07:00
95900f5e17
Make more member functions in CollectionNotifier pure virtual
2016-05-11 16:08:30 -07:00
9883944df4
Pull CollectionChangeBuilder into its own file
2016-05-11 16:08:30 -07:00
66666a75b0
Iterate backwards to pick the last valid list in select_link_list
2016-05-11 16:08:30 -07:00
23c16f8e67
Use aggregate initialization for the base class in CollectionChangeBuilder
2016-05-11 16:08:30 -07:00
c0350b9001
Rename CollectionChangeIndices to CollectionChangeSet
2016-05-11 16:08:30 -07:00
953e1b15a8
Rename BackgroundCollection to CollectionNotifier
2016-05-11 16:08:30 -07:00
fe5564f40e
Change all of the mentions of 'query' in NotificationToken to 'notifier'
2016-05-11 16:08:30 -07:00
31c3982bff
Fix some typos
2016-05-11 16:08:30 -07:00
e75ff49421
Fix check for the target results being invalid in ResultsNotifier::deliver()
...
m_target_results is no longer actually set to null when the notifier is
unregistered, so check the thing which is (i.e. m_realm).
2016-05-11 16:08:30 -07:00
238e9e3b6b
Fix tracking of which tables need change info with multiple source notifier versions
2016-05-11 16:08:30 -07:00
ea3a2f4711
Refactor the incremental change tracking for mixed source versions
2016-05-11 16:08:30 -07:00
69cefd052e
Deliver the new TableView even if it did not change
...
Even if the new TV has the same rows as the old one, we need to hand it over to
the destination thread to bump the outside version of the destination thread's
TV to avoid rerunning the query there.
2016-05-11 16:08:30 -07:00
83b4d8ded2
Make RealmCoordinator::run_async_notifiers a bit less gross
2016-05-11 16:08:30 -07:00
32b05314f5
Remove extraneous semicolons
2016-05-11 16:08:30 -07:00
2ce0e2e37f
Remove transaction log handlers for old pk functions
2016-05-11 16:08:30 -07:00
c12d87427a
Clean up includes and forward declarations a bit
2016-05-11 16:08:30 -07:00
155d949793
Only track inserts and deletes for tables being queried directly
...
# Conflicts:
# src/collection_notifications.cpp
# src/collection_notifications.hpp
2016-05-11 16:08:30 -07:00
a86265f4dc
Move CollectionChangeBuilder to background_collection.hpp
2016-05-11 16:08:30 -07:00
bc78c02e9d
Fix quadratic runtime of move_last_over() parsing
2016-05-11 16:08:30 -07:00
2e80716629
Improve performance of move mapping when there are a lot of deletions
2016-05-11 16:08:30 -07:00
ae9516dbb7
Improve performance for large numbers of deletions
2016-05-11 16:08:30 -07:00
8623aa6c6b
Actually unregister List notifiers when the List is destroyed
2016-05-11 16:08:30 -07:00
45705b18d2
Build all of the fuzzer variants
2016-05-11 16:08:30 -07:00
510c049855
Don't run the LV commands at all if fuzzing non-linkview
2016-05-11 16:08:30 -07:00
5eb18ed487
Allow non-empty no-op changesets when there should be no notification in the fuzzer
2016-05-11 16:08:30 -07:00
7a75e2bae2
Use a better data structure for IndexSet
...
Switch to a chunked vector-of-vectors which makes mid-insertions on large sets
much faster, and cache the begin/end/count for each chunk to make lookups much
more cache-friendly.
2016-05-11 16:08:30 -07:00
f600487769
Speed up CollectionChangeBuilder::move_over()
2016-05-11 16:08:30 -07:00
f051337cd3
Rename erase_and_unshift() to erase_or_unshift()
2016-05-11 16:08:30 -07:00
b81c950056
Put the fuzzer realm file in the working directory
...
mkstemp() eventually becomes a bottleneck due to thousands of stale
files from crashes.
2016-05-11 16:08:30 -07:00
dd336120b2
Fix compilation with GCC 4.9
2016-05-11 16:08:30 -07:00
784c34e052
Add property.hpp to HEADERS
2016-05-11 16:08:30 -07:00
bab5540cf6
Fix incorrect results when the second-to-last row is deleted
2016-05-11 16:08:30 -07:00
20d9da973b
Make List and Results notifications more consistent
...
Deliver the initial results for both of them and include the changeset
in the initial delivery for both, rather than having them behave weirdly
differently.
2016-05-11 16:08:30 -07:00
7a74a22558
Fix tracking of modifications after linkview moves
2016-05-11 16:08:30 -07:00
a0b16305c9
Fix dangling pointers to a reallocated vector when there are multiple source versions for handover
2016-05-11 16:08:30 -07:00
ef632804ef
Clean up stale moves for linkviews even without a merge
2016-05-11 16:08:30 -07:00
feed7c3479
Update moves when there is another move to exactly the previous move target
2016-05-11 16:08:30 -07:00
0a3158ce74
Fix marking deletions when chaining move_last_over()
2016-05-11 16:08:30 -07:00
51edc6909c
Log more in the fuzzer
2016-05-11 16:08:30 -07:00
1289c4806c
Fix handling of move_last_over() on the second-to-last row
2016-05-11 16:08:30 -07:00
47cee90d32
Refactor the fuzzer a bit
2016-05-11 16:08:30 -07:00
edc0d1fc4a
Improve and expand the changeset calculation tests
2016-05-11 16:08:30 -07:00
0e11a791e9
Improve and expand the IndexSet tests
...
This gets index_set.cpp back up to 100% line coverage from just the
targeted unit tests.
2016-05-11 16:08:30 -07:00
Thomas Goyne
Thomas Goyne