react-native/React
Tsolis Dimitris Sotiris 1d674f0309 Fix crash when loading local bundle and hot reload is enabled
Summary:
<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html

Happy contributing!

-->

When initializing react native module using a url pointing to local jsbundle and hot reload is enabled, bridge, is trying to initialize the feature but crashes because there is no host in a local file url.

1. Create a new project.

```sh
$ react-native init testPlanApp && cd testPlanApp
```

2. Create jsbundle.

```sh
$ react-native bundle --platform ios --dev false --entry-file index.js --bundle-output ios/main.jsbundle
```

3. Run the app and enable hot reload.
4. Enable airplane mode.
5. Close application and re-run.
6. See app crashes.

<!--
Help reviewers and the release process by writing your own release notes

**INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

  CATEGORY
[----------]        TYPE
[ CLI      ]   [-------------]      LOCATION
[ DOCS     ]   [ BREAKING    ]   [-------------]
[ GENERAl  ]   [ BUGFIX      ]   [-{Component}-]
[ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
[ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
[ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
[----------]   [-------------]   [-------------]   |-----------|

[CATEGORY] [TYPE] [LOCATION] - MESSAGE

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->

[IOS] [BUGFIX] [Hot reloading] - Fix crash when loading local bundle and hot reload is enabled.
Closes https://github.com/facebook/react-native/pull/16504

Differential Revision: D6133767

Pulled By: shergin

fbshipit-source-id: 3f7668e3e8fa7e772f58420e5a8a0985a5f8e48b
2017-10-24 00:06:31 -07:00
..
Base Fix potential retain cycles in Animated iOS 2017-10-23 13:20:59 -07:00
CxxBridge Fix crash when loading local bundle and hot reload is enabled 2017-10-24 00:06:31 -07:00
CxxModule Remove usage of "this" in a callback in RCTNativeModule 2017-10-04 06:00:09 -07:00
CxxUtils More efficient dynamic->NSString conversion. 2017-07-26 18:31:12 -07:00
DevSupport Unify sampling profiler and reload logic by leveraging RCTPackagerConnection 2017-10-04 19:17:06 -07:00
Executors Add more information to `__fbBatchedBridge is undefined` error 2017-07-26 11:21:59 -07:00
Inspector Remove 'Debug JS on-device (experimental)' feature 2017-08-29 04:29:57 -07:00
Modules Implement gating support for direction-aware API changes 2017-10-18 19:33:31 -07:00
Profiler Bunch of utility funcs were moved to RCTUIManagerUtils 2017-09-26 14:08:28 -07:00
React.xcodeproj SafeAreaView was added to OSS RNTester project file 2017-10-03 11:30:56 -07:00
ReactLegacy.xcodeproj Bunch of utility funcs were moved to RCTUIManagerUtils 2017-09-26 14:08:28 -07:00
Views (iOS) Support for ExtraBold alias of Heavy (font-weight 800) 2017-10-23 11:24:18 -07:00
third-party.xcconfig More attempts to fix Travis CI runs 2017-05-10 04:32:54 -07:00