status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

(iOS) Support for ExtraBold alias of Heavy (font-weight 800) 

Summary:
ExtraBold is a fairly common suffix in font naming. A good example is "Circe-ExtraBold". It's usually synonymous with Heavy or Black at font weight 800, as described here: https://www.webtype.com/info/articles/fonts-weights/

This fixes a regression with ExtraBold fonts introduced in d3007b0 where simply having an extrabold font will cause `weightOfFont` to choose this weight aggressively, resulting in all bold text erroneously interpreted as extrabold/heavy. This fix ensures that extrabold is detected before bold, and correctly attributed to `UIFontWeightHeavy`.
Closes https://github.com/facebook/react-native/pull/16323

Differential Revision: D6119059

Pulled By: shergin

fbshipit-source-id: 56a5c30584f220974308a7d6068c8d952aa20fb8
This commit is contained in:
Sam Mueller 2017-10-23 11:18:31 -07:00 committed by Facebook Github Bot
parent 95073f8589
commit d38b95f8b7
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
React/Views/RCTFont.mm
View File

@ -51,6 +51,7 @@ static RCTFontWeight weightOfFont(UIFont *font)
@"medium",
@"semibold",
@"demibold",
@"extrabold",
@"bold",
@"heavy",
@"black"
@ -64,6 +65,7 @@ static RCTFontWeight weightOfFont(UIFont *font)
@(UIFontWeightMedium),
@(UIFontWeightSemibold),
@(UIFontWeightSemibold),
@(UIFontWeightHeavy),
@(UIFontWeightBold),
@(UIFontWeightHeavy),
@(UIFontWeightBlack)