Fix crash when loading local bundle and hot reload is enabled
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> When initializing react native module using a url pointing to local jsbundle and hot reload is enabled, bridge, is trying to initialize the feature but crashes because there is no host in a local file url. 1. Create a new project. ```sh $ react-native init testPlanApp && cd testPlanApp ``` 2. Create jsbundle. ```sh $ react-native bundle --platform ios --dev false --entry-file index.js --bundle-output ios/main.jsbundle ``` 3. Run the app and enable hot reload. 4. Enable airplane mode. 5. Close application and re-run. 6. See app crashes. <!-- Help reviewers and the release process by writing your own release notes **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAl ] [ BUGFIX ] [-{Component}-] [ INTERNAL ] [ ENHANCEMENT ] [ {File} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| [CATEGORY] [TYPE] [LOCATION] - MESSAGE EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> [IOS] [BUGFIX] [Hot reloading] - Fix crash when loading local bundle and hot reload is enabled. Closes https://github.com/facebook/react-native/pull/16504 Differential Revision: D6133767 Pulled By: shergin fbshipit-source-id: 3f7668e3e8fa7e772f58420e5a8a0985a5f8e48b
This commit is contained in:
parent
ce967c6fbe
commit
1d674f0309
|
@ -810,7 +810,7 @@ struct RCTInstanceCallback : public InstanceCallback {
|
|||
}
|
||||
|
||||
#if RCT_DEV
|
||||
if (self.devSettings.isHotLoadingEnabled) {
|
||||
if (self.devSettings.isHotLoadingAvailable && self.devSettings.isHotLoadingEnabled) {
|
||||
NSString *path = [self.bundleURL.path substringFromIndex:1]; // strip initial slash
|
||||
NSString *host = self.bundleURL.host;
|
||||
NSNumber *port = self.bundleURL.port;
|
||||
|
|
Loading…
Reference in New Issue