status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-23 14:48:25 +00:00
Code Issues Projects Releases Wiki Activity
14,810 Commits 61 Branches 315 Tags 184 MiB
Commit Graph

294 Commits

Author SHA1 Message Date
Pritesh Nandgaonkar
fda861a889 Replaced first pass with a function 
Reviewed By: emilsjolander

Differential Revision: D6819719

fbshipit-source-id: e5e77c21d1dca2255433da3388887d9db3f7b642
 2018-02-05 07:04:53 -08:00
Pritesh Nandgaonkar
34b7ec82b5 Moved out logic to calculate size consumed on a line into seperate function 
Reviewed By: emilsjolander

Differential Revision: D6797640

fbshipit-source-id: ad9757e7d603c0ce57f452b1e5c404037605bed9
 2018-02-05 07:04:53 -08:00
Pritesh Nandgaonkar
9f7cedbe14 Remove the use of legacy flag and log the diff if its used 
Reviewed By: emilsjolander

Differential Revision: D6856812

fbshipit-source-id: e4724d80702cc75c1894e348e137b24e663573d2
 2018-02-02 07:40:25 -08:00
Mark Wang
9f57dedc17 Use delete instead of free 
Reviewed By: richardjrossiii

Differential Revision: D6866064

fbshipit-source-id: a44828cedb5045b6c97179fb30ffd8c8dafcbfbe
 2018-01-31 18:01:34 -08:00
Pritesh Nandgaonkar
be8e7c6e65 Made logging logic dynamic to log string length 
Reviewed By: emilsjolander

Differential Revision: D6784491

fbshipit-source-id: 26e4520a84be355ff992b808297ce7a95b3d09e3
 2018-01-23 06:46:08 -08:00
Jonathan Kim
4f2cc42a2d Make xplat react native files buildable 
Reviewed By: mzlee

Differential Revision: D6605611

fbshipit-source-id: baa33947319a27b95020924d177a9398a276dabe
 2018-01-21 22:05:05 -08:00
Pritesh Nandgaonkar
d0f7d4d107 Use vector instead of linked list 
Reviewed By: emilsjolander

Differential Revision: D6722959

fbshipit-source-id: 4e81176802b9a9319bc5f385c824a06be14a83a2
 2018-01-16 09:36:09 -08:00
Pritesh Nandgaonkar
ee5c91c031 Fix for failing screenshot tests 
Reviewed By: emilsjolander

Differential Revision: D6726745

fbshipit-source-id: 99f91aabe2337b23953724545f97695238f2124e
 2018-01-16 09:16:01 -08:00
Valentin Shergin
6bb8617f3a Exposing setDirtiedFunc as plain C function YGNodeSetDirtiedFunc 
Summary: Trivial. Those lines were lost during rebasing of the original commit.

Reviewed By: priteshrnandgaonkar

Differential Revision: D6717696

fbshipit-source-id: a5dce25427c8977352b3ae7ea01e546a540e0c13
 2018-01-15 16:06:11 -08:00
Pritesh Nandgaonkar
831a1bb4b1 Moved leadingpaddingnandborder function as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6711991

fbshipit-source-id: 41ad7191bf8df6fe3131106436dc0c87e9dee297
 2018-01-15 10:17:29 -08:00
Pritesh Nandgaonkar
2fe65b032e Move trailing padding function as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6711897

fbshipit-source-id: fa2e1a8e31242358a6e94aef51368e2c2c58b79d
 2018-01-15 10:17:29 -08:00
Pritesh Nandgaonkar
bd7bf94af9 Moved leading padding function as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6711830

fbshipit-source-id: d2f6f55ec23b007bb51f8a91385e02236f46dc7b
 2018-01-15 10:17:29 -08:00
Pritesh Nandgaonkar
7f94bff89a Resolve direction function is now as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6711755

fbshipit-source-id: a0e80596e10f0c7fb7a31b75377da4db846c4bbb
 2018-01-15 10:17:29 -08:00
Pritesh Nandgaonkar
82088580ab Move trailing border function as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6711666

fbshipit-source-id: fe4fdfc2db59d03beb763317e1a6f9de52f851d4
 2018-01-15 10:17:29 -08:00
Pritesh Nandgaonkar
210ae5b95a Move leading border function as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6711523

fbshipit-source-id: 76e90083a9dd0728dc9557cc3b0a1f431f3afd5d
 2018-01-15 10:17:29 -08:00
Pritesh Nandgaonkar
2b27f1aa19 Moved YGNodeIsFlex as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6711536

fbshipit-source-id: e60be7da55e3e8d254eb253c141d219a37a76087
 2018-01-15 10:17:28 -08:00
Pritesh Nandgaonkar
fcf2c7cf61 Refactored step3 of flexbox algorithm 
Reviewed By: emilsjolander

Differential Revision: D6702749

fbshipit-source-id: 15dcc94ae30ac185e4d1c7d6e3744a40cfa47317
 2018-01-15 10:17:28 -08:00
Pritesh Nandgaonkar
ac1c8c265e Refactored the flexbox step to determine available space in main and cross dim 
Reviewed By: emilsjolander

Differential Revision: D6693777

fbshipit-source-id: d6c87670e74bdc22b32916c2d77fe423d831b378
 2018-01-15 06:05:24 -08:00
Semen Zhydenko
d2c569795c Typos in comments and log messages 
Summary:
No code changes, no testing required.

alligned -> aligned
allignment -> alignment
completly -> completely
conseptually -> conceptually
decendents -> descendants
indefinetly -> indefinitely
dimention -> dimension
doesnt -> doesn't
safegaurd -> safeguard
intialization -> initialization
hierachy -> hierarchy
happend -> happened
gaurd -> guard
programatically -> programmatically
initalized -> initialized
immidiately -> immediately
occured -> occurred
unkown -> unknown
neccessary -> necessary
neccesarily -> necessarily
occuring -> occurring
comoponent -> component
propogate -> propagate
recieved -> received
referece -> reference
perfomance -> performance
recieving -> receiving
subsquently -> subsequently
scoll -> scroll
suprisingly -> surprisingly
targetting -> targeting
tranform -> transform
symetrical -> symmetrical
wtih -> with
Closes https://github.com/facebook/react-native/pull/17578

Differential Revision: D6718791

Pulled By: shergin

fbshipit-source-id: 4ab79c1131ec5971d35a0c7199eba7ec0a0918ad
 2018-01-12 22:18:45 -08:00
Sergei Dryganets
c8e98bbaf5 CI for Android fixed 
Summary:
Fix for android github CI.

Github CI doesn't work without this change.

CI passes.

[INTERNAL] Android CI fix.
Closes https://github.com/facebook/react-native/pull/17551

Differential Revision: D6707477

Pulled By: hramos

fbshipit-source-id: f98515234da3b90ee3233523bcd7cc67ed82c1b4
 2018-01-12 08:01:00 -08:00
Pritesh Nandgaonkar
4b4959a21c Moved setPosition as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6683387

fbshipit-source-id: 83f64101faa700933771c69b222056ec2a6b8d1e
 2018-01-11 05:13:56 -08:00
Pritesh Nandgaonkar
89c14579d0 Moved trailingmargin function as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6683313

fbshipit-source-id: 5ee458c2f4698768724901df0e3f5d8805c7c8f5
 2018-01-11 05:13:51 -08:00
Pritesh Nandgaonkar
f0f4bee429 Moved getLeadingMargin as a function on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6683270

fbshipit-source-id: a26663006419e13cb783e9849183e3c665f59b3c
 2018-01-11 05:13:47 -08:00
Pritesh Nandgaonkar
b709ff4f13 Moved getTrailingPosition function as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6683205

fbshipit-source-id: d30003d90d634c644d92c833e58165b073d4d13e
 2018-01-11 05:13:45 -08:00
Pritesh Nandgaonkar
040197a485 Moved is isTrailingPos defined as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6683190

fbshipit-source-id: c37e57d02cc4475eb8181a2bb003c555bdb0aaea
 2018-01-11 05:13:43 -08:00
Pritesh Nandgaonkar
98a74b0a2b Moved isLeadingPos defined as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6682956

fbshipit-source-id: 31c60e0eae906e1434a6969f3cd786fcaf9097a5
 2018-01-11 05:13:39 -08:00
Pritesh Nandgaonkar
00f1a37b2c Moved YGNodeLeading position as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6682929

fbshipit-source-id: 3607aab1544b62b1126c5d75b2f6fb8f5ca2d45f
 2018-01-11 05:13:33 -08:00
Valentin Shergin
c2b0f34533 Introducing on-dirty handler (aka YGNodeSetDirtiedFunc) 
Summary:
Currently, we can dirty leaf nodes with `measure` function, we also can get `dirty` status for any node, but we cannot handle a moment when this change happen. This diff introduces a new call-back-manner handler for it.
We need this to plug Yoga inside and outside other layout systems without maintaining own dirty propagation infrastructure.
Consider using Yoga for flex-box layout in React Native where we can have deeply nested layout like `<View><Text><View><Text/></View></Text></View>` where all content of all <Text> nodes are laid out using native text/inline (not flex-box!) layout system. In this case, when some change dirties some deeply nested Yoga node, we have to propagate the dirty state down to outer one. Having this handler makes possible to wire up `on-dirty` handler on the root node and `setDirtied` for the leaf node.
Removing custom dirting mechanism from React Native should drastically simplify rendering layer and bring a huge performance win.

Reviewed By: emilsjolander

Differential Revision: D6597856

fbshipit-source-id: 6588cd712f9c1dede4af32f3d326f90103e48ff0
 2018-01-10 09:56:41 -08:00
Pritesh Nandgaonkar
b41d41fd40 Move utility functions to utils file 
Reviewed By: emilsjolander

Differential Revision: D6682933

fbshipit-source-id: 0fd90fdaf5ca4f9b7a11cbd15d8c54c7d0ce8a03
 2018-01-10 05:02:24 -08:00
Pritesh Nandgaonkar
a8d4666651 Fix warnings of casting and null pointer handling 
Reviewed By: emilsjolander

Differential Revision: D6675111

fbshipit-source-id: 884659fabb05033b4d43d3aa6629e22481d39b7e
 2018-01-09 04:30:56 -08:00
Pritesh Nandgaonkar
d85da86dc7 Move YGNodeResolveFlexShrink to a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6611418

fbshipit-source-id: 6e5ba39b555d313a967800589891027920112c15
 2018-01-08 03:01:30 -08:00
Pritesh Nandgaonkar
6627d7723c Moved YGResolveFlexGrow as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6611385

fbshipit-source-id: 71660946c469fac77c5ffa0284c793e6adc9db7b
 2018-01-08 03:01:30 -08:00
Pritesh Nandgaonkar
0a9e652bdd Move markDirtyInternal as a method in YGNode 
Reviewed By: emilsjolander

Differential Revision: D6611287

fbshipit-source-id: 54402145d51ea717553ea136be739b9880a79817
 2018-01-08 03:01:30 -08:00
Pritesh Nandgaonkar
28968e2c0b Move YGCloneChildrenIfNeeded as a method on YGNode 
Reviewed By: emilsjolander

Differential Revision: D6611155

fbshipit-source-id: 463723a363e0fbd2c7686f65226eca73236bd07e
 2018-01-08 03:01:30 -08:00
Dan Zimmerman
1fd7315c3b Remove unnecessary include 
Reviewed By: mzlee

Differential Revision: D6638538

fbshipit-source-id: 4b11b8f4f88aa533ac0467348df36e5780bfbb70
 2017-12-27 13:16:30 -08:00
Héctor Ramos
33da6047a3 Include OSS defs in Yoga BUCK 
Reviewed By: ttsugriy

Differential Revision: D6630280

fbshipit-source-id: 6355d4b64a39feb000d5a104f39733a90fc5a31e
 2017-12-22 14:31:21 -08:00
Pritesh Nandgaonkar
a163f70f87 Optimize the performance of Origami 
Reviewed By: emilsjolander

Differential Revision: D6619293

fbshipit-source-id: c1632efd97f47696b7f8bb1b3e763de92c707287
 2017-12-22 06:51:09 -08:00
Taras Tsugrii
ba31d29dc9 Replace native cxx_library with fb-specific macros. 
Reviewed By: adamjernst

Differential Revision: D6618153

fbshipit-source-id: 188e2ca3cc78efad6e71f0a22547e26abf2f62e1
 2017-12-21 08:58:50 -08:00
Pritesh Nandgaonkar
4cdbb77c33 Do not set FB_ASSERTION_ENABLED 
Reviewed By: emilsjolander

Differential Revision: D6611904

fbshipit-source-id: f01ac144159c1b333d8deb8cbb5ba0288e4bf7a4
 2017-12-21 04:45:34 -08:00
Pritesh Nandgaonkar
f1055bcac8 Make YGNode as c++ struct with properties exposed through accessors 
Reviewed By: emilsjolander

Differential Revision: D6592257

fbshipit-source-id: 641e8b9462ad00731a094511f9f5608b23a6bb21
 2017-12-19 11:32:49 -08:00
Pritesh Nandgaonkar
d89901fa60 Use wildcard instead of manual file addition 
Reviewed By: emilsjolander

Differential Revision: D6601704

fbshipit-source-id: 9bac4bc1a8d9e40feb0111fc4c7a627d4d3c4270
 2017-12-19 07:41:57 -08:00
Greg McGary
f8fe6b0c70 Explicitly #define isnan __builtin_isnan for Android clang-5 to mimic gcc's default behavior 
Reviewed By: passy

Differential Revision: D6527499

fbshipit-source-id: 65d9e43c7e7d973a6c92e9863ebe469b35a24ac8
 2017-12-12 17:02:08 -08:00
Ben Nham
e76abfa036 Revert D6155682: Use clang-5.0 -Oz 
Differential Revision: D6155682

fbshipit-source-id: 9139ed14e0d24784bf25b2783e364a511173ab83
 2017-12-08 09:54:37 -08:00
Greg McGary
f59140eb21 Use clang-5.0 -Oz 
Reviewed By: mzlee

Differential Revision: D6155682

fbshipit-source-id: 2f64e742f4dc44be171274c2ad0a41fb1e7079d7
 2017-12-07 13:32:23 -08:00
Yaroslav Pavlov
4034febb7e Round size geometry for Button and RichText components. 
Reviewed By: cuva

Differential Revision: D6466875

fbshipit-source-id: 62a480411e7d2354a6879917c42bbf0ee96cdadd
 2017-12-06 16:33:34 -08:00
Pritesh Nandgaonkar
b08a912f11 vector instead of YGNodeList 
Reviewed By: jonathandann, emilsjolander

Differential Revision: D6442379

fbshipit-source-id: d2d48ef0676351d2eeaa2d427dcd72e082cd15a1
 2017-12-05 08:30:15 -08:00
Lukas Wöhrl
4fdaf2de98 Fix min/max percentage constraints on measured nodes 
Summary:
Fix min/max percentage constraints on measured nodes. Currently we passed in the available size instead of the parent size.
Fixes #611
Closes https://github.com/facebook/yoga/pull/649

Reviewed By: priteshrnandgaonkar

Differential Revision: D6408019

Pulled By: emilsjolander

fbshipit-source-id: 18be5056dbc0dc179970ec231ab8b4e2cdba65c5
 2017-11-30 08:16:50 -08:00
Lukas Wöhrl
72e762d4bc Suppress unused warnings on YGDefaultLog 
Summary:
Suppresses the unused warnings on ```YGDefaultLog```. It uses a more generic macro which simply casts the variable to ```(void)```. This is the simples approach to make mutiple different compilers happy. Fixes #650
Closes https://github.com/facebook/yoga/pull/651

Differential Revision: D6407999

Pulled By: emilsjolander

fbshipit-source-id: 19fd78dd8b84eafdbb48875dd003d506a98c4807
 2017-11-28 10:36:16 -08:00
Lukas Wöhrl
5f99b1a55f Measure nodes which have margin: auto and align-item: stretch 
Summary:
If you have a measurable node and set ```marign-left: auto``` + ```align-item:stretch``` on it, it won't get measured and they get a width/height of ```-(nan)```. This change fixes that behaviour. Fixes #644.
Closes https://github.com/facebook/yoga/pull/645

Differential Revision: D6413512

Pulled By: emilsjolander

fbshipit-source-id: 755febeb33bb0d4520ca6b3c28d56ac333e4a14d
 2017-11-27 05:30:30 -08:00
Lukas Wöhrl
1050e0b476 Add justify-content: space-evenly 
Summary:
Adds new ```space-evenly``` for ```justify-content```.

Also adds a typofix in one of the other justify-content tests.

Fixes #657
Closes https://github.com/facebook/yoga/pull/658

Differential Revision: D6407996

Pulled By: emilsjolander

fbshipit-source-id: cc837409e1345624b4bd72c31e25fe68dcb0f6a3
 2017-11-27 04:01:02 -08:00