Commit Graph

200 Commits

Author SHA1 Message Date
James Ide 62766e6077 [Text] Account for font leading so descenders are not clipped
Summary:
Prior to this diff, descenders (the hanging tail on letters like g and j) were clipped on the last line because the text measurer did not account for the font leading. With `NSStringDrawingUsesFontLeading` it honors the fonts line spacing.

To test: open the Text demo of the UIExplorer and see that the bottom of the letter g is no longer clipped off.

## Before

![Screenshot Before](https://cloud.githubusercontent.com/assets/379606/6364746/1c5527a0-bc60-11e4-8aeb-2147a6eb6596.png)

## After

![Screenshot After](https://cloud.githubusercontent.com/assets/379606/6364747/1e9abe58-bc60-11e4-8c34-9f20ad8572ff.png)
Closes https://github.com/facebook/react-native/pull/96
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
2015-03-23 11:40:24 -08:00
Christopher Chedeau f67a36733f [ReactNative] Expanded license on js packager files 2015-03-23 11:28:51 -08:00
Basil Hosmer d6bb48d972 more UIExplorer flow 2015-03-23 11:21:08 -08:00
Amjad Masad a6b154332b [react-packager] Pick up package changes while running 2015-03-23 11:15:52 -08:00
Bryce Redd ac8cd5a5d0 Added a graph view and a ReactNative metric that displays current queue and execution time for the JS thread. 2015-03-23 10:52:19 -08:00
Alex Kotliarskyi e4990939e4 [ReactNative] Add NativeModules and DeviceEventEmitter to react-native exports 2015-03-23 09:23:51 -08:00
Alex Akers 48cc440bd3 [React Native] Fix iOS 7 crashes b/c missing Photos.fmwk 2015-03-23 08:06:58 -08:00
Basil Hosmer 45a7b5cdcb UIExplorer flowification 2015-03-23 00:24:47 -08:00
Marshall Roch 05409868b6 Add clearImmediate module 2015-03-22 23:28:04 -08:00
Alex Kotliarskyi 5023931272 [ReactNative] Print directories packager is serving files from 2015-03-22 22:37:55 -08:00
Marshall Roch 0a88663b1e Work around flow bug with exports 2015-03-22 22:12:18 -08:00
Alex Kotliarskyi b612741b21 [ReactNative] Move packager/init.sh to GitHub 2015-03-22 20:17:39 -08:00
Christopher Chedeau 87f42ab450 [ReactNative] Remove react-native/package.json 2015-03-22 20:17:01 -08:00
Henry Lung 6b0711b719 [ReactNative] Returning actual contentSize for RCTScrollViewManager 2015-03-22 13:31:32 -08:00
Basil Hosmer 10b6c57731 declare timeoutID 2015-03-20 17:51:06 -08:00
Tadeu Zagallo b881028494 [ReactNative] Add root package.json name back 2015-03-20 17:38:23 -08:00
Amjad Masad ce6354604c [react-packager] Allow entry point extensions like .ios.js 2015-03-20 17:24:51 -08:00
Felix Kling 81d024924c [react-native] Use SpreadProperty to make react-docgen happy 2015-03-20 17:04:12 -08:00
Basil Hosmer ca3be21484 clean Examples/2048 2015-03-20 16:33:03 -08:00
Alex Kotliarskyi 33b46c3ba9 [ReactNative] Adjust packager default root when running from within node_modules 2015-03-20 16:12:57 -08:00
Alex Kotliarskyi 0c5f9e3662 [ReactNative] Add missing websocket dependency 2015-03-20 15:29:56 -08:00
Amjad Masad f1746ac83e [react-packager] change all but one `ix` to `require` 2015-03-20 15:26:58 -08:00
Amjad Masad 258a81388e [react-packager] Make sure projectRoots is converted to an array 2015-03-20 14:09:31 -08:00
Alex Kotliarskyi 6d88898404 [ReactNative] Init script that bootstraps new Xcode project 2015-03-20 13:41:50 -08:00
Alex Kotliarskyi d56a57c956 [ReactNative] New SampleApp 2015-03-20 13:41:49 -08:00
Eric Vicenti c445cbdb1e [ReactNative] Touchable invoke press on longPress when longPress handler missing 2015-03-20 11:47:01 -08:00
Alex Kotliarskyi 21a1cd52b5 [ReactNative] Commit missing RCTWebSocketDebugger.xcodeproj 2015-03-20 11:16:41 -08:00
Christopher Chedeau ac804244a6 [ReactNative] Add Custom Components folder 2015-03-20 09:19:28 -08:00
Amjad Masad c68fc1a976 [react-packager] Hash cache file name information to avoid long names 2015-03-19 16:40:35 -08:00
Alex Kotliarskyi 3fd4ed1464 [ReactNative] Put all iOS-related files in a subfolder 2015-03-19 14:37:44 -08:00
Amjad Masad 115ad71831 [react-packager] Fix OOM 2015-03-19 11:50:27 -08:00
Alex Kotliarskyi 8dea55618d [ReactNative] Bring Chrome debugger to OSS. Part 2 2015-03-19 11:48:51 -08:00
Tadeu Zagallo da2b122e21 [ReactNative] Add search to UIExplorer 2015-03-19 11:03:28 -08:00
Alex Kotliarskyi 0de49ab0d5 [ReactNative][RFC] Bring Chrome debugger to OSS. Part 1 2015-03-19 09:32:52 -08:00
Tadeu Zagallo 1289536fe1 [ReactNative] Return the appropriate status code from XHR 2015-03-19 09:27:06 -08:00
Alex Kotliarskyi d6a031b431 [ReactNative] Make JS stack traces in Xcode prettier 2015-03-19 09:25:46 -08:00
Christopher Chedeau 737cae8f19 [ReactNative] Remove duplicate package.json with the same name 2015-03-19 09:04:39 -08:00
Christopher Chedeau 2cace1a5b3 [ReactNative] Remove invariant from require('react-native') 2015-03-18 18:58:12 -08:00
Christopher Chedeau 48f7399cfc [ReactNative] Remove ListViewDataSource from require('react-native') 2015-03-18 18:53:16 -08:00
Amjad Masad 319ea3242a [react-packager] Add assetRoots option 2015-03-18 18:26:35 -08:00
Christopher Chedeau 13e054a714 Convert UIExplorer to ListView
Summary:
Using <ListView> is not that much more work but gives us section headers for free :) Now there are two groups: Components and APIs. It mirrors the documentation.

Closes https://github.com/facebook/react-native/pull/163
Github Author: Christopher Chedeau <vjeux@fb.com>

Test Plan: ![ios simulator screen shot mar 17 2015 9 09 07 pm](https://cloud.githubusercontent.com/assets/197597/6702577/d40c00ae-ccea-11e4-8035-cfb46367ea1d.png)
2015-03-18 17:52:53 -08:00
Basil Hosmer f2d688debb purge rni 2015-03-18 17:17:08 -08:00
Christopher Chedeau 4b42f8c9e9 [ReactNative] s/render*View/render/ in <WebView> 2015-03-18 16:02:19 -08:00
Alex Kotliarskyi afb71ae1c3 [ReactNative] Fix async stacktrace in RedBox 2015-03-18 15:35:51 -08:00
Spencer Ahrens 198640b087 [ReactNative] Add AsyncStorageTest 2015-03-18 13:15:40 -08:00
Spencer Ahrens fbc3a16047 [ReactNative] Add timers integration test 2015-03-18 13:15:39 -08:00
Tadeu Zagallo 196bc85629 [ReactNative] Remove ExpandingText 2015-03-18 13:08:23 -08:00
James Ide f002fda275 [TouchableHighlight] Preserve underlay style when restoring inactive props
Summary:
If you give a TouchableHighlight component some styling (e.g. a background color) with the `underlayStyle` prop, the style is wiped away after touching the component. This diff restores the `underlayStyle`.

Closes https://github.com/facebook/react-native/pull/129
Github Author: James Ide <ide@jameside.com>

Test Plan:
 Create a TouchableHighlight that receives `underlayStyle={{style:
'blue'}}`. It initially has a blue background. Touch it and let go. See the blue background now comes back as expected.
2015-03-18 11:56:24 -08:00
Basil Hosmer c43d1458c7 clean flow errors in react-native-github 2015-03-18 11:44:13 -08:00
Christopher Chedeau 0f5a3c16e4 [ReactNative] Sort React Native exports into two groups, Components and ...
Summary:
...APIs

This maps the way the docs are structured, this is easier to figure out when the docs are stale
Closes https://github.com/facebook/react-native/pull/161
Github Author: Christopher Chedeau <vjeux@fb.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
2015-03-18 09:49:58 -08:00