cddf9cf114
Refactor
2020-05-05 21:42:00 +08:00
dab5a936c4
wip shard fork choice rule
2020-05-05 21:41:46 +08:00
ee4c866575
Merge branch 'dev' into dankrad-custody-256bit-merging
2020-05-05 15:22:36 +08:00
3f250f7dd3
PR feedback
2020-05-04 21:05:10 -06:00
a7354bd358
Merge branch 'dev' into rewards-rework
2020-05-04 13:34:35 -06:00
71dc744f42
Merge pull request #1703 from ethereum/hwwhww/signed_pattern
...
Rework shard block and fraud proof (shard state transition) spec
2020-05-04 10:39:47 -06:00
7a770186b5
Reorg beacon-chain spec a bit
2020-05-02 02:32:37 +08:00
4558c7db4e
Reorg the file structure
2020-05-02 02:32:37 +08:00
b43e24acb6
specs/phase1/fraud-proofs.md -> specs/phase1/shard-transition.md
2020-05-02 02:32:37 +08:00
ff85025113
PR feedback from terence
2020-05-02 02:32:37 +08:00
e758fb76c2
Check `head_shard_root` of all `transition_attestations`
2020-05-02 02:32:36 +08:00
524ba166d1
[squashed] shard chain updates wip
...
Fix wrong field names
Fix `build_attestation_data` and other PR feedback from Danny and
Terence
1. Rename `get_previous_slot` to `compute_previous_slot`
2. Break down `build_empty_block` into
`get_state_and_beacon_parent_root_at_slot`, use it in
`build_shard_block`
3. Set defult `slot` to `shard_state.slot + 1` in `build_shard_block`
Update `verify_shard_block_message`: check beacon_parent_root at fork
choice rule stage instead of state transition
Fix `beacon-chain.md`
1. Fix typo `attestation.slot == state.slot` -> `attestation.data.slot == state.slot` in `is_winning_attestation`
2. Check `verify_shard_transition_false_positives` **after** `process_operations`
3. Fix `shard_attestations` filter in `process_crosslinks`: since attestations come from block, should use `attestation.data.slot + MIN_ATTESTATION_INCLUSION_DELAY == state.slot`
4. [TBD] Allow empty `light_client_signature` to make the tests pass
5. [TBD] Add `is_shard_attestation`, filter out empty `ShardTransition()`
Rework `test_process_crosslink`
Add basic phase 1 `test_blocks`
Add more test cases
Revert `is_shard_attestation` and fix test cases backward compatibility.
Remove `test_process_beacon_block_no_shard_transition` and consider it as invalid case.
2020-05-02 02:32:31 +08:00
c8a473ba24
Apply suggestions from code review
...
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2020-05-02 02:32:30 +08:00
40483b587b
[squashed] shard chain updates wip
...
Use `ShardBlock` in `shard_state_transition`
PR feedback
1. Rename `ShardState.data` -> `ShardState.transition_digest`
2. Rename `compute_shard_transition_data` to `compute_shard_transition_digest`
3. Add `assert state.slot > PHASE_1_GENESIS_SLOT` just in case, may move it later
Add `get_post_shard_state` as a pure function wrapper
2020-05-02 02:32:24 +08:00
85d5a9abaf
[squashed] shard chain updates wip
...
PR feedback from Danny and some refactor
1. Add stub `PHASE_1_GENESIS_SLOT`
2. Rename `get_updated_gasprice` to `compute_updated_gasprice`
3. Rename `compute_shard_data_roots` to `compute_shard_body_roots`
Apply shard transition for the skipped slots
Refactor `shard_state_transition`
Get `beacon_parent_root` from offset slot
Add more test
Add `verify_shard_block_message`
Add `> 0`
Keep `beacon_parent_block` unchanged in `is_valid_fraud_proof`
Remove some lines
Fix type
Refactor + simplify skipped slot processing
2020-05-02 02:31:54 +08:00
9724cb832d
Apply suggestions from code review from @djrtwo
...
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2020-05-02 02:31:53 +08:00
afa12caf1f
Refactor `get_shard_state_transition_result`
2020-05-02 02:31:53 +08:00
4e8a7ff115
[squashed] shard transition wip
...
Fix the wrong `get_shard_proposer_index` parameters order
Phase 1 WIP
Add shard transition basic test
Fix lint error
Fix
2020-05-02 02:31:10 +08:00
849d3f83bf
Apply @terencechain 's review feedback
...
Co-Authored-By: terence tsao <terence@prysmaticlabs.com>
2020-05-02 02:31:09 +08:00
247a6c8fca
Add `verify_fraud_proof` function
2020-05-02 02:31:09 +08:00
be50020bf8
Refactor `get_light_client_committee` to similar to
...
`get_shard_committee`
2020-05-02 02:31:08 +08:00
5f69afea38
Make `shard_state_transition` more like beacon state_transition function
2020-05-02 02:31:08 +08:00
e9f1e4186d
Add `proposer_index` to shard block
2020-05-02 02:31:08 +08:00
feb27a14be
beacon-chain.md: Replace block wrapper with signable pattern
2020-05-02 02:31:08 +08:00
c2c27791c5
Merge branch 'dev' into rewards-rework
2020-05-01 10:52:19 -06:00
09cae4b3cc
Handle empty-aggregation-bits case, and add tests. See #1713
2020-05-01 15:17:41 +02:00
964bf42335
Fix type
2020-05-01 00:32:02 +01:00
d30f11a781
Fix lint
2020-05-01 00:16:00 +01:00
d58d7627b7
Fix toc
2020-04-30 19:25:18 +01:00
4b4fc32f9c
Merge pull request #1755 from paulhauner/patch-23
...
Fork choice: Remove redundant check in validate_on_attestation
2020-04-30 11:06:29 -06:00
2dc5156651
Add message about delaying consideration
2020-04-30 16:27:02 +10:00
6a40f71a31
add note about beacon committees not going into attnets
2020-04-29 20:29:48 -06:00
cd27e5e045
add tests for source, target, head
2020-04-29 10:23:12 -06:00
5f18dd778c
add baseline get_target_deltas tests
2020-04-28 19:26:14 -06:00
4a086fba5c
Merge branch 'dev' into rewards-rework
2020-04-28 17:24:45 -06:00
0e2931b9b3
All tests passed
2020-04-28 01:09:20 +01:00
87586837c3
remove interop from phase 0 p2p specs
2020-04-27 17:39:39 -06:00
d128400da5
remove interop from header and gossip sections in network spec
2020-04-27 17:39:31 -06:00
553a33cd2d
Merge pull request #1766 from ethereum/dev
...
backport dev to v012x
2020-04-27 17:35:28 -06:00
9d39c292e0
Merge pull request #1763 from ethereum/master
...
Backport v0.11.2 hotfixes from master to dev
2020-04-28 00:18:52 +02:00
dae623b097
Merge pull request #1756 from byz-f/q9-genesis-eth1
...
genesis: clarify that eth1 timestamp can be less than min genesis time
2020-04-27 10:15:18 -06:00
2449db1bb6
Phase 1 block tests are working
2020-04-27 16:08:49 +01:00
2dbc333270
Make `compute_new_state_root` a pure function
2020-04-27 22:18:43 +08:00
4d980aec71
Fix validator guide
...
1. Avoid negative computation in `is_candidate_block`
2. Fix `get_block_signature`: avoid extra casting; it's simpler to use BeaconBlock instead of
BeaconHeader
2020-04-27 21:47:24 +08:00
c841aa102b
genesis: clarify that eth1 timestamp can be less than min genesis time
2020-04-26 10:09:22 +02:00
1a81c873af
Remove redundant check in fork choice
2020-04-26 16:24:16 +10:00
9acea51938
Simplified by re-using get_ancestor()
2020-04-25 14:17:28 -07:00
0c67aaa68e
Include fork digest in example gossip topic name
2020-04-25 00:05:37 +02:00
fde9b410f0
Merge pull request #1752 from ethereum/dev
...
sync v0.11.2 to `v012x`
2020-04-24 11:36:17 -06:00
ab2ee0e2c2
Restoring chunk challenges and testing
2020-04-24 17:06:27 +01:00
bf806b9efa
Require "seen" aggregates to be valid
2020-04-24 15:01:18 +10:00
7612667bbe
minor feedback and fixes on rewards/penalites proposal
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2020-04-23 11:13:09 -06:00
fe13bab338
rework rewards/penalties to be more granular
2020-04-23 10:26:34 -06:00
11d164748c
add 'valid' when de-deduplication of attestations on gossip subnets
2020-04-22 14:45:01 -06:00
d8662d49ea
Merge pull request #1730 from ethereum/bootnode-enr
...
add note about distributing bootnode ENRs prior to genesis
2020-04-22 14:38:38 -06:00
3d4122a2f6
add note about distributing bootnode ENRs prior to genesis
2020-04-22 14:33:57 -06:00
9bbac0d2cc
Added consistency check for FFG & LMD vote in validate_on_atttestation(), fixes #1636 , fixes #1456 , fixes #1408
2020-04-21 23:56:44 -07:00
5929aac799
Cosmetic changes from #1737
2020-04-22 11:40:10 +08:00
a6b2679cb0
Merge pull request #1739 from ethereum/JustinDrake-patch-4
...
Partial fix for #1701
2020-04-21 08:44:22 -06:00
3436021e72
Update beacon-chain.md
2020-04-21 15:34:55 +01:00
ebf888bcf7
Merge pull request #1736 from status-im/rannge-req
...
simplify block range request description
2020-04-21 08:21:57 -06:00
e2a320ef32
Partial fix for #1701
...
Clarify that state transitions with `uint64` overflows are invalid.
2020-04-21 08:59:53 +01:00
508811d641
Fix #1735—remove redundant check
...
As per #1735 the check `if not len(indices) <= MAX_VALIDATORS_PER_COMMITTEE: return False` is redundant. As such this PR should be purely cosmetic.
2020-04-21 08:50:42 +01:00
4915014a19
simplify block range request description
...
There's room for ambiguity as to what `count` means - this clarifies
that it always relates to the slot, and not the number of blocks in the
response which allows clients to request ranges epoch by epoch (for
example) without worrying about overlaps caused by empty slots.
2020-04-20 20:03:15 +02:00
6fdee75475
Fix phase0 types
2020-04-17 23:55:25 +08:00
e58cfedb68
clarify ssz_snappy for gossip
2020-04-16 11:12:24 -06:00
4a94200c0b
Merge pull request #1712 from ethereum/hwwhww/inactivity_penalty_quotient_bug
...
Fix `INACTIVITY_PENALTY_QUOTIENT`
2020-04-14 11:53:43 -06:00
b2f6325db3
Fix `compute_committee`
2020-04-09 17:50:23 +08:00
890c27d091
The input parameter `index` in `compute_shuffled_index` is the position of the given list, not `ValidatorIndex`
2020-04-09 17:33:14 +08:00
c10e59bdf7
Fix `INACTIVITY_PENALTY_QUOTIENT`
...
The amount of inactivity penalty was adjusted to half since we were applying penalty for missing FFG target and source. But now we only apply it for missing target, so `INACTIVITY_PENALTY_QUOTIENT` should be `2**24`.
2020-04-08 10:32:16 +08:00
2a36f366ef
Merge pull request #1710 from paulhauner/patch-20
...
Tighten aggregate attn propogation condition
2020-04-07 18:56:04 -06:00
26492651b6
Merge pull request #1706 from paulhauner/patch-19
...
Redefine attestation propogation condition
2020-04-07 18:55:41 -06:00
c96a3366fa
Tighten aggregate attn propogation condition
2020-04-07 16:07:41 +10:00
616385a094
Fix spelling mistake
2020-04-07 07:45:15 +10:00
021cb98dbb
Use epoch for attestation subnet seen-ness.
2020-04-07 07:05:51 +10:00
bdf087d7f3
add notes about how to handle peer discovery and gossip topics prior to genesis
2020-04-06 09:57:23 -06:00
7d4b97240b
Redefine attestation propogation condition
2020-04-06 17:46:33 +10:00
907c56dabd
Fix ToC
2020-04-05 15:47:59 +01:00
c3c24b4fc4
Fix lint
2020-04-05 15:35:11 +01:00
bf34fdf023
Fix ToC
2020-04-05 15:10:09 +01:00
ca6af0c2e9
256-bit custody atoms for better alignment with rest of the spec and greater efficiency
2020-04-05 14:39:00 +01:00
f135eff021
add lookahed for shard subnets for beacon committee in validator guide
2020-04-03 13:23:38 -06:00
e86c5ef41d
final PR nitpicks
2020-04-03 10:29:35 -06:00
c3e5ddaabc
Merge branch 'dev' into phase1-tests
2020-04-03 09:54:34 -06:00
246b46771e
address @hwwhww feedback
2020-04-03 09:46:57 -06:00
f2c2da95ed
add compute_offset_slots
2020-04-03 09:19:56 -06:00
d61b2991a0
fix lint
2020-04-02 16:58:39 -06:00
6067c511c5
add light client to phase 1 validator
2020-04-02 16:48:02 -06:00
d789f3d32d
getting phase 1 val guide in place
2020-04-02 15:09:45 -06:00
613f368c00
fix call to get_beacon_committee in process_crosslink_for_shard
2020-04-01 12:20:32 -06:00
16208790a5
Merge pull request #1699 from ethereum/hwwhww/unpack_compact_validator
...
Add `unpack_compact_validator` back
2020-03-31 10:40:45 -06:00
f82cdb7e68
beacon-chain.md: add `unpack_compact_validator` for `light-client-sync.md`
2020-03-31 22:13:48 +08:00
071f6b5126
Gasprice rework: use `MIN_GASPRICE` as the initial gasprice and change `MIN_GASPRICE` to 8 gwei
2020-03-31 22:09:20 +08:00
2daa26442b
Tighten restriction on a "seen" attestation
...
Declares that only a verified block can stop an attestation from being propagated.
This achieves two things:
1. Ensures that clients don't need to scan invalid blocks for attestations and then modify their state based upon them.
1. Disallows "muting" attestations by sending around a junk block with that attestation in it.
2020-03-30 10:44:46 +11:00
073f78efa1
Merge branch 'dev' into phase1-tests
2020-03-29 17:04:25 -06:00
d07aa00307
Merge pull request #1692 from ethereum/master
...
Backport v0.11.1 to dev
2020-03-29 16:38:50 -06:00
d42e08a6e1
verify proposer sig before proposer shuffling in p2p block gossip conditions
2020-03-26 11:43:32 -06:00
c46fe86839
Merge branch 'v011x' into publish-vs-subscribe
2020-03-26 10:48:23 -06:00
a83e7a5ecc
proto PR feedback
2020-03-26 10:46:06 -06:00
050b42806d
Merge pull request #1684 from ethereum/enr-ping
...
MetaData and Ping
2020-03-26 10:40:46 -06:00
ee45cf77ef
proto feedback on MetaData
2020-03-26 07:47:20 -06:00
7af6a3afa4
do not require non-aggregating validators to subscribe to attestation subnet for beacon committee duties
2020-03-25 15:56:26 -06:00
d5a9af6469
update ping protocol to use MetaData
2020-03-25 12:08:27 -06:00
b8d25dc5b4
Merge pull request #1682 from ethereum/reward-acc-bug
...
Attestation reward bug
2020-03-24 19:36:23 -06:00
88fddf2379
Remove unneccessary clock disparity check
...
There is no need to mention clock disparity when comparing two static slot values (assuming the clock disparity is less than a slot, even then I don't think that's the intention).
2020-03-24 08:13:36 -06:00
1c49f99094
Fix bug in attestation reward calculation
2020-03-24 07:40:58 -06:00
f227e026fa
Draft PING and ENR rpc protocol
2020-03-24 15:10:47 +11:00
cf20a7ae3e
Shift some ENR fields to MAY
2020-03-24 15:07:43 +11:00
2978f21a39
minor edit to validator get_attestation_signature
2020-03-19 15:17:06 -06:00
759af67345
Normalize attestation signature getter name
2020-03-19 15:13:59 -06:00
2b8c32a347
Merge pull request #1664 from ethereum/div-zero-total-balance
...
avoid div by zero in extreme balance case
2020-03-19 08:50:09 -06:00
0a9b306d60
PR feedback from @hwwhww
2020-03-18 09:55:09 -06:00
e6998a61cd
remove IK handshake from noise spec (removed in core libp2p specs)
2020-03-17 10:54:48 -06:00
e2ef4365e2
min total balance is now EFFECTIVE_BALANCE_INCREMENT. update testing
2020-03-16 11:19:21 -06:00
d299b06a1c
fix custody bit calculation format
2020-03-16 09:52:27 -06:00
5315f3db35
clarify proposer_index must be from expected shuffling when validating block gossip
2020-03-13 12:00:34 -06:00
9b7e0ab2be
Fix error in custody bit computation
2020-03-13 17:15:25 +00:00
1293320675
Merge branch 'dev' into phase1-tests
2020-03-12 07:12:41 -06:00
c894f5ecec
fork choice error note
2020-03-11 16:41:27 -06:00
a612df1119
minor typos and clarifications in fork choice
2020-03-11 16:11:42 -06:00
47bbffa0d6
'get_checkpoint_store' -> 'get_forkchoice_store' typo
2020-03-11 15:03:14 -06:00
81dc71c312
Merge pull request #1652 from ethereum/gossip-topics-with-fork-digest
...
Gossip topics with fork digest
2020-03-11 13:32:25 -06:00
4bcdf91e8b
Apply suggestions from code review
...
PR feedback
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2020-03-11 13:24:30 -06:00
36e48fba99
enforce must match target to match head to avoid perverse incentive path
2020-03-11 12:51:05 -06:00
0881e21dc5
cleanup gossip topic fork digest based on PR feedback
2020-03-11 12:02:31 -06:00
baee673124
add note about preparing for subnet backbone for forks
2020-03-10 17:29:39 -06:00
e2918c6364
Merge pull request #1626 from ethereum/proposer-index
...
add proposer index to BeaconBlock
2020-03-10 15:10:07 -06:00
fccd3ab1ce
clarify hex-encoded bytes string representation for fork digest in gossip topic
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2020-03-10 15:04:44 -06:00
415544bf03
modify gossip topics to use ForkDigest
2020-03-10 14:44:35 -06:00
b25ca8e32c
Merge branch 'gossip-topic' of https://github.com/status-im/eth2.0-specs into status-im-gossip-topic
2020-03-10 14:02:44 -06:00
ab24e7cab7
Merge pull request #1651 from ethereum/revert-forkchoice-header
...
revert fork choice store.blocks to BeaconBlock
2020-03-10 20:25:18 +01:00
3b7704a78f
Merge pull request #1649 from ethereum/eth1-voting-period-in-epochs
...
Eth1 voting period in epochs [updated for configs/phase1/tests compat.]
2020-03-10 13:24:03 -06:00
1c9ca3c168
Merge pull request #1635 from ethereum/rewards-overflow
...
handle rewards overflow
2020-03-10 13:23:21 -06:00
c91eee6bdf
revert fork choice store.blocks to store BeaconBlock
2020-03-10 13:20:57 -06:00
0d01299d17
Merge pull request #1648 from sgryphon/feature/clarify-store-signed-block
...
Put back in a requirement to store recent signed blocks
2020-03-10 13:13:33 -06:00
1579072e15
add note about total balance overflowing
2020-03-10 13:12:17 -06:00
d6eedd95c0
fix wording to be clear it is about serving blocks
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2020-03-10 13:04:28 -06:00
bd5231a975
Merge pull request #1614 from ethereum/eth2-enr
...
add eth2 key/value ENR to phase 0 p2p
2020-03-10 13:02:32 -06:00
1818f349ad
add ForkDigest type, clarify how genesis_validators_root is mixed into domains for chain isolation in p2p faq
2020-03-10 11:59:34 -06:00
55d436db51
simplify description of voting period time
2020-03-10 18:55:59 +01:00
2d7a292d36
eth1 vote period constant in epochs: update configs, phase1, tests
2020-03-10 18:36:53 +01:00
882b9ee035
Merge branch 'dev' into rewards-overflow
2020-03-11 00:41:17 +08:00
da5720f9d1
Put back in a requirement to store recent signed blocks that was removed when SignedBeaconBlock was introduced (prior to that the signature was in BeaconBlock, which was recorded in Store).
2020-03-10 21:31:03 +10:00
92eef0e00b
fix light client sig verification in phase 1
2020-03-09 14:52:30 -06:00
6230a22976
Merge pull request #1606 from ethereum/rpc-snappy-lengths
...
RPC chunks with streaming SSZ decoding, snappy frames, and stricter DOS limits where possible.
2020-03-09 11:04:12 -06:00
7e04989e29
add genesis_validators_root to beaconstate and utilize in sig domain separation as well as fork separation
2020-03-05 09:21:32 -07:00
37b1fed8ff
update eth2 ENR field to use ENRForkID
2020-03-04 14:16:30 -07:00
5dae252f56
add eth2 key/value ENR to phase 0 p2p
2020-03-04 12:33:23 -07:00
f082aa6ca9
use EFFECTIVE_BALANCE_INCREMENT to normalize reward calculations
2020-03-03 15:34:02 -07:00
5e1fb79a8e
Merge pull request #1627 from ethereum/hysteris-fix
...
adjust hysteresis to avoid initial over-deposit incentive
2020-03-03 14:15:24 -07:00
33e7680836
make hysteresis calculations configurable
2020-03-03 10:58:47 -07:00
2d4ec7d52f
add REWARD_OVERFLOW_INCREMENT to avoid overflow in rewards calculation
2020-03-03 10:23:08 -07:00
b4c7481b35
Fix the misc table
2020-03-03 01:28:58 +01:00
0122081d05
hysteresis to -0.25/+1.25
2020-03-02 15:55:01 -07:00
38323d8186
Add faq
2020-03-01 17:17:29 +01:00
186d4258b6
fix shard offsets
2020-02-28 13:20:37 -06:00
bb82a051ff
clean up, add invalid input handling
2020-02-27 19:39:34 +00:00
4d72dcf3ab
@hwwhww feedback
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2020-02-27 12:00:55 -06:00
9718d206a7
fix attester slahsing test
2020-02-26 11:20:19 -06:00
721f605a91
Merge branch 'dev' into phase1-tests
2020-02-22 12:10:35 -06:00
4c1fc9bffa
work through phase 1 tests
2020-02-22 12:06:31 -06:00
97fa3741af
working through test issues
2020-02-22 09:30:33 -06:00
ceb6633eb9
working through phase 1 attestation testing
2020-02-22 09:24:14 -06:00
934c037a8a
Correct the duration of HISTORICAL_ROOTS_LIMIT
...
The duration of HISTORICAL_ROOTS_LIMIT is:
SECONDS_PER_SLOT * SLOTS_PER_HISTORICAL_ROOT * HISTORICAL_ROOTS_LIMIT
which is
12s * 2^13 * 2^24 = 1.65e12s = 52,262 years
2020-02-22 09:22:52 -06:00
3bb8e0d962
cleanup attester slashing conditon code snippet
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2020-02-22 09:22:52 -06:00
f671b86776
add DoS prevention validation conditions to voluntary_exit, proposer_slashing, and attester_slashing gossipsub channels
2020-02-22 09:22:52 -06:00
7329cc0933
pr feedback
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2020-02-22 09:22:51 -06:00
3404f1e078
add lower bound condition on block gossip
2020-02-22 09:22:51 -06:00
581257e269
reorder gossip conditions to put cheap checks before signature verifications
2020-02-22 09:22:51 -06:00
f7181adece
reverse params in get_aggregate_and_proof to match ssz type
2020-02-22 09:22:51 -06:00
d2e08c0cdf
subnet validation PR feedback
2020-02-22 09:22:51 -06:00
dde69cb8e2
add explicit instrucutions for construction of signed_aggregate_and_proof. add DOMAIN_SELECTION_PROOF and DOMAIN_AGGREGATE_AND_PROOF
2020-02-22 09:22:51 -06:00
5ee1f9b545
fix up some p2p validation conditions based on PR feedback
2020-02-22 09:22:50 -06:00
fd633d2467
add clarifying note to signedaggregateandproof in vaidator guide and fix tocs
2020-02-22 09:22:50 -06:00
343168908c
prevent multiple beacon blocks from same proposer in a given slot
2020-02-22 09:22:50 -06:00
8da7a84eb7
create SignedAggregateAndProof to prevent DoS attacks
2020-02-22 09:22:50 -06:00
047936eb2d
Add no repeat attestation condition for committee_index_beacon_attestation gossip channel
2020-02-22 09:22:50 -06:00
0a849acdce
fix validator guide to show that block slashing is per slot rather than per epoch
2020-02-22 09:22:49 -06:00
d414aac933
rework process_attestation and work through tests
2020-02-22 09:22:49 -06:00
61f661b3ec
Update specs/phase0/p2p-interface.md
...
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2020-02-20 08:23:09 +01:00
a02aac43c2
adjust hysteresis to avoid initial over-deposit incentive
2020-02-18 12:36:20 -06:00
757f5a31dd
add proposer index and add/modify tests
2020-02-18 11:38:17 -06:00
cfcb7b2f01
Measure eth1 voting period in epochs instead of slots
2020-02-18 16:12:43 +03:00
52b45ab9de
Add fork version to topic
...
Gossipsub peers are separate from the ETH2 RPC protocol, and thus cannot
rely on the application-level `Status` negotiation to establish if
they're on the same network.
Segregating gossipsub topics by fork version decouples RPC from gossip
further and allows peers to more easily listen only to the traffic of
the network they're interested in, without further negotiation.
2020-02-17 10:03:32 +01:00
8620adcdf1
Correct the duration of HISTORICAL_ROOTS_LIMIT
...
The duration of HISTORICAL_ROOTS_LIMIT is:
SECONDS_PER_SLOT * SLOTS_PER_HISTORICAL_ROOT * HISTORICAL_ROOTS_LIMIT
which is
12s * 2^13 * 2^24 = 1.65e12s = 52,262 years
2020-02-14 14:29:45 +00:00
40b4931f01
cleanup attester slashing conditon code snippet
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2020-02-13 11:17:19 -07:00
a7ef70eb9b
add DoS prevention validation conditions to voluntary_exit, proposer_slashing, and attester_slashing gossipsub channels
2020-02-12 15:56:03 -07:00
f441fadfff
pr feedback
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2020-02-12 15:50:22 -07:00
f8b72f5057
add lower bound condition on block gossip
2020-02-12 12:07:57 -07:00
a9fae27379
Merge pull request #1615 from ethereum/subnet-validations
...
Add subnet validations for DoS resistance
2020-02-12 12:02:28 -07:00
714a7de8a2
reorder gossip conditions to put cheap checks before signature verifications
2020-02-12 11:59:00 -07:00
90476388fe
reverse params in get_aggregate_and_proof to match ssz type
2020-02-11 15:54:18 -07:00
bf8252aeb6
subnet validation PR feedback
2020-02-11 15:46:30 -07:00
eec57f29b7
add explicit instrucutions for construction of signed_aggregate_and_proof. add DOMAIN_SELECTION_PROOF and DOMAIN_AGGREGATE_AND_PROOF
2020-02-11 15:45:51 -07:00
8d16d428e0
fix up some p2p validation conditions based on PR feedback
2020-02-10 21:35:39 -07:00
3d111f7bdd
Merge pull request #1612 from ethereum/v-guide-per-slot-slash
...
[validator guide] beacon block is per-slot slashing
2020-02-10 19:42:01 -07:00
8a2a689c80
add clarifying note to signedaggregateandproof in vaidator guide and fix tocs
2020-02-10 19:36:08 -07:00
1ca4e3538c
prevent multiple beacon blocks from same proposer in a given slot
2020-02-10 19:28:37 -07:00
118a755bbb
create SignedAggregateAndProof to prevent DoS attacks
2020-02-10 19:18:14 -07:00
c1a51a9358
Add no repeat attestation condition for committee_index_beacon_attestation gossip channel
2020-02-10 18:53:26 -07:00
129aa02cb3
support tests with SLOTS_PER_EPOCH * 256 vals
2020-02-10 17:56:05 -07:00
d5f1402d0d
Merge pull request #1604 from status-im/fewer-head-block-roots
...
drop `head_block_root` from BeaconBlocksByRange
2020-02-08 18:24:54 -06:00
43cacc3fe9
fix validator guide to show that block slashing is per slot rather than per epoch
2020-02-08 16:58:05 -07:00
6188f350f6
it's just a number
2020-02-07 19:03:33 +01:00
97d931b705
rephrase fork choice requirement
2020-02-07 19:03:09 +01:00
b398e42439
another typo in pubsub channel name
2020-02-06 16:41:53 -08:00
7aeeb372a7
[validator-guide] typo fix
2020-02-06 16:03:40 -08:00
03f53e9928
Merge pull request #1607 from AgeManning/noise-specification
...
Add libp2p-noise specification
2020-02-06 12:05:49 -06:00
9355a6ebca
Noise libp2p specification
2020-02-05 14:33:00 +11:00
93249aadda
Proposal to focus on length-encoding SSZ contents, enable streaming of chunk contents, and put stricter DOS limits in place
2020-02-04 13:56:32 +01:00
74c75fd6f1
Remove extraneous word
2020-02-02 22:08:11 +00:00
c943b5832e
drop `head_block_root` from BeaconBlocksByRange
...
This change simplifies the protocol and removes a race condition between
block request and response. In the case of honest server, this helps
serve the canonical / fork-chosen chain better while dishonest or broken
servers still need to be handled the same way.
Might as well get started on versions and upgrade it to 2, since the
change is backwards incompatible.
2020-01-31 22:04:48 +01:00
fe58c78da8
Fix table
2020-01-29 14:08:48 -08:00
51f2974678
Update validator.md
...
Minor edit
2020-01-29 13:51:38 +00:00
52fb929978
Update specs/core/1_beacon-chain.md
2020-01-28 17:32:57 -07:00
2a91b43eaf
Remove shard block chunking
...
Only store a 32 byte root for every shard block
Rationale: originally, I added shard block chunking (store 4 chunks for every shard block instead of one root) to facilitate construction of data availability roots. However, it turns out that there is an easier technique. Set the width of the data availability rectangle's rows to be 1/4 the max size of a shard block, so each block would fill multiple rows. Then, non-full blocks will generally create lots of zero rows. For example if the block bodies are `31415926535` and `897932` with a max size of 24 bytes, the rows might look like this:
```
31415926
53500000
00000000
89793200
00000000
00000000
```
Zero rows would extend rightward to complete zero rows, and when extending downward we can count the number of zero rows, and reduce the number of extra rows that we make, so we only make a new row for every nonzero row in the original data. This way we get only a close-to-optimal ~4-5x blowup in the data even if the data has zero rows in the middle.
2020-01-28 17:31:51 -07:00
d9f62f9303
Remerkleable - merkle tree based ssz for better and faster spec
2020-01-25 00:43:43 +01:00
67a4d5e659
Merge branch 'dev' into master-copy
2020-01-24 13:49:22 -07:00
d4ae00819a
Fix for increased seconds per slot
2020-01-23 13:08:52 -07:00
86b699bfd1
Merge branch 'dev' into phase1rebase
2020-01-23 19:24:03 +01:00
de1bb7bde1
Update for renamed constant
2020-01-23 09:55:04 -07:00
a13271af41
Fix BLS API description
2020-01-23 09:52:40 -07:00
f8250b6a1a
Correct typo in heading level
2020-01-23 09:51:58 -07:00
14cfc66c33
Fix p2p interface indentation
2020-01-23 09:51:38 -07:00
eed3f6053d
Merge pull request #1580 from ethereum/fork-choice-fix-1574
...
Fork choice fix issue 1574
2020-01-22 16:56:00 -07:00
d672c47aba
Merge pull request #1579 from ethereum/epochs-in-fork-choice
...
Properly handle skip slots in fork choice
2020-01-22 16:55:15 -07:00
9f5f501e5b
Merge pull request #1586 from ethereum/fix-default-compute-domain
...
fix default value in compute_domain
2020-01-23 00:29:28 +01:00
ebac603745
Update for renamed constant
2020-01-22 22:23:36 +00:00
fe103394db
Merge pull request #1583 from sigp/kirk-baird-patch-02
...
Update BLS Link
2020-01-22 14:57:36 -07:00
b357e43aab
clarifying comment on call to get_ancestor in on_block
2020-01-22 14:31:23 -07:00
e821476c07
explicitly use Optiona type for fork_version in compute_domain
...
Co-Authored-By: Carl Beekhuizen <carl@ethereum.org>
2020-01-22 11:38:50 -07:00
cf18b040b4
fix default value in compute_domain
2020-01-22 07:24:15 -07:00
601701241c
Update link
...
Signed-off-by: Kirk Baird <baird.k@outlook.com>
2020-01-22 11:04:45 +11:00
2015433fa1
revert exit queue epoch issue introduced in v0.10.0. add test to catch subtlety
2020-01-20 20:03:38 -07:00
00d3fb4fe6
fix issue 1574 by ensuring that justified checkpoint in store updates when finalized updates if needbe
2020-01-20 18:50:50 -07:00
e98c1b4154
don't consider blocks with slots earlier than finalized in on_block fork choice (optimization)
2020-01-20 18:10:39 -07:00
f1697d03e7
fix corner case to properly handle skipped slots in get_ancestor
2020-01-20 17:49:09 -07:00
7a412534d9
remove test_shard_blocks (outdated) and reduce PERSISTENT_COMMITTEE_PERIOD in minimal config
2020-01-15 18:17:07 -07:00
c0b69e531f
cycle through committee indexes instead of through active shards when forming crosslinks
2020-01-15 17:43:11 -07:00
3c07b2c954
Make phase 0 fork choice more modular to more easily adopt for slight modifications in phase 1
2020-01-15 16:40:50 -07:00
08621a7973
Merge pull request #1567 from ethereum/fix_bls_api
...
[Minor] fix BLS API description
2020-01-15 14:21:15 -07:00
1756348e8d
Merge pull request #1569 from ChihChengLiang/minor-fix-indentation
...
[Minor] Fix p2p interface table level
2020-01-15 14:19:42 -07:00
5785b4fc5b
custody bits temporary solution
2020-01-14 01:59:01 +01:00
f04a686db7
doctoc
2020-01-14 01:42:19 +01:00
f6f8bd5350
no custody bits fallback
2020-01-14 01:36:16 +01:00
6c74468142
forkchoice store on top of any state now
2020-01-14 01:02:02 +01:00
702b253361
update configs for phase1
2020-01-13 19:50:36 +01:00
419b6a3250
config change, need more space for worst-case reveals
2020-01-13 19:00:24 +01:00
507a9afbfb
apply custody bit fix suggestion from Dankrad
2020-01-13 18:57:56 +01:00
4732c7beb1
merge in dev (v0.10) and fix reorg/lint issues
2020-01-13 18:55:21 +01:00
065b4ef856
Fix p2p interface indentation
2020-01-13 20:42:23 +08:00
b001f250db
Correct typo in heading level
2020-01-13 09:34:34 +00:00
efbea8c53c
Fix BLS API description
2020-01-13 12:49:03 +08:00
676e216beb
reorg specs by fork and move ssz out to own folder. make all of the build and link changes to support move
2020-01-10 11:55:13 -07:00
5e96c08f41
add MAXIMUM_GOSSIP_CLOCK_DISPARITY for gossip subnet validations
2020-01-10 07:28:14 -07:00
e0cd1090bd
fix voluntary exit to be wrt signed voluntary exit in p2p spec
2020-01-09 17:38:43 -07:00
af702d42fd
add slot validation condition for beacon block gossip sub channel
2020-01-09 17:14:00 -07:00
68ff136b5d
warn about broken attestation validation, fix most attester slashings tests
2020-01-10 00:00:10 +01:00
b8d4ce4c39
fix default value when voting on eth1data
2020-01-09 14:54:07 -07:00
140129ec51
Merge dev into phase1 refactor, update BLS phase1
2020-01-09 14:56:06 +01:00
f01254dd7f
Merge branch 'dev' into JustinDrake-patch-2
2020-01-08 13:54:16 -07:00
fff354d673
Merge branch 'dev' into carl_new_new_bls
2020-01-07 15:44:30 -07:00
12ea891ce5
`py_ecc` 2.0.0 baby!
2020-01-07 20:52:20 +01:00
8948393e76
Remove references to BLS messages
2020-01-07 20:28:16 +01:00
fbfe024e7a
Rename vyper file from `.v.py` to `.vy`
2020-01-07 17:20:17 +08:00
c3f7f0bc2b
Merge pull request #1556 from ethereum/constant-genesis-slot
...
move GENESIS_SLOT/EPOCH to constants
2020-01-06 17:28:06 -07:00
b637b9ad72
fix mod bug for voting period
2020-01-06 17:19:31 -07:00
9ea03dce60
add compute_time_at_slot helper in validator doc
2020-01-06 12:16:47 -07:00
a295451f37
Merge pull request #1555 from ethereum/att-when-ready
...
add eager attestation broadcasting
2020-01-06 01:15:13 +01:00
68d93f945c
online countdown fixes
2020-01-06 00:46:36 +01:00
9c07e26a4d
length assert not applicable anymore
2020-01-06 00:25:18 +01:00
6b872da3ec
light client bitfield is vector now, small size anyway, better separation of committee complexity from data init
2020-01-06 00:17:48 +01:00
2f3919c176
bugfix: pass block body to sub processing functions
2020-01-05 23:51:24 +01:00
2e6090fcd8
bugfixes for experimental phase0 -> phase1 fork py code
2020-01-05 23:37:42 +01:00
50c8727ae7
make genesis delay configurable
2020-01-05 15:29:23 -07:00
8515aec7aa
move GENESIS_SLOT/EPOCH to constants as they are not truly configurable
2020-01-05 15:07:41 -07:00
5ac0d12205
Merge pull request #1553 from ethereum/eth1-caching
...
`get_eth1_data` uses timestamp instead of block height
2020-01-05 14:44:47 -07:00
43d095214c
add note that validator should broadcast attestation immediately when receiving block from expected proposer
2020-01-05 14:10:06 -07:00
a8276f683e
don't hardcode shard count, bad example, need upgradeability
2020-01-05 20:20:20 +01:00
018927def0
generalize previous-slot function
2020-01-05 20:11:55 +01:00
a5faabbf19
Merge branch 'version-pyspec-module' into phase1rebase
2020-01-04 18:28:34 +01:00
6dbc02031d
add GENESIS_FORK_VERSION and make associated modifications to support configuration of this variable
2020-01-03 17:48:03 -07:00
261b6c0d23
modify get_eth1_data to use timestamp instead of block height
2020-01-03 16:57:04 -07:00
7b1a609335
Merge pull request #1549 from status-im/empty-block-response
...
Allow empty lists in streamed responses
2020-01-03 08:14:51 -07:00
c9f52d0099
Merge branch 'dev' into phase1rebase
2020-01-03 07:49:23 -07:00
0a3cc8a84a
malefactor_key -> malefactor_secret
2020-01-03 07:29:23 -07:00
8580ec33f2
'message' -> 'signing_root'
2020-01-03 08:18:34 +01:00
51bcb29e28
'DomainWrapper' -> 'SigningRoot'
2020-01-03 07:46:27 +01:00
a65d96da04
Merge in dev
2020-01-03 07:35:19 +01:00
defeb4e2fd
Merge pull request #1550 from terencechain/patch-94
...
`get_filtered_block_tree` typo
2019-12-31 12:39:52 -07:00
e70863ca93
Bytes4 -> DomainType
2019-12-30 06:52:00 +01:00
765176ec8c
PySpec SSZ Bytes instantiated from hex
2019-12-27 09:37:26 +01:00
662a986d04
Update 0_fork-choice.md
2019-12-25 09:51:29 -08:00
850d45dae0
Allow empty lists in streamed responses
...
It's possible that block request responses end up not containing any
blocks, so we need a way to encode this.
2019-12-21 17:26:14 +01:00
b698eff2a7
Merge pull request #1546 from ethereum/master
...
Backport v0.9.4 to dev
2019-12-20 21:25:50 +01:00
7af4429011
Make bls a module
2019-12-20 08:41:46 +02:00
1e410a1290
Fix typo due to change of interface
...
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-12-20 08:12:43 +02:00
780dff76d4
Merge pull request #1540 from ChihChengLiang/note-on-requesting-status-again
...
Add a note on requesting STATUS again
2019-12-19 14:10:54 -07:00
e34d22e4f8
bad -> abnormal
2019-12-19 14:04:45 -07:00
62cbd0e7da
Revert domain 6 -> 5 to prevent confusion
2019-12-19 15:49:10 +02:00
42a3dd4ab1
Implement @djrtwo's review suggestions
2019-12-19 15:47:42 +02:00
c4b23590d4
Add a note on requesting STATUS again
2019-12-19 18:50:49 +08:00
31d90ea799
add p2p faq on why message-id override
2019-12-18 14:46:35 -07:00
8a03e6d291
Add gossipsub message-id specification
2019-12-18 14:20:51 -07:00
caffe8d720
update ENR to use attesation subnets instead of shards
2019-12-17 16:27:13 -07:00
fa916323f0
add basics for ENR bitfield
2019-12-17 10:59:15 -07:00
177ec939f0
Update ToC
2019-12-17 15:40:26 +02:00
995c895b9c
New BLS in Phase 1
2019-12-17 15:33:37 +02:00
c239ffb78c
Linting fixes
2019-12-17 12:30:46 +02:00
80eb721895
Domains are bytes
2019-12-17 12:20:34 +02:00
502ee29537
Phase 0 new BLS
2019-12-17 12:04:56 +02:00
a4f8a77c02
Fix spelling errors found by codespell
2019-12-16 13:02:36 +01:00
412a06608c
Update 0_beacon-chain.md
2019-12-15 11:32:11 +00:00
48317d8ac0
Minor cosmetic cleanups
...
* remove `BLS_WITHDRAWAL_PREFIX` (it is not used in phase 1, not phase 0)
* avoid inline comment (# Validate state root)
* simplify header inequality check in `process_proposer_slashing` (using uniqueness of BLS signatures)
* add `block = signed_block.message` helper variable for readability
* (typo) clarify that the state transition function consumes a signed block (as opposed to a block)
* generally make comments more consistent
* consistent formatting of container instantiation for `DepositMessage`
* avoid using three lines for `rewards[index] += Gwei(max_attester_reward // attestation.inclusion_delay)`
* introduce `effective_balance` helper variable for readability, and to avoid multi-line statement
* consistent ordering of `MIN_EPOCHS_TO_INACTIVITY_PENALTY` in the time parameters table
* (typo) "Dequeued validators for activation up to churn limit" => Dequeue validators
* "Save current block as the new latest block" => "Cache current block" (for consistent with `process_slot`)
* (typo) "Verify the validator has not yet exited" => "Verify exit has not been initiated"
* Use Pythonic `default=` for `max()` call in `initiate_validator_exit`
2019-12-15 11:10:43 +00:00
88e954a9c7
Merge pull request #1522 from ethereum/master
...
backport v093 to dev
2019-12-13 18:56:31 +01:00
b09c45ffd2
remove last two references to signing root
2019-12-12 12:34:02 -07:00
47ecedb81d
update tocs
2019-12-12 09:48:53 -07:00
49a8264f5d
Merge branch 'v09x' into toc_ci
2019-12-12 09:47:20 -07:00
4a31503ec0
Merge pull request #1516 from ethereum/dup-indices-attest
...
Fixes #1486 : disallow duplicate indices in indexed attestation
2019-12-12 08:32:43 -07:00
52a6cf7ba3
Merge pull request #1514 from ethereum/queue-fix-on-finality
...
Fix queue rate and only activate upon finality
2019-12-12 07:44:57 -07:00
199933cb26
fix tocs
2019-12-12 06:57:11 -07:00
86fb3acd59
minor changes to finality in activation queue
2019-12-12 06:53:56 -07:00
19ec01e4e9
add comment about activation queue sort order
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-12 06:43:37 -07:00
3d48a3e9eb
Fix dead link to use Internet Archive
2019-12-11 18:17:20 -08:00
2405060a7e
Fixes #1486 : disallow duplicate indices in indexed attestation
2019-12-12 01:45:59 +01:00
e117b58ae2
add queue eligibility helper
2019-12-11 16:10:18 -07:00
6610aeea2f
fix activation queue to finality
2019-12-11 16:00:46 -07:00
40025c96dd
Merge pull request #1509 from ethereum/match-slot-target
...
ensure that epoch of attestation slot matches the target epoch
2019-12-10 13:42:32 -07:00
66652d0ebd
Merge pull request #1508 from ethereum/better-best
...
ensure the best better-justification is stored in fork choice
2019-12-10 13:41:45 -07:00
4636b3e824
Merge pull request #1510 from ethereum/genesis-slot-time
...
explicit use of GENESIS_SLOT in fork choice
2019-12-10 13:41:13 -07:00
e4d710590a
add test for queue efficiency
2019-12-10 11:49:26 -07:00
d126162ca8
fix activation queue efficiency
2019-12-10 11:25:55 -07:00
ca2b6a0e52
Use consistent header level for TOC generation
2019-12-10 18:29:50 +01:00
12ff64ea1a
Update ToC of specs to consistent use of doctoc
2019-12-10 18:29:40 +01:00
2c5c9cb71a
feedback from mikhail
2019-12-10 10:14:49 -07:00
8861ca0282
minor typo
...
Co-Authored-By: MrChico <martin.lundfall@protonmail.com>
2019-12-10 10:05:19 -07:00
9989f3ea9d
ensure fork choice functions when GENESIS_SLOT != 0
2019-12-09 19:02:16 -07:00
432257659e
add asserts to ensure that attestation slot must match the target epoch
2019-12-09 17:31:43 -07:00
d4d17ecc4e
ensure the best better-justification is stored in fork choice
2019-12-09 16:47:43 -07:00
57aeed1473
Merge branch 'v09x' into filter-fc-justified
2019-12-08 12:17:28 -07:00
e53a6daecc
clarify fliter block tree through two line usage
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-08 11:53:45 -07:00
ce40666003
version pyspec module and test on one attesterslashing test
2019-12-05 15:06:32 -07:00
da17f4b3a8
Merge pull request #1505 from ethereum/v09x
...
backport V09x
2019-12-05 22:15:47 +01:00
e31f17f037
modify phase 1 to use new signature (no signing_root) pattern
2019-12-05 13:49:52 -07:00
a32b0100ff
rebase fixes
2019-12-05 13:31:42 -07:00
4bf5eb86c4
fix issues using indexed attestation and custody bit wrapper
2019-12-05 13:31:42 -07:00
f533fef167
add missing attestation validations; cleanup process_attestations and fix minor bugs
2019-12-05 13:31:41 -07:00
a1ac0d5a80
fix get_shard_committee
2019-12-05 13:31:41 -07:00
ddd7cd2964
divide new and old containers out in phase 1
2019-12-05 13:31:41 -07:00
72a9dfc430
fix lint problems
2019-12-05 13:31:41 -07:00
Hsiao-Wei Wang
Danny Ryan
protolambda
Dankrad Feist
Paul Hauner
Raw Pong Ghmoa
Aditya Asgaonkar
Justin
Jacek Sieka
Michael Sproul
Age Manning
Sly Gryphon
Ben Edgington
Anton Nashatyrev
Alex Stokes
Jim McDonald
terence tsao
Herman Junge
vbuterin
Chih Cheng Liang
Kirk Baird
Carl Beekhuizen
Martin Lundfall
ethers