1ad381dccb
adding get_extended_sample_count docsstring
...
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-27 10:28:21 +02:00
78b583d8b0
clarify use of get_extended_sample_count
...
Here we assume uniform random selection without replacement.
If other methods are used, the target false positive threshold
is the main rule to follow.
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-27 09:48:32 +02:00
17dfb9ae57
fix get_extended_sample_count proc signature
...
Co-authored-by: Pop Chunhapanya <haxx.pop@gmail.com>
2024-06-27 09:30:39 +02:00
4539265c55
moving part of text in custody section
...
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-25 10:36:53 +02:00
1f87bbeac0
Merge branch 'dev' into pr3782
2024-06-25 16:21:00 +08:00
beedf852cb
Revert division change and add comments
2024-06-25 16:15:16 +08:00
fb020456cb
Add `get_extended_sample_count` unit tests
2024-06-19 02:18:29 +08:00
483a286ba5
Remove `assert len(missing_cell_indices) != 0` check
2024-06-14 23:57:33 +08:00
77eac20df6
Update specs/_features/eip7594/polynomial-commitments-sampling.md
...
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2024-06-13 17:20:04 +02:00
1c675ae4a1
Update polynomial-commitments-sampling.md - Fix dead link
2024-06-13 16:30:05 +02:00
43d96cff3f
Merge pull request #3772 from nalepae/patch-3
...
EIP-7594 - Update ENR record
2024-06-12 23:16:04 +08:00
6efab19ad0
chore: Refactor cell recovery code ( #3781 )
...
* multi:
- Remove shift_polynomial_coeff
- Remove recover_shifted_data
- Remove recover_original_data
- Move `zero_poly_eval_brp ` under sanity check comment as its only used for sanity checking
* chore: remove sanity check -- this was doing a wasteful `compute_root_of_unity` operation
* chore: add previous sanity check as a unit test
* chore: copy values python was taking a reference, so it passes in our regular codepaths but not in isolated test
* chore: add coset_fft test
* Update specs/_features/eip7594/polynomial-commitments-sampling.md
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
* Update specs/_features/eip7594/polynomial-commitments-sampling.md
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
* chore: linter
* chore: asn (switch to bls_modular_inverse)
* chore: (ben) rename func to test_construct_vanishing_polynomial
* chore: (ben) rename `extended_evaluations_coeffs` to `extended_evaluation_times_zero_coeffs`
* chore: compute `roots_of_unity_extended` in recover_data method
* chore: add more comments explaining whats happening in recover_data
* chore: compute_zero_poly_coeff in recover_data
* chore: make lint
* chore: add doc comment to coset_fft_field
* chore: (ben) add code to generate the vanishing polynomial when all cells are missing
* chore: remove handling of edge case when constructing a vanishing polynomial
* chore: rename H(x) to Q_3(x)
* chore: remove trailing whitespace
* chore: add whitespace between comments
* chore: (asn) add assert that num missing cells is not 0
* chore: (justin) address comments
* chore: merge resolution
* chore: fixup remaining IDs -> indices
* chore: use indice nomenclature in tests
---------
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
2024-06-11 20:26:19 +03:00
93dfcdaf4c
Remove compute_cells from list of public methods
2024-06-11 19:17:46 +03:00
10bac07b39
Remove compute_cells method
2024-06-11 19:17:43 +03:00
7b7ada7d46
Merge pull request #3797 from jtraglia/rename-cellid-to-cellindex
...
Rename `CellID` to `CellIndex`
2024-06-11 18:45:32 +03:00
c5e9c3cb4e
Add public methods section in KZG spec ( #3795 )
2024-06-11 07:43:40 -05:00
d137553f96
Rename CellID to CellIndex
2024-06-11 07:41:52 -05:00
5ace424cd8
`recover_cells_and_kzg_proofs` & matrix refactor ( #3788 )
...
* Recover cells and proofs & matrix clean up
* Fix table of contents
* Update reference tests generator
* Update test format
* Remove unused imports
* Fix some minor nits
* Rename MatrixEntry's proof to kzg_proof
* Move RowIndex & ColumnIndex to das-core
2024-06-11 14:52:24 +03:00
6711acf3e2
clarifying reconstruction and cross-seeding
...
- when should a node reconstruct
- how to cross-seed for subscribed and unsubscribed topics
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-11 02:31:22 +02:00
2ab4f1e12e
get_extended_sample_count: use SAMPLES_PER_SLOT constant
...
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-10 11:16:06 +02:00
ac105f472a
update polynomial-commitments-sampling.md -- fix shift_polynomialcoeff
2024-06-06 16:36:03 +02:00
4c57399887
self-contained get_extended_sample_count
...
Importing scipy is not preferred. This is a self-contained
version. Eventually an import of math and use of math.comb
makes it simpler.
Solving other formatting issues as well.
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-04 09:41:29 +02:00
436e58e3f8
add get_extended_sample_count helper function
...
add LossyDAS sample count generation helper function
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-29 14:27:31 +02:00
5f3beca871
remove LossyDAS naming from spec
...
While the technique was introduced as LossyDAS, we don't need the name
in the specification itself.
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-29 11:08:52 +02:00
a04cd87c38
fix the (source-view) formatting of the table
...
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-29 11:04:10 +02:00
4e1d566c43
improve candidate peer text
...
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-29 11:01:50 +02:00
7b4d23c0ba
fix toc
2024-05-28 22:57:52 +08:00
8d332788b9
clarify the use of LossyDAS
...
Clarify that what matters is the false positive threshold, allowing
different sampling strategies as protocol compliant behavior.
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-28 13:54:27 +02:00
b848ca6dc7
improved sampling description
...
- describe sample selection
- describe sample queries
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-28 13:54:27 +02:00
8737e69c21
use execution_witness_root in header
2024-05-28 10:39:35 +02:00
744ae2e687
Add EIP-6800 linter checks.
...
Fix the lint errors.
Remove custom type `StateDiff` and then use `List[StemStateDiff, MAX_STEMS]` directly in `ExecutionWitness`.
2024-05-28 16:24:11 +08:00
fd246d8ebf
Merge branch 'dev' into pr3230
2024-05-28 12:55:33 +08:00
0fd49c1a32
fix spelling error
2024-05-27 14:10:58 +02:00
7fbbb252d8
rebase on top of deneb
2024-05-27 12:46:30 +02:00
5c13f5c651
fix depth+extension serialization type
...
Co-authored-by: g11tech <develop@g11tech.io>
2024-05-27 11:53:38 +02:00
64b93c9361
Fix table.
2024-05-17 17:47:38 +03:00
f7bb8aab1a
EIP-7594 - Update ENR record
...
Proposal for https://github.com/ethereum/consensus-specs/issues/3744
2024-05-17 17:31:08 +03:00
fdeff744ff
EIP-7594: Add a missing check and a missing test vector ( #3765 )
2024-05-14 17:18:14 +03:00
8f73a47423
Update p2p-interface.md
2024-05-09 16:14:52 +08:00
b9befda08b
Update p2p-interface.md
2024-05-09 16:03:55 +08:00
313a64e9c1
Merge pull request #3748 from ethereum/fix-get_custody_columns
...
Fix `get_custody_columns`
2024-05-07 22:43:46 +08:00
9ffd08a9dc
The return values MUST be sent in `(slot, column_index)` order.
2024-05-07 20:28:34 +08:00
fdad206f3c
Apply @dankrad's suggestion
2024-05-07 20:26:56 +08:00
950136c50d
Apply suggestions from code review
...
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
2024-05-07 18:30:28 +08:00
34756a81c6
Add `DataColumnSidecarsByRange` v1 Req/Resp
2024-05-06 19:11:23 +08:00
9c1acbb5e5
Fix `get_custody_columns`
2024-05-06 17:25:47 +08:00
1ef75e0875
Be consistent between ids and indices
2024-05-03 19:00:51 +03:00
5699eedd4d
pad column_indices
2024-05-03 16:43:11 +01:00
e7b49dc670
chore: Add type casts reducing the diff for #3697 ( #3734 )
2024-04-29 08:14:55 -05:00
a4e04ebf64
Misc fix
2024-04-27 12:11:29 +08:00
b4188829b3
Rename compute_cells_and_proofs to compute_cells_and_kzg_proofs
2024-04-25 21:57:22 -05:00
4f66521208
Fix parameter indentations
2024-04-25 17:34:10 -05:00
ac1ce3b3f0
Rename verify_cell_proof to verify_cell_kzg_proof
2024-04-25 17:31:22 -05:00
e1d71216bb
Merge pull request #3715 from ethereum/das-test-vectors
...
Make `get_custody_columns` return sorted values and add `get_custody_columns` tests
2024-04-25 03:01:51 +08:00
24899b7fba
Apply suggestions from @jtraglia
2024-04-24 19:04:40 +08:00
b13e03e671
Merge pull request #3714 from kevaundray/kw/use-optimized-bls-msm
...
chore: use py-arkworks's multi-exp method inside of `g1_lincomb` and `g2_lincomb`
2024-04-23 11:57:13 -06:00
f3302a3836
- return serialized identity points
...
- result = None initially
2024-04-23 15:11:46 +01:00
d28a0164d2
add is_zero check
2024-04-23 14:55:37 +01:00
5eb19b3cef
modify g1_lincomb and g2_lincomb
2024-04-23 14:21:54 +01:00
5a74f40442
g2_lincomb uses g2_multi_exp
2024-04-23 13:38:27 +01:00
57c14e5400
Add `get_custody_columns` tests
2024-04-23 20:21:33 +08:00
73637c84b2
EIP-7594: Add asserts for public functions ( #3684 )
...
* Add length asserts for public PeerDAS functions
* Fix cell asserts
* Rename field variable to satisfy linter
* Add asserts for row/column indices
* Use CELLS_PER_EXT_BLOB
* Update to work with new spec changes
* Fix indentation
* Add explict check for cell_id
2024-04-23 12:12:26 +03:00
e51f7df77d
chore: make list copy explicit in `divide_polynomialcoeff` ( #3706 )
2024-04-22 10:43:04 -05:00
4fceca2b75
Merge pull request #3710 from kevaundray/kw/rm-field-elements-from-das-core
...
chore: use CELLS_PER_EXT_BLOB to compute the number of columns
2024-04-22 17:59:31 +03:00
bcd0a09e68
Integrate new Coset/CosetEvals types ( #3701 )
...
* Add CellBytes type
* Use ByteVector, not Vector
* Fix tests
* Replace b"" with []
* Apply suggestions for bytes_to_cell
* Add/integrate new CosetEvals type
* Remove accidental new line
* Fix recover_all_cells
* Fix recover_matrix
* fix CosetEvals abstraction leak
* Introduce internal Coset type for `coset_for_cell()`
* Use CosetEvals in compute_kzg_proof_multi_impl()
* update test
* satisfy linter
* Fix two nits I noticed
---------
Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Co-authored-by: George Kadianakis <desnacked@riseup.net>
2024-04-22 17:03:57 +03:00
79d255b15a
use CELLS_PER_EXT_BLOB in das-core
2024-04-22 14:08:44 +01:00
5c561722b8
add BLS_MODULUS to places where we subtract two integers ( #3709 )
2024-04-22 15:57:52 +03:00
858f51617d
Merge pull request #3708 from kevaundray/kw/hww-max-extended-matrix-size
...
chore: add a new config `MAX_EXTENDED_MATRIX_SIZE`
2024-04-22 15:56:51 +03:00
3f2d498cee
rename
2024-04-22 13:02:42 +01:00
0ffd0ca432
Merge pull request #3703 from kevaundray/kw/add-comment-for-verify-kzg
...
chore: Add more docs for the kzg verify algorithm
2024-04-22 12:46:12 +03:00
e46c4c39fb
workaround: add a new config `MAX_EXTENDED_MATRIX_SIZE` to avoid `class Container(List[c, a*b])`
2024-04-22 10:31:58 +01:00
dca048d8df
push @asn-d6 suggestions
2024-04-22 09:57:58 +01:00
0e4fc984ef
Remove unused return value ( #3704 )
2024-04-19 20:16:19 -05:00
4684c5748c
add comment for verify algorithm
2024-04-19 19:19:17 +01:00
bc69c357b4
Merge pull request #3702 from kevaundray/kw/fix_recover_polynomial
...
Change `recover_polynomial` to `recover_all_cells`
2024-04-19 12:54:21 -05:00
3ddd00e741
use recover_all_cells
2024-04-19 12:50:32 +01:00
32cbda9de2
rename to recover_all_cells
2024-04-19 12:50:22 +01:00
33dfa88160
fix bad merge
2024-04-19 12:07:58 +01:00
c2b7c0b414
Merge branch 'dev' into kw/optimize-compute-kzg-proof-multi
2024-04-19 12:04:15 +01:00
9c04cf13c9
Merge pull request #3695 from kevaundray/kw/fix-kzg-multi-comment
...
chore: Fixes and elaborates on comments for `compute_kzg_proof_multi`
2024-04-19 15:32:09 +09:00
0b312cae8b
Merge pull request #3692 from kevaundray/patch-11
...
chore: Change g2_lincomb to take in G2Points
2024-04-19 15:30:22 +09:00
8e3500b2b5
Update specs/_features/eip7594/polynomial-commitments-sampling.md
...
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
2024-04-18 20:26:52 +01:00
1669723adf
Update specs/_features/eip7594/polynomial-commitments-sampling.md
...
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
2024-04-18 20:26:46 +01:00
6c8955d4bc
chore: fix comment
2024-04-18 18:12:15 +01:00
912038bb08
modify cell proofs comment
2024-04-18 18:11:41 +01:00
4d073f10a2
remove remainder polynomial when in monomial form
2024-04-18 18:00:01 +01:00
d913140164
fix comments for kzg_proof_multi
2024-04-18 17:52:33 +01:00
7e85c962f2
change CELLS_PER_BLOB in das-core.md
2024-04-18 17:40:51 +01:00
3b889645ff
number of cells in an extended blob
2024-04-18 17:38:04 +01:00
45e70747bb
Update polynomial-commitments-sampling.md
2024-04-18 15:02:30 +01:00
034909ddb6
Merge in EIP-7251 tests to Electra
2024-04-15 20:10:14 -06:00
ce3931653d
Add EIP-7251 to Electra fork
2024-04-15 19:37:49 -06:00
4c60dade42
Merge branch 'fix-7251-tests' into pr/ralexstokes/3656-1
2024-04-15 14:00:04 -06:00
397f9eb15a
Merge branch 'dev' into pr3656
2024-04-10 21:39:44 +09:00
dd0bea032f
improve pending consolidation tests, fix bug in beacon-chain
2024-04-10 14:11:38 +02:00
4835ed1040
some clean ups from merging EIP-7002 into Electra
2024-04-09 12:58:30 -06:00
4e8e1784bc
Merge pull request #3662 from jtraglia/per-ext-blob
...
EIP-7594: Use FIELD_ELEMENTS_PER_EXT_BLOB in NUMBER_OF_COLUMNS
2024-04-10 01:03:11 +09:00
3dcf9ebe54
Use FIELD_ELEMENTS_PER_EXT_BLOB in NUMBER_OF_COLUMNS
2024-04-09 08:44:30 -05:00
94a0b6c581
Merge branch 'dev' into pr3653
2024-04-09 12:55:56 +09:00
ab8815ba10
Merge branch 'dev' into init-electra
2024-04-09 12:26:07 +09:00
1db1c54323
add comment
2024-04-09 10:33:48 +08:00
3cf3e21504
Update beacon-chain.md
2024-04-08 16:28:17 -06:00
2ed284da22
format comment in EIP-7251 spec
2024-04-08 08:19:29 -06:00
dd2721f3c6
Merge pull request #3657 from ralexstokes/eip-7251-spec-fixes
...
Various spec fixes for EIP-7251
2024-04-08 08:09:51 -06:00
64da0da132
Fix has_sufficient_effective_balance computation
2024-04-07 18:15:01 +06:00
8cf2fd50f6
add EIP-7251 `initialize_beacon_state_from_eth1` function
2024-04-06 17:18:15 -06:00
61168e6124
spec bugfix: incorrect `process_epoch` definition
2024-04-06 17:18:15 -06:00
b5d7bd0a8a
bugfix: voluntary exit processing in EIP-7251
2024-04-06 17:18:15 -06:00
a80a777589
add missing extended types for EIP-7251
2024-04-06 17:18:15 -06:00
982a983072
EIP-7251: format/lint fixes/docs, add validator guide
2024-04-06 17:18:12 -06:00
b18bbd8c61
Merge pull request #3636 from mkalinin/eip-7251
...
EIP-7251: misc changes
2024-04-06 10:22:45 -06:00
6ad0c07c78
Remove extra ` queue_excess_active_balance` call
2024-04-06 22:53:04 +08:00
e4068b5391
Merge EIP-7549 into Electra
2024-04-05 13:56:57 -06:00
55c81e7fa1
Merge EIP7002 into Electra
2024-04-05 11:36:49 -06:00
d2c69fe3cf
Rename EIP6110 to Electra
2024-04-05 10:53:42 -06:00
ace9db9aa9
Set FULL_EXIT_REQUEST_AMOUNT to 0
2024-04-05 15:35:06 +03:00
806ed66769
Merge branch 'dev' into init-electra
2024-04-05 07:03:29 +09:00
6cfa8f713e
Merge pull request #3629 from StefanBratanov/eip_6110_rename_function
...
EIP-6110 rename `get_eth1_deposit_count` function
2024-04-05 06:02:20 +08:00
cd91c04066
Merge branch 'dev' into init-electra
2024-04-04 22:49:53 +09:00
8728561da3
Merge branch 'dev' into peer-das
2024-04-04 22:23:02 +09:00
4f8fb6f716
Update specs/_features/eip7251/beacon-chain.md
...
Co-authored-by: fradamt <104826920+fradamt@users.noreply.github.com>
2024-04-04 14:49:25 +03:00
881768c9d5
Replace MAX_EB with MIN_AB
2024-04-03 17:45:48 +03:00
025ebed9c8
Merge pull request #3640 from ethereum/eip7549-tests
...
EIP-7549: Enable EIP-7549 on CI
2024-04-03 20:57:05 +08:00
9b291ab0a1
fix toc link
2024-04-02 16:11:59 +10:00
4606ab43e5
[EIP-7251] rename PartialWithdrawal field
2024-04-02 15:43:28 +10:00
ce591f98c8
Enable EIP7549 CI
2024-04-01 10:43:38 +09:00
cf3c4eca8c
Fix conflicts with #3631
2024-04-01 10:37:49 +09:00
eec5503d4f
Fix tests and specs
2024-03-31 16:35:24 +09:00
52e9552bbd
Fix bug in get_active_balance()
2024-03-29 11:59:16 -06:00
221f273e14
Fix lint
2024-03-29 22:35:12 +06:00
7bbecfb762
Revert "Replace MIN_ACTIVATION_BALANCE with MAX_EFFECTIVE_BALANCE"
...
This reverts commit 6f5cc4baf5
2024-03-29 15:27:12 +06:00
d004391fb1
Merge branch 'dev' into eip-7251
2024-03-29 15:25:07 +06:00
e926d2e791
Merge pull request #3618 from dapplion/eip-7251
...
Add EIP-7251 spec: Increase MAX_EFFECTIVE_BALANCE
2024-03-28 14:13:26 +08:00
534bcfc116
Use source.effective_balance for consolidaiton churn
2024-03-28 11:49:44 +06:00
915f90e13e
Strictly check withdrawal address upon consolidation
2024-03-27 18:05:05 +06:00
517f741f29
Abort voluntary exit if validator has pending partial withdrawals
2024-03-27 17:57:54 +06:00
46638d31ba
Remove unused method
2024-03-27 17:42:10 +06:00
31142b0ba1
Require sufficient EB to emit partial withdrawal
2024-03-27 17:41:00 +06:00
6f5cc4baf5
Replace MIN_ACTIVATION_BALANCE with MAX_EFFECTIVE_BALANCE
2024-03-27 17:35:27 +06:00
cda10d059b
Refactor EL withdraw request processing
2024-03-27 16:51:38 +06:00
73ede3a804
Fix pending_balance_to_withdraw == 0 check when full exit
2024-03-27 15:44:38 +06:00
5e32d442a2
Fix the sweep by enabling 0x02 creds
2024-03-27 12:42:37 +06:00
06104f24e3
Fix is_partially_withdrawable_validator
2024-03-27 01:43:15 +09:00
e6aaa9d44d
Fix lint
2024-03-27 01:35:36 +09:00
23ad85e8bf
Allow to switch to compounding validator on deposit
2024-03-27 00:31:09 +09:00
30be96bac3
Merge pull request #3632 from parithosh/add-electra-config
...
Add electra fork config
2024-03-26 21:48:28 +08:00
88a35a1de1
update the spec files too
2024-03-26 13:18:40 +08:00
4775641f05
fix broken pending deposits tests and typo
2024-03-25 15:26:50 +01:00
bb8ba9c045
Apply suggestions from code review
...
Co-authored-by: Lion - dapplion <35266934+dapplion@users.noreply.github.com>
2024-03-25 19:20:58 +06:00
97966d825a
small fixes
2024-03-25 12:23:19 +01:00
Csaba Kiraly
Csaba Kiraly
Hsiao-Wei Wang
Benedikt Wagner
kevaundray
Justin Traglia
George Kadianakis
Justin Traglia
b-wagn
Guillaume Ballet
Manu NALEPA
Nishant Das
Alex Stokes
fradamt
Mikhail Kalinin
NC
Paul Harris
Mark Mackey
dapplion