Hsiao-Wei Wang
e52c19896d
Update
...
1. Check on-time attestations fit `attestation.data.shard_transition_root != hash_tree_root(ShardTransition())`
2. Move `attestation.data.shard_head_root` check to after winning root
2020-06-23 18:22:18 +08:00
Hsiao-Wei Wang
5357bddcf8
PR feedback: use `filter_participant_set`
2020-06-23 00:13:48 +08:00
Hsiao-Wei Wang
97d0048eaa
PR feedback: use condition to determine if the test should be skipped
2020-06-23 00:06:35 +08:00
Hsiao-Wei Wang
1a5016157a
Fix
...
1. To make it more compatible, update `is_on_time_attestation` argument: replace `attestation: Attestation` with `attestation_data:
AttestationData`
2. Fix `get_sample_shard_transition`
2020-06-19 23:46:01 +08:00
Hsiao-Wei Wang
c28857e4e1
Fix `attestation.data.shard_head_root` bug
2020-06-19 23:34:51 +08:00
Hsiao-Wei Wang
80c6c0b5f1
valid==True for `run_successful_crosslink_tests` helper
2020-06-19 23:07:39 +08:00
Hsiao-Wei Wang
b8caa6ee85
Add `test_wrong_shard_transition_root`
2020-06-19 22:52:38 +08:00
Hsiao-Wei Wang
a9f8411a51
Verify all shard states
2020-06-19 22:42:18 +08:00
Hsiao-Wei Wang
37d1a0750d
Use `get_shard_winning_roots` to verify
2020-06-19 22:29:49 +08:00
Hsiao-Wei Wang
43605eebe8
Add `test_no_winning_root`
2020-06-19 22:21:29 +08:00
Hsiao-Wei Wang
c2c2b4c444
Crosslink bugfix
...
1. Fix `is_winning_attestation` condition
2. Fix `process_crosslink_for_shard`: we can only check
`shard_data_roots` if `shard_transition != ShardTransition()`
2020-06-19 22:19:21 +08:00
Hsiao-Wei Wang
3117cf3140
Refactor
2020-06-19 19:09:11 +08:00
Hsiao-Wei Wang
ea59193157
Rename some `shard_blocks` to `shard_block_dict`
2020-06-19 18:11:28 +08:00
Danny Ryan
520ad97c3e
Merge pull request #1920 from terencechain/patch-104
...
Fix usages of shard in `process_crosslink_for_shard`
2020-06-18 14:02:55 -06:00
terence tsao
3888dc27a9
@djrtwo's feedback
2020-06-18 12:39:48 -07:00
terence tsao
db81f88c4e
Update beacon-chain.md
2020-06-18 10:59:37 -07:00
Danny Ryan
153b4206e8
Merge pull request #1904 from ethereum/epochwise_committee_count_per_slot
...
Avoid state in p2p validation, compute committee count per slot for epoch
2020-06-18 09:52:40 -06:00
Danny Ryan
bd61c2686b
PR feedback
2020-06-18 09:45:10 -06:00
Danny Ryan
948ad23f96
Merge branch 'dev' into epochwise_committee_count_per_slot
2020-06-18 09:44:02 -06:00
Danny Ryan
05453b786d
Merge pull request #1895 from ethereum/hwwhww/attestation-shard
...
Add `shard: Shard` field to `AttestationData`
2020-06-18 09:37:07 -06:00
Danny Ryan
02d518c9e3
Merge pull request #1919 from ethereum/hwwhww/shard_block_length
...
Fix shard_block_length type in `compute_updated_gasprice`
2020-06-18 09:35:59 -06:00
Danny Ryan
13e7e7986d
Merge pull request #1915 from ethereum/hwwhww/fix-validator-arguments
...
Fix missing arguments of validator guide
2020-06-18 09:34:45 -06:00
Hsiao-Wei Wang
fe47869d5f
Revert `process_crosslinks` and add comment
2020-06-18 23:32:23 +08:00
Danny Ryan
df330810d8
Merge pull request #1914 from ethereum/hwwhww/align_fork_name
...
Align directory names of forks
2020-06-18 09:30:02 -06:00
Danny Ryan
6b3d391bfa
Merge pull request #1913 from ethereum/hwwhww/ini-config
...
Add linter config file
2020-06-18 09:26:20 -06:00
Hsiao-Wei Wang
35bf3b5290
Refactor `validate_attestation`
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2020-06-18 23:20:24 +08:00
Hsiao-Wei Wang
398ad99013
Merge pull request #1902 from ethereum/repo-specific-gitignore
...
revert local config settings from .gitignore
2020-06-18 23:18:12 +08:00
Hsiao-Wei Wang
8cf0774290
Fix shard_block_length type in `compute_updated_gasprice`
2020-06-18 20:39:29 +08:00
Hsiao-Wei Wang
5171a91dfb
Fix path
2020-06-18 19:03:40 +08:00
Diederik Loerakker
0a3f246ea0
Merge pull request #1912 from booleanfunction/dev
...
Clarification of SSZ bitlist and bitvector types.
2020-06-18 12:24:50 +02:00
Hsiao-Wei Wang
6aca7afd81
Add notes of active shard count
2020-06-18 17:35:24 +08:00
Hsiao-Wei Wang
7dbecdf904
Fix some missing arguments
2020-06-18 17:35:16 +08:00
Hsiao-Wei Wang
c0b6df8fd0
Merge pull request #1906 from terencechain/patch-102
...
Fix links in phase1 validator doc
2020-06-18 15:10:43 +08:00
Hsiao-Wei Wang
ec25f78632
Update path
2020-06-18 14:55:50 +08:00
Hsiao-Wei Wang
27eb2e2579
Move testing files from */phase_0 to */phase0, */phase_1 to */phase1
2020-06-18 14:54:27 +08:00
Hsiao-Wei Wang
51e7969147
Set linter configs in `linter.ini`
2020-06-18 14:36:14 +08:00
Joanne Fuller
974ef47c03
Clarification of types.
2020-06-18 14:47:10 +10:00
Hsiao-Wei Wang
0ae11cd70c
Merge pull request #1911 from terencechain/patch-103
...
get_shard_winning_roots uses on_time_slot
2020-06-18 12:28:23 +08:00
Hsiao-Wei Wang
0eeffc47bc
Merge pull request #1909 from ericsson49/fix_process_custody_game_operations
...
Fix typing error in `process_custody_game_operations`
2020-06-18 12:22:35 +08:00
ericsson
9dc43957e2
a fix according to @protolambda comments
2020-06-18 03:39:51 +03:00
Diederik Loerakker
3d544d5345
Merge pull request #1910 from ericsson49/fix_get_best_light_client_aggregate
...
Fix exception in `get_best_light_client_aggregate`
2020-06-18 02:16:58 +02:00
ericsson
e479e96480
lint fix
2020-06-18 02:46:06 +03:00
terence tsao
cc84b49d13
on_time_attestation_slot instead of current_slot
2020-06-17 16:20:46 -07:00
ericsson
adced70c54
use `aggregate.data` instead of hust `data`
2020-06-18 02:04:16 +03:00
ericsson
17c86177d9
Change types of BeaconBlockBody chunk_challenges and
...
chunk_challenge_responses to List[CustodyChunkChallenge, ...]
2020-06-18 01:43:41 +03:00
terence tsao
3eabcddb4c
Update validator.md
2020-06-17 13:24:00 -07:00
protolambda
ce0371a66b
fix comment: committees per slot for given *epoch*
2020-06-17 20:23:26 +02:00
protolambda
9b60a9b799
Avoid state usage in p2p validation, compute committee count per slot for epoch as a whole
2020-06-17 20:19:32 +02:00
Hsiao-Wei Wang
7117d2e75a
Merge pull request #1896 from lsankar4033/helper_tests
...
Add unit tests for `compute_fork_digest` and `compute_subnet_for_attestation`
2020-06-17 20:52:19 +08:00
Danny Ryan
8e30ee55d6
Merge pull request #1704 from ethereum/phase1-validator
...
phase 1 validator guide (round 1)
2020-06-16 22:41:36 -06:00