312 Commits

Author SHA1 Message Date
kevaundray
6efab19ad0
chore: Refactor cell recovery code (#3781)
* multi:

- Remove shift_polynomial_coeff
- Remove recover_shifted_data
- Remove recover_original_data
- Move `zero_poly_eval_brp ` under sanity check comment as its only used for sanity checking

* chore: remove sanity check -- this was doing a wasteful `compute_root_of_unity` operation

* chore: add previous sanity check as a unit test

* chore: copy values python was taking a reference, so it passes in our regular codepaths but not in isolated test

* chore: add coset_fft test

* Update specs/_features/eip7594/polynomial-commitments-sampling.md

Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>

* Update specs/_features/eip7594/polynomial-commitments-sampling.md

Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>

* chore: linter

* chore: asn (switch to bls_modular_inverse)

* chore: (ben) rename func to test_construct_vanishing_polynomial

* chore: (ben) rename `extended_evaluations_coeffs` to `extended_evaluation_times_zero_coeffs`

* chore: compute `roots_of_unity_extended` in recover_data method

* chore: add more comments explaining whats happening in recover_data

* chore: compute_zero_poly_coeff in recover_data

* chore: make lint

* chore: add doc comment to coset_fft_field

* chore: (ben) add code to generate the vanishing polynomial when all cells are missing

* chore: remove handling of edge case when constructing a vanishing polynomial

* chore: rename H(x) to Q_3(x)

* chore: remove trailing whitespace

* chore: add whitespace between comments

* chore: (asn) add assert that num missing cells is not 0

* chore: (justin) address comments

* chore: merge resolution

* chore: fixup remaining IDs -> indices

* chore: use indice nomenclature in tests

---------

Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
2024-06-11 20:26:19 +03:00
Justin Traglia
93dfcdaf4c Remove compute_cells from list of public methods 2024-06-11 19:17:46 +03:00
George Kadianakis
10bac07b39 Remove compute_cells method 2024-06-11 19:17:43 +03:00
George Kadianakis
7b7ada7d46
Merge pull request #3797 from jtraglia/rename-cellid-to-cellindex
Rename `CellID` to `CellIndex`
2024-06-11 18:45:32 +03:00
Benedikt Wagner
c5e9c3cb4e
Add public methods section in KZG spec (#3795) 2024-06-11 07:43:40 -05:00
Justin Traglia
d137553f96 Rename CellID to CellIndex 2024-06-11 07:41:52 -05:00
Justin Traglia
5ace424cd8
recover_cells_and_kzg_proofs & matrix refactor (#3788)
* Recover cells and proofs & matrix clean up

* Fix table of contents

* Update reference tests generator

* Update test format

* Remove unused imports

* Fix some minor nits

* Rename MatrixEntry's proof to kzg_proof

* Move RowIndex & ColumnIndex to das-core
2024-06-11 14:52:24 +03:00
b-wagn
ac105f472a update polynomial-commitments-sampling.md -- fix shift_polynomialcoeff 2024-06-06 16:36:03 +02:00
Guillaume Ballet
8737e69c21
use execution_witness_root in header 2024-05-28 10:39:35 +02:00
Hsiao-Wei Wang
744ae2e687
Add EIP-6800 linter checks.
Fix the lint errors.
Remove custom type `StateDiff` and then use `List[StemStateDiff, MAX_STEMS]` directly in `ExecutionWitness`.
2024-05-28 16:24:11 +08:00
Hsiao-Wei Wang
fd246d8ebf
Merge branch 'dev' into pr3230 2024-05-28 12:55:33 +08:00
Guillaume Ballet
0fd49c1a32 fix spelling error 2024-05-27 14:10:58 +02:00
Guillaume Ballet
7fbbb252d8 rebase on top of deneb 2024-05-27 12:46:30 +02:00
Guillaume Ballet
5c13f5c651
fix depth+extension serialization type
Co-authored-by: g11tech <develop@g11tech.io>
2024-05-27 11:53:38 +02:00
George Kadianakis
fdeff744ff
EIP-7594: Add a missing check and a missing test vector (#3765) 2024-05-14 17:18:14 +03:00
Nishant Das
8f73a47423
Update p2p-interface.md 2024-05-09 16:14:52 +08:00
Nishant Das
b9befda08b
Update p2p-interface.md 2024-05-09 16:03:55 +08:00
Hsiao-Wei Wang
313a64e9c1
Merge pull request #3748 from ethereum/fix-get_custody_columns
Fix `get_custody_columns`
2024-05-07 22:43:46 +08:00
Hsiao-Wei Wang
9ffd08a9dc
The return values MUST be sent in (slot, column_index) order. 2024-05-07 20:28:34 +08:00
Hsiao-Wei Wang
fdad206f3c
Apply @dankrad's suggestion 2024-05-07 20:26:56 +08:00
Hsiao-Wei Wang
950136c50d
Apply suggestions from code review
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
2024-05-07 18:30:28 +08:00
Hsiao-Wei Wang
34756a81c6
Add DataColumnSidecarsByRange v1 Req/Resp 2024-05-06 19:11:23 +08:00
Hsiao-Wei Wang
9c1acbb5e5
Fix get_custody_columns 2024-05-06 17:25:47 +08:00
George Kadianakis
1ef75e0875 Be consistent between ids and indices 2024-05-03 19:00:51 +03:00
Kevaundray Wedderburn
5699eedd4d pad column_indices 2024-05-03 16:43:11 +01:00
kevaundray
e7b49dc670
chore: Add type casts reducing the diff for #3697 (#3734) 2024-04-29 08:14:55 -05:00
Hsiao-Wei Wang
a4e04ebf64
Misc fix 2024-04-27 12:11:29 +08:00
Justin Traglia
b4188829b3 Rename compute_cells_and_proofs to compute_cells_and_kzg_proofs 2024-04-25 21:57:22 -05:00
Justin Traglia
4f66521208 Fix parameter indentations 2024-04-25 17:34:10 -05:00
Justin Traglia
ac1ce3b3f0 Rename verify_cell_proof to verify_cell_kzg_proof 2024-04-25 17:31:22 -05:00
Hsiao-Wei Wang
e1d71216bb
Merge pull request #3715 from ethereum/das-test-vectors
Make `get_custody_columns` return sorted values and add `get_custody_columns` tests
2024-04-25 03:01:51 +08:00
Hsiao-Wei Wang
24899b7fba
Apply suggestions from @jtraglia 2024-04-24 19:04:40 +08:00
Alex Stokes
b13e03e671
Merge pull request #3714 from kevaundray/kw/use-optimized-bls-msm
chore: use py-arkworks's multi-exp method inside of `g1_lincomb` and `g2_lincomb`
2024-04-23 11:57:13 -06:00
Kevaundray Wedderburn
f3302a3836 - return serialized identity points
- result = None initially
2024-04-23 15:11:46 +01:00
Kevaundray Wedderburn
d28a0164d2 add is_zero check 2024-04-23 14:55:37 +01:00
Kevaundray Wedderburn
5eb19b3cef modify g1_lincomb and g2_lincomb 2024-04-23 14:21:54 +01:00
Kevaundray Wedderburn
5a74f40442 g2_lincomb uses g2_multi_exp 2024-04-23 13:38:27 +01:00
Hsiao-Wei Wang
57c14e5400
Add get_custody_columns tests 2024-04-23 20:21:33 +08:00
Justin Traglia
73637c84b2
EIP-7594: Add asserts for public functions (#3684)
* Add length asserts for public PeerDAS functions

* Fix cell asserts

* Rename field variable to satisfy linter

* Add asserts for row/column indices

* Use CELLS_PER_EXT_BLOB

* Update to work with new spec changes

* Fix indentation

* Add explict check for cell_id
2024-04-23 12:12:26 +03:00
kevaundray
e51f7df77d
chore: make list copy explicit in divide_polynomialcoeff (#3706) 2024-04-22 10:43:04 -05:00
George Kadianakis
4fceca2b75
Merge pull request #3710 from kevaundray/kw/rm-field-elements-from-das-core
chore: use CELLS_PER_EXT_BLOB to compute the number of columns
2024-04-22 17:59:31 +03:00
Justin Traglia
bcd0a09e68
Integrate new Coset/CosetEvals types (#3701)
* Add CellBytes type

* Use ByteVector, not Vector

* Fix tests

* Replace b"" with []

* Apply suggestions for bytes_to_cell

* Add/integrate new CosetEvals type

* Remove accidental new line

* Fix recover_all_cells

* Fix recover_matrix

* fix CosetEvals abstraction leak

* Introduce internal Coset type for `coset_for_cell()`

* Use CosetEvals in compute_kzg_proof_multi_impl()

* update test

* satisfy linter

* Fix two nits I noticed

---------

Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Co-authored-by: George Kadianakis <desnacked@riseup.net>
2024-04-22 17:03:57 +03:00
Kevaundray Wedderburn
79d255b15a use CELLS_PER_EXT_BLOB in das-core 2024-04-22 14:08:44 +01:00
kevaundray
5c561722b8
add BLS_MODULUS to places where we subtract two integers (#3709) 2024-04-22 15:57:52 +03:00
George Kadianakis
858f51617d
Merge pull request #3708 from kevaundray/kw/hww-max-extended-matrix-size
chore: add a new config `MAX_EXTENDED_MATRIX_SIZE`
2024-04-22 15:56:51 +03:00
Kevaundray Wedderburn
3f2d498cee rename 2024-04-22 13:02:42 +01:00
George Kadianakis
0ffd0ca432
Merge pull request #3703 from kevaundray/kw/add-comment-for-verify-kzg
chore: Add more docs for the kzg verify algorithm
2024-04-22 12:46:12 +03:00
Hsiao-Wei Wang
e46c4c39fb workaround: add a new config MAX_EXTENDED_MATRIX_SIZE to avoid class Container(List[c, a*b]) 2024-04-22 10:31:58 +01:00
Kevaundray Wedderburn
dca048d8df push @asn-d6 suggestions 2024-04-22 09:57:58 +01:00
kevaundray
0e4fc984ef
Remove unused return value (#3704) 2024-04-19 20:16:19 -05:00