Commit Graph

5748 Commits

Author SHA1 Message Date
Alex Stokes ccfbf5c70a
Fix use of block root in Altair validator guide 2021-03-26 11:59:01 -07:00
Alex Vlasov 020895e35d
Typing problems fixes (#2271)
* Typing problem fixed: `process_block_header` passes `Bytes32()` to `state_root` of `BeaconBlockHeader`, which type is `Root`

* Typing problem fixed in `initialize_beacon_state_from_eth1`: `len` returns an `int` value, while `deposit_count=uint64` of `Eth1Data` has type `uint64`

* Typing problem fixed in `process_rewards_and_penalties`: `numerator` of type `int` passed to `weight` parameter of `get_flag_index_deltas`, which has type `uint64`

* Typing problem fixed in `process_attestation`; `False` passes as `crosslink_success` parameter of `PendingAttestation`, which has type `boolean`. `False` is an instance of `(python.)bool` and is not an instance of `(ssz.)boolean`

* Typing problem fixed: `shard_data_roots` of `ShardTransition` has type `List[Bytes32]`, but its elements are used as if they were `Root` values, e.g. in `process_chunk_challenge` method: passed to `data_root` of `CustodyChunkChallengeRecord` which has type `Root`

* Typing problem fixed in `process_custody_final_updates`: `index` has type `int`, while `validator_indices_in_records` has type `Set[ValidatorIndex]`, so tesing whether `index in validator_indices_in_records` can be risky, depending on implementation details. `ValidatorIndex(index) in validator_indices_in_records` is a safer variant.

* Typing problem fixed: `slashed` parameter of `pack_compact_validator` has type `(python.)bool`, however in `committee_to_compact_committee` a value of `(ssz.)boolean` is passed as a value of the parameter

* Typing problem fixed: `inactivity_scores` is a `List[uint64,...]`, while it is intialized/appended with values of `(python.)int` type

* fixed according to @protolambda suggestions

* changed types of _WEIGHT constants and appropriate variables/parameters, according to @protolambda suggestions

* revert code formatting back

* Introduced ZERO_ROOT according to @protolambda 's suggestion

* Reverted back to , according to @protolambda comments
2021-03-25 22:03:21 +01:00
Hsiao-Wei Wang e095090cf4
Merge pull request #2272 from ethereum/fix-filter-test
patch test_filtered_block_tree test generator
2021-03-25 16:18:00 +08:00
Danny Ryan 6c0a0ab3f2
patch test_filtered_block_tree test generator based on @ajsutton report 2021-03-24 12:57:14 -06:00
Danny Ryan 5e83e60a59
Merge pull request #2266 from ethereum/update-altair-aggregation-config
Update Altair config files: add signature domains
2021-03-23 09:35:10 -06:00
Hsiao-Wei Wang ae258bc335
Update config files, add `DOMAIN_SYNC_COMMITTEE_SELECTION_PROOF` and `DOMAIN_CONTRIBUTION_AND_PROOF` 2021-03-23 20:52:03 +08:00
Hsiao-Wei Wang 399d28bfb9
Merge pull request #2263 from terencechain/patch-112
Fix spelling
2021-03-23 18:02:07 +08:00
terence tsao d0b1ac1934
Update beacon-chain.md 2021-03-22 16:28:45 -07:00
Danny Ryan d49cddc1d8
Merge pull request #2255 from ralexstokes/update-subcommittee-name
Use different name for constant for sync committee aggregates
2021-03-22 11:34:32 -06:00
Danny Ryan 3a5f0e994a
Merge pull request #2253 from ethereum/master
backport generator fixes to dev
2021-03-22 11:11:10 -06:00
Danny Ryan 3374784bd3
Merge pull request #2261 from ethereum/altair-test-format-fix
Altair tests - fix mixed up formats
2021-03-22 11:10:56 -06:00
Danny Ryan 69937849f9
Merge pull request #2259 from ethereum/fix-minimal-fork-versions
Altair testing fork version fixes
2021-03-22 11:04:21 -06:00
Danny Ryan 4407c594bf
Merge pull request #2258 from ethereum/justification-altair
reduce justification and finalization Altair diff
2021-03-22 11:03:32 -06:00
Danny Ryan bb85ef5a57
pr cleanup 2021-03-22 10:53:26 -06:00
protolambda 4dd855667a
fix mixed up formats. Output slots as ints, output genesis eth1 init data as yaml dict 2021-03-22 02:50:05 +01:00
protolambda 4a82a375ae
avoid altair fork version collision, update test prep, fix genesis state creator bug 2021-03-21 22:07:28 +01:00
protolambda 493dd17cc4
reduce justification and finalization Altair diff 2021-03-21 04:22:45 +01:00
Hsiao-Wei Wang a69ad6c2db
Merge pull request #2256 from ethereum/altair-validator-executable 2021-03-20 08:12:01 +08:00
Hsiao-Wei Wang 2ce389216d
Executable Altair validator guide 2021-03-19 23:38:59 +08:00
Alex Stokes 484fae3c2b
update constant name 2021-03-19 07:59:49 -06:00
Justin 053661ad20
Update beacon-chain.md 2021-03-19 10:04:46 +00:00
Alex Stokes 208a658305
Use different name for constant for sync committee aggregates 2021-03-18 15:53:57 -06:00
Danny Ryan 2f99d0b444
Merge pull request #2251 from ralexstokes/hoist-container-defns
Organize phase 0 validator guide type definitions
2021-03-17 12:50:25 -06:00
Danny Ryan 409cf0fb59
Merge pull request #2252 from ethereum/fix-gens
fix v1.1.0-alpha.1 test generators
2021-03-17 10:53:28 -06:00
Danny Ryan 1707978189
fix v1.1.0-alpha.1 generators 2021-03-17 10:32:23 -06:00
Alex Stokes c661ddf12c
hoist container definitions to preamble 2021-03-17 09:35:39 -06:00
Danny Ryan 3ce090f4be
Merge pull request #2230 from ethereum/dev
Altair pre-release v1.1.0-alpha.1
2021-03-16 21:15:13 -06:00
Danny Ryan e2c9a15aaf
Merge pull request #2246 from ethereum/sync_rewards
refactor sync committee rewards
2021-03-16 20:27:04 -06:00
Danny Ryan 5f2fa5b1ae
Merge pull request #2249 from ethereum/bump-version
bump version.txt to 1.1.0-alpha.1
2021-03-16 20:23:47 -06:00
Danny Ryan 7e1f7c392e
bump version.txt to 1.1.0-alpha.1 2021-03-16 20:03:19 -06:00
Danny Ryan 16b55c76da
Merge pull request #2244 from ethereum/altair-p2p
Altair P2P
2021-03-16 19:57:25 -06:00
Danny Ryan 337795b05b
Merge pull request #2201 from ralexstokes/add-hf1-val-guide-and-networking
Add Altair validator guide and initial p2p spec
2021-03-16 19:55:02 -06:00
protolambda 0fe5e1ef6e
update of req-resp, v2 sync methods, gossip topics 2021-03-17 00:54:29 +01:00
Alex Stokes 893134d2ab
Add validator guide and initial P2P spec for Altair 2021-03-16 17:37:42 -06:00
Hsiao-Wei Wang 1f927d553e
Merge pull request #2247 from ethereum/gen_runner_log_and_incomplete_tag
Enhance gen_runner error handler + check with `INCOMPLETE` temporary file
2021-03-17 02:55:33 +08:00
Hsiao-Wei Wang f360a9823f
Add Makefile commands `detect_generator_error_log` and `detect_generator_incomplete` 2021-03-17 02:45:52 +08:00
Hsiao-Wei Wang 2ee559eca1
Fix `SkippedTest` cases. Should remove the folder 2021-03-17 02:40:59 +08:00
Danny Ryan b0a9fc8277
clean up and extend sync committee rewards tests 2021-03-16 11:18:26 -06:00
Hsiao-Wei Wang d3c9eacd14
Disable MAINNET test_valid_signature_future_committee 2021-03-17 00:28:12 +08:00
Hsiao-Wei Wang c9de95541f
Use a dummy `INCOMPLETE` file to indicate that the test generation is incomplete 2021-03-17 00:28:09 +08:00
Justin Drake 27e88a2484 (WIP) refactor sync committee rewards 2021-03-16 15:30:25 +00:00
Danny Ryan 0a97f65729
Merge pull request #2243 from ethereum/fix-altair-gens
fix altair test generators
2021-03-16 08:26:29 -06:00
Danny Ryan 85d323c227
Merge pull request #2242 from ethereum/sync_aggregate
Define SyncAggregate to bundle sync committee bits and signature
2021-03-15 15:48:20 -06:00
protolambda 1eaa3c1742
Define SyncAggregate to bundle sync committee bits and signature, update tests to better isolate the state-change, introduce helper function for future tests, and update test doc 2021-03-15 21:55:36 +01:00
Danny Ryan 06eed71856
fix altair test generators 2021-03-15 13:10:19 -06:00
Danny Ryan 3e386184bc
Merge pull request #2241 from ethereum/altair-config
suffix ALTAIR on update constants
2021-03-15 12:12:11 -06:00
Danny Ryan 4afb6533a2
suffix ALTAIR on update constants 2021-03-15 11:46:53 -06:00
Hsiao-Wei Wang 8fdc0338ac
Merge pull request #2240 from ethereum/altair-genesis-tests
Enable Altair genesis tests + rename `SpecLightclient` -> `SpecAltair` + disable too slow test
2021-03-16 01:19:14 +08:00
Hsiao-Wei Wang 64dbcdce35
Use @with_all_phases 2021-03-16 01:10:18 +08:00
Hsiao-Wei Wang 734863a6d6
Skip mainnet genesis tests 2021-03-16 00:46:57 +08:00