Carl Beekhuizen
c2a4838f5a
Implments suggestions from review
2019-06-30 21:49:29 +02:00
Carl Beekhuizen
0fd1d38417
`Misc` function rename
2019-06-30 20:58:02 +02:00
Danny Ryan
daa624e977
Merge pull request #1237 from ethereum/helperscleanup
...
Helpers cleanup
2019-06-30 13:23:17 -05:00
Danny Ryan
6be1404b66
delayed_activation_exit_epoch -> compute_activation_exit_epoch
2019-06-30 13:16:56 -05:00
Danny Ryan
d1bc2f03ac
remove 'int' types from spec typehints. replace with uint64
2019-06-30 13:00:22 -05:00
Danny Ryan
3ae077a09b
'beacon state getters' -> ' beacon state accessors'
2019-06-30 12:51:13 -05:00
Danny Ryan
6d5e4da3e0
PR feedback
2019-06-30 12:42:24 -05:00
Justin Drake
0be2b8e620
Cleanup
2019-06-30 16:10:22 +01:00
Justin Drake
1daaf7412d
Merge branch 'helperscleanup' of github.com:ethereum/eth2.0-specs into helperscleanup
2019-06-30 14:46:29 +01:00
Justin Drake
423d6dcb29
Fix bug
2019-06-30 14:45:36 +01:00
Justin
bdb372ea21
Merge branch 'dev' into helperscleanup
2019-06-30 14:34:41 +01:00
Justin Drake
e873bb6e59
ready for review
2019-06-30 14:32:50 +01:00
Justin Drake
94404a5856
A few more cleanups
2019-06-30 14:11:46 +01:00
Justin Drake
58c864ddf4
Push draft
2019-06-30 11:01:54 +01:00
Justin Drake
e8532ced79
WIP
2019-06-30 10:56:14 +01:00
Carl Beekhuizen
2e41f2da3b
Merge pull request #1235 from ethereum/JustinDrake-patch-20
...
Minor copyedit
2019-06-30 11:17:35 +02:00
Justin Drake
369c457d76
WIP2
2019-06-30 10:11:23 +01:00
Carl Beekhuizen
14701aa094
Merge pull request #1234 from ethereum/JustinDrake-patch-14
...
Fix typo
2019-06-30 11:09:50 +02:00
Justin Drake
d0acd81157
WIP
2019-06-30 10:02:18 +01:00
Justin
ae888e148c
Minor copyedit
...
Can the linter catch non-capitalised comments?
2019-06-30 08:13:07 +01:00
Justin
6cfd3b5047
Fix typo
...
Thanks @NIC619 https://github.com/ethereum/eth2.0-specs/pull/1219#discussion_r298818138
2019-06-30 08:10:23 +01:00
Danny Ryan
2f43f9c339
Merge pull request #1202 from ethereum/test_genesis
...
Add `test_genesis.py` and fix `is_genesis_trigger`
2019-06-29 23:31:32 -05:00
Danny Ryan
f1749df587
minor typo
2019-06-29 22:25:51 -06:00
protolambda
4d5d5971e2
fix genesis tests; sign deposit-datas, and lower min validator count for testing
2019-06-30 02:10:18 +02:00
protolambda
8d2cbc9722
add comments to make variations in genesis initialization clear, and about the mix-in in verification
2019-06-30 02:08:34 +02:00
Hsiao-Wei Wang
47cdae4292
Refactor
...
1. Rename the current `get_genesis_beacon_state(...)` to `initialize_beacon_state_from_eth1(...)`
2. Extract `is_valid_genesis_state(state: BeaconState) -> bool` from `initialize_beacon_state_from_eth1(...)`
2019-06-30 06:38:30 +08:00
Danny Ryan
aec971928b
Merge pull request #1221 from ethereum/ralexstokes-patch-3
...
Clarify `get_randao_mix` accessor
2019-06-29 16:57:33 -05:00
Justin
2a2bd72425
Update 0_beacon-chain.md
2019-06-29 22:52:01 +01:00
Danny Ryan
f0e65709c2
Merge branch 'dev' into ralexstokes-patch-3
2019-06-29 15:50:29 -06:00
Danny Ryan
ded936ebad
quick comment on avoiding underflow
2019-06-29 15:49:11 -06:00
Danny Ryan
34ad123a46
Merge pull request #1206 from ethereum/cov-hunt
...
Test coverage improvements
2019-06-29 16:09:52 -05:00
Hsiao-Wei Wang
03a243e96c
fix basic test
2019-06-30 05:06:17 +08:00
Justin Drake
6d45513605
Make timestamp a uint64
2019-06-29 21:56:07 +01:00
Justin Drake
a356fc9fc8
Fixes
2019-06-29 21:53:04 +01:00
Justin Drake
43beb743e6
typo
2019-06-29 21:39:55 +01:00
Justin Drake
ada3cb2ae1
Fix genesis balance bug (git add -u)
2019-06-29 21:36:27 +01:00
Justin Drake
3a5872f8e4
Cleanups and fixes
2019-06-29 21:29:10 +01:00
protolambda
36dd977b85
fix finalize on double justification in 123 rule
2019-06-29 22:27:05 +02:00
Justin Drake
d00b5b9ea0
Merge is_genesis_trigger into get_genesis_state
2019-06-29 21:18:18 +01:00
Justin Drake
22476420f3
Cleanups; think about merging is_genesis_trigger into get_genesis_state
2019-06-29 21:03:15 +01:00
Hsiao-Wei Wang
12dff5349d
Renames:
...
1. `Deposit` log -> `DepositEvent` log
2. `get_deposit_root` -> `get_hash_tree_root`
2019-06-30 03:42:00 +08:00
protolambda
afb33ddc5b
fix typo in justification wording
2019-06-29 21:39:10 +02:00
protolambda
302b3afe2a
rename/fix roots in justification tests for consistency
2019-06-29 21:37:54 +02:00
Hsiao-Wei Wang
56caa48314
Should use Sequence
2019-06-30 03:27:25 +08:00
Hsiao-Wei Wang
125660c5af
Update input `deposits` type from `Sequence[Deposit]` to `List[Deposit, 2**DEPOSIT_CONTRACT_TREE_DEPTH` and fix tests
2019-06-30 03:20:11 +08:00
protolambda
ff185c3486
fix deposit state mocking for tests
2019-06-29 20:40:25 +02:00
Danny Ryan
33a0580253
Merge pull request #1230 from ethereum/JustinDrake-patch-14
...
Fix comment
2019-06-29 13:39:26 -05:00
protolambda
fb165dc14e
fixes a few tests, not all
2019-06-29 20:33:11 +02:00
protolambda
e4eebef3a4
fix broken deposits test, now same error as others
2019-06-29 20:09:43 +02:00
Hsiao-Wei Wang
354cd1c1e1
Clean up leftover and linter
2019-06-30 02:02:05 +08:00