0afa7e1b38
update language to reflect latest work on withdrawals
2022-03-15 18:01:47 -06:00
825a39577e
Merge pull request #2845 from ethereum/discard-equivocations
...
Remove equivocating validators from fork choice consideration
2022-03-08 11:41:04 -07:00
bd6d2ad4ce
minor copy edit
2022-03-08 11:33:59 -07:00
a0ba6b2a1a
Add note about syncing
2022-03-08 06:52:03 -08:00
15a90407ef
minor comment change
2022-03-03 13:50:05 -07:00
37b8a89bb1
Apply code review from @djrtwo
2022-03-03 11:43:52 -08:00
70e8243450
Update p2p-interface.md
2022-03-02 12:39:21 +08:00
7f31c80b8f
Fix lint & CI
2022-03-01 11:47:45 -08:00
4fbe162655
Add on_attester_slashing() and related test
2022-03-01 11:42:49 -08:00
3f2d5ecda7
Merge pull request #2838 from ethereum/revert-dupe-condition
...
revert removal of aggregate deduplication condition from #2183
2022-02-28 08:19:45 -07:00
03f0f6762a
revert removal of aggregate deduplication condition from #2183
2022-02-25 10:25:27 -07:00
9fb2dd16c1
Ignore attestations voting for the wrong finalized checkpoint
...
When nodes are syncing but have not yet reached the canonical `head`,
they cannot determine whether nodes they are connected to serve a valid
history or are making bogus claims in their `Status` advertisement.
Thus, the best course of action that a client can take is to vote for
its "current" best synced head, regardless of whether it's connected to
peers that claim to have other heads or not.
However, in the p2p spec, we penalize such peers with a `REJECT` - this
should be an `IGNORE` instead because this vote is correct per the spec,
albeit "late" according to the validating clients' view of the chain.
2022-02-11 17:12:13 +01:00
20c8d0d641
Update reserved libp2p error documentation
...
The spec reserves the libp2p error code range `[3, 127]` for future use
but actually defines error code `3` as `ResourceUnavailable`. This patch
updates the reserved range to `[4, 127]`.
2022-01-28 00:33:38 +01:00
2b45496fe4
clean up unused argument from `phase0`
2022-01-13 11:39:36 -08:00
8c226013fd
minor fix
2021-12-23 17:32:15 +08:00
41af639517
PR feedback from @mkalinin
2021-12-23 17:26:48 +08:00
200ed58dd9
Merge branch 'dev' into ex-ante-tests
2021-12-07 18:29:48 +08:00
3a9777eebc
Update specs/phase0/fork-choice.md
2021-12-02 14:00:06 -07:00
0d8fab3986
Apply Danny's suggestion
2021-12-02 09:57:28 -08:00
6f3379c7be
Apply HWW's suggestion
...
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-12-01 20:11:52 -08:00
3e2890bb3e
Apply proposer boost to ancestors correctly
2021-12-01 18:03:40 -08:00
0bc0769767
Simplify logic in calculating proposer score
2021-11-30 15:44:56 -05:00
d7f6a42729
[WIP] Add ex-ante fork choice test cases
2021-12-01 02:37:22 +08:00
395fdd4566
Merge pull request #2730 from ethereum/proposer-score-boost
...
Proposer LMD Score Boosting
2021-11-23 11:39:07 -07:00
2a5c9d8dc5
Set PROPOSER_SCORE_BOOST to 70%
2021-11-23 07:23:59 -08:00
44fec310b3
Eth1 block hashes have type Hash32 ( #2693 )
...
* Eth1 block hashes have type Hash32
* Modify other forks as well
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-11-23 08:20:26 -07:00
a0b5a809d5
Apply HWW code's review - fix is_before_attesting_interval
2021-11-23 07:02:04 -08:00
1d835c5198
Apply Danny's code review & suggestions
2021-11-22 14:44:52 -08:00
ea09df50db
toc
2021-11-22 11:39:08 -07:00
282d85b9e7
simplify on_tick proposer boost update
2021-11-22 11:31:44 -07:00
cebe6ba7e7
minor formatting cleanups
2021-11-22 11:31:17 -07:00
88c76abd7f
Apply Danny's code review
2021-11-22 11:12:25 -07:00
859bbf4358
This reverts commit 4c726cdff39a10c5d096b294fb562cfc99c1f068.
2021-11-22 11:12:24 -07:00
3b20e3ea02
Apply suggestions from code review
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2021-11-22 11:12:24 -07:00
b0fb861cf5
Make PROPOSER_SCORE_BOOST a percentage value
2021-11-22 11:12:24 -07:00
504d82cc1a
Add datatype to new parameters
2021-11-22 11:12:24 -07:00
47fa6d108a
Add parameter for score boost value
2021-11-22 11:12:24 -07:00
281c1b2d1a
Update validator guide with ATTESTATION_OFFSET_QUOTIENT
2021-11-22 11:12:24 -07:00
2d161b4244
Add proposer score boosting & related tests
2021-11-22 11:12:24 -07:00
3d4ece44df
port phase0 forkchocie changes to merge
2021-11-17 18:37:45 -07:00
eb00f8f735
cleanup forkchoice tests
2021-11-17 18:24:47 -07:00
d9e8306c5a
Refactoring
2021-11-13 18:38:53 +08:00
f643554aa5
Fix issue around on_attestation validation by skipping epoch scope
...
validation if attestation is from a block message
2021-11-13 18:28:05 +08:00
cd3d2ce692
working through test issues
2021-11-12 12:43:54 -07:00
46f7845c42
Fixed link to Attesting in beacon chain responsibilities
2021-11-06 16:28:13 +01:00
d0bcf294a8
Fix typo
2021-10-28 18:42:16 +08:00
15a6c48a46
Merge pull request #2518 from ethereum/fix-store-justified-checkpoint
...
Fix fork choice store checkpoints inconsistency issue
2021-08-23 23:41:11 +08:00
206126644f
More fixes
2021-08-19 23:34:54 +08:00
59d8ee34f9
Update some "1.0" "2.0" wording
2021-08-19 23:24:04 +08:00
4c1156d504
rename eth1 and eth2 throughout specs and readme where reasonable
2021-08-18 17:13:24 -06:00
6ffc735642
Merge branch 'dev' into fix-store-justified-checkpoint
2021-08-17 21:28:42 +08:00
43a1617ffa
Ensure that the given PKs are valid PKs + fix typos
2021-08-04 21:25:37 +08:00
63ca480ea3
Add condition check in `on_tick` to ensure that `store.justified_checkpoint` is a descendant of `store.finalized_checkpoint`
2021-07-14 20:02:28 +08:00
bca467c926
fmt
2021-05-21 14:36:43 -06:00
5bf01c4298
add resourceunavailable error code with more guidance
2021-05-21 14:24:58 -06:00
ff021da551
change line formatting, new refence as config var implicitly takes more space
2021-05-19 17:21:30 +02:00
291168e1e3
clarify config/preset separation, address review comments by @djrtwo
2021-05-19 17:15:34 +02:00
2c7a68406f
update config section markdown table header
2021-05-18 09:55:25 +02:00
e4593d2d0c
update with configs<>presets separation
2021-05-18 09:55:20 +02:00
b9ffd8f640
Phase0 constant/config/preset separation
2021-05-18 09:20:41 +02:00
110e6b38ee
remove resourceunavailable for more discussion
2021-05-14 08:07:08 -06:00
f52f067b8e
add resourceunavailable error code
2021-05-12 08:36:27 -06:00
82b7a7be3b
Apply suggestions from code review
...
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Jacek Sieka <jacek@status.im>
2021-05-12 08:29:42 -06:00
488ceed4f9
add notes about repeatedly failing tos erve blocks as being disconncetable
2021-05-11 11:29:37 -06:00
5792afca46
Merge branch 'dev' into bbr-ws
2021-05-11 09:51:57 -06:00
c7166a37af
change eth1data block_hash type to Hash32 in phase 0
2021-04-15 06:47:11 -05:00
b2f42bf4d7
broadast -> broadcast
2021-04-05 17:05:59 -07:00
ed6358a719
Merge pull request #2248 from hukkinj1/dev
...
Fix list indentation
2021-03-30 07:32:35 -06:00
07b7774241
misc. phase1 modules refactor updates
2021-03-30 01:46:02 +02:00
b23b16c7b7
Fix list indentation
2021-03-29 01:10:36 +03:00
020895e35d
Typing problems fixes ( #2271 )
...
* Typing problem fixed: `process_block_header` passes `Bytes32()` to `state_root` of `BeaconBlockHeader`, which type is `Root`
* Typing problem fixed in `initialize_beacon_state_from_eth1`: `len` returns an `int` value, while `deposit_count=uint64` of `Eth1Data` has type `uint64`
* Typing problem fixed in `process_rewards_and_penalties`: `numerator` of type `int` passed to `weight` parameter of `get_flag_index_deltas`, which has type `uint64`
* Typing problem fixed in `process_attestation`; `False` passes as `crosslink_success` parameter of `PendingAttestation`, which has type `boolean`. `False` is an instance of `(python.)bool` and is not an instance of `(ssz.)boolean`
* Typing problem fixed: `shard_data_roots` of `ShardTransition` has type `List[Bytes32]`, but its elements are used as if they were `Root` values, e.g. in `process_chunk_challenge` method: passed to `data_root` of `CustodyChunkChallengeRecord` which has type `Root`
* Typing problem fixed in `process_custody_final_updates`: `index` has type `int`, while `validator_indices_in_records` has type `Set[ValidatorIndex]`, so tesing whether `index in validator_indices_in_records` can be risky, depending on implementation details. `ValidatorIndex(index) in validator_indices_in_records` is a safer variant.
* Typing problem fixed: `slashed` parameter of `pack_compact_validator` has type `(python.)bool`, however in `committee_to_compact_committee` a value of `(ssz.)boolean` is passed as a value of the parameter
* Typing problem fixed: `inactivity_scores` is a `List[uint64,...]`, while it is intialized/appended with values of `(python.)int` type
* fixed according to @protolambda suggestions
* changed types of _WEIGHT constants and appropriate variables/parameters, according to @protolambda suggestions
* revert code formatting back
* Introduced ZERO_ROOT according to @protolambda 's suggestion
* Reverted back to , according to @protolambda comments
2021-03-25 22:03:21 +01:00
bb85ef5a57
pr cleanup
2021-03-22 10:53:26 -06:00
493dd17cc4
reduce justification and finalization Altair diff
2021-03-21 04:22:45 +01:00
c661ddf12c
hoist container definitions to preamble
2021-03-17 09:35:39 -06:00
b8bf7f0f80
Merge pull request #2236 from ethereum/justin_altair_cleanups
...
Altair cosmetic cleanups plus a couple substantive changes
2021-03-15 08:57:35 -06:00
e7ebd08d69
Altair cosmetic cleanups plus a couple substantive changes
2021-03-15 11:08:41 +00:00
dd341adc20
remove faulty de-duplication condition for seen aggregates
2021-03-10 18:55:21 -07:00
e1023f55d1
Fix a small typo
2021-03-05 18:05:15 -08:00
63e014791c
Merge branch 'dev' into dev-merge
2021-02-24 16:23:04 -07:00
396d399129
Apply suggestions from code review form @hwwhww
...
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-02-24 08:53:54 -06:00
b789b10397
Minor update ToC
2021-02-23 16:31:19 -07:00
1f7e9fabf2
minor 0x01 PR feedback
2021-02-23 16:16:46 -07:00
a0ae048395
copy edits
2021-02-23 16:16:46 -07:00
5992e8ff05
Update deposit-contract.md
2021-02-23 16:16:46 -07:00
809fc7afaf
Update validator.md
2021-02-23 16:16:45 -07:00
1f8ca7179f
Update validator.md
2021-02-23 16:16:45 -07:00
80613a99bd
Update validator.md
2021-02-23 16:16:45 -07:00
0f94fa51b8
Update validator.md
2021-02-23 16:16:45 -07:00
e93f1e1fa8
Copy-edit deposit-contract.md
2021-02-23 16:16:45 -07:00
47ebf438b3
Cleaner section title
...
"Withdrawal prefixes" matches `[BLS]/[ETH1_ADDRESS]_WITHDRAWAL_PREFIX`
2021-02-23 16:16:45 -07:00
128efdd34d
Fix table for withdrawal credentials prefixes
...
Minor cosmetic fixes (misformated table, section title).
2021-02-23 16:16:45 -07:00
7af50cc827
add eth1 withdrawal credentials to spec
2021-02-23 16:16:35 -07:00
8ec082fcf9
Merge pull request #2149 from ethereum/0x01-creds
...
Eth1 withdrawal credentials (0x01)
2021-02-16 13:06:34 -06:00
7050cb0add
minor 0x01 PR feedback
2021-02-16 11:55:01 -07:00
7d715220bb
Don't propagate blocks with a faulty slot ( #2196 )
2021-02-10 12:39:42 -07:00
0fd0db1ffc
Fix some typos ( #2195 )
...
* Fix typo for P2P Networking document
* Fix link typo of P2P networking document
* fix typo for light clients beacon chain document
2021-02-06 06:20:35 -07:00
fe52f377e6
Merge pull request #2190 from ethereum/update-ws-calc
...
Updated Weak Subjectivity Calculations
2021-02-04 10:23:08 -06:00
8b217d9277
Fix typo
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2021-02-02 12:17:56 -08:00
a28f52729d
Rename variables for clarity
2021-01-27 15:58:19 -08:00
742d21e914
Updates based on review
2021-01-27 15:16:15 -08:00
Alex Stokes
Danny Ryan
Aditya Asgaonkar
Nishant Das
Jacek Sieka
Etan Kissling
Hsiao-Wei Wang
Aditya Asgaonkar
realbigsean
Ben Edgington
Fredrik Svantes
protolambda
terence tsao
Taneli Hukkinen
Alex Vlasov
Justin Drake
Hsiao-Wei Wang
Paul Hauner
Phong Phan