Commit Graph

5478 Commits

Author SHA1 Message Date
Alex Stokes b94af435da Refactor helpers into separate module 2021-01-06 09:45:17 -08:00
Danny Ryan ca35773d2b
Merge pull request #2178 from ethereum/ralexstokes-patch-1
Bugfix in sync committee proposer rewards
2021-01-06 10:47:28 -06:00
Alex Stokes a3bf632b4f
Bugfix in sync committee proposer rewards
The variable used to accumulate proposer rewards across the sync committee processing was shadowed by the per-participant proposer reward.

This means the total proposer reward would simply be twice the output of `get_proposer_reward` for the last participant in the sync committee.

I believe we want to sum all contributions to the proposer reward across sync committee participants which is what this PR does.
2021-01-06 08:39:21 -08:00
Hsiao-Wei Wang 5cb47a4ecb
Merge pull request #2173 from farazdagi/ws-fix-typo
Fix typo
2021-01-06 13:34:43 +08:00
Victor Farazdagi 70e25e6390
Update specs/phase0/weak-subjectivity.md
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-01-05 21:13:35 -08:00
Hsiao-Wei Wang 844c879f1c
Bump `py_ecc` and `milagro_bls_binding` (#2169)
* Bump py_ecc to v5.1.0 and milagro_bls_binding to v1.6.2

* python3.8 -> python3 for py39 compatibility

* fix

* Try python:3.9

* Revert: using Python3.8 in CI now
2021-01-05 21:00:52 +08:00
Victor Farazdagi 7d60e482b9 fix typo 2021-01-05 08:48:25 +03:00
Danny Ryan 86f616b607
Merge pull request #2162 from ethereum/ralexstokes-patch-1
Refactor sync committee rewards to use helper
2021-01-03 11:00:14 -06:00
Danny Ryan 951ee08569
Merge pull request #2165 from SifraiHQ/dev
Updated Sharding technical details link in readme.
2021-01-03 10:57:35 -06:00
Saulius Grigaitis 6a8cb48f49 Updated Sharding technical details link in readme. 2020-12-27 00:20:08 +02:00
multisignature cc80dd758c
Update README.md (#2164)
* Update README.md

I've removed an incorrectly placed comma.

Since the comma is placed before 'and', and the conjunction isn't being used to either a) denote the last element of a list with more than two elements or b) separate two independent clauses, it's not necessary here.

* Update validator.md

Fixed a couple of minor errors.
2020-12-26 14:53:42 +08:00
Alex Stokes edfd04c212
Refactor sync committee rewards to use helper
This change is functionally equivalent but uses the helper we already have for proposer rewards.

The argument for this change is better encapsulation of the reward which makes it easier in general to reason about properties of the spec ("are the attestation proposer rewards and the sync committee proposer rewards equivalent?") and a single point of maintenance in the event that rewards get refactored in the future (which makes refactoring safer overall).
2020-12-22 10:42:59 -08:00
Hsiao-Wei Wang 2ef55744df
Merge pull request #2158 from ethereum/ralexstokes-patch-1
Update names in pyspec README
2020-12-21 21:41:53 +08:00
Hsiao-Wei Wang 114965cdf0
Merge pull request #2160 from benjaminion/fix-typo
Fix typo
2020-12-21 21:40:01 +08:00
Ben Edgington 452e3301be Fix typo 2020-12-21 10:22:04 +00:00
Alex Stokes 71c5eb5c2f
Update names in pyspec README
Names for pip categories have been updated
2020-12-18 11:11:44 -08:00
vbuterin aa16da1099
Updated readme (#2157) 2020-12-18 19:03:05 +08:00
Danny Ryan f137bb037a
Merge pull request #2130 from ethereum/vbuterin-patch-2
Added standalone light client patch
2020-12-17 07:53:33 -06:00
Danny Ryan aabc010da6
Merge pull request #2156 from ethereum/lc-tests
light client tests
2020-12-17 07:44:34 -06:00
Danny Ryan 89c5ca6bcd
'light_client' -> 'sync_committee' 2020-12-17 06:30:36 -07:00
Danny Ryan cc9a4cdc46
add base sanity light client tests 2020-12-16 17:14:42 -07:00
Hsiao-Wei Wang e63c96416a
Add a FIXME comment. 2020-12-16 15:10:54 +08:00
Hsiao-Wei Wang acfe49e3f3
executable light client patch: beacon-chain.md (#2141)
* Bump remerkleable to 0.1.18

* Disable `sync-protocol.md` for now. Make linter pass

* Enable lightclient tests

* Use *new* `optional_fast_aggregate_verify`

* Fix ToC and codespell

* Do not run phase1 tests with Lightclient patch

* Fix the Eth1Data casting bug. Add a workaround.

* Fix `run_on_attestation` testing helper

* Revert

* Rename `optional_fast_aggregate_verify` to `eth2_fast_aggregate_verify`

* Apply Proto's suggestion

* Apply Danny's suggestion

* Fixing tests

* Fix after rebasing

* Rename `LIGHTCLIENT` -> `LIGHTCLIENT_PATCH`

* New doctoc

* Add lightclient patch configs

* fix gitignore light client patch generator output

* Upgrade state for light client patch

* Add `lightclient-fork.md` to deal the fork boundary and fix
`process_block_header`

* Misc cleanups

1) Add a summary note for every function that is changed.
2) Avoid changing `process_block` (instead only change `process_block_header`).
3) Rename `G2_INFINITY_POINT_SIG` to `G2_POINT_AT_INFINITY` to avoid `SIG` contraction.
4) Misc cleanups

* Update block.py

* Update beacon-chain.md

* Fix typo "minimal" -> "mainnet"

Co-authored-by: Marin Petrunić <mpetrunic@users.noreply.github.com>

* Use the new `BeaconBlockHeader` instead of phase 0 version

* Update config files

* Move `sync_committee_bits` and `sync_committee_signature` back to `BeaconBlockBody`

Co-authored-by: protolambda <proto@protolambda.com>
Co-authored-by: Justin <drakefjustin@gmail.com>
Co-authored-by: Marin Petrunić <mpetrunic@users.noreply.github.com>
2020-12-15 13:18:20 +08:00
Danny Ryan 99934ee16c
Merge pull request #2143 from ethereum/JustinDrake-patch-5
Cosmetic cleanups to BLS signatures section
2020-12-08 07:40:48 -06:00
Justin f2fe390638
secret_key => privkey 2020-12-08 09:20:50 +00:00
Hsiao-Wei Wang 2a37e96b39
Merge pull request #2145 from ethereum/disbable-deposit-contract-tests
Disable the deposit contract tests.
2020-12-08 03:13:34 +08:00
Hsiao-Wei Wang 1a30ea9da9
Merge branch 'dev' into vbuterin-patch-2 2020-12-08 00:24:55 +08:00
Justin 0b9e80d1eb
grammar 2020-12-07 23:15:34 +08:00
Danny Ryan 3b7c02514b
straightforward light client edits 2020-12-07 08:10:39 -07:00
Justin 56048cbf56
Cosmetic cleanups to BLS signatures section
Miscellaneous cosmetic cleanups to the " BLS signatures" section:

1) fix section capitalisation for spec consistency
2) avoid uncapitalised "eth2" for spec consistency
3) avoid contractions (such as `PK` for `pubkey`) for spec consistency
4) various copyedits
2020-12-07 07:28:01 -07:00
Hsiao-Wei Wang b817b7690c
Disable the deposit contract tests.
Only keep the `build_deposit_contract` to verify the bytecode.
2020-12-07 07:26:37 -07:00
Danny Ryan 02f388fe86
Merge pull request #2144 from ethereum/bump_codespell_doctoc
Bump codespell and doctoc
2020-12-07 08:25:45 -06:00
Hsiao-Wei Wang 64412be0d7
Minor update ToC 2020-12-07 11:10:19 +08:00
Hsiao-Wei Wang 8587e8c5f2
Fix doctoc@2 version 2020-12-07 11:10:11 +08:00
Hsiao-Wei Wang 7bf5539b2f
Set codespell<3.0.0,>=2.0.0 version and add `ether` to whitelist 2020-12-07 11:08:54 +08:00
Justin b2d25f7454
Nitpicks 2020-11-25 11:59:01 +00:00
vbuterin 5bfe61f865
Embiggened sync committee size and added sub-aggregates 2020-11-25 19:38:45 +08:00
Diederik Loerakker cd3a39a84a
Merge pull request #2139 from MicahZoltu/patch-1
Redirects implementation list to one that is actually maintained.
2020-11-22 20:51:17 +01:00
Micah Zoltu bf48c1ce79
Redirects implementation list to one that is actually maintained.
Unmaintained lists are bad, especially when there is a maintained one elsewhere.  Lets keep a single list.

@protolambda
2020-11-22 14:12:32 +08:00
Justin 09ec58131d
Optimised updates as suggested by @vbuterin 2020-11-18 10:33:42 +00:00
Justin d16900a753
Fixes from @ralexstokes 2020-11-18 09:31:41 +00:00
Justin 664bc4b42e
Polish and fixes including fixed-size sync committees 2020-11-18 09:19:32 +00:00
vbuterin 171b21301b
Added support for updates that point to finalized ancestors 2020-11-18 16:27:19 +08:00
vbuterin 830efa496a
Removed compact validators, make committee balance-based 2020-11-18 16:15:30 +08:00
Justin 5e717a456d
More polish and fixes 2020-11-17 15:30:09 +00:00
Justin 7ffc9c5bc0
More polish and fixes to the sync protocol 2020-11-17 14:18:58 +00:00
Justin 99219c874f
Revamp minimal light client (lots of polish and some bug fixes) 2020-11-17 12:42:09 +00:00
vbuterin 692a0aaaa5
Update specs/lightclient/sync-protocol.md
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
2020-11-17 13:26:26 +08:00
vbuterin 5e5d03d56f
Update specs/lightclient/sync-protocol.md
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
2020-11-17 13:26:18 +08:00
vbuterin 1c146b2c03
Update specs/lightclient/sync-protocol.md
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
2020-11-17 13:26:08 +08:00