Commit Graph

69 Commits

Author SHA1 Message Date
kevaundray a3a6c916b2
Remove proof parameter from `recover_cells_and_kzg_proofs` (#3819) 2024-06-27 14:17:14 -05:00
Hsiao-Wei Wang 483a286ba5
Remove `assert len(missing_cell_indices) != 0` check 2024-06-14 23:57:33 +08:00
Benedikt Wagner 77eac20df6
Update specs/_features/eip7594/polynomial-commitments-sampling.md
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2024-06-13 17:20:04 +02:00
Benedikt Wagner 1c675ae4a1
Update polynomial-commitments-sampling.md - Fix dead link 2024-06-13 16:30:05 +02:00
kevaundray 6efab19ad0
chore: Refactor cell recovery code (#3781)
* multi:

- Remove shift_polynomial_coeff
- Remove recover_shifted_data
- Remove recover_original_data
- Move `zero_poly_eval_brp ` under sanity check comment as its only used for sanity checking

* chore: remove sanity check -- this was doing a wasteful `compute_root_of_unity` operation

* chore: add previous sanity check as a unit test

* chore: copy values python was taking a reference, so it passes in our regular codepaths but not in isolated test

* chore: add coset_fft test

* Update specs/_features/eip7594/polynomial-commitments-sampling.md

Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>

* Update specs/_features/eip7594/polynomial-commitments-sampling.md

Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>

* chore: linter

* chore: asn (switch to bls_modular_inverse)

* chore: (ben) rename func to test_construct_vanishing_polynomial

* chore: (ben) rename `extended_evaluations_coeffs` to `extended_evaluation_times_zero_coeffs`

* chore: compute `roots_of_unity_extended` in recover_data method

* chore: add more comments explaining whats happening in recover_data

* chore: compute_zero_poly_coeff in recover_data

* chore: make lint

* chore: add doc comment to coset_fft_field

* chore: (ben) add code to generate the vanishing polynomial when all cells are missing

* chore: remove handling of edge case when constructing a vanishing polynomial

* chore: rename H(x) to Q_3(x)

* chore: remove trailing whitespace

* chore: add whitespace between comments

* chore: (asn) add assert that num missing cells is not 0

* chore: (justin) address comments

* chore: merge resolution

* chore: fixup remaining IDs -> indices

* chore: use indice nomenclature in tests

---------

Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
2024-06-11 20:26:19 +03:00
Justin Traglia 93dfcdaf4c Remove compute_cells from list of public methods 2024-06-11 19:17:46 +03:00
George Kadianakis 10bac07b39 Remove compute_cells method 2024-06-11 19:17:43 +03:00
George Kadianakis 7b7ada7d46
Merge pull request #3797 from jtraglia/rename-cellid-to-cellindex
Rename `CellID` to `CellIndex`
2024-06-11 18:45:32 +03:00
Benedikt Wagner c5e9c3cb4e
Add public methods section in KZG spec (#3795) 2024-06-11 07:43:40 -05:00
Justin Traglia d137553f96 Rename CellID to CellIndex 2024-06-11 07:41:52 -05:00
Justin Traglia 5ace424cd8
`recover_cells_and_kzg_proofs` & matrix refactor (#3788)
* Recover cells and proofs & matrix clean up

* Fix table of contents

* Update reference tests generator

* Update test format

* Remove unused imports

* Fix some minor nits

* Rename MatrixEntry's proof to kzg_proof

* Move RowIndex & ColumnIndex to das-core
2024-06-11 14:52:24 +03:00
b-wagn ac105f472a update polynomial-commitments-sampling.md -- fix shift_polynomialcoeff 2024-06-06 16:36:03 +02:00
George Kadianakis fdeff744ff
EIP-7594: Add a missing check and a missing test vector (#3765) 2024-05-14 17:18:14 +03:00
kevaundray e7b49dc670
chore: Add type casts reducing the diff for #3697 (#3734) 2024-04-29 08:14:55 -05:00
Justin Traglia b4188829b3 Rename compute_cells_and_proofs to compute_cells_and_kzg_proofs 2024-04-25 21:57:22 -05:00
Justin Traglia 4f66521208 Fix parameter indentations 2024-04-25 17:34:10 -05:00
Justin Traglia ac1ce3b3f0 Rename verify_cell_proof to verify_cell_kzg_proof 2024-04-25 17:31:22 -05:00
Alex Stokes b13e03e671
Merge pull request #3714 from kevaundray/kw/use-optimized-bls-msm
chore: use py-arkworks's multi-exp method inside of `g1_lincomb` and `g2_lincomb`
2024-04-23 11:57:13 -06:00
Kevaundray Wedderburn f3302a3836 - return serialized identity points
- result = None initially
2024-04-23 15:11:46 +01:00
Kevaundray Wedderburn d28a0164d2 add is_zero check 2024-04-23 14:55:37 +01:00
Kevaundray Wedderburn 5eb19b3cef modify g1_lincomb and g2_lincomb 2024-04-23 14:21:54 +01:00
Kevaundray Wedderburn 5a74f40442 g2_lincomb uses g2_multi_exp 2024-04-23 13:38:27 +01:00
Justin Traglia 73637c84b2
EIP-7594: Add asserts for public functions (#3684)
* Add length asserts for public PeerDAS functions

* Fix cell asserts

* Rename field variable to satisfy linter

* Add asserts for row/column indices

* Use CELLS_PER_EXT_BLOB

* Update to work with new spec changes

* Fix indentation

* Add explict check for cell_id
2024-04-23 12:12:26 +03:00
kevaundray e51f7df77d
chore: make list copy explicit in `divide_polynomialcoeff` (#3706) 2024-04-22 10:43:04 -05:00
Justin Traglia bcd0a09e68
Integrate new Coset/CosetEvals types (#3701)
* Add CellBytes type

* Use ByteVector, not Vector

* Fix tests

* Replace b"" with []

* Apply suggestions for bytes_to_cell

* Add/integrate new CosetEvals type

* Remove accidental new line

* Fix recover_all_cells

* Fix recover_matrix

* fix CosetEvals abstraction leak

* Introduce internal Coset type for `coset_for_cell()`

* Use CosetEvals in compute_kzg_proof_multi_impl()

* update test

* satisfy linter

* Fix two nits I noticed

---------

Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Co-authored-by: George Kadianakis <desnacked@riseup.net>
2024-04-22 17:03:57 +03:00
kevaundray 5c561722b8
add BLS_MODULUS to places where we subtract two integers (#3709) 2024-04-22 15:57:52 +03:00
George Kadianakis 0ffd0ca432
Merge pull request #3703 from kevaundray/kw/add-comment-for-verify-kzg
chore: Add more docs for the kzg verify algorithm
2024-04-22 12:46:12 +03:00
Kevaundray Wedderburn dca048d8df push @asn-d6 suggestions 2024-04-22 09:57:58 +01:00
kevaundray 0e4fc984ef
Remove unused return value (#3704) 2024-04-19 20:16:19 -05:00
Kevaundray Wedderburn 4684c5748c add comment for verify algorithm 2024-04-19 19:19:17 +01:00
Justin Traglia bc69c357b4
Merge pull request #3702 from kevaundray/kw/fix_recover_polynomial
Change `recover_polynomial` to `recover_all_cells`
2024-04-19 12:54:21 -05:00
Kevaundray Wedderburn 32cbda9de2 rename to recover_all_cells 2024-04-19 12:50:22 +01:00
Kevaundray Wedderburn 33dfa88160 fix bad merge 2024-04-19 12:07:58 +01:00
Kevaundray Wedderburn c2b7c0b414 Merge branch 'dev' into kw/optimize-compute-kzg-proof-multi 2024-04-19 12:04:15 +01:00
Hsiao-Wei Wang 9c04cf13c9
Merge pull request #3695 from kevaundray/kw/fix-kzg-multi-comment
chore: Fixes and elaborates on comments for `compute_kzg_proof_multi`
2024-04-19 15:32:09 +09:00
Hsiao-Wei Wang 0b312cae8b
Merge pull request #3692 from kevaundray/patch-11
chore: Change g2_lincomb to take in G2Points
2024-04-19 15:30:22 +09:00
kevaundray 8e3500b2b5
Update specs/_features/eip7594/polynomial-commitments-sampling.md
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
2024-04-18 20:26:52 +01:00
kevaundray 1669723adf
Update specs/_features/eip7594/polynomial-commitments-sampling.md
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
2024-04-18 20:26:46 +01:00
Kevaundray Wedderburn 6c8955d4bc chore: fix comment 2024-04-18 18:12:15 +01:00
Kevaundray Wedderburn 912038bb08 modify cell proofs comment 2024-04-18 18:11:41 +01:00
Kevaundray Wedderburn 4d073f10a2 remove remainder polynomial when in monomial form 2024-04-18 18:00:01 +01:00
Kevaundray Wedderburn d913140164 fix comments for kzg_proof_multi 2024-04-18 17:52:33 +01:00
Kevaundray Wedderburn 3b889645ff number of cells in an extended blob 2024-04-18 17:38:04 +01:00
kevaundray 45e70747bb
Update polynomial-commitments-sampling.md 2024-04-18 15:02:30 +01:00
Hsiao-Wei Wang 8728561da3
Merge branch 'dev' into peer-das 2024-04-04 22:23:02 +09:00
George Kadianakis 4b6b07b73e PeerDAS: Use FIELD_ELEMENTS_PER_EXT_BLOB in def of PolynomialCoeff 2024-03-12 15:07:42 +02:00
George Kadianakis c71fb00c8e PeerDAS: Check for degree overflow in multiply_polynomialcoeff() 2024-03-08 18:04:55 +02:00
Hsiao-Wei Wang 90afb238ed
Update specs/_features/eip7594/polynomial-commitments-sampling.md 2024-02-14 20:51:50 +08:00
George Kadianakis 385b0f35ac
Update specs/_features/eip7594/polynomial-commitments-sampling.md
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
2024-02-06 13:10:31 +02:00
George Kadianakis f1dd735784
Update specs/_features/eip7594/polynomial-commitments-sampling.md
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
2024-02-06 13:10:24 +02:00