Commit Graph

2933 Commits

Author SHA1 Message Date
Justin d7e628e08f
WIP! 2019-08-28 22:57:24 +01:00
dankrad 5f1cdc4acc
Merge pull request #1384 from ethereum/length-check-fix
Remove bug bitlist length checks in process_attestation
2019-08-28 13:44:44 +01:00
Justin Drake c8c47e3986 Abstract away compute_proposer_index for phase 1 2019-08-28 10:22:34 +01:00
Danny Ryan 78a0e15e9c
explicitly cast to bool 2019-08-27 10:36:25 -06:00
Danny Ryan d0b4dc2b01
remove bad length checks from process attestation; ensure committee count and committee size not equal 2019-08-27 09:16:02 -06:00
Justin 334d6c6bc7
Revamp 1_shard-data-chains.md
WIP!

* Significant simplifications
* A few bug fixes
* Lots of cleanups and reorganising (making it consistent with `0_beacon-chain.md`)
* Likely a few bugs introduced
2019-08-27 14:58:28 +01:00
Hsiao-Wei Wang 979fa38ae8
fix linter error 2019-08-27 20:10:55 +08:00
Hsiao-Wei Wang 17702e6d88
Shard slot -> slot for PHASE_1_FORK_SLOT part2 2019-08-27 20:10:39 +08:00
vbuterin 0f2e814c63
Shard slot -> slot for PHASE_1_FORK_SLOT 2019-08-27 13:19:04 +02:00
vbuterin 0b38ff0fe2
Update specs/core/1_beacon-chain-misc.md
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-08-27 13:17:38 +02:00
vbuterin ab4820ced6
Update specs/core/1_beacon-chain-misc.md
Co-Authored-By: John Adler <adlerjohn@users.noreply.github.com>
2019-08-27 13:13:47 +02:00
Dankrad Feist 4768ec89f6
SSZ clarifications on deserialization 2019-08-27 11:45:17 +01:00
terence tsao 79e34a00e8
Update sync_protocol.md 2019-08-26 17:37:18 -07:00
Danny Ryan ffdc36920e
lint 2019-08-26 08:55:50 -06:00
Danny Ryan 2abb81d4e9
Merge pull request #1366 from ethereum/remove-val-api
remove Val API and add links to outside spec/standards repos
2019-08-26 08:41:56 -06:00
vbuterin f1caa85aaf
Update specs/core/1_beacon-chain-misc.md
Co-Authored-By: John Adler <adlerjohn@users.noreply.github.com>
2019-08-26 10:09:43 +02:00
vbuterin 9b3cb306e3
Update specs/core/1_beacon-chain-misc.md
Co-Authored-By: John Adler <adlerjohn@users.noreply.github.com>
2019-08-26 10:09:13 +02:00
Hsiao-Wei Wang 01af8e6297
Use `get_previous_power_of_two` from merkle proofs spec 2019-08-25 17:19:19 +08:00
Hsiao-Wei Wang 178dd23314
`MINOR_REWARD_QUOTIENT` for rewarding the proposer for including shard receipt proof
Co-Authored-By: vbuterin <v@buterin.com>
2019-08-24 20:26:35 +08:00
vbuterin a509c68c30
Update specs/core/0_beacon-chain.md 2019-08-24 13:55:35 +02:00
vbuterin 7175ac5593
Update specs/core/0_beacon-chain.md 2019-08-24 13:55:18 +02:00
vbuterin fb59160e6a
Persistent -> period, process_shard_receipt: add _proofs 2019-08-24 13:54:48 +02:00
vbuterin b6d854de09
Fix ToC 2019-08-24 13:50:57 +02:00
Danny Ryan 6923bdc46a
remove Optional None from get_generalized_index. instead throw 2019-08-23 14:49:19 -06:00
Danny Ryan a4f86a8b24
Merge branch 'dev' into vbuterin-patch-13 2019-08-23 14:18:00 -06:00
Hsiao-Wei Wang f8d9b0d283
Merge branch 'dev' into roots-removal 2019-08-24 03:10:02 +08:00
Hsiao-Wei Wang 17043891ff
Fix some mypy errors 2019-08-24 03:03:00 +08:00
Hsiao-Wei Wang bcdbf7dfc7
Fix some flake8 errors 2019-08-24 02:44:22 +08:00
Hsiao-Wei Wang 72b9781051
Merge branch 'dev' into vbuterin-patch-13 2019-08-24 02:37:19 +08:00
Danny Ryan 56954ec508
fix adding fields to phase 1 ssz objects 2019-08-23 12:16:57 -06:00
Danny Ryan 1392c931d0
add GeneralizedIndex to custom types 2019-08-23 12:00:01 -06:00
Danny Ryan 3d97160098
Update specs/networking/p2p-interface.md
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2019-08-23 18:33:18 +02:00
Danny Ryan 0547d0ce67
add note on local aggregation for interop 2019-08-23 18:33:18 +02:00
Danny Ryan f62aedec31
minor formatting 2019-08-23 18:33:18 +02:00
Age Manning 194f292348
Minor corrections and clarifications to the network specification 2019-08-23 18:33:18 +02:00
JSON dee70df3a9
doc standardization for networking spec (#1338)
* Update p2p-interface.md

* Update p2p-interface.md

* Update p2p-interface.md

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-08-23 18:33:17 +02:00
Jacek Sieka 94d2368970
discuss length-prefixing pro/con, consider for removal, add link 2019-08-23 18:33:17 +02:00
Jacek Sieka f0ce20b922
cleanups 2019-08-23 18:33:17 +02:00
Jacek Sieka 26ea675f9c
Updates
* constants -> configurations
* constant name updates
* initial validation requirement for attestations
* allow aggregated attestations to be published
* move discv5 down a bit
* additional rationale
2019-08-23 18:33:17 +02:00
Raúl Kripalani d0e1f29beb
apply more editorial suggestions.
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-08-23 18:33:17 +02:00
Raúl Kripalani e147684907
apply editorial suggestions.
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
Co-Authored-By: Preston Van Loon <preston@prysmaticlabs.com>
2019-08-23 18:33:17 +02:00
Raúl Kripalani 26d342e918
fmt. 2019-08-23 18:33:17 +02:00
Raúl Kripalani e81629df63
document doctoc command for posterity. 2019-08-23 18:33:16 +02:00
Raúl Kripalani aa2859299f
gossip domain: clarify why we use plaintext topic names. 2019-08-23 18:33:16 +02:00
Raúl Kripalani 4bae9b4bd1
add table of contents; amend heading level. 2019-08-23 18:33:16 +02:00
Jacek Sieka a8ac4d6c6f
Update libp2p networking spec 2019-08-23 18:33:16 +02:00
Matt Garnett 520c872d21
Improve readability of SSZ type defaults 2019-08-23 18:31:10 +02:00
Diederik Loerakker 5d2f34f882
Merge pull request #1363 from ethereum/executable_merkle_proofs
Executable Merkle proofs
2019-08-23 14:50:12 +02:00
Hsiao-Wei Wang bbaa238742
Fix the definition of `GeneralizedIndex` 2019-08-23 20:20:35 +08:00
vbuterin c1f2e92ad1
Update specs/core/1_beacon-chain-misc.md
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-08-23 12:33:25 +02:00
vbuterin 5fcfcac75e Updated light client sync for newer committees (#1316) 2019-08-20 14:33:29 +02:00
Hsiao-Wei Wang d6bbd9bfa1
Add `BaseBytes` to cover `Bytes` and `BytesN` 2019-08-20 19:23:31 +08:00
Hsiao-Wei Wang 6577f159c9
Merge branch 'dev' into executable_merkle_proofs 2019-08-20 19:13:12 +08:00
Hsiao-Wei Wang 663d43d07f
PR feedback, fix type hinting, add missing `Container.get_field_names()` method 2019-08-20 18:55:30 +08:00
Justin Drake df6e531d74 Improve beacon proposer selection logic 2019-08-20 11:37:27 +02:00
Martin Lundfall a843e9aeeb specs/ fix links 2019-08-19 13:47:09 +02:00
Martin Lundfall 35d89e2706 merkle_proofs, simple-serialize, test_gen/README: update ToC 2019-08-19 13:03:51 +02:00
Danny Ryan 83566afa1b
remove APIs and add links to outside spec/stnards repos 2019-08-16 13:35:23 -06:00
Hsiao-Wei Wang bb0b5b09cc
Use `SSZVariableName` instead of `str`, and fix some mypy errors 2019-08-15 19:02:21 +08:00
vbuterin e4a18f6fa4
Made persistent committee roots a vector 2019-08-15 12:51:11 +02:00
Hsiao-Wei Wang 2741a5f33d
Minor fixes 2019-08-15 18:36:48 +08:00
Hsiao-Wei Wang 0f52d460a5
Use the `get_previous_power_of_2` function in ethereum/eth2.0-specs#1323 2019-08-15 16:14:07 +08:00
Hsiao-Wei Wang d88a83d482
Fix most mypy errors 2019-08-15 16:01:53 +08:00
Hsiao-Wei Wang dc93391421
Make flake8 check pass 2019-08-15 15:30:01 +08:00
Diederik Loerakker f9d703c126
Merge pull request #1186 from ethereum/vbuterin-patch-3
Updates to SSZ Merkle proofs phase 0 doc
2019-08-14 23:49:54 +02:00
vbuterin 72103e9deb
Update specs/light_client/merkle_proofs.md
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2019-08-14 23:44:26 +02:00
vbuterin c7af2496ef
Update specs/light_client/merkle_proofs.md
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2019-08-14 23:44:19 +02:00
vbuterin 8255091e40
ShardReceipt -> ShardReceiptProof 2019-08-14 23:35:26 +02:00
vbuterin fd24308d19
Update specs/core/1_beacon-chain-misc.md 2019-08-14 23:32:10 +02:00
vbuterin d424863fc0
Update specs/core/1_beacon-chain-misc.md 2019-08-14 23:32:01 +02:00
vbuterin 49a008df60
Update specs/core/1_beacon-chain-misc.md 2019-08-14 23:31:55 +02:00
vbuterin 4f92e7fe30
Update specs/core/1_beacon-chain-misc.md 2019-08-14 23:31:48 +02:00
vbuterin 0cf454547b
Update specs/core/1_beacon-chain-misc.md 2019-08-14 23:27:25 +02:00
Danny Ryan 5d8c31cfb1
Update specs/simple-serialize.md 2019-08-14 11:07:03 -06:00
Justin 84558e0c4c
Add summaries and expansions to simple-serialize.md 2019-08-14 15:48:30 +02:00
Danny Ryan 931c51ce7a
Merge pull request #1350 from AgeManning/network-spec-corrections
Minor corrections and clarifications to the network specification
2019-08-13 07:46:27 -06:00
vbuterin f9849ca562
Update specs/core/1_beacon-chain-misc.md
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-08-13 06:14:51 -04:00
vbuterin cb3e0f2146
Update specs/core/1_beacon-chain-misc.md
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-08-13 06:12:51 -04:00
Age Manning 8cf4544ef2
Merge latest dev 2019-08-13 12:41:34 +10:00
Danny Ryan c224af999e
MAX_PERSISTENT_COMMITTEE_SIZE -> TARGET_PERSISTENT_COMMITTEE_SIZE 2019-08-12 19:05:16 -06:00
Age Manning e23b37842e
Update specs/networking/p2p-interface.md
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-08-13 08:09:44 +10:00
Hsiao-Wei Wang d84c902bb1
Merge branch 'dev' into v082_backport 2019-08-12 01:47:24 +08:00
Hsiao-Wei Wang 8ac5ea20be
Merge pull request #1353 from mcdee/dev
Add link from DepositData reference to definition
2019-08-12 01:08:04 +08:00
dankrad b345dc0f5f Legendre custody construction (#1305)
* Stab at Legendre custody construction + some tests

* Fix some problems and fix function puller to remove phase0 only lines in phase1

* Pass the linter

* Add headings

* Fix domain for BLS stub

* Change Jacobi to Legendre

* n -> q to clarify notation

* Headings

* Another missing heading

* Custody subchunks via padding

* Fix max_reveal_lateness stuff

* Better names for reveal period functions

* Better parametrization of max_reveal_lateness computation and tests for custody reveal processing

* Fix linter

* Allow challenging for one period after the custody reveal, shorter periods for minimal tests

* Fix lint

* Fix linter error
2019-08-11 13:05:17 -04:00
Hsiao-Wei Wang 40fbcd3d59
Merge branch 'dev' into v082_backport 2019-08-12 00:58:20 +08:00
Hsiao-Wei Wang a0b8e9bbc7
Merge branch 'dev' into vbuterin-patch-13 2019-08-12 00:40:16 +08:00
Hsiao-Wei Wang 01d58eb1c6
Merge branch 'dev' into v082_backport 2019-08-12 00:18:25 +08:00
Hsiao-Wei Wang 4df372deb7
Merge branch 'dev' into vbuterin-patch-17 2019-08-11 23:45:18 +08:00
vbuterin 36a2283052
Shard receipts cannot penalize withdrawn validators 2019-08-11 23:18:48 +08:00
vbuterin 7132778a69
Added compact committee class 2019-08-11 23:18:48 +08:00
Danny Ryan 0fa4491c41
lint 2019-08-11 23:18:48 +08:00
Danny Ryan 6560bc42d2
Apply suggestions from code review
Co-Authored-By: Carl Beekhuizen <carl@ethereum.org>
2019-08-11 23:18:48 +08:00
Danny Ryan 2ae7323183
use codeblock syntax for misc beacon updates 2019-08-11 23:18:48 +08:00
Danny Ryan a273d9e09d
minor rename of beacon chain misc to conform to other files 2019-08-11 23:18:48 +08:00
vbuterin b9fddfe310
Made code work with #1186 2019-08-11 23:18:48 +08:00
vbuterin fab37e747a
Fixed position of Classes 2019-08-11 23:18:47 +08:00
vbuterin 5dad213457
Fixed up ToC 2019-08-11 23:18:47 +08:00
vbuterin 3f20aca65e
Added comments and ToC 2019-08-11 23:18:47 +08:00
vbuterin caadc0d234
Update 1_beacon_chain_misc.md 2019-08-11 23:18:47 +08:00
vbuterin fe9fe8a151
[WIP] add receipt processing to phase 1 beacon chain 2019-08-11 23:18:47 +08:00
vbuterin 3dc7430ae9
Starting on phase 1 misc beacon changes 2019-08-11 23:18:47 +08:00
Hsiao-Wei Wang 5290b62465
Fix + refactor `is_valid_beacon_attestation` and add basic test 2019-08-11 22:24:21 +08:00
Jim McDonald 0e7287eda5 Add link from DepositData reference to definition 2019-08-09 19:09:04 +01:00
JSON 5808ab3ce7 doc standardization for networking spec (#1338)
* Update p2p-interface.md

* Update p2p-interface.md

* Update p2p-interface.md

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-08-09 13:30:05 +08:00
Age Manning 2a2c9967a8
Minor corrections and clarifications to the network specification 2019-08-09 12:38:48 +10:00
Hsiao-Wei Wang 095cfe6633
Fix build_spec and typo 2019-08-07 19:29:24 +08:00
vbuterin cb92aa91dd
Include state root blocks in crosslink data in non-block slots
Also adds `total_bytes` to state. The goal is to facilitate easier fraud proofs, so that one needs to simply check two adjacent headers in a crosslink and their respective bodies to verify a fraud proof.
2019-08-05 14:37:38 -04:00
Ben Edgington 499e187382 Fix constants table
Tables need header rows in Markdown.
2019-08-05 12:19:32 +01:00
Jacek Sieka d09d56bec8
discuss length-prefixing pro/con, consider for removal, add link 2019-08-04 20:56:41 +02:00
Paul Hauner 32a43acfc1
Clarify length bit for Bitlist merklization 2019-08-04 12:10:32 -06:00
Jacek Sieka cf1d49a1de
cleanups 2019-08-03 09:27:49 +02:00
protolambda 63e2915e12
update SSZ static doc to reflect options in test conditions 2019-08-02 21:43:36 +02:00
Jacek Sieka 514ff5814f
Updates
* constants -> configurations
* constant name updates
* initial validation requirement for attestations
* allow aggregated attestations to be published
* move discv5 down a bit
* additional rationale
2019-08-02 21:12:40 +02:00
vbuterin 5237ac4954
Update specs/light_client/merkle_proofs.md 2019-08-02 09:57:32 -04:00
vbuterin 6138edc5be
log -> log2 2019-08-02 09:49:35 -04:00
vbuterin c8d128aa59
Update specs/light_client/merkle_proofs.md
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2019-08-02 09:46:59 -04:00
vbuterin c6cdec8217
Fixed get generalized indices 2019-08-02 09:45:26 -04:00
vbuterin 59307d1380
Update specs/light_client/merkle_proofs.md
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2019-08-02 09:43:42 -04:00
vbuterin 845daf5b1f
Update specs/light_client/merkle_proofs.md
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2019-08-02 09:43:24 -04:00
vbuterin 0a874528a8
Update specs/light_client/merkle_proofs.md
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-08-02 09:43:03 -04:00
vbuterin ddd43ad99d
<= becomes < 2019-08-02 09:40:49 -04:00
vbuterin c29d85aafb
Update specs/core/1_shard-data-chains.md
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-08-02 09:40:26 -04:00
Raúl Kripalani f3c11852d7
apply more editorial suggestions.
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-08-02 12:38:59 +01:00
Raúl Kripalani 5248bb6a15
apply editorial suggestions.
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
Co-Authored-By: Preston Van Loon <preston@prysmaticlabs.com>
2019-08-02 12:35:50 +01:00
vbuterin 2e7c8fa529
Update specs/light_client/merkle_proofs.md 2019-08-01 18:12:35 -04:00
vbuterin e93e7a3f1a
Update specs/light_client/merkle_proofs.md 2019-08-01 18:12:27 -04:00
vbuterin 44bd00164e
Update specs/light_client/merkle_proofs.md
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-08-01 18:11:45 -04:00
vbuterin 1b852adef1
Simplified merkle multiproofs 2019-08-01 18:11:30 -04:00
protolambda 8563dbf5c0
make ssz_static output roots to roots.yaml instead of meta 2019-08-01 22:03:40 +02:00
Justin Drake 26641aa699 Remove light client infrastructure (better stuff to be added in phase 1) 2019-08-01 17:03:23 +01:00
Raúl Kripalani 02bb92e714 fmt. 2019-08-01 16:57:04 +01:00
vbuterin 725bdf8223
Update specs/light_client/merkle_proofs.md 2019-08-01 11:40:40 -04:00
Raúl Kripalani 3d4dde412b document doctoc command for posterity. 2019-08-01 16:04:59 +01:00
Raúl Kripalani 1ba03b4c33 gossip domain: clarify why we use plaintext topic names. 2019-08-01 15:56:53 +01:00
vbuterin 55f5f106f1
Updated type checkers for generalized index functions. 2019-08-01 10:56:31 -04:00
Raúl Kripalani c108444c06 add table of contents; amend heading level. 2019-08-01 15:47:11 +01:00
Jacek Sieka e5350c1026
Update libp2p networking spec 2019-08-01 14:47:05 +02:00
vbuterin 446ad3c392
Update specs/light_client/merkle_proofs.md
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-08-01 08:08:18 -04:00
vbuterin 92fc0f2b81
Update specs/light_client/merkle_proofs.md
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-08-01 08:08:12 -04:00
vbuterin ed3749264b
Update specs/light_client/merkle_proofs.md
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-08-01 08:07:57 -04:00
vbuterin cb1a0cbd5f
Update specs/light_client/merkle_proofs.md 2019-08-01 07:57:34 -04:00
Hsiao-Wei Wang 4163053cca
Clean up type hintings, especially `reward` is denominated in uint, and `fee` is in `Gwei` 2019-08-01 16:45:01 +08:00
Hsiao-Wei Wang ce3df38028
Some updates:
1. Clean up configurations
2. Add `HISTORY_ACCUMULATOR_VECTOR`
3. Add `validate_state_root` flag in `shard_state_transition` for testing
4. Rename `history_acc` to `history_accumulator`
2019-08-01 14:17:05 +08:00
Hsiao-Wei Wang 7a4a136d6c
Fix `later_committee` 2019-08-01 13:32:37 +08:00
vbuterin 52705f6fab
Quick fix 2019-07-31 21:28:07 -04:00
vbuterin b57aed2380
A few fixes 2019-07-31 21:26:47 -04:00
vbuterin e08c365e2f
Update specs/core/1_shard-data-chains.md
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-07-31 17:25:55 -04:00
Hsiao-Wei Wang 13d6a31c5c
misc fix 2019-08-01 00:27:31 +08:00
Hsiao-Wei Wang fe2adfa0e2
Fix many typos and lint errors 2019-07-31 18:18:07 +08:00
Hsiao-Wei Wang bc7f849246
Merge branch 'dev' into vbuterin-patch-17 2019-07-31 17:51:26 +08:00
Hsiao-Wei Wang f263b71875
ZERO_HASH -> Hash() 2019-07-31 17:50:55 +08:00
Hsiao-Wei Wang 058e63654d
Fix typo 2019-07-31 17:44:33 +08:00
protolambda 18fc4edfd4
reword to 'also available as <name>.ssz' 2019-07-31 02:16:41 +02:00
Diederik Loerakker d0985dbb5b
Apply suggestions from code review
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-07-31 02:05:52 +02:00
Diederik Loerakker 9f0a601a40
Apply suggestions from code review
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-07-31 02:02:50 +02:00
protolambda 5f33560b47
Merge branch 'v08x' into testgen-reorg 2019-07-30 22:21:59 +02:00
protolambda 5bdcd269ea
new ssz generic format + typo fix in shuffling format doc 2019-07-30 22:16:43 +02:00
Danny Ryan 6f62146905
Merge branch 'dev' into vbuterin-patch-3 2019-07-30 13:32:58 -06:00
vbuterin cf7d65e8ff
Added generalized index handling functions 2019-07-30 12:15:46 -04:00
protolambda 5ec941e698
more documentation updates 2019-07-30 15:06:15 +02:00
protolambda ff2b533c40
update test format docs with new test structure 2019-07-30 14:09:20 +02:00
protolambda 2ba3cc993d
update test format doc and SSZ-static format docs 2019-07-30 03:40:25 +02:00
Danny Ryan b4577e571b
Merge pull request #1314 from paulhauner/patch-14
Clarify length bit for Bitlist merklization
2019-07-29 17:33:47 -06:00
vbuterin 4b2b5815c9
Add shard state transition function 2019-07-29 16:43:55 -04:00
dankrad ab156f31b1
Merge pull request #1283 from ethereum/n_zero
Clarify the illegal SSZ types
2019-07-29 17:40:38 +01:00
vbuterin de9b4f2d6d
Attestation changes + persistent committee changes (#1294)
* Minimal attestation simplification

* minor fix

* Make the tests pass

* Decrease `PLACEHOLDER`, Use `compute_epoch_of_shard_slot`

* Fix proposer signature name and use get_seed() to calculate current_shuffling_seed

* Fix linter error

* Add the WIP `test_is_valid_shard_block`

* Add `get_shard_block_attester_committee`

* Simplified committee selection

* Added some helpers and simplified

* Update specs/core/1_shard-data-chains.md

* Update 1_shard-data-chains.md

* Simplified switchover epochs, changed block structure, changed crosslink structure

* Update 1_shard-data-chains.md

* Moved balance dependency to proposer selection

* Update specs/core/1_shard-data-chains.md

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

* Update specs/core/1_shard-data-chains.md

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

* Update specs/core/1_shard-data-chains.md

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

* Update specs/core/1_shard-data-chains.md

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

* Update specs/core/1_shard-data-chains.md

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

* Update specs/core/1_shard-data-chains.md

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

* Update specs/core/1_shard-data-chains.md

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

* Update specs/core/1_shard-data-chains.md

* Fixed shard header flattening

* Update specs/core/1_shard-data-chains.md

* Minor fixes

* Update specs/core/1_shard-data-chains.md

* Update specs/core/1_shard-data-chains.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* cleanup testing and lint

* return none if not active validators in persistent committee

* only allow active validators as shard proposer
2019-07-29 09:47:35 -04:00
Alex Stokes 3c575ceee2
The key in the provided test data is `block` not `block_header`. 2019-07-26 09:15:36 -07:00
protolambda b73625fbf1
update test generation code (work in progress), improve the simplicity of configuration in context of forks, and update docs 2019-07-25 23:13:33 +02:00
Diederik Loerakker d791e9f7e8
Merge pull request #1319 from ethereum/compact_committees-shard
Fix start shard for compact committees root
2019-07-25 21:40:06 +02:00
Diederik Loerakker e20f5eb455
Merge pull request #1317 from ethereum/attestation-bit-lengths
Check attestation bit lengths
2019-07-25 21:17:39 +02:00
Danny Ryan 1ec20f6c1f
do not reset start_shard until after processing compact root 2019-07-25 12:59:38 -06:00
Justin 3f75f1e2c3
Update 0_beacon-chain.md 2019-07-25 19:32:56 +01:00
Danny Ryan bd69dc7e3c
add tests for bit lengths 2019-07-25 12:28:29 -06:00
Hsiao-Wei Wang f336e7ffb3
Rename `is_empty` to `is_zero` 2019-07-25 17:32:27 +08:00
Hsiao-Wei Wang 62138fed34
Update Illegal types 2019-07-25 17:26:27 +08:00
Hsiao-Wei Wang c01995436e
Merge branch 'v08x' into n_zero 2019-07-25 17:25:41 +08:00
Danny Ryan f9f722c505
Merge pull request #1306 from ethereum/old_latest_message
Found by Cem Özer: Ignore older latest messages in attesting balance
2019-07-24 20:03:23 -06:00
Paul Hauner 6f208b6f45
Clarify length bit for Bitlist merklization 2019-07-25 10:18:10 +10:00
Chih Cheng Liang 9c6ba9cd0f
Fix md table 2019-07-24 13:39:04 +08:00
Danny Ryan a90d273fbd
fix minor var typo 2019-07-22 07:19:42 -06:00
Danny Ryan 43a0ca4eeb
check bit lengths 2019-07-22 07:13:07 -06:00
protolambda 01af304403
Found by Cem Özer: Ignore older latest messages in attesting balance sum, instead of assertion error 2019-07-20 02:13:52 +02:00
Diederik Loerakker 866d3f30cc
Merge pull request #1299 from ethereum/master
backport v0.8.1 to dev
2019-07-15 19:34:51 +02:00
protolambda ef659144b4
make zero hash representation clear, fixes #1282 2019-07-15 02:05:16 +02:00
Danny Ryan 77f007cab5
Merge pull request #1267 from ethereum/dankrad-patch-9
Define Bitlist/Bitvector serialization using bytes, not bigints
2019-07-14 17:20:12 -06:00
Danny Ryan 07a0e7b7dd
Merge pull request #1292 from ethereum/correct-merkle
Correct merkleization
2019-07-14 17:19:39 -06:00
protolambda d9fd1d3a2a
improve type wording based on PR 1292 feedback 2019-07-15 00:13:00 +02:00
Danny Ryan 8970b71ca4
ensure min_seed_lookahead functions properly 2019-07-14 16:05:51 -06:00
Danny Ryan 9401383317
Merge pull request #1275 from ethereum/minor-cosmetics
Minor cosmetic fixes
2019-07-14 15:36:24 -06:00
protolambda ac6d019870
bits serialization clear now, directly to bytes 2019-07-12 22:20:07 +02:00
protolambda a8dc9157b8
clean up merkleization text in SSZ spec 2019-07-12 21:15:28 +02:00
Danny Ryan 6dc306700b avoid overflow in slashing penalty calculation (#1286)
Change presentation to avoid uint64 overflow in slashing penalty calculation. (Factor out `EFFECTIVE_BALANCE_INCREMENT` from `validator.effective_balance`.)
2019-07-11 09:53:51 +01:00
Alex Stokes 4def681a4e
Remove another unnecessary list materialization 2019-07-10 17:05:49 -07:00
Alex Stokes b80d6e0495
Avoid unnecessary materialization of list
There is a realization of a `list` in the `get_unslashed_attesting_indices` helper that is unnecessary.

The functionality in this PR is the same so this change should only really be cosmetic wrt the spec.
2019-07-10 17:00:11 -07:00
Danny Ryan 57c0eee197
Merge pull request #1285 from decanus/patch-24
Update 0_beacon-chain.md
2019-07-10 12:34:53 -06:00
Dean Eigenmann 0eadf61631
Update 0_beacon-chain.md 2019-07-10 13:11:34 -04:00
Hsiao-Wei Wang 25ec084cc5
To fit in `MAX_TRANSFERS=0` case 2019-07-10 17:20:50 +08:00
Hsiao-Wei Wang 1644ae6125
Clarify the illegal types 2019-07-10 16:46:59 +08:00
Justin Drake 591f9658d3 Copy edit 2019-07-05 15:04:57 +01:00
Justin Drake c8c810c0e1 Minor fixes 2019-07-05 15:03:37 +01:00
Hsiao-Wei Wang d04d81038a
Merge pull request #1271 from ethereum/hwwhww/ssz-clarify
Cosmetic SSZ spec + add `pack()` in `Bitvector` and `Bitlist` Merkleization
2019-07-05 15:27:40 +08:00
Hsiao-Wei Wang 21535fe901
Fix indent 2019-07-04 21:38:08 +08:00
Hsiao-Wei Wang f37aa1acde
Add `pack()` for `Bitvector` and `Bitlist` Merkleization 2019-07-04 21:35:55 +08:00
Hsiao-Wei Wang d483a3b573
Set default `pad_for=1` 2019-07-04 21:17:21 +08:00
Hsiao-Wei Wang 733653f169
Update some missing type hinting of phase 1 2019-07-04 20:52:58 +08:00
Hsiao-Wei Wang bc39f39d5d
Move `SECONDS_PER_SLOT` back to 0_beacon_chain spec so that the "duration" notes make more sense 2019-07-04 20:41:00 +08:00
Hsiao-Wei Wang b3d65368a1
`PERSISTENT_COMMITTEE_PERIOD` has been defined in phase 0 2019-07-04 20:38:18 +08:00
Danny Ryan 88892028dc
update test formats list in readme 2019-07-02 12:35:26 -06:00
Dean Eigenmann f8fa6f0046
Update 0_beacon-chain.md 2019-07-02 05:43:17 +02:00
Dean Eigenmann ea2f577a8d
Update 0_beacon-chain.md 2019-07-02 05:31:49 +02:00
Danny Ryan 4ea79ee13b
Merge pull request #1257 from ethereum/scale-inclusion-reward
scale inclusion reward properly
2019-06-30 23:08:05 -05:00
Danny Ryan de95f54c4f
Merge pull request #1256 from ethereum/misc_fix
[meta] Fix ToC of SSZ spec and  Use relative inner repo link
2019-06-30 22:49:31 -05:00
Danny Ryan 126591b2f9
scale inclusion reward properly 2019-06-30 22:34:35 -05:00
Hsiao-Wei Wang ac741c096d
Fix ToC of SSZ spec 2019-07-01 11:29:10 +08:00
Danny Ryan 63d4653453
remove unnecessary casting 2019-06-30 22:29:02 -05:00
Danny Ryan 82d3c4f606
Merge pull request #1251 from ethereum/last-minute-cleanups-2
#1244 without "5 slots is a `Slot`"
2019-06-30 22:22:23 -05:00
Hsiao-Wei Wang 93fc81e761
Use relative inner repo link 2019-07-01 11:22:18 +08:00
Danny Ryan 476dbdb153
add time param back tp units 2019-06-30 22:14:53 -05:00
Danny Ryan e1030843d6
Merge branch 'dev' into last-minute-cleanups-2 2019-06-30 22:11:48 -05:00
Danny Ryan 200da4de93
Merge branch 'dev' into v_guide_checkpoint 2019-06-30 22:08:23 -05:00
Danny Ryan 2855e43551
Merge pull request #1236 from ethereum/exec_v_spec
Executable Validator Guide
2019-06-30 22:05:45 -05:00
Danny Ryan 350b9d79ae
Merge pull request #1250 from ethereum/fork_choice_rule_test
Fix `justified_checkpoint` update
2019-06-30 22:03:27 -05:00
Danny Ryan 2539406324
Merge branch 'dev' into exec_v_spec 2019-06-30 22:00:18 -05:00
Hsiao-Wei Wang 4f360a58e2
Fix outdated `fork.slot` and `attestation_data.slot` 2019-07-01 10:58:09 +08:00
Hsiao-Wei Wang f7ed186447
Use `Checkpoint` 2019-07-01 10:46:22 +08:00
Danny Ryan f4907d67ee
clean up commitee assignment typing 2019-06-30 20:44:02 -05:00
Hsiao-Wei Wang 83a68feac6
Merge branch 'dev' into last-minute-cleanups-2 2019-07-01 09:36:13 +08:00
Danny Ryan af5719031c
Merge branch 'dev' into fix-bls-domain-type 2019-06-30 20:28:18 -05:00
Hsiao-Wei Wang 9e5117aff7
Merge branch 'dev' into fork_choice_rule_test 2019-07-01 09:27:55 +08:00
Hsiao-Wei Wang b29c751cb7
Merge branch 'dev' into last-minute-cleanups-2 2019-07-01 09:25:06 +08:00
Danny Ryan 2ab55bf1e4
Merge pull request #1247 from ethereum/add-active-index-roots-back
add back in active_index_roots
2019-06-30 19:23:15 -06:00
Danny Ryan 155158f461
Merge pull request #1241 from ethereum/rename_misc
Renaming of functions in the `Misc` section
2019-06-30 19:21:10 -06:00
Hsiao-Wei Wang e061972eee
Revert State list lengths 2019-07-01 09:17:03 +08:00
Danny Ryan b08d1d8d73
fix associtivity in conditional 2019-06-30 20:13:27 -05:00
Hsiao-Wei Wang 8da447f607
Revert "5 slots is a `Slot`" 2019-07-01 09:07:33 +08:00
Justin Drake 1698263621 BLS domain => domain 2019-07-01 00:36:19 +01:00
Justin Drake aeba6ee8fb compute_domain for consistency with get_domain 2019-07-01 00:35:09 +01:00
Carl Beekhuizen 4f47e30144
separates out `domain` 2019-07-01 01:22:58 +02:00
protolambda ab2001e237
Merge branch 'dev' into last-minute-cleanups 2019-07-01 01:17:18 +02:00
Carl Beekhuizen 7ef98f7478
Compact `get_domain` calls 2019-07-01 01:06:27 +02:00
Diederik Loerakker c79f93fe99
Merge pull request #1248 from ethereum/fix-effective-balance
Fix genesis effective balance
2019-07-01 01:03:51 +02:00
Justin Drake b582afed84 Add back effective balance initialisation 2019-06-30 23:49:53 +01:00
Justin Drake 6a799903a9 Simplify 2019-06-30 23:36:26 +01:00
Hsiao-Wei Wang 84d8ca740c
Improve fork choice rule test coverage 2019-07-01 06:33:10 +08:00
Carl Beekhuizen ca731d32cf
Merge in `dev` and resolve conflicts 2019-07-01 00:27:27 +02:00
protolambda 393c583d06
move endianness to be a constant 2019-07-01 00:21:19 +02:00
Carl Beekhuizen 41897e779a
validate_indexed_attestation -> is_valid_indexed_attestation` 2019-07-01 00:10:28 +02:00
protolambda 7f2eb813cb
minor BLS domain type related improvements 2019-07-01 00:05:40 +02:00
Justin Drake 9df17f5494 Explitcit zero byte 2019-06-30 22:58:02 +01:00
Justin Drake cf59c303f0 Remove index_count 2019-06-30 22:50:01 +01:00
Carl Beekhuizen 6e5f43c033
merge in `dev` and resolve conflicts 2019-06-30 23:37:56 +02:00
Carl Beekhuizen 918192cdab
`compute_slot_epoch`->`compute_epoch_of_slot` 2019-06-30 23:35:07 +02:00
Danny Ryan db8bd07eeb
Merge pull request #1249 from ethereum/format_binary_operations
Minor python style tweaks
2019-06-30 16:18:34 -05:00
Carl Beekhuizen 8b10ed598e
Adds a lone space 2019-06-30 23:14:16 +02:00
Carl Beekhuizen fe68a8d1f0
Minor python style tweaks 2019-06-30 22:59:12 +02:00
Hsiao-Wei Wang 67b0b4ad33
Update other spec files 2019-07-01 04:57:42 +08:00
Justin Drake d329e90aa5 Fix effective balance 2019-06-30 21:27:01 +01:00
Danny Ryan c42b26b0c4
add back in active_index_roots 2019-06-30 15:19:52 -05:00
protolambda d45b73389e
update BLS test generator and format to reflect spec change in BLS 2019-06-30 22:18:52 +02:00
protolambda e53063c08d
type BLS domain and domain type 2019-06-30 22:12:49 +02:00
Hsiao-Wei Wang fb598bc70c
Update ToC 2019-07-01 04:11:17 +08:00
Carl Beekhuizen cb71409114
Merge in `dev` 2019-06-30 22:03:19 +02:00
Danny Ryan 3d2eaa22cb
Merge pull request #1238 from ethereum/update-generators
Update test vector generators
2019-06-30 14:57:13 -05:00
Justin Drake f1931c030f Fix 2019-06-30 20:56:55 +01:00
Carl Beekhuizen 361732f409
merge in dev and resolve conflicts 2019-06-30 21:54:30 +02:00
Justin Drake e4a225ba68 BLS_WITHDRAWAL_PREFIX a Bytes1 2019-06-30 20:51:44 +01:00
Justin Drake 9b5e18b61c Last minute cleanups 2019-06-30 20:51:10 +01:00
Carl Beekhuizen c2a4838f5a
Implments suggestions from review 2019-06-30 21:49:29 +02:00
Danny Ryan 83e961d5cc
Merge branch 'dev' into update-generators 2019-06-30 14:48:12 -05:00
Carl Beekhuizen e0a0f6e156
Makes markdown comply with linter 2019-06-30 21:25:58 +02:00
Diederik Loerakker 1ba955b5f0
Update specs/test_formats/epoch_processing/README.md
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-06-30 21:19:19 +02:00
Carl Beekhuizen 9deb4090b0
Merge branch 'dev' into exec_v_spec
* dev:
  delayed_activation_exit_epoch -> compute_activation_exit_epoch
  remove 'int' types from spec typehints. replace with uint64
  'beacon state getters' -> ' beacon state accessors'
  PR feedback
  Cleanup
  Fix bug
  ready for review
  A few more cleanups
  Push draft
  WIP
  WIP2
  WIP
2019-06-30 21:03:27 +02:00
Carl Beekhuizen 0fd1d38417
`Misc` function rename 2019-06-30 20:58:02 +02:00
Danny Ryan 6be1404b66
delayed_activation_exit_epoch -> compute_activation_exit_epoch 2019-06-30 13:16:56 -05:00
Danny Ryan d1bc2f03ac
remove 'int' types from spec typehints. replace with uint64 2019-06-30 13:00:22 -05:00
Danny Ryan 3ae077a09b
'beacon state getters' -> ' beacon state accessors' 2019-06-30 12:51:13 -05:00
Danny Ryan 6d5e4da3e0
PR feedback 2019-06-30 12:42:24 -05:00
Justin Drake 0be2b8e620 Cleanup 2019-06-30 16:10:22 +01:00
protolambda 91f55f55b5
make BLS test format and output consistent with spec 2019-06-30 16:07:54 +02:00
Justin Drake 423d6dcb29 Fix bug 2019-06-30 14:45:36 +01:00
Justin Drake e873bb6e59 ready for review 2019-06-30 14:32:50 +01:00
Justin Drake 94404a5856 A few more cleanups 2019-06-30 14:11:46 +01:00
protolambda 83d91f81db
update sanity slots description to match new transition naming 2019-06-30 15:03:50 +02:00
protolambda da090b67f6
document genesis test vector format, fix missing label and assertion in tests 2019-06-30 14:58:53 +02:00
protolambda 992a51b587
add note to block operatiosn test format 2019-06-30 14:35:07 +02:00
protolambda abdcbc4972
update epoch processing tests generation and format 2019-06-30 14:32:38 +02:00
Justin Drake 58c864ddf4 Push draft 2019-06-30 11:01:54 +01:00
Justin Drake e8532ced79 WIP 2019-06-30 10:56:14 +01:00
Carl Beekhuizen fa7f80157d
Merge branch 'dev' into exec_v_spec
* dev: (112 commits)
  Minor copyedit
  Fix typo
  minor typo
  fix genesis tests; sign deposit-datas, and lower min validator count for testing
  add comments to make variations in genesis initialization clear, and about the mix-in in verification
  Refactor
  Update 0_beacon-chain.md
  quick comment on avoiding underflow
  fix basic test
  Make timestamp a uint64
  Fixes
  typo
  Fix genesis balance bug (git add -u)
  Cleanups and fixes
  fix finalize on double justification in 123 rule
  Merge is_genesis_trigger into get_genesis_state
  Cleanups; think about merging is_genesis_trigger into get_genesis_state
  Renames:
  fix typo in justification wording
  rename/fix roots in justification tests for consistency
  ...
2019-06-30 11:19:21 +02:00
Carl Beekhuizen f6322e199b
Fixes typing and Makefile 2019-06-30 11:18:36 +02:00
Carl Beekhuizen 2e41f2da3b
Merge pull request #1235 from ethereum/JustinDrake-patch-20
Minor copyedit
2019-06-30 11:17:35 +02:00
Justin Drake 369c457d76 WIP2 2019-06-30 10:11:23 +01:00
Justin Drake d0acd81157 WIP 2019-06-30 10:02:18 +01:00
Carl Beekhuizen 1d9fe90d97
Makes v-guide executable 2019-06-30 10:58:04 +02:00
Justin ae888e148c
Minor copyedit
Can the linter catch non-capitalised comments?
2019-06-30 08:13:07 +01:00
Justin 6cfd3b5047
Fix typo
Thanks @NIC619 https://github.com/ethereum/eth2.0-specs/pull/1219#discussion_r298818138
2019-06-30 08:10:23 +01:00
Danny Ryan 2f43f9c339
Merge pull request #1202 from ethereum/test_genesis
Add `test_genesis.py` and fix `is_genesis_trigger`
2019-06-29 23:31:32 -05:00
protolambda 8d2cbc9722
add comments to make variations in genesis initialization clear, and about the mix-in in verification 2019-06-30 02:08:34 +02:00
Hsiao-Wei Wang 47cdae4292
Refactor
1. Rename the current `get_genesis_beacon_state(...)` to `initialize_beacon_state_from_eth1(...)`
2. Extract `is_valid_genesis_state(state: BeaconState) -> bool` from `initialize_beacon_state_from_eth1(...)`
2019-06-30 06:38:30 +08:00
Justin 2a2bd72425
Update 0_beacon-chain.md 2019-06-29 22:52:01 +01:00