status-im/PyGithub
1
0
Fork 0
mirror of https://github.com/status-im/PyGithub.git synced 2026-09-02 03:41:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Remove NamedUser.contributions (#774)" (#865)

Browse Source 
This reverts commit a519e4675a.

NamedUser.contributions can be populated, so we should fill in the data.

Fixes #850
This commit is contained in:
Steve Kowalik
2018-08-15 11:39:08 +08:00
committed by Wan Liuyang
parent a7c16c64d6
commit b91dee8df6
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
github/NamedUser.py
+11
View File
@@ -101,6 +101,14 @@ class NamedUser(github.GithubObject.CompletableGithubObject):
self._completeIfNotSet(self._company)
return self._company.value
@property
def contributions(self):
"""
:type: integer
"""
self._completeIfNotSet(self._contributions)
return self._contributions.value
@property
def created_at(self):
"""
@@ -563,6 +571,7 @@ class NamedUser(github.GithubObject.CompletableGithubObject):
self._blog = github.GithubObject.NotSet
self._collaborators = github.GithubObject.NotSet
self._company = github.GithubObject.NotSet
self._contributions = github.GithubObject.NotSet
self._created_at = github.GithubObject.NotSet
self._disk_usage = github.GithubObject.NotSet
self._email = github.GithubObject.NotSet
@@ -607,6 +616,8 @@ class NamedUser(github.GithubObject.CompletableGithubObject):
self._collaborators = self._makeIntAttribute(attributes["collaborators"])
if "company" in attributes: # pragma no branch
self._company = self._makeStringAttribute(attributes["company"])
if "contributions" in attributes: # pragma no branch
self._contributions = self._makeIntAttribute(attributes["contributions"])
if "created_at" in attributes: # pragma no branch
self._created_at = self._makeDatetimeAttribute(attributes["created_at"])
if "disk_usage" in attributes: # pragma no branch
github/tests/Repository.py
+1 -1
View File
@@ -110,7 +110,7 @@ class Repository(Framework.TestCase):
repo.delete()
def testGetContributors(self):
self.assertListKeyEqual(self.repo.get_contributors(), lambda c: c.login, ["jacquev6"])
self.assertListKeyEqual(self.repo.get_contributors(), lambda c: (c.login, c.contributions), [("jacquev6", 355)])
def testCreateMilestone(self):
milestone = self.repo.create_milestone("Milestone created by PyGithub", state="open", description="Description created by PyGithub", due_on=datetime.date(2012, 6, 15))