status-im/PyGithub
1
0
Fork 0
mirror of https://github.com/status-im/PyGithub.git synced 2026-09-02 11:51:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove NamedUser.contributions (#774)

Browse Source 
The contributions attribute is no longer sent by Github for NamedUsers,
so remove the attribute.

Fixes #443
This commit is contained in:
Steve Kowalik
2018-04-30 10:12:43 +08:00
committed by Wan Liuyang
parent b1e9ae68a2
commit a519e4675a
2 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
github/NamedUser.py
-11
View File
@@ -101,14 +101,6 @@ class NamedUser(github.GithubObject.CompletableGithubObject):
self._completeIfNotSet(self._company)
return self._company.value
@property
def contributions(self):
"""
:type: integer
"""
self._completeIfNotSet(self._contributions)
return self._contributions.value
@property
def created_at(self):
"""
@@ -571,7 +563,6 @@ class NamedUser(github.GithubObject.CompletableGithubObject):
self._blog = github.GithubObject.NotSet
self._collaborators = github.GithubObject.NotSet
self._company = github.GithubObject.NotSet
self._contributions = github.GithubObject.NotSet
self._created_at = github.GithubObject.NotSet
self._disk_usage = github.GithubObject.NotSet
self._email = github.GithubObject.NotSet
@@ -616,8 +607,6 @@ class NamedUser(github.GithubObject.CompletableGithubObject):
self._collaborators = self._makeIntAttribute(attributes["collaborators"])
if "company" in attributes: # pragma no branch
self._company = self._makeStringAttribute(attributes["company"])
if "contributions" in attributes: # pragma no branch
self._contributions = self._makeIntAttribute(attributes["contributions"])
if "created_at" in attributes: # pragma no branch
self._created_at = self._makeDatetimeAttribute(attributes["created_at"])
if "disk_usage" in attributes: # pragma no branch
github/tests/Repository.py
+1 -1
View File
@@ -198,7 +198,7 @@ class Repository(Framework.TestCase):
repo.delete()
def testGetContributors(self):
self.assertListKeyEqual(self.repo.get_contributors(), lambda c: (c.login, c.contributions), [("jacquev6", 355)])
self.assertListKeyEqual(self.repo.get_contributors(), lambda c: c.login, ["jacquev6"])
def testCreateMilestone(self):
milestone = self.repo.create_milestone("Milestone created by PyGithub", state="open", description="Description created by PyGithub", due_on=datetime.date(2012, 6, 15))