2689 Commits

Author SHA1 Message Date
Dan
82a90846fc Upgrading libraries - upgrade to Flask 2.0 (previously locked at 1.1.4 because of Connexion) 2022-02-24 15:38:08 -05:00
Dan
3442655bd1 Performance Improvements:
1. Avoid ever re-generating the list of scripts that can be used in a script task.  Terribly expensive as we call eval constantly, and it never ever changes once the app starts. (see script.py changes, and comments)
2. Cache the DocumentStatus list in the flask session, so we calculate it at most once per API Call.  It's at least .25 seconds per call.  (see study_sevice)
3. We called UserFileService.get_files_for_study (which runs a db query EVERY time) for every possible document type.  Now we run the query once (study service line 321)
4. When returning a workflow, we looped through every single task in that workflow's navigation, and called the expensive spiff_task_to_api_task just to figure out it's proper display name. We run a much faster and more efficient method to calculate the display name naow (see workflow_service on lie 680, and 799)
5. A hellton of @timeit and sincetime() calls, that I want to leave in, to help debug any slowness on production.
2022-02-24 14:25:42 -05:00
Dan Funk
33dc1f0868
Merge pull request #465 from sartography/bug/628_jinja_template_errors
fix to assure we produce a usable error message
2022-02-24 08:50:41 -05:00
Dan Funk
e8617038ab
Merge pull request #461 from sartography/bug/missing-executabe-option-601
Bug/missing executabe option #601
2022-02-24 08:46:46 -05:00
Dan
23a43c0472 fix to assure we produce a usable error message 2022-02-23 11:53:24 -05:00
Dan Funk
5fee42b437
Merge pull request #463 from sartography/bug/validation-fields
Fixes a bug so that you can reference later fields (and they'll validate
2022-02-22 13:59:27 -05:00
alicia pritchett
095856d3c7 Fixes a bug so that you can reference later fields (and they'll validate 2022-02-22 10:18:09 -05:00
Dan Funk
d3b225d509
Merge pull request #460 from sartography/chore/variables-in-forms-550
Chore/variables in forms 550
2022-02-21 10:26:22 -05:00
mike cullerton
1cd3be70a7 Test for bug fix 2022-02-21 10:17:18 -05:00
mike cullerton
a830657ebd raise ApiError when isExecutable tag is missing.
Unsure how this would actually happen, since it should get set to False if box is unchecked.
2022-02-21 10:17:01 -05:00
Dan
24f33ec9c9 Merge branch 'chore/variables-in-forms-550' of github.com:sartography/cr-connect-workflow into chore/variables-in-forms-550 2022-02-21 09:57:19 -05:00
alicia pritchett
70fc9451a4 fix tests (update BPMNs)
test_stupid_slow_file_upload_form still fails
2022-02-21 09:44:00 -05:00
alicia pritchett
bb3d3a5907 Merge remote-tracking branch 'origin/chore/variables-in-forms-550' into chore/variables-in-forms-550 2022-02-21 08:56:11 -05:00
Dan
06b9b653b2 don't overwrite the field.label during an eval. It should remain as it is, just assure that it /can/ be evaluated. 2022-02-19 17:43:12 -05:00
Dan
4f32cf753c Merge branch 'chore/variables-in-forms-550' of github.com:sartography/cr-connect-workflow into chore/variables-in-forms-550 2022-02-18 17:20:10 -05:00
Dan
c3e52f960b Minor stuff to help digging into validation of current workflows. 2022-02-18 17:20:04 -05:00
Dan
a7f591d2ac Merge branch 'dev' into chore/variables-in-forms-550 2022-02-18 17:19:01 -05:00
alicia pritchett
3b48435411 Merge branch 'master' into chore/variables-in-forms-550 2022-02-18 13:23:33 -05:00
alicia pritchett
4b92b0ee71 oops 2022-02-18 11:57:13 -05:00
alicia pritchett
e7c0e66f86 Merge remote-tracking branch 'origin/chore/variables-in-forms-550' into chore/variables-in-forms-550 2022-02-18 11:41:15 -05:00
alicia pritchett
a912e8ef49 validate checks/catches default value and label value 2022-02-18 11:41:07 -05:00
Dan
779ac38513 Fix validate-all 2022-02-18 11:40:58 -05:00
Dan
b90be07bca Remove these bloodly log files from the repo. 2022-02-18 11:40:10 -05:00
Dan
e91be2a54d Merge branch 'dev' into chore/variables-in-forms-550 2022-02-18 11:27:58 -05:00
Dan
635a112796 still trying to fix a rogue test. 2022-02-18 10:41:24 -05:00
Dan
6adf1107fe Trying to figure out why these files are not the same on testing. 2022-02-18 10:12:36 -05:00
alicia pritchett
753534c4cd Remove boolean tests
It could only be True or False now. And again this should be a frontend test now
2022-02-18 10:09:24 -05:00
alicia pritchett
55aacae608 more BPMN's 2022-02-18 10:05:46 -05:00
alicia pritchett
ad58b67bb6 Delete read only field test
This is really something the frontend should be testing. Perhaps in the libraries test suite
2022-02-18 10:00:15 -05:00
alicia pritchett
7d597a82f4 mostly fixing bpmns 2022-02-18 09:48:02 -05:00
alicia pritchett
06dc20657b Fixing various BPMN's for tests 2022-02-17 17:29:44 -05:00
alicia pritchett
a5acd9b07e Merge branch 'dev' into chore/variables-in-forms-550 2022-02-17 15:04:41 -05:00
Dan
65e62a72e1 These migrations were not runnable from blank state, so cleared out broken code, so someone can still brining up a system. 2022-02-17 15:04:09 -05:00
Dan
c2c6410bbb Assure we update the workflow model, so we don't keep reporting the error over and over again. 2022-02-17 14:12:31 -05:00
Dan
8a81265ae8 Merge branch 'dev' 2022-02-17 14:07:45 -05:00
alicia pritchett
19965d18da Refactor test workflow_enum_value_expression
Same as other commit pretty much
2022-02-17 14:07:41 -05:00
Dan
3704279f20 Quick fix, assure we can reset studies. 2022-02-17 14:07:33 -05:00
Dan
82b0cb453a Merge branch 'dev' 2022-02-17 13:16:26 -05:00
Dan Funk
be48f86440
Merge pull request #459 from sartography/bug/619_lookup_tables
Another re-work to fix 619 - and to assure that we aren't rebuilding …
2022-02-17 13:15:37 -05:00
Dan Funk
c71b1f6963
Merge pull request #451 from sartography/get-erroring-workflows-574
Get erroring workflows #574
2022-02-17 13:15:19 -05:00
Dan
c2dbec1e3f Merge remote-tracking branch 'origin/dev' into bug/619_lookup_tables 2022-02-17 12:51:24 -05:00
Dan
9a26e56cc6 fixing some failing tests, due to previously lazy conflict merge. 2022-02-17 12:39:52 -05:00
Dan
e0a8e7300c Merge remote-tracking branch 'origin/dev' into get-erroring-workflows-574 2022-02-17 12:37:34 -05:00
alicia pritchett
218429f196 Refactor test workflow_value_expression
the backend shouldn't try to set a dynamic default value. Instead, the frontend will initialize it to an empty string, then evaluate a default value, then choose to set it. (Basically, move this function from the backend and put the burden on formly)
2022-02-17 12:25:40 -05:00
Dan Funk
9d74ee5790
Merge pull request #458 from sartography/bug/date-field-validation-622
Bug/date field validation #622
2022-02-17 12:18:39 -05:00
Dan Funk
484b9a9c7c
Merge pull request #457 from sartography/feature/get-spec-script-613
Feature/get spec script #613
2022-02-17 12:17:12 -05:00
alicia pritchett
08c1571803 Remove value_expression 2022-02-17 12:16:15 -05:00
Dan Funk
b91372171c
Merge pull request #454 from sartography/git-integration-fixes-596
Git integration fixes #596
2022-02-17 12:15:13 -05:00
Dan Funk
5def436602
Merge branch 'dev' into get-erroring-workflows-574 2022-02-17 12:12:42 -05:00
Dan
b72ecb8375 Another re-work to fix 619 - and to assure that we aren't rebuilding the lookup tables too frequently. 2022-02-17 11:59:48 -05:00