Minor stuff to help digging into validation of current workflows.

crc/__init__.py

@@ -1,5 +1,6 @@
 import logging.config
 import os
+import traceback
 
 import click
 import sentry_sdk
@@ -151,5 +152,7 @@ def validate_all(study_id, category=None, spec_id=None):
             continue
         except Exception as e:
             print(f"Unexpected Error ({e.__class__.__name__}), {e} validate workflow {spec.id} in Category {spec.category.display_name}")
+            # printing stack trace
+            traceback.print_exc()
             print(e)
-            continue
+            return

crc/services/workflow_processor.py

@@ -237,7 +237,7 @@ class WorkflowProcessor(object):
             elif file.type == FileType.dmn:
                 dmn: etree.Element = etree.fromstring(data)
                 parser.add_dmn_xml(dmn, filename=file.name)
-        if workflow_spec_info.primary_process_id is None:
+        if workflow_spec_info.primary_process_id is None or workflow_spec_info.primary_process_id == "":
             raise (ApiError(code="no_primary_bpmn_error",
                             message="There is no primary BPMN model defined for workflow %s" % workflow_spec_info.id))
         try:

crc/services/workflow_service.py

@@ -16,6 +16,7 @@ from SpiffWorkflow.bpmn.specs.ScriptTask import ScriptTask
 from SpiffWorkflow.bpmn.specs.UserTask import UserTask
 from SpiffWorkflow.bpmn.specs.events import EndEvent, StartEvent
 from SpiffWorkflow.dmn.specs.BusinessRuleTask import BusinessRuleTask
+from SpiffWorkflow.exceptions import WorkflowTaskExecException
 from SpiffWorkflow.specs import CancelTask, StartTask
 from SpiffWorkflow.util.deep_merge import DeepMerge
 from SpiffWorkflow.util.metrics import timeit
@@ -468,8 +469,10 @@ class WorkflowService(object):
         # default = WorkflowService.evaluate_property(Task.FIELD_PROP_VALUE_EXPRESSION, field, task)
         default = None
         if field.default_value is not None:
-            default = task.workflow.script_engine._evaluate(field.default_value, data)
-
+            try:
+                default = task.workflow.script_engine._evaluate(field.default_value, data)
+            except Exception as e:
+                raise WorkflowTaskExecException(task, "invalid_default", e)
         # If no default exists, return None
         # Note: if default is False, we don't want to execute this code
         if default is None or (isinstance(default, str) and default.strip() == ''):