wborgeaud
fc9d64defe
Small nits for the exponentiation gate
2021-08-02 13:12:50 +02:00
Daniel Lubarov
018fb005f8
Move stuff around ( #135 )
...
No functional changes here. The biggest change was moving certain files into new directories like `plonk` and `iop` (for things like `Challenger` that could be used in STARKs or other IOPs). I also split a few files, renames, etc, but again nothing functional, so I don't think a careful review is necessary (just a sanity check).
2021-07-29 22:00:29 -07:00
Nicholas Ward
9eda81c293
minor changes
2021-07-29 15:31:04 -07:00
Nicholas Ward
cfda56e3d3
Merge branch 'main' into exp_gate_config
2021-07-29 14:19:24 -07:00
Nicholas Ward
a111fc3164
fixes
2021-07-29 14:18:18 -07:00
Nicholas Ward
95503ff7fa
Merge branch 'main' into exp_gate_config
2021-07-29 14:10:35 -07:00
Nicholas Ward
e46bd08f00
exponention gate takes only bits
2021-07-29 12:59:11 -07:00
Daniel Lubarov
e382decc9f
Import fixes
2021-07-29 11:45:58 -07:00
Nicholas Ward
56b62f1964
new exp gate takes in CircuitConfig and determines num_bits
2021-07-29 10:26:46 -07:00
Nicholas Ward
2fd9ce2114
fixes to exp functions
2021-07-28 13:38:41 -07:00
Nicholas Ward
6749a94c52
fix
2021-07-28 10:17:32 -07:00
Nicholas Ward
607d0a89cb
fixed max_power_bits
2021-07-28 10:09:35 -07:00
Nicholas Ward
68672c0038
addressed comments
2021-07-28 09:20:20 -07:00
Nicholas Ward
a38a5e227d
select_ext takes bit as extension; used in recursive eval
2021-07-27 22:51:40 -07:00
Nicholas Ward
33ba269ccb
fixes
2021-07-27 15:58:19 -07:00
Nicholas Ward
3944c5e68e
added eval_unfiltered_recursively
2021-07-27 13:29:57 -07:00
Nicholas Ward
044eb597c2
added eval_unfiltered_base
2021-07-27 13:18:42 -07:00
Nicholas Ward
21ec75335a
fix: power bits in test now LE
2021-07-27 13:09:28 -07:00
Nicholas Ward
b5418bffb3
added output wire
2021-07-27 13:09:15 -07:00
Daniel Lubarov
54626be7ce
comment
2021-07-27 12:48:52 -07:00
Daniel Lubarov
1e9845afcf
nits
2021-07-27 12:47:15 -07:00
Nicholas Ward
b66ad6c96a
added debug assert
2021-07-27 12:34:47 -07:00
Nicholas Ward
34d59305a1
Merge branch 'main' into exp_gate
2021-07-27 12:29:24 -07:00
Nicholas Ward
7e5e4fc682
updated num_constraints
2021-07-27 12:18:09 -07:00
Nicholas Ward
59bfc52f9c
removed extraneous constraint
2021-07-27 11:55:25 -07:00
Nicholas Ward
695e5bc98c
fix?
2021-07-27 11:04:16 -07:00
Nicholas Ward
0b8f5860f5
removed if statement
2021-07-27 10:46:10 -07:00
Nicholas Ward
af62688bd7
fixes
2021-07-27 10:19:46 -07:00
Daniel Lubarov
3fc02c76bc
Couple fixes to ReducingGate ( #128 )
2021-07-25 09:34:51 -07:00
wborgeaud
deea1c979b
PR feedback
2021-07-25 18:12:26 +02:00
Nicholas Ward
d7a9274fef
updated for add_gate changes
2021-07-23 20:06:00 -07:00
Nicholas Ward
da9017bcbc
Merge branch 'main' into exp_gate
2021-07-23 20:01:58 -07:00
Nicholas Ward
b06d7bc8f5
cargo fmt
2021-07-23 15:56:25 -07:00
Nicholas Ward
0c4a1bc5af
fixes
2021-07-23 15:56:14 -07:00
Nicholas Ward
8e2f33bd42
fix
2021-07-23 15:52:37 -07:00
Nicholas Ward
64d8a44320
cargo fmt
2021-07-23 15:47:03 -07:00
Nicholas Ward
1c8015b93d
finished tests (don't pass yet)
2021-07-23 15:46:52 -07:00
Nicholas Ward
9932517e86
cargo fmt
2021-07-23 15:11:53 -07:00
Nicholas Ward
40055dc45d
basic tests
2021-07-23 15:11:42 -07:00
Nicholas Ward
6d22ad6ee0
initial version of exponentiation gate
2021-07-23 15:08:54 -07:00
wborgeaud
d509f03b1b
Implement eval_unfiltered_base
2021-07-23 18:32:59 +02:00
wborgeaud
8f18089aac
Implement eval_unfiltered_recursively for ReducingGate
2021-07-23 18:06:14 +02:00
wborgeaud
2ea35bd9e4
Comments
2021-07-23 17:38:24 +02:00
wborgeaud
5a16d7c555
Change number of coeffs supported in ReducingGate depending on config
2021-07-23 17:35:23 +02:00
wborgeaud
0526a9e149
Working ReducingGate
2021-07-23 17:16:53 +02:00
Daniel Lubarov
bcf524bed0
Have add_gate take a generic type instead of GateRef ( #125 )
...
* Have add_gate take a generic type instead of GateRef
There are a couple advantages
- Users writing their own gates won't need to know about the `GateRef` wrapper; it's more of an internal thing now.
- Easier access to gate methods requiring `self` -- for example, `split_le_base` can just call `gate_type.limbs()` now.
* Update comment
* Always insert
2021-07-22 23:48:03 -07:00
wborgeaud
a70e97befc
Fix merge issues
2021-07-23 08:21:55 +02:00
wborgeaud
9a1c289f8e
Merge branch 'main' into remove_acc_in_gmimc
...
# Conflicts:
# src/gadgets/arithmetic.rs
2021-07-23 08:16:23 +02:00
wborgeaud
d8b8161cb9
Merge pull request #122 from mir-protocol/eval_unfilterd_base
...
Manually implement `eval_unfiltered_base` for all gates
2021-07-23 08:12:01 +02:00
wborgeaud
ca3a2fcfc8
Clippy
2021-07-22 16:09:54 +02:00