1856 Commits

Author SHA1 Message Date
wborgeaud
c472afe12e Merge branch 'main' into glv
# Conflicts:
#	ecdsa/src/curve/ecdsa.rs
#	plonky2/src/gadgets/ecdsa.rs
2022-03-18 07:19:28 +01:00
wborgeaud
296b21aed9 Not working 2022-03-17 11:48:44 +01:00
wborgeaud
e77383b559 Progress 2022-03-17 11:08:25 +01:00
Daniel Lubarov
7d6c0a448d
Halo2 style lookup arguments in System Zero (#513)
* Halo2 style lookup arguments in System Zero

It's a really nice and simple protocol, particularly for the verifier since the constraints are trivial (aside from the underlying batched permutation checks, which we already support). See the [Halo2 book](https://zcash.github.io/halo2/design/proving-system/lookup.html) and this [talk](https://www.youtube.com/watch?v=YlTt12s7vGE&t=5237s) by @daira.

Previously we generated the whole trace in row-wise form, but it's much more efficient to generate these "permuted" columns column-wise. So I changed our STARK framework to accept the trace in column-wise form. STARK impls now have the flexibility to do some generation row-wise and some column-wise (without extra costs; there's a single transpose as before).

* sorting

* fixes

* PR feedback

* into_iter

* timing
2022-03-16 17:37:34 -07:00
wborgeaud
63a3090452 Start selectors 2022-03-16 18:09:36 +01:00
wborgeaud
deec6a784c
Merge pull request #516 from mir-protocol/ecdsa_module
Move nonnative/curve/ecdsa code to `ecdsa` module
2022-03-16 18:06:51 +01:00
wborgeaud
786c1eafcf Minor 2022-03-16 05:44:02 +01:00
wborgeaud
534ee7d637 Add untracked files 2022-03-16 05:39:45 +01:00
wborgeaud
660d785ed1
Merge pull request #515 from mir-protocol/fix_salt_issue
Fix salt issues
2022-03-16 03:40:59 +01:00
Daniel Lubarov
627e80bfd5
Filter mul-add constraints (#512) 2022-03-15 09:24:10 -07:00
wborgeaud
cc9a43b574 Fix salt issues 2022-03-15 17:14:45 +01:00
wborgeaud
2e5c2e8984 Add ecdsa module 2022-03-15 16:55:08 +01:00
wborgeaud
50f722d83e
Merge pull request #511 from mir-protocol/gadget_curve_msm
Gadget for curve MSM, fixed-base scalar multiplication and ECDSA verification in under `2^17` or `2^16` gates
2022-03-05 02:50:57 +01:00
wborgeaud
954eaf16f2 PR feedback 2022-03-05 02:36:08 +01:00
Hamish Ivey-Law
310493c293
Faster extension field multiplication (#500)
* Initial implementation of quintic extensions.

* Update to/from_biguint() methods.

* Draft of fast multiplication on quintic extensions over 64-bit base.

* cargo fmt

* Typo.

* Document functions (a bit).

* Refactor reduction step.

* Change multiplication call so that LLVM generates better assembly.

* Use one main accumulator instead of two minor ones; faster reduce.

* Use one main accumulator in square too; clean up redundant code.

* Call faster routines from Mul and Square impls.

* Fix reduction function.

* Fix square calculation.

* Slightly faster reduction.

* Clean up names and types.

* cargo fmt

* Move extension field mul/sqr specialisations to their own file.

* Rename functions to have unique prefix.

* Add faster quadratic multiplication/squaring.

* Faster quartic multiplication and squaring.

* cargo fmt

* clippy

* Alternative reduce160 function.

* Typo.

* Remove alternative reduction function.

* Remove delayed reduction implementation of squaring.

* Enforce assumptions about extension generators.

* Make the accumulation variable a u32 instead of u64.

* Add test to trigger carry branch in reduce160.

* cargo fmt

* Some documentation.

* Clippy; improved comments.

* cargo fmt

* Remove redundant Square specialisations.

* Fix reduce*() visibility.

* Faster reduce160 from Jakub.

* Change mul-by-const functions to operate on 160 bits instead of 128.

* Move code for extensions of GoldilocksField to its own file.
2022-03-04 09:34:31 +11:00
wborgeaud
3a68a458c4 Ignore large tests 2022-03-03 08:44:27 +01:00
wborgeaud
5febea778b Fixes 2022-03-03 08:14:56 +01:00
wborgeaud
18e341ff18 Comments 2022-03-03 08:06:21 +01:00
wborgeaud
47523c086a Minor 2022-03-03 07:59:47 +01:00
wborgeaud
90df0d9d3a Clippy 2022-03-03 07:59:44 +01:00
wborgeaud
f6525ed11a Add wide config for ECDSA in < 2^16 gates 2022-03-03 07:59:32 +01:00
Daniel Lubarov
7329dade94
IS_MUL -> IS_MUL_ADD (#510) 2022-03-02 22:49:57 -08:00
Hamish Ivey-Law
2644f5f74a
System Zero subtraction operation (#508)
* First draft of subtraction operation.

* Daniel comments.

* Fix constraint calculation.

* cargo fmt

* Align native and recursive eval functions; fix typo.
2022-03-03 14:18:19 +11:00
wborgeaud
c8d3335bce ECDSA verification in 101k gates 2022-03-02 13:37:01 +01:00
wborgeaud
2571862f00 Working GLV decomposition check 2022-03-02 13:31:16 +01:00
wborgeaud
7c70c46ca7 Working GLV with MSM 2022-03-02 13:19:31 +01:00
wborgeaud
850df4dfb1 Add fixed base file 2022-03-02 11:16:32 +01:00
wborgeaud
6f3ca6a0bc Fixed base works 2022-03-02 11:04:05 +01:00
wborgeaud
ba5b1f7278 Fix set_biguint_target 2022-03-02 10:27:20 +01:00
wborgeaud
74cf1d3887 Minor improvement 2022-03-01 07:59:35 +01:00
wborgeaud
61af3a0de2 Cleaning 2022-02-25 19:39:30 +01:00
wborgeaud
efb074b247 Works with 2 2022-02-25 17:21:35 +01:00
wborgeaud
772ff8d69a Works 2022-02-25 16:30:01 +01:00
Nicholas Ward
6b386e756a
Merge pull request #503 from mir-protocol/ecdsa_target_visibility
ECDSA targets visibility
2022-02-24 12:44:03 -08:00
Nicholas Ward
bd7f43adc2 visibility 2022-02-24 10:19:16 -08:00
Nicholas Ward
7b4ddf852c
Merge pull request #502 from mir-protocol/ecdsa_secret_to_public
ECDSA secret_to_public fn
2022-02-24 10:09:08 -08:00
Nicholas Ward
383b8b68b3 secret_to_public fn 2022-02-24 10:01:38 -08:00
wborgeaud
517d26e4c1
Merge pull request #499 from mir-protocol/stark_permutation_checks
Stark verifier permutation checks
2022-02-23 09:56:02 +01:00
wborgeaud
dd4cc21309 PR feedback 2022-02-23 09:36:28 +01:00
wborgeaud
8c5cbbc7c6 Add first row Z check 2022-02-22 17:40:48 +01:00
wborgeaud
17bbc6f3e4 Minor 2022-02-22 17:30:08 +01:00
wborgeaud
a31c58b69d Use ReducingFactor 2022-02-22 17:23:55 +01:00
wborgeaud
150d764440 Simplification 2022-02-22 17:00:08 +01:00
wborgeaud
4ea418a486 Clippy 2022-02-22 16:35:20 +01:00
wborgeaud
064b3c07a8 Forgot to set permutation cap 2022-02-22 16:18:41 +01:00
wborgeaud
6cd2fc62b5 Should work (does not) 2022-02-22 11:44:24 +01:00
wborgeaud
ed4aef0fa0 Fill permutation todos 2022-02-22 10:46:51 +01:00
wborgeaud
56e269e27a Working (not recursively) 2022-02-22 10:37:08 +01:00
Jakub Nabaglo
c7af639579
Restore vectorization to full Poseidon rounds on Aarch64 (#498)
* Restore vectorization to full Poseidon layers on Aarch64

* Typos
2022-02-21 17:45:01 -08:00
wborgeaud
85c1e1d5e0 Should work (does not) 2022-02-21 18:00:03 +01:00