Forgot to set permutation cap

This commit is contained in:
wborgeaud 2022-02-22 16:18:41 +01:00
parent 6cd2fc62b5
commit 064b3c07a8
4 changed files with 6 additions and 4 deletions

View File

@ -294,8 +294,6 @@ where
permutation_check_data,
&mut consumer,
);
// stark.eval_packed_base(vars, &mut consumer);
// TODO: Add in constraints for permutation arguments.
// TODO: Fix this once we use a genuine `PackedField`.
let mut constraints_evals = consumer.accumulators();
// We divide the constraints evaluations by `Z_H(x)`.

View File

@ -295,5 +295,11 @@ pub fn set_stark_proof_target<F, C: GenericConfig<D, F = F>, W, const D: usize>(
&proof.openings.to_fri_openings(),
);
if let (Some(permutation_zs_cap_target), Some(permutation_zs_cap)) =
(&proof_target.permutation_zs_cap, &proof.permutation_zs_cap)
{
witness.set_cap_target(&permutation_zs_cap_target, &permutation_zs_cap);
}
set_fri_proof_target(witness, &proof_target.opening_proof, &proof.opening_proof);
}

View File

@ -16,7 +16,6 @@ use crate::vars::StarkEvaluationTargets;
use crate::vars::StarkEvaluationVars;
/// Represents a STARK system.
// TODO: Add a `constraint_degree` fn that returns the maximum constraint degree.
pub trait Stark<F: RichField + Extendable<D>, const D: usize>: Sync {
/// The total number of columns in the trace.
const COLUMNS: usize;

View File

@ -102,7 +102,6 @@ where
permutation_data,
&mut consumer,
);
// TODO: Add in constraints for permutation arguments.
let vanishing_polys_zeta = consumer.accumulators();
// Check each polynomial identity, of the form `vanishing(x) = Z_H(x) quotient(x)`, at zeta.