The change ownership menu item was broken due to Gtk deprecation
changes in commit #bcaaeac.
Fixed by correctly setting the RadioMenuItem group
Refactored to simplify the code
Removed dead or unneeded code
Fixes: https://dev.deluge-torrent.org/ticket/3610
Noticed mismatch with current lt docs and found usage of deprecated
status.paused.
The actual check here is not required we should just attempt to pause
the torrent.
Issue: https://dev.deluge-torrent.org/ticket/3499
The GitHub CI tests on Linux were failing due to ProcessTerminated
> await daemon.kill()
E twisted.internet.error.ProcessTerminated: A process has ended with a probable error condition: process ended by signal 6.
Added a try..except in daemon as a quick solution but might need to
investigate the ProcessOutputHandler.kill method.
We are currently creating a copy of each alert to avoid segfaults when
the next pop_alerts invalidates the lt alert objects we are holding
for handler callbacks.
However these alert copies are not deep enough since need to also
resolve the alert object methods e.g. message() therefore it is still
possible to result in lt segfaults.
The workaround is to check for any handlers not called, give them some
more time and eventually discard if still not handled.
Ref: https://github.com/arvidn/libtorrent/issues/6437
This spawns a thread in alertmanager to call wait_for_alert in a thread.
This reduces latency to deluge responding to events.
And removes all `hasattr` checks in Component
Closes: https://github.com/deluge-torrent/deluge/pull/221
With recent update to pyinstaller 6.0 the libraries are now placed in an
`_internal` folder within the bundle. This has resulted in the failure
to create copies of libssl.
However after examining the new _internal dir it appears that the x64
lib are now created so this step is no longer required.
For new UI features to be added, one should make sure the backend daemon
is supported and add fallback in case it doesn't.
Here we add the ability to get the daemon version from the `Client`
class and also check the version against a desired version.
Closes: https://github.com/deluge-torrent/deluge/pull/427
Add support for v2 torrents in create_torrent, but keep the old
default of only adding the v1 metadata.
Unify the single-file and directory cases to avoid code
duplication.
V2 torrents require files to be piece-aligned. The same for
hybrid v1/v2 ones. To handle both cases of piece-aligned and
non-aligned files, always read the files in piece-aligned
chunks. Re-slice the buffer if needed (for v1-only multi-file
torrents).
Also, had to adapt to progress event. It now depends on the
number of bytes hashed rather than the number of pieces. To
avoid sending and excessive amount of event when handling a
directory with many small files, add a mechanism to limit
event period at 1 per piece_length.
Closes: https://github.com/deluge-torrent/deluge/pull/430
If target=None and add_to_session is True, the torrent will be
directly added to the session without writing the torrent file
to disk. This will allow to programmatically control deluge via
RPC without creating .torrent files all over the place.
Also, make most create_torrent parameters optional.
Tests were stalling in deluge_ui_entry with pytest 7.4.3 likely due to
changes in the way it handles stderr but it is not clean the extact
issue.
For now we will pin the pytest version and look to fix the issue later.
Reference: https://docs.pytest.org/en/stable/changelog.html#pytest-7-4-3-2023-10-24
Preferable to be working with Python scripts for easier development.
This is direct port of the original bash script with the slight
modification to also use pngquant to reduce file size further.
Change the default compression tool to oxipng since it produces smaller
files faster than zopfli.
Add the ECT tool as an option to get maximum compression but is quite
slow to complete.
Using Efficient-Compression-Tool, we managed to reduge image sizes by
Saved 9.45KB out of 241.88KB (3.9065%) without changing visual appearence.
It's a small improvement, but we get something for nothing and that's nice.
ect -keep --allfilters-b --pal_sort=120 -30060 -recurse --mt-file ./
Closes: https://github.com/deluge-torrent/deluge/pull/405
When you set a config directory path (-c) on the command line, and only when,
a file named logging.conf is read to set fine grained log levels.
This allows to have per module/plugin log levels.
A simple logging.conf could be:
-<8 -------------------
deluge:info
deluge.plugin.foo:debug
-----------------------
The file is parsed and the log levels are set in the deluge.log.tweak_logging_levels.
This function set the appropriate logger to the desired level.
Despite the log level is changed, log levels less than ERROR are still not
logged.
The reason is that the log level check is done twice, in the logging.Logger class
and in the logging.Handler class.
The fix is to not set the logging level in the Handler in deluge.log.setup_logger
and let only the logging.Logger check the level.
Closes: https://github.com/deluge-torrent/deluge/pull/428
The latest Pillow 10 does not support Py3.7 therefore wheels are no
longer available and we need to specify previous major version.
Older versions of setuptools do not correctly determine the Twisted
requirement for zope.interface>5 on Python 3.7 so ensure latest
installed. For the CD builds we don't want any surprises so keep the
setuptools version pinned.
Refs: https://pillow.readthedocs.io/en/stable/installation.html
Closes: https://github.com/deluge-torrent/deluge/pull/433
CreateShortCut "$SMPROGRAMS\$StartMenuFolder\Website.lnk" "$INSTDIR\homepage.url"
gets made in the installer but the uninstaller was looking for
Delete "$SMPROGRAMS\$StartMenuFolder\Deluge Website.lnk"
therefore this file was being left behind and since the folder was not empty
$StartMenuFolder\Deluge
was being left behinde as well.
Closes: https://github.com/deluge-torrent/deluge/pull/426
In some cases, when emiting events with EventManager.emit_event(), the underlying
dictionary of interested sessions can change during iteration, causing:
RuntimeError: dictionary changed size during iteration
Fix by iterating over a copy of the dictionary.
Closes: https://dev.deluge-torrent.org/ticket/3351
Closes: https://github.com/deluge-torrent/deluge/pull/425
When adding a torrent in the add torrents dialog, containing only
a single directory with a single file inside, the directory is not
included as a prefix to the filename.
The prefix is added only if there are multiple files inside the directory.
Fix by adding the prefix also when there is only one file inside a dir.
Closes: https://dev.deluge-torrent.org/ticket/3602
Closes: https://github.com/deluge-torrent/deluge/pull/424
With an existing Deluge package installed on the system errors were
occuring trying to start a development instance in virtualenv.
Fixed by replacing usage of deprecated pkg_resource for finding
non-python data files. Includes fallback for Python 3.7/3.8 but drops
Python 3.6 support.
The plugins are still using pkg_resources since they are distributed as
eggs and importlib extracts those data files differently to
pkg_resources so requires a different solution, either as a file stream
or manually cached when plugins are installed.
Closes: https://github.com/deluge-torrent/deluge/pull/403
Co-authored-by: DjLegolas <djlegolas@protonmail.com>
On GNOME, I don't believe any tray icon or indicator support is enabled
by default, but one can easily install an extension for indicators
whereas I'm not sure about tray icons, but the 'top icons' extension I
believe has had a flaky history. I'm not entirely sure how KDE handles
things, but out of the box it too has indicator support and I believe
that is preferred with the move to Wayland. In Xfce, the tray icon area
is called "Status tray" and has support for both tray icons and
indicators.
Closes: https://github.com/deluge-torrent/deluge/pull/318
Issue with legacy tray icon being used despite AyatanaAppIndicator3
installed. The problem is due to option to use AppIndicator not being
shown in Preferences.
Fixes: https://dev.deluge-torrent.org/ticket/3598
When server is busy or the request is slow for big file list, WebUI still
requests for new update blindly. "Connection lost" is often triggerd.
Change to only ask for update 2s after reponse (either success or error)
Signed-off-by: Xuefer H <xuefer@gmail.com>
Closes: https://github.com/deluge-torrent/deluge/pull/416
Encountered a problem with dht_error alert not returning the correct
alert name using Python type.
This should likely be fixed in libtorrent but we should be using
the alert.what method to determine alert type/name.
Since the alert name does not include the `_alert` suffix, strip this
when registering alerts.
Since all of our async tests should be run with twisted, it's
annoying to have to decorate them with pytest_twisted.ensureDeferred.
Forgetting to do this will cause the test to pass without actually
running. This changes the behavior to detect all coroutine function
tests and mark them to be run by pytest_twisted the same way the
decorator does.
Closes: https://github.com/deluge-torrent/deluge/pull/414
Modified test functions to be async.
Used pytest_twisted_ensuredeferred_for_class decorator to avoid needed
ensureDeferred for each test within the class. There might be a way to
do this with fixtures so likely to be improvements for use in all test
classes.
Used Mock in component subclass for simpler tracking of event method calls
Calum Lind
Arkadiusz Bulski
DjLegolas
DjLegolas
Radu Carpa
Anthony Ryan
Sébastien Luttringer
Myrmecophaga tridactyla
doadin
bendikro
Unit 193
Xuefer
Chase Sterling