codex-storage
/
deluge
mirror of https://github.com/codex-storage/deluge.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Packaging] Fix NSIS Uninstaller Not Removing File\Folder 

CreateShortCut "$SMPROGRAMS\$StartMenuFolder\Website.lnk" "$INSTDIR\homepage.url"

gets made in the installer but the uninstaller was looking for

 Delete "$SMPROGRAMS\$StartMenuFolder\Deluge Website.lnk"

therefore this file was being left behind and since the folder was not empty

$StartMenuFolder\Deluge

was being left behinde as well.

Closes: https://github.com/deluge-torrent/deluge/pull/426
This commit is contained in:
doadin 2023-05-29 16:30:57 -04:00 committed by Calum Lind
parent d8b586e6ba
commit 8001110625
No known key found for this signature in database
GPG Key ID: 90597A687B836BA3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packaging/win/deluge-win-installer.nsi
View File

@ -203,8 +203,8 @@ Section Uninstall
!insertmacro MUI_STARTMENU_GETFOLDER Application $StartMenuFolder
SetShellVarContext all
Delete "$SMPROGRAMS\$StartMenuFolder\Deluge.lnk"
Delete "$SMPROGRAMS\$StartMenuFolder\Website.lnk"
Delete "$SMPROGRAMS\$StartMenuFolder\Uninstall Deluge.lnk"
Delete "$SMPROGRAMS\$StartMenuFolder\Deluge Website.lnk"
RmDir "$SMPROGRAMS\$StartMenuFolder"
DeleteRegKey /ifempty HKCR "Software\Deluge"