vacp2p
/
rfc
mirror of https://github.com/vacp2p/rfc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update schema of ContentFilter in 16/WAKU-RPC specs (#363) 

* Update schema of ContentFilter in 16/WAKU-RPC specs
closes #348

* Update schema of ContentFilter in 12/WAKU2-FILTER
This commit is contained in:
Ebube Sered Ud 2021-05-04 10:57:38 +01:00 committed by GitHub
parent e8988ab300
commit eedddc895c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
content/docs/rfcs/12/README.md
View File

@ -8,6 +8,7 @@ contributors:
- Dean Eigenmann <dean@status.im> - Dean Eigenmann <dean@status.im>
- Oskar Thorén <oskar@status.im> - Oskar Thorén <oskar@status.im>
- Sanaz Taheri <sanaz@status.im> - Sanaz Taheri <sanaz@status.im>
- Ebube Ud <ebube@status.im>
--- ---
`WakuFilter` is a protocol that enables subscribing to messages that a peer receives. This is a more lightweight version of `WakuRelay` specifically designed for bandwidth restricted devices. This is due to the fact that light nodes subscribe to full-nodes and only receive the messages they desire. `WakuFilter` is a protocol that enables subscribing to messages that a peer receives. This is a more lightweight version of `WakuRelay` specifically designed for bandwidth restricted devices. This is due to the fact that light nodes subscribe to full-nodes and only receive the messages they desire.
@ -65,7 +66,7 @@ message FilterRequest {
repeated ContentFilter contentFilters = 3; repeated ContentFilter contentFilters = 3;
message ContentFilter { message ContentFilter {
repeated string contentTopics = 1; string contentTopic = 1;
} }
} }
@ -148,7 +149,7 @@ implementation, though a reasonable default is one minute.
### 2.0.0-beta2 ### 2.0.0-beta2
Initial draft version. Released [2020-10-28](https://github.com/vacp2p/specs/commit/5ceeb88cee7b918bb58f38e7c4de5d581ff31e68) Initial draft version. Released [2020-10-28](https://github.com/vacp2p/specs/commit/5ceeb88cee7b918bb58f38e7c4de5d581ff31e68)
- Fix: Ensure contentFilter and contentTopic are repeated fields, per implementation - Fix: Ensure contentFilter is a repeated field, on implementation
- Change: Add ability to unsubscribe from filters. Make `subscribe` an explicit boolean indication. Edit protobuf field order to be consistent with libp2p. - Change: Add ability to unsubscribe from filters. Make `subscribe` an explicit boolean indication. Edit protobuf field order to be consistent with libp2p.
### 2.0.0-beta1 ### 2.0.0-beta1

2
content/docs/rfcs/16/README.md
View File

@ -240,7 +240,7 @@ The following structured types are defined for use on the Filter API:
| Field | Type | Inclusion | Description | | Field | Type | Inclusion | Description |
| ----: | :---: | :---: |----------- | | ----: | :---: | :---: |----------- |
| `topics` | `Array`[`String`] | mandatory | Array of message content topics | | `contentTopic` | `String` | mandatory | message content topic |
### `post_waku_v2_filter_v1_subscription` ### `post_waku_v2_filter_v1_subscription`