From eedddc895c1029aae449e639669cfcceaca40a1b Mon Sep 17 00:00:00 2001 From: Ebube Sered Ud Date: Tue, 4 May 2021 10:57:38 +0100 Subject: [PATCH] Update schema of ContentFilter in 16/WAKU-RPC specs (#363) * Update schema of ContentFilter in 16/WAKU-RPC specs closes #348 * Update schema of ContentFilter in 12/WAKU2-FILTER --- content/docs/rfcs/12/README.md | 5 +++-- content/docs/rfcs/16/README.md | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/content/docs/rfcs/12/README.md b/content/docs/rfcs/12/README.md index 24ff4200..168ac77b 100644 --- a/content/docs/rfcs/12/README.md +++ b/content/docs/rfcs/12/README.md @@ -8,6 +8,7 @@ contributors: - Dean Eigenmann - Oskar Thorén - Sanaz Taheri + - Ebube Ud --- `WakuFilter` is a protocol that enables subscribing to messages that a peer receives. This is a more lightweight version of `WakuRelay` specifically designed for bandwidth restricted devices. This is due to the fact that light nodes subscribe to full-nodes and only receive the messages they desire. @@ -65,7 +66,7 @@ message FilterRequest { repeated ContentFilter contentFilters = 3; message ContentFilter { - repeated string contentTopics = 1; + string contentTopic = 1; } } @@ -148,7 +149,7 @@ implementation, though a reasonable default is one minute. ### 2.0.0-beta2 Initial draft version. Released [2020-10-28](https://github.com/vacp2p/specs/commit/5ceeb88cee7b918bb58f38e7c4de5d581ff31e68) -- Fix: Ensure contentFilter and contentTopic are repeated fields, per implementation +- Fix: Ensure contentFilter is a repeated field, on implementation - Change: Add ability to unsubscribe from filters. Make `subscribe` an explicit boolean indication. Edit protobuf field order to be consistent with libp2p. ### 2.0.0-beta1 diff --git a/content/docs/rfcs/16/README.md b/content/docs/rfcs/16/README.md index bffe9aa3..0433793d 100644 --- a/content/docs/rfcs/16/README.md +++ b/content/docs/rfcs/16/README.md @@ -240,7 +240,7 @@ The following structured types are defined for use on the Filter API: | Field | Type | Inclusion | Description | | ----: | :---: | :---: |----------- | -| `topics` | `Array`[`String`] | mandatory | Array of message content topics | +| `contentTopic` | `String` | mandatory | message content topic | ### `post_waku_v2_filter_v1_subscription`