vacp2p
/
rfc
mirror of https://github.com/vacp2p/rfc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add "repeated" indication to contentFilters and contentTopics to refl… (#216) 

* Add "repeated" indication to contentFilters and contentTopics to reflect implementation intent

* Update waku-filter.md

* Update specs/waku/v2/waku-filter.md

Co-authored-by: jm-clius <hanno@status.im>
Co-authored-by: Oskar Thorén <ot@oskarthoren.com>
This commit is contained in:
Hanno Cornelius 2020-10-15 06:23:58 +02:00 committed by GitHub
parent 88a1ec0368
commit 8920dd7b9d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
specs/waku/v2/waku-filter.md
View File

@ -49,10 +49,10 @@ frequent polling.
```protobuf ```protobuf
message FilterRequest { message FilterRequest {
string topic = 1; string topic = 1;
ContentFilter contentFilters = 2; repeated ContentFilter contentFilters = 2;
message ContentFilter { message ContentFilter {
string contentTopics = 1; repeated string contentTopics = 1;
} }
} }
@ -113,6 +113,10 @@ implementation, though a reasonable default is one minute.
# Changelog # Changelog
### Next version
- Fix: Ensure contentFilter and contentTopic are repeated fields, per implementation
### 2.0.0-beta1 ### 2.0.0-beta1
Initial draft version. Released [2020-10-05](https://github.com/vacp2p/specs/commit/31857c7434fa17efc00e3cd648d90448797d107b) Initial draft version. Released [2020-10-05](https://github.com/vacp2p/specs/commit/31857c7434fa17efc00e3cd648d90448797d107b)