From 8920dd7b9d48bca4c64ef7001f05cd616c1455b9 Mon Sep 17 00:00:00 2001 From: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com> Date: Thu, 15 Oct 2020 06:23:58 +0200 Subject: [PATCH] =?UTF-8?q?Add=20"repeated"=20indication=20to=20contentFil?= =?UTF-8?q?ters=20and=20contentTopics=20to=20refl=E2=80=A6=20(#216)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Add "repeated" indication to contentFilters and contentTopics to reflect implementation intent * Update waku-filter.md * Update specs/waku/v2/waku-filter.md Co-authored-by: jm-clius Co-authored-by: Oskar Thorén --- specs/waku/v2/waku-filter.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/specs/waku/v2/waku-filter.md b/specs/waku/v2/waku-filter.md index d4694b7f..4efe3a5b 100644 --- a/specs/waku/v2/waku-filter.md +++ b/specs/waku/v2/waku-filter.md @@ -49,10 +49,10 @@ frequent polling. ```protobuf message FilterRequest { string topic = 1; - ContentFilter contentFilters = 2; + repeated ContentFilter contentFilters = 2; message ContentFilter { - string contentTopics = 1; + repeated string contentTopics = 1; } } @@ -113,6 +113,10 @@ implementation, though a reasonable default is one minute. # Changelog +### Next version + +- Fix: Ensure contentFilter and contentTopic are repeated fields, per implementation + ### 2.0.0-beta1 Initial draft version. Released [2020-10-05](https://github.com/vacp2p/specs/commit/31857c7434fa17efc00e3cd648d90448797d107b)