vacp2p
/
nim-libp2p
mirror of https://github.com/vacp2p/nim-libp2p.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(ci): windows-amd64 (Nim version-1-6) (#1160) 

The failure is due to incompatibility (in caching) after Nimble's
v.0.14.0 update, where they changed the dependencies directory name from
`pkgs` to `pkgs2`.
This PR includes the nim branch in the cache key to avoid the directory
name issue.

In the future, if we deprecate support for Nim 1.6 we may remove this.

fixes https://github.com/vacp2p/nim-libp2p/issues/1157

---------

Co-authored-by: Diego <diego@status.im>
This commit is contained in:
Álex 2024-08-01 12:54:18 +02:00 committed by GitHub
parent f8d4da6421
commit e5e319c1a9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/ci.yml vendored
View File

@ -77,7 +77,9 @@ jobs:
uses: actions/cache@v3 uses: actions/cache@v3
with: with:
path: nimbledeps path: nimbledeps
key: nimbledeps-${{ hashFiles('.pinned') }} # Using nim.branch as a simple way to differentiate between nimble using the "pkgs" or "pkgs2" directories.
# The change happened on Nimble v0.14.0.
key: nimbledeps-${{ matrix.branch }}-${{ hashFiles('.pinned') }} # hashFiles returns a different value on windows
- name: Install deps - name: Install deps
if: ${{ steps.deps-cache.outputs.cache-hit != 'true' }} if: ${{ steps.deps-cache.outputs.cache-hit != 'true' }}