From e5e319c1a975b258969abf20ee1f8a5061637f85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lex?= Date: Thu, 1 Aug 2024 12:54:18 +0200 Subject: [PATCH] fix(ci): windows-amd64 (Nim version-1-6) (#1160) The failure is due to incompatibility (in caching) after Nimble's v.0.14.0 update, where they changed the dependencies directory name from `pkgs` to `pkgs2`. This PR includes the nim branch in the cache key to avoid the directory name issue. In the future, if we deprecate support for Nim 1.6 we may remove this. fixes https://github.com/vacp2p/nim-libp2p/issues/1157 --------- Co-authored-by: Diego --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 66ec97080..768727020 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -77,7 +77,9 @@ jobs: uses: actions/cache@v3 with: path: nimbledeps - key: nimbledeps-${{ hashFiles('.pinned') }} + # Using nim.branch as a simple way to differentiate between nimble using the "pkgs" or "pkgs2" directories. + # The change happened on Nimble v0.14.0. + key: nimbledeps-${{ matrix.branch }}-${{ hashFiles('.pinned') }} # hashFiles returns a different value on windows - name: Install deps if: ${{ steps.deps-cache.outputs.cache-hit != 'true' }}