Commit Graph

104 Commits

Author SHA1 Message Date
Ricardo Guilherme Schmidt e715502da1
Check for reentrancy double spend on onTransfer (#29)
* chore: add missing trailing slash in remapping

This was not causing any compilation issues, but the solidity language
server gets confused by this and complains about incorrect import
statements otherwise.

* TokenController interactions after balance updates

This test demonstrates that all transfer methods are vulnerable to
callback reentrancy attacks if the controller of the `MiniMeToken` is
malicious.

---------

Co-authored-by: r4bbit <445106+0x-r4bbit@users.noreply.github.com>
2023-09-22 20:25:23 +02:00
Ricardo Guilherme Schmidt 85ca91ccc9 replace forge test with pnpm gas-report 2023-09-19 10:36:28 -03:00
Ricardo Guilherme Schmidt aa8cee3b8f gas-report output to console + save filter output 2023-09-19 10:36:28 -03:00
Ricardo Guilherme Schmidt 6bf228162d add gas-report tracking 2023-09-19 10:36:28 -03:00
r4bbit 0caec481cb docs: add CI and codecov badges
Our fork has diverged significantly from its upstream repository, so we
should show the CI and codecov of its own source.
2023-09-19 09:58:19 -03:00
r4bbit fe4146bccb cleanup: remove unused javascript tests
These have been ported to foundry tests.
2023-09-19 09:57:50 -03:00
Ricardo Guilherme Schmidt 9014aee8a2 set immutables and constants
Fixes vacp2p/minime#21
2023-09-15 09:37:53 -03:00
Ricardo Guilherme Schmidt d6ce59e502 Separate contracts source into dedicated files
Fixes vacp2p/minime#15
2023-09-14 13:34:43 -03:00
Ricardo Guilherme Schmidt b899e5a8ec Make MiniMe implement OZ ERC20
Fixes vacp2p/minime#4
2023-09-14 11:46:00 -03:00
Ricardo Guilherme Schmidt c8581cd22d remove string error messages 2023-09-13 11:47:40 -03:00
Ricardo Guilherme Schmidt 2636a070b1 add gas snapshot before changes 2023-09-13 11:47:40 -03:00
Ricardo Guilherme Schmidt ed1df75a92
fix lint on SampleCampaign (#12) 2023-09-12 15:25:29 -03:00
Ricardo Guilherme Schmidt a7237e0bc9
Fix-lint (#10)
* fix lint issues
* add require error msg
* fix warnings with 'forge fmt'
* fix grammar
2023-09-12 14:08:26 -03:00
r4bbit 5386b09f55
tests: port existing JS tests to foundry tests (#9) 2023-09-12 17:08:59 +02:00
Ricardo Guilherme Schmidt 2a8505f3b2
update to solidity 0.8.19 (#1) 2023-09-12 16:22:43 +02:00
r4bbit 4d63c8448a
refactor: migrate codebase to foundry-template (#8)
Closes #3
2023-09-12 16:21:51 +02:00
Jordi Baylina ea04d950ee
Minor bug fixed. And throw instead of return false when no funds is hited 2017-12-09 21:52:46 +01:00
Jordi Baylina c23d03cb02
trigger travis 2017-10-21 09:14:40 +02:00
Jordi Baylina 5665bd4e9a
Full refactor of the tests to use await method 2017-10-21 09:10:44 +02:00
Jordi Baylina b828579608 Merge pull request #34 from sophiii/patch-1
Update MiniMeToken.sol
2017-10-19 16:31:24 +02:00
Jordi Baylina 4c8b7626e1 Merge pull request #35 from ojones/master
readme header png
2017-10-19 16:30:50 +02:00
ojones efd360efcc readme header png 2017-10-17 23:17:42 -07:00
sophiii 80dcefc3af Update MiniMeToken.sol
Since the change of `throw` to `require` should we upgrade the version number inside the contract?
2017-10-16 14:43:59 +01:00
Jordi Baylina 815699db3e Merge pull request #26 from eduadiez/master
Version adapter of SampleCampaign-TokenController.sol
2017-08-09 21:15:35 +02:00
eduardo-antuna 6c8548c80e Version adapter of SampleCampaign-TokenController.sol 2017-08-06 21:56:41 +02:00
Jordi Baylina 2b61f1c0fa
Version adapter 2017-08-04 10:32:33 +02:00
Jordi Baylina 8e46200213
Failsafe external tokens 2017-08-04 10:14:04 +02:00
Jordi Baylina 891cd7da32
Merge branch 'master' of github.com:Giveth/minime 2017-08-04 09:57:09 +02:00
Jordi Baylina 0c9b00071e
version 2017-08-04 09:56:57 +02:00
Jordi Baylina 42ec2ce148 Merge pull request #21 from ltfschoen/patch-1
Update README.md
2017-07-30 17:38:13 +02:00
Jordi Baylina 83940910f0 Merge pull request #25 from Giveth/readabilityOverflowCheck
Readability of overflow check
2017-07-30 17:15:45 +02:00
Jordi Baylina 31b6bf3001
Readability of overflow check 2017-07-30 17:14:56 +02:00
Jordi Baylina 9b31d6493e Merge pull request #24 from Giveth/fixCreateAndDestroyTokensInCloned
Fix Create and destroy tokens in cloned tokens
2017-07-30 10:46:15 +02:00
Jordi Baylina d8983286f2
Fix Create and destroy tokens in cloned tokens 2017-07-30 10:41:34 +02:00
Luke Schoen 2b7ff07d17 Update README.md
Fixed typo
2017-07-14 15:42:15 +10:00
Jordi Baylina 6a5e38f4bd Merge pull request #17 from Giveth/fixRaceConditionClone2
Fix race condition and allow to clone a token in the future
2017-05-24 17:54:42 +02:00
Jordi Baylina 68627576ca Fix race condition and allow to clone a token in the future 2017-05-18 10:16:43 +02:00
Jordi Baylina 3205f89710 Remove Minime.sol from root directory. The valid is in contracts 2017-05-08 11:59:39 +02:00
Jordi Baylina 878b412664 Merge pull request #14 from Giveth/KeepParentHistory
Keep the parent history when you clone a token
2017-05-03 15:24:30 +02:00
Jordi Baylina 4c367d1ba4 Keep the parent history when you clone a token 2017-05-03 15:22:42 +02:00
Jordi Baylina 81233b8c15 Merge pull request #6 from ameten/apostrophe
Replaced apostrophe with a more traditional one
2017-05-03 14:51:33 +02:00
Jordi Baylina a3204ab85a Merge pull request #12 from Giveth/approveAndCallFix
Approve and call fix
2017-05-03 14:50:48 +02:00
Jordi Baylina 5c82c0b125 Merge pull request #13 from Giveth/fixOverflows
Fix some possible overflows
2017-05-02 15:23:52 +02:00
Jordi Baylina 95adb311c9 Fix some possible overflows 2017-05-02 15:22:19 +02:00
Jordi Baylina 41e87ca01f Approve and call use the approve function to be coherent with all the logic 2017-05-01 18:27:03 +02:00
Jordi Baylina 38b64110cc Compiled and tests passed 2017-05-01 17:36:04 +02:00
Jordi Baylina 282380156e Approve and call fix of the data param construction 2017-05-01 17:32:33 +02:00
Danil Nemirovsky 9fd455a4b6 - replaced apostrophe with a more traditional one. 2017-02-23 02:55:28 +03:00
Danil Nemirovsky 1489f7d90a - removed unnecessary apostrophe. 2017-02-23 02:20:22 +03:00
Jordi Baylina 31bce217fb deps 2017-02-12 14:00:40 +01:00